Le Friday 10 July 2015 à 19:46 +0530, Kashyap Desai a écrit :
> >
> > I am about to commit the patch that was successfully tested by the
> > customer on
> > SLES 12, but I'm a bit confused. The upstream patch you referred to is:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/com
In case encountered a PI error, use scsi_set_sense_information
instead of open coding information descriptor format.
Signed-off-by: Sagi Grimberg
---
drivers/scsi/libiscsi.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libisc
In case a LU spans 64bit sectors, fixed size sense data information
field is only 32 bits which means the sector information will be truncated.
Thus, if the LU spans 64bit sectors, use descriptor format sense data to
correctly report sector information.
Reported-by: Christoph Hellwig
Signed-off-
The sense header additional sense length should be the accumulated
size of all the descriptors. Information descriptor size is 12 bytes.
When setting the additional sense length we should add 0xc instead of
0xa.
Signed-off-by: Sagi Grimberg
Reviewed-by: Hannes Reinecke
Reviewed-by: Martin K. Pet
This small patchset addresses some issues with descriptor format
sense data.
Patch 1 fixes wrong additional sense length for descriptor format
information field.
Patch 2 protects against buffer overflow in scsi_set_information_sense
(reported by Hannes).
Patch 3 converts the target stack to repo
On 07/15/2015 09:55 AM, Sagi Grimberg wrote:
> In case a LU spans 64bit sectors, fixed size sense data information
> field is only 32 bits which means the sector information will be truncated.
>
> Thus, if the LU spans 64bit sectors, use descriptor format sense data to
> correctly report sector in
On 07/15/2015 09:55 AM, Sagi Grimberg wrote:
> In case encountered a PI error, use scsi_set_sense_information
> instead of open coding information descriptor format.
>
> Signed-off-by: Sagi Grimberg
> ---
> drivers/scsi/libiscsi.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
Make sure that the input sense buffer has sufficient length
to fit the information descriptor (12 additional bytes).
Modify scsi_set_sense_information to receive the sense buffer
length and adjust its callers scsi target and libata.
Reported-by: Hannes Reinecke
Signed-off-by: Sagi Grimberg
Revie
On Wed, Jul 15, 2015 at 10:55:36AM +0300, Sagi Grimberg wrote:
> The sense header additional sense length should be the accumulated
> size of all the descriptors. Information descriptor size is 12 bytes.
> When setting the additional sense length we should add 0xc instead of
> 0xa.
>
> Signed-off-
On Wed, Jul 15, 2015 at 10:55:37AM +0300, Sagi Grimberg wrote:
> Make sure that the input sense buffer has sufficient length
> to fit the information descriptor (12 additional bytes).
> Modify scsi_set_sense_information to receive the sense buffer
> length and adjust its callers scsi target and lib
On Wed, Jul 15, 2015 at 10:55:38AM +0300, Sagi Grimberg wrote:
> In case a LU spans 64bit sectors, fixed size sense data information
> field is only 32 bits which means the sector information will be truncated.
>
> Thus, if the LU spans 64bit sectors, use descriptor format sense data to
> correctl
On Wed, Jul 15, 2015 at 10:55:39AM +0300, Sagi Grimberg wrote:
> In case encountered a PI error, use scsi_set_sense_information
> instead of open coding information descriptor format.
>
> Signed-off-by: Sagi Grimberg
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list:
If dm-mpath encounters an reservation conflict it should not
fail the path (as communication with the target is not affected)
but should rather retry on another path.
However, in doing so we might be inducing a ping-pong between
paths, with no guarantee of any forward progress.
And arguably a reser
On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote:
> If dm-mpath encounters an reservation conflict it should not
> fail the path (as communication with the target is not affected)
> but should rather retry on another path.
> However, in doing so we might be inducing a ping-pong between
> pa
On 07/15/2015 01:35 PM, James Bottomley wrote:
> On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote:
>> If dm-mpath encounters an reservation conflict it should not
>> fail the path (as communication with the target is not affected)
>> but should rather retry on another path.
>> However, in d
An array can't issue a reservation, the initiator needs to register
it. Right now the only way to do it is through SG_IO passthrough,
which is a best luck effort it I/O isn't also using SG_IO and can't
be properly supported because of that.
However I will submit an in-kernel reservation API soon
On Wed, 2015-07-15 at 13:52 +0200, Hannes Reinecke wrote:
> On 07/15/2015 01:35 PM, James Bottomley wrote:
> > On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote:
> >> If dm-mpath encounters an reservation conflict it should not
> >> fail the path (as communication with the target is not affe
On 07/15/2015 01:56 PM, Christoph Hellwig wrote:
> An array can't issue a reservation, the initiator needs to register
> it. Right now the only way to do it is through SG_IO passthrough,
> which is a best luck effort it I/O isn't also using SG_IO and can't
> be properly supported because of that.
On 07/15/2015 02:01 PM, James Bottomley wrote:
> On Wed, 2015-07-15 at 13:52 +0200, Hannes Reinecke wrote:
>> On 07/15/2015 01:35 PM, James Bottomley wrote:
>>> On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote:
If dm-mpath encounters an reservation conflict it should not
fail the
With the following setup/steps I can consistently trigger the scsi host to
hang requiring a reboot:
1. iMX6Q processor with built in AHCI compatible SATA host
2. SATA port multiplier in CBS mode connected to iMX6Q
3. HDD connected to port multiplier
4. CDROM connected to port multiplier
5. trigger
On Wed, Jul 15 2015 at 8:15am -0400,
Hannes Reinecke wrote:
> On 07/15/2015 02:01 PM, James Bottomley wrote:
> > On Wed, 2015-07-15 at 13:52 +0200, Hannes Reinecke wrote:
> >> On 07/15/2015 01:35 PM, James Bottomley wrote:
> >>> On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote:
> If
On 07/15/2015 01:24 AM, Sreekanth Reddy wrote:
> On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote:
>> On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy
>> wrote:
>>> Driver crashes if the BIOS do not set up at least one
>>> memory I/O resource. This failure can happen if the device is too
On 07/15/15 00:55, Sagi Grimberg wrote:
+bool target_sense_desc_format(struct se_device *dev)
+{
+ return dev->transport->get_blocks(dev) > 0xULL;
+}
Please consider to use U32_MAX instead of 0xULL since that would
make this function easier to read and to verify.
Bart.
Caro User Account Mail:
Sua caixa de correio excedeu o limite de armazenamento que é de 20 GB como
definido pelo
administrador, que está actualmente em execução em 20,9 GB e você pode não ser
capaz
para enviar ou receber novas mensagens até que volte a validar a sua caixa de
correio.
Para volta
On Wed, Jul 15, 2015 at 08:52:13AM -0500, Timothy Pearson wrote:
> On 07/15/2015 01:24 AM, Sreekanth Reddy wrote:
> > On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote:
> >> On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy
> >> wrote:
> >>> Driver crashes if the BIOS do not set up at leas
On Wed, Jul 15, 2015 at 6:52 AM, Timothy Pearson
wrote:
>> I have just kept the same description provide by Timothy in his
>> initial patch.
>>
>> But I observe that their may be chance of getting "unable to handle
>> kernel NULL pointer dereference" kernel panic if no Memory Resource
>> available
On 07/15/2015 01:28 PM, Yinghai Lu wrote:
> On Wed, Jul 15, 2015 at 6:52 AM, Timothy Pearson
> wrote:
>>> I have just kept the same description provide by Timothy in his
>>> initial patch.
>>>
>>> But I observe that their may be chance of getting "unable to handle
>>> kernel NULL pointer dereferen
Use 'list_for_each_safe' instead of 'list_for_each' + own logic to keep
safe when a list entry is deleted.
Delete the now useless 'csio_list_prev' macro.
Signed-off-by: Christophe JAILLET
---
drivers/scsi/csiostor/csio_defs.h | 1 -
drivers/scsi/csiostor/csio_hw.c | 10 --
drivers/scs
On Wed, Jul 15, 2015 at 10:19:56AM +0530, Sreekanth Reddy wrote:
> Driver crashes if the BIOS do not set up at least one
> memory I/O resource. This failure can happen if the device is too
> slow to respond during POST and is missed by the BIOS, but Linux
> then detects the device later in the boot
Hello,
Currently I don't see any users of aio cancellation facility (except a
USB gadget driver).
I have a SATA controller and disk that both support the NCQ command
aborts, and I am thinking of ways to implement aio cancellation on
these devices in the kernel. The way I see it, at the time user
> "Sagi" == Sagi Grimberg writes:
Sagi> In case encountered a PI error, use scsi_set_sense_information
Sagi> instead of open coding information descriptor format.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the
> "Sagi" == Sagi Grimberg writes:
Sagi> In case a LU spans 64bit sectors, fixed size sense data
Sagi> information field is only 32 bits which means the sector
Sagi> information will be truncated.
Sagi> Thus, if the LU spans 64bit sectors, use descriptor format sense
Sagi> data to correctly r
> "Sreekanth" == Sreekanth Reddy writes:
Sreekanth> Updating maintainers list for the entry LSILOGIC MPT FUSION
Sreekanth> DRIVERS in MAINTAINERS file
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsub
Commit bcdb247c6b6a ("sd: Limit transfer length") clamped the maximum
size of an I/O request to the MAXIMUM TRANSFER LENGTH field in the BLOCK
LIMITS VPD. This had the unfortunate effect of also limiting the maximum
size of non-filesystem requests sent to the device through sg/bsg.
Avoid using blk
Christophe JAILLET writes:
> Use 'list_for_each_safe' instead of 'list_for_each' + own logic to keep
> safe when a list entry is deleted.
> Delete the now useless 'csio_list_prev' macro.
>
> Signed-off-by: Christophe JAILLET
> ---
> drivers/scsi/csiostor/csio_defs.h | 1 -
> drivers/scsi/csios
35 matches
Mail list logo
