https://bugzilla.kernel.org/show_bug.cgi?id=101371
Bug ID: 101371
Summary: OOPS: unplugging western digital passport drive
Product: IO/Storage
Version: 2.5
Kernel Version: 4.0.7
Hardware: Intel
OS: Linux
Tree:
This small patchset addresses some issues with descriptor format
sense data.
Patch 1 fixes wrong additional sense length for descriptor format
information field.
Patch 2 protects against buffer overflow in scsi_set_information_sense
(reported by Hannes).
Patch 3 converts the target stack to repo
In case encountered a PI error, use scsi_set_sense_information
instead of open coding information descriptor format.
Signed-off-by: Sagi Grimberg
---
drivers/scsi/libiscsi.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libisc
Make sure that the input sense buffer has sufficient length
to fit the information descriptor (12 additional bytes).
Modify scsi_set_sense_information to receive the sense buffer
length and adjust it's callers scsi target and libata.
Reported-by: Hannes Reinecke
Signed-off-by: Sagi Grimberg
Cc:
Fixed size sense data information field is only 32 bits which
means the sector (64 bits) information will be truncated.
Move to descriptor format sense data to correctly report full
sector information.
Reported-by: Christoph Hellwig
Signed-off-by: Sagi Grimberg
---
drivers/target/target_core_s
The sense header additional sense length should be the accumulated
size of all the descriptors. Information descriptor size is 12 bytes.
When setting the additional sense length we should add 0xc instead of
0xa.
Signed-off-by: Sagi Grimberg
---
drivers/scsi/scsi_common.c | 2 +-
1 file changed,
By implementing an arch_nvram_ops struct, any platform can re-use the
drivers/char/nvram module without needing any arch-specific code
in that module. Atari does so here.
Atari has one user of nvram_check_checksum() whereas the other platforms
(i.e. x86 and ARM platforms) have none at all. Replace
On powerpc, setting CONFIG_NVRAM=n builds a kernel with no NVRAM support.
Setting CONFIG_NVRAM=m enables the /dev/nvram misc device module without
enabling NVRAM support in drivers. Setting CONFIG_NVRAM=y enables the
misc device (built-in) and also enables NVRAM support in drivers.
m68k shares the
Drop unused scsi_dif_tuple and use t10_pi_tuple instead of own sd_dif_tuple
copy.
Signed-off-by: Sebastian Herbszt
diff -urp linux/drivers/scsi/qla2xxx-orig/qla_def.h
linux/drivers/scsi/qla2xxx/qla_def.h
--- linux/drivers/scsi/qla2xxx-orig/qla_def.h 2015-04-15 06:18:24.681045138
+0200
+++ l
On 07/12/15 07:06, Sebastian Herbszt wrote:
- spt = page_address(sg_page(sg)) + sg->offset;
- spt += j;
+ pi = page_address(sg_page(sg)) + sg->offset;
+ pi += j;
Sorry that I hadn't noticed this before but p
Drop unused scsi_dif_tuple and use t10_pi_tuple instead of own sd_dif_tuple
copy.
Also use sg_virt() instead of open coding it.
Signed-off-by: Sebastian Herbszt
diff -urp linux/drivers/scsi/qla2xxx-orig/qla_def.h
linux/drivers/scsi/qla2xxx/qla_def.h
--- linux/drivers/scsi/qla2xxx-orig/qla_def.
On 07/12/15 14:54, Sebastian Herbszt wrote:
Drop unused scsi_dif_tuple and use t10_pi_tuple instead of own sd_dif_tuple
copy.
Also use sg_virt() instead of open coding it.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
On Sat, Jul 11, 2015 at 09:24:55PM -0700, Calvin Owens wrote:
> These objects can be referenced concurrently throughout the driver, we
> need a way to make sure threads can't delete them out from under each
> other. This patch adds the refcount, and refactors the code to use it.
>
> Additionally,
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
14 matches
Mail list logo
