Re: [RFC 1/2] target: Add support for fabric IRQ completion

2015-06-29 Thread Sagi Grimberg
On 6/9/2015 10:27 AM, Christoph Hellwig wrote: diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c index 3fbb0d4..aa08d6b 100644 --- a/drivers/target/target_core_tpg.c +++ b/drivers/target/target_core_tpg.c @@ -37,6 +37,7 @@ #include #include +#include #incl

Re: [PATCH] scsi_dh: convert __ATTR macro to DEVICE_ATTR_RW and snprintf show method cleanup

2015-06-29 Thread Hannes Reinecke
On 06/26/2015 08:38 AM, Seymour, Shane M wrote: > > Converted dh_state to use DEVICE_ATTR_RW macro > instead of __ATTR. That forced a change to the associated > show/store function names and the name of the attribute. > > Changed usage of snprintf in show function to scnprintf per > Documentatio

[RFC] implementaion of ufs variant

2015-06-29 Thread Dov Levenglick
Hi James et. al, We had a lively discussion in the thread titled "Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device" regarding the proper implementation of a UFS controller variant. After further consideration, we propose to go with what Rob initially suggested

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-06-29 Thread Jean Delvare
Hi Kashyap, Thanks for the patch. May I ask what tree it was based on? Linus' latest? I am trying to apply it to the SLES 11 SP3 and SLES 12 kernel trees (based on kernel v3.0 + a bunch of backports and v3.12 respectively) but your patch fails to apply in both cases. I'll try harder but I don't kn

[PATCH RFC] target: Use scsi helpers to build the sense data correctly

2015-06-29 Thread Sagi Grimberg
Instead of open coding the sense buffer construction, use scsi scsi_build_sense_buffer() and scsi_set_sense_information() helpers. This patch also fixes wrong setting of descriptor format sense data for t10-pi integrity errors. Signed-off-by: Sagi Grimberg --- drivers/target/target_core_spc.c

Re: [PATCH 0/3] libfc patches for kernel v4.2

2015-06-29 Thread Vasu Dev
On Fri, 2015-06-05 at 14:20 -0700, Vasu Dev wrote: > These libfc fixes are for kernel 4.2 and with two patches CCed for stable > kernel also, those two could be picked for current 4.1 cycle now but in case > too late for current 4.1 then anyway should get picked up by 4.1 stable > kernel later. >

[Bug 98171] [Regression] Marvell SE91xx SATA 3 controllers not recognized correctly

2015-06-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=98171 --- Comment #1 from nuc...@hotmail.com --- > This is a regression against 3.14? There was only one change affecting > mvsas between those kernels and that was the libsas change: > > commit bc6e7c4b0d1a1f742d96556f63d68f17f4e232c3 > Author: Dan Wil

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-06-29 Thread Greg KH
On Fri, May 22, 2015 at 12:19:16PM -0700, Vinson Lee wrote: > On Sat, May 2, 2015 at 10:56 AM, Greg KH wrote: > > On Mon, Apr 27, 2015 at 03:10:35PM +0200, Tomas Henzl wrote: > >> On 04/27/2015 02:55 PM, Greg KH wrote: > >> > On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote: > >> >> On

[PATCH] virtio scsi: fix unused variable warning

2015-06-29 Thread Stephen Rothwell
Fixes: drivers/scsi/virtio_scsi.c: In function 'virtscsi_probe': drivers/scsi/virtio_scsi.c:952:11: warning: unused variable 'host_prot' [-Wunused-variable] int err, host_prot; ^ Signed-off-by: Stephen Rothwell --- drivers/scsi/virtio_scsi.c | 4 +++- 1 file changed, 3 insertions(

[PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

2015-06-29 Thread Seymour, Shane M
Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method sprint/snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour --- --- a/drivers/scsi/hpsa.c 2015-06-25 15:

[PATCH 00/20] mpt3sas: driver update

2015-06-29 Thread Sreekanth Reddy
This patch set contains all the features and defect fixes from Phase4 to Phase8. Except below patch, all other patches have Reviewed-by signature from either Martin K. Petersen, Johannes Thumshirn, Tomas Henzl and Joe Lawrence. Thanks for reviewing these patches. [PATCH v2 16/20] [SCSI] mpt3sas: A

[PATCH v2 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-29 Thread Sreekanth Reddy
Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send IOC facts request message only if HBA is in operational or ready state. 2.If IOC is in fault state, a diagnostic reset wou

[PATCH v2 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-06-29 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-06-29 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insert

[PATCH v2 03/20] [SCSI] mpt3sas: Don't block the drive when drive addition under the control of SML

2015-06-29 Thread Sreekanth Reddy
During hot-plugging of a disk(having a flaky link), the disk addition stops and any further disk addition or removal doesn't happen on that controller. This is because, when driver receives DELAY_NOT_RESPONDING event for a disk while it is undergoing addition at the SCSI Transport layer, the drive

[PATCH v2 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-06-29 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Changes in v2: Patch version ch

[PATCH v2 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-06-29 Thread Sreekanth Reddy
Issue: When the disks are getting discovered and assigned device handles by the kernel, a device block followed by an unblock (due to broadcast primitives) issued by the driver is interspersed by the kernel changing the state of the device. Therefore the unblock by the driver results in a no operat

[PATCH v2 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-29 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Changes in v1: No need to check for backport compatibility in the upstream kernel. so removing the else section where driver

[PATCH v2 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-06-29 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -