On 06/24/2015 05:16 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 24 Jun 2015 16:06:21 +0200
>
> The put_disk() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coc
Hi Timothy,
Thanks for the patch.
I feel there is some code redundancy after including this patch, I
mean to say is twice we are checking for (ioc->chip == NULL). So I am
working on to reduce this redundancy. Soon I will post a new patch.
Thanks,
Sreekanth
On Sun, Jun 28, 2015 at 7:00 AM, Timot
From: rudhresh
Return is not a function so parenthesis is not required
Signed-off-by: Rudhresh
---
drivers/scsi/dtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 4c74c7b..c793ecf 100644
--- a/drivers/scsi/dtc.c
+++ b/dri
Removed unneccessary initialization of zero to a static variable
Signed-off-by: Rudhresh Kumar J
---
drivers/scsi/dtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 4c74c7b..99164d6 100644
--- a/drivers/scsi/dtc.c
+++ b/dri
Currently port pointer is derefrenced before NULL check.
So NULL check is misleading, Thus it is better to use port
pointer after NULL Check.
Signed-off-by: Maninder Singh
Reviewed-by: Akhilesh Kumar
---
drivers/scsi/bfa/bfa_fcs_lport.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
5 matches
Mail list logo