Re: [PATCH 4/6] target: Send UA on ALUA target port group change

2015-06-23 Thread Nicholas A. Bellinger
On Fri, 2015-06-19 at 15:05 +0200, Christoph Hellwig wrote: > > --- a/drivers/target/target_core_alua.c > > +++ b/drivers/target/target_core_alua.c > > @@ -1880,12 +1880,19 @@ static void core_alua_put_tg_pt_gp_from_name( > > static void __target_attach_tg_pt_gp(struct se_lun *lun, > >

Re: [PATCH 5/6] target: Send UA upon LUN RESET tmr completion

2015-06-23 Thread Nicholas A. Bellinger
On Fri, 2015-06-19 at 15:06 +0200, Christoph Hellwig wrote: > On Thu, Jun 11, 2015 at 10:01:28AM +0200, Hannes Reinecke wrote: > > SAM mandates that an BUS DEVICE RESET FUNCTION OCCURRED > > UA needs to be send after a LUN RESET tmr has completed. > > > > Signed-off-by: Hannes Reinecke > > --- >

Re: [PATCH 6/6] target: Send UA when changing LUN inventory

2015-06-23 Thread Nicholas A. Bellinger
On Fri, 2015-06-19 at 15:07 +0200, Christoph Hellwig wrote: > > + hlist_for_each_entry_rcu(tmp, &nacl->lun_entry_hlist, link) { > > + if (tmp == new) > > + continue; > > + core_scsi3_ua_allocate(tmp, 0x3F, > > +

[PATCH] st: convert to using driver attr groups for sysfs

2015-06-23 Thread Seymour, Shane M
This patch changes the st driver to use attribute groups so driver sysfs files are created automatically. See the following for reference: http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ Signed-off-by: Shane Seymour --- --- a/drivers/scsi/st.c 2015-06-22 14:20:40.82961

Re: [PATCH 0/8] tcm_loop updates

2015-06-23 Thread Nicholas A. Bellinger
On Fri, 2015-06-19 at 09:13 +0200, Hannes Reinecke wrote: > On 06/19/2015 08:48 AM, Christoph Hellwig wrote: > > What's the benefit of the SAS transport class writeout? I honestly > > always saw tcm_loop as a simple loopback driver, with the different > > transport IDs in the PR code as a gimmick.

[PATCH] libiscsi: Fix host busy blocking during connection teardown

2015-06-23 Thread John Soni Jose
Issue: In case of hw iscsi offload, an host can have N-number of active connections. There can be IO's running on some connections which make host->host_busy always TRUE. Now if logout from a connection is tried then the code gets into an infinite loop as host->host_busy is always TRUE. isc

Re: [PATCH 0/8] tcm_loop updates

2015-06-23 Thread Hannes Reinecke
On 06/23/2015 10:29 AM, Nicholas A. Bellinger wrote: > On Fri, 2015-06-19 at 09:13 +0200, Hannes Reinecke wrote: >> On 06/19/2015 08:48 AM, Christoph Hellwig wrote: >>> What's the benefit of the SAS transport class writeout? I honestly >>> always saw tcm_loop as a simple loopback driver, with the

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Joe Lawrence
On 06/21/2015 02:46 PM, Timothy Pearson wrote: > On 06/16/2015 01:49 PM, Timothy Pearson wrote: >> On 06/16/2015 12:42 PM, Joe Lawrence wrote: >>> On 06/16/2015 12:28 PM, Timothy Pearson wrote: On 06/12/2015 05:05 PM, Timothy Pearson wrote: > The mpt2sas driver crashes if the BIOS does n

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Sreekanth Reddy
Hi, Upstream contributor should not add copyright to this driver code. Regards, Sreekanth On Tue, Jun 23, 2015 at 9:24 AM, Joe Lawrence wrote: > > > On 06/21/2015 02:46 PM, Timothy Pearson wrote: >> On 06/16/2015 01:49 PM, Timothy Pearson wrote: >>> On 06/16/2015 12:42 PM, Joe Lawrence wrote: >

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: > Hi, > > Upstream contributor should not add copyright to this driver code. I can't agree with that as a general rule: it depends on the significance of the contribution. The somewhat ill defined standard for this is the contribution mus

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Sreekanth Reddy
On Tue, Jun 23, 2015 at 7:05 PM, James Bottomley wrote: > On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: >> Hi, >> >> Upstream contributor should not add copyright to this driver code. > > I can't agree with that as a general rule: it depends on the > significance of the contribution.

Re: configurable discard parameters

2015-06-23 Thread Tom Yan
Still, I wonder if the kernel should allow the user to configure the real granularity and send ATA commands that are rounded off by it (which works just like --step in blkdiscard). For example, (64 * 65535) % 8 = 0 but 65535 % 8 = 7 So the block count limit for the ATA commands would be 65535 -

RE: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-23 Thread David Laight
From: Of James Bottomley > Sent: 22 June 2015 18:36 > To: Alan Stern ... > > > Obviously, for a disk with a writeback cache that can't do flush, that > > > window is much wider and the real solution should be to try to switch > > > the cache to write through. > > > > I agree. Doing the switch manu

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> I don't know whether the USB bridging or the way hdparm does TRIM Tom> matters, but it seems that some devices can't really handle limit Tom> like 0x3fffc0 blocks. The 0x3fffc0 limit is for SATA devices connected through Linux' libata SCSI ATA translation. Thi

[PATCH] sd: Fix maximum I/O size for BLOCK_PC requests

2015-06-23 Thread Martin K. Petersen
Commit bcdb247c6b6a ("sd: Limit transfer length") clamped the maximum size of an I/O request to the MAXIMUM TRANSFER LENGTH field in the BLOCK LIMITS VPD. This had the unfortunate effect of also limiting the maximum size of non-filesystem requests sent to the device through sg/bsg. Avoid using blk

[PATCH 1/2] sd: Sanity check the optimal I/O size

2015-06-23 Thread Martin K. Petersen
We have come across a couple of devices that report unreasonable values in the optimal I/O size in the Block Limits VPD page. Since this is a 32-bit entity that gets multiplied by the logical block size we can get disproportionately large values reported to the block layer. Cap io_opt at 256 MB.

[PATCH 2/2] scsi: Remove VPD quirk for Seagate drives

2015-06-23 Thread Martin K. Petersen
Now that we sanity check the optimal I/O size reported by the device we no longer need to blacklist the VPD pages on certain Seagate drives. Signed-off-by: Martin K. Petersen Cc: sta...@vger.kernel.org --- drivers/scsi/scsi_devinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scs

Re: [PATCH v2 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-23 Thread Martin K. Petersen
> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> In this patch, increased the number of MSIX vector support Sreekanth> for SAS3 C0 HBAs to up-to 96. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu

Re: [PATCH v1 09/20] [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-23 Thread Martin K. Petersen
> Sreekanth Reddy writes: > Following is the change set, 1. Added more defines for the BiosOptions > field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added > MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- T

Re: configurable discard parameters

2015-06-23 Thread Tom Yan
On 23 June 2015 at 23:36, Martin K. Petersen wrote: > > You haven't given us any reason to. We are not aware of any ATA drives > that put constraints on the range block count. > What I have been doing is trying to show you example of those constraints. When I talked about the block count limit of

Re: [Open-FCoE] [PATCH] [trivial] scsi:fcoe: Fix typo "a ethernet" in fcoe_transport.c

2015-06-23 Thread Vasu Dev
On Thu, 2015-06-04 at 00:54 +0900, Masanari Iida wrote: > This patch fix some "a ethernet" in MODULE_DESCRIPTIONS in > fcoe_transport.c > > Signed-off-by: Masanari Iida > --- > drivers/scsi/fcoe/fcoe_transport.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dr

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> Currently what the kernel does is assume all devices support 1 Tom> sector granularity. The ATA Command Set does not allow for any other granularity than 1 sector. Bigger granularity reporting is supported in SCSI SBC to allow for thinly provisioned disk arra

Re: configurable discard parameters

2015-06-23 Thread Tom Yan
On 24 June 2015 at 01:03, Martin K. Petersen wrote: > > It don't know what these "lower limits" you are talking about are. > [tom@localhost ~]$ sudo shred -v -n 1 /dev/sda3 [tom@localhost ~]$ sudo blkdiscard -l 512 /dev/sda3 [tom@localhost ~]$ sudo hexdump -n 4096 /dev/sda3 | head 000 58c7 f

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Timothy Pearson
On 06/23/2015 08:35 AM, James Bottomley wrote: On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: Hi, Upstream contributor should not add copyright to this driver code. I can't agree with that as a general rule: it depends on the significance of the contribution. The somewhat ill defi

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: > On 06/23/2015 08:35 AM, James Bottomley wrote: > > On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: > >> Hi, > >> > >> Upstream contributor should not add copyright to this driver code. > > > > I can't agree with that as a general

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Timothy Pearson
On 06/23/2015 12:45 PM, James Bottomley wrote: On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: On 06/23/2015 08:35 AM, James Bottomley wrote: On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: Hi, Upstream contributor should not add copyright to this driver code. I can't ag

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:47 -0500, Timothy Pearson wrote: > On 06/23/2015 12:45 PM, James Bottomley wrote: > > On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: > >> On 06/23/2015 08:35 AM, James Bottomley wrote: > >>> On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: > Hi, > >

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread Timothy Pearson
On 06/23/2015 12:56 PM, James Bottomley wrote: On Tue, 2015-06-23 at 12:47 -0500, Timothy Pearson wrote: On 06/23/2015 12:45 PM, James Bottomley wrote: On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: On 06/23/2015 08:35 AM, James Bottomley wrote: On Tue, 2015-06-23 at 18:06 +0530, S

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:59 -0500, Timothy Pearson wrote: > On 06/23/2015 12:56 PM, James Bottomley wrote: > > On Tue, 2015-06-23 at 12:47 -0500, Timothy Pearson wrote: > >> On 06/23/2015 12:45 PM, James Bottomley wrote: > >>> On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: > On 06/2

Re: [PATCH RESEND] Documentation/scsi: Documentation about scsi_cmnd lifecycle

2015-06-23 Thread Rajat Jain
Hello James, I haven't heard any feedback on this patch, so I was wondering if this documentation patch is something you're considering to review? Many thanks in advance, Rajat On Tue, Jun 9, 2015 at 10:43 AM, Rajat Jain wrote: > Add documentation to describe the various scenarios that the scs

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> So when libata issue ATA commands with ranges of 65535 sectors, Tom> only 65535-(65535%8) = 65528 sectors are discarded, That's unfortunate but TRIM is advisory so the drive is free to ignore all or parts of the request. What happens if you discard sectors 0-

[PATCH v2] mpt2sas: Abort initialization if no memory I/O resources detected

2015-06-23 Thread Timothy Pearson
The mpt2sas driver crashes if the BIOS does not set up at least one memory I/O resource. This failure can happen if the device is too slow to respond during POST and is missed by the BIOS, but Linux then detects the device later in the boot process. Signed-off-by: Timothy Pearson Tested-by: Timo

[PATCH] mpt3sas: Abort initialization if no memory I/O resources detected

2015-06-23 Thread Timothy Pearson
The mpt3sas driver crashes if the BIOS does not set up at least one memory I/O resource. This failure can happen if the device is too slow to respond during POST and is missed by the BIOS, but Linux then detects the device later in the boot process. Signed-off-by: Timothy Pearson --- drivers/sc

Re: configurable discard parameters

2015-06-23 Thread Tom Yan
First of all let me add another "statistic" about the issue: [tom@localhost ~]$ sudo shred -n 1 /dev/sda3 [tom@localhost ~]$ sudo blkdiscard /dev/sda3 [tom@localhost ~]$ sudo hexdump /dev/sda3 | wc -l 310635 [tom@localhost ~]$ sudo hexdump /dev/sda3 | pcregrep -M ' 000

Re: [PATCH] st: convert to using driver attr groups for sysfs

2015-06-23 Thread Greg KH
On Tue, Jun 23, 2015 at 08:11:00AM +, Seymour, Shane M wrote: > This patch changes the st driver to use attribute groups so > driver sysfs files are created automatically. See the > following for reference: > > http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ > > Sig

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> total untrimmed sectors: (310635 - 1 - 2410) / 32 = 9632 total Tom> ranges: (43 GiB * (1024 ^ 3) / 512) / 65535 ~= 1376 average Tom> untrimmed sectors per range: (9632 / 1376) = 7 = (65535 % 8) Every type of drive has its own internal restrictions. Unless the

[PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-06-23 Thread linux
Support HighPoint RR36xx HBAs which are based on Marvell Frey. Support SAS tape and SAS media changer. Signed-off-by: HighPoint Linux Team drivers/scsi/hptiop.c | 104 +++ drivers/scsi/hptiop.h |6 +-- 2 files changed, 69 insertio

RE: [Patch V2 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 4/9] [SCSI] aacraid: Enable 64-bit write to controller register

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 2/9] [SCSI] aacraid: Add Power Management support

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 3/9] [SCSI] aacraid: Enable MSI interrupt for series-6 controller

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 6/9] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 5/9] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 7/9] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:12 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 8/9] [SCSI] aacraid: Send commit-config to controller firmware

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:13 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [Patch V2 9/9] [SCSI] aacraid: Update driver version

2015-06-23 Thread Mahesh Rajashekhara
Reviewed-by: Mahesh Rajashekhara -Original Message- From: Rajinikanth Pandurangan Sent: Thursday, June 11, 2015 7:13 AM To: jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Mahesh Rajashekhara; Rich Bono; Achim Leubner; Murthy Bhat; Rajinikan

RE: [PATCH] megaraid:Make functions static in the file megaraid_sas_base.c

2015-06-23 Thread Sumit Saxena
-Original Message- From: Nicholas Krause [mailto:xerofo...@gmail.com] Sent: Wednesday, June 24, 2015 5:43 AM To: kashyap.de...@avagotech.com Cc: sumit.sax...@avagotech.com; uday.ling...@avagotech.com; jbottom...@odin.com; megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org; linux-ke

st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-23 Thread Seymour, Shane M
Convert DRIVER_ATTR macros to DRIVER_ATTR_RO as requested by Greg KH. Also switched to using sprintf as nothing printed should exceed PAGE_SIZE - based on feedback from Greg when implementing show functions for tape stats. Suggested-by: Greg Kroah-Hartman Signed-off-by: Shane Seymour --- This p

[PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-23 Thread Seymour, Shane M
Convert DRIVER_ATTR macros to DRIVER_ATTR_RO as requested by Greg KH. Also switched to using sprintf as nothing printed should exceed PAGE_SIZE - based on feedback from Greg when implementing show functions for tape stats. Suggested-by: Greg Kroah-Hartman Signed-off-by: Shane Seymour --- This p

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-23 Thread Sergey Senozhatsky
On (06/24/15 06:10), Seymour, Shane M wrote: [..] > > /* The sysfs driver interface. Read-only at the moment */ > -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) > +static ssize_t try_direct_io_show(struct device_driver *ddp, char *buf) > { > - return snprintf(bu

[PATCH v2] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-23 Thread Seymour, Shane M
Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by Greg KH. Also switched to using scnprintf instead of snprintf per Documentation/filesystems/sysfs.txt. Suggested-by: Greg Kroah-Hartman Signed-off-by: Shane Seymour --- This patch was implemented on top of the previous patch to convert t