Re: [PATCH] mvsas: always iounmap resources

2015-06-22 Thread Johannes Thumshirn
On Fri, Jun 12, 2015 at 08:31:38AM +0200, Hannes Reinecke wrote: > On 05/22/2015 11:15 AM, Johannes Thumshirn wrote: > > In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap > > returns without doing an iounmap() of mvi->regs_ex. > > > > Found by the cocinelle tool. > > > >

Re: [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-22 Thread Sreekanth Reddy
On Sat, Jun 20, 2015 at 1:57 AM, Martin K. Petersen wrote: >> Sreekanth Reddy writes: > >> @@ -1334,9 +1336,17 @@ typedef struct _MPI2_CONFIG_PAGE_BIOS_1 { >> *PTR_MPI2_CONFIG_PAGE_BIOS_1, >> Mpi2BiosPage1_t, *pMpi2BiosPage1_t; >> >> -#define MPI2_BIOSPAGE1_PAGEVERSION

Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-22 Thread Sreekanth Reddy
On Sat, Jun 20, 2015 at 2:14 AM, Martin K. Petersen wrote: >> Sreekanth Reddy writes: > >> Added support for below customer specific brandings "VendorID" >> "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding >> String 0x1000 0x97 0x1137 0x154 Cisco 9300-8i 12Gbps SAS HBA 0x10

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Sreekanth Reddy
On Fri, Jun 19, 2015 at 8:27 PM, Martin K. Petersen wrote: >> "Sreekanth" == Sreekanth Reddy writes: > > Sreekanth, > > It's fine that you outline the 96 / 12 = 8 layout in the patch > description. But that relationship is not made clear when reading the > code. Please add a comment describin

[PATCH v2 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Sreekanth Reddy
In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. This feature is enabled only for SAS3 C0 and higher revision cards and also only when reply post free queue count is greater than 8. 2. To support this fe

[PATCH v1 09/20] [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-22 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 14 +

Re: OOPS: unplugging western digital passport drive

2015-06-22 Thread Joe Lawrence
Hi Alan -- last I heard from Stan on this bug was April 14 -- he was on "long holidays" at that time :) -- Joe On 06/17/2015 03:09 PM, Alan Stern wrote: > Joe or Stanisナ^ツaw: > > I never heard anything back about this. Does the patch fix the crash? > > Alan Stern > > > On Wed, 18 Mar 2015, A

Re: optimal io size / custom alignment

2015-06-22 Thread Alan Stern
On Sun, 21 Jun 2015, Tom Yan wrote: > I was not saying RAIDs are virtual devices. I just mentioned it > because I saw things like virtio-blk or zram use blk_queue_io_opt(). > > I know they all use VPDs, but the main point is whether those hardware > RAIDs or so are handled by sd_mod, and whether

Re: OOPS: unplugging western digital passport drive

2015-06-22 Thread Alan Stern
On Mon, 22 Jun 2015, Joe Lawrence wrote: > Hi Alan -- last I heard from Stan on this bug was April 14 -- he was on > "long holidays" at that time :) > > -- Joe Without knowing whether the patch really fixes the problem, I can't tell whether it should be submitted! Alan Stern -- To unsubscribe

[PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Alan Stern
Some USB mass-storage devices claim to have a write-back cache but don't support the SYNCHRONIZE CACHE command, which means there is no way to tell these devices to flush their caches out to permanent storage. Unfortunately, there is nothing we can do about this. Until recently this deficiency di

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 10:55 -0400, Alan Stern wrote: > Some USB mass-storage devices claim to have a write-back cache but > don't support the SYNCHRONIZE CACHE command, which means there is no > way to tell these devices to flush their caches out to permanent > storage. Unfortunately, there is not

Re: [PATCH] Doc: Docbook: Change wikipedia's URL from http to https in scsi.tmpl

2015-06-22 Thread Jonathan Corbet
On Thu, 18 Jun 2015 23:44:25 +0900 Masanari Iida wrote: > Recently wikipedia announced to secure access to the servers. > Now all http access re-route to https. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Alan Stern
On Mon, 22 Jun 2015, James Bottomley wrote: > I'm not sure I entirely like this: we are back again treating data > corruption problems silently. > > However, I also believe treating a single flush failure as a critical > filesystem error is also wrong: The data's all there correctly; all it > d

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > On Mon, 22 Jun 2015, James Bottomley wrote: > > > I'm not sure I entirely like this: we are back again treating data > > corruption problems silently. > > > > However, I also believe treating a single flush failure as a critical > > filesyst

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Alan Stern
On Mon, 22 Jun 2015, James Bottomley wrote: > On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > > I'm not sure I entirely like this: we are back again treating data > > > corruption problems silently. > > > > > > However, I also believe

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Markus Rathgeb
>> > Maybe your patch will be acceptable, though. We'll have to hear from >> > Markus and Matt. >> >> We'll probably have to take this to fsdevel as well ... they might have >> opinions about whether the FS wants to be informed about flush failure. So, it is okay to wait for the end of that discu

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Alan Stern
On Mon, 22 Jun 2015, Markus Rathgeb wrote: > >> > Maybe your patch will be acceptable, though. We'll have to hear from > >> > Markus and Matt. > >> > >> We'll probably have to take this to fsdevel as well ... they might have > >> opinions about whether the FS wants to be informed about flush fail

Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-22 Thread Martin K. Petersen
> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> I agree with you that these changes belong in pci.ids. But Sreekanth> Customers are asking us to print the HBA branding name while Sreekanth> loading the driver on their custom HBA's. Yes, and other HBA vendors have done the same (although

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Martin K. Petersen
> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> I will remove these extra brackets. but SAS3 HBA's less than Sreekanth> C0 revision (which doesn't support this Combined Reply Queue Sreekanth> feature) will support up to 16 MSI-X vectors. Ah, I missed that. Fair enough. -- Martin K. Pet

Re: configurable discard parameters

2015-06-22 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> However, I am curious what is the meaning of "Our current TRIM Tom> payload is a single sector that can accommodate 64 * 65535 blocks Tom> being unmapped. Report this value in the Block Limits Maximum Unmap Tom> LBA count field." in the commit message. What doe

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 13:48 -0400, Alan Stern wrote: > On Mon, 22 Jun 2015, James Bottomley wrote: > > > On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > > > > I'm not sure I entirely like this: we are back again treating data > > > >

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread Markus Rathgeb
> Please test it now. I'd like to know if it fixes your problem, > regardless of how the discussion goes. Seems to be working, I also attached the kernel log. The "flush failed" will grow with disc activity (but that was to be expected). Jun 22 23:24:50 m3800 kernel: usb 1-3: new high-speed USB

[GIT PULL] SCSI updates for the 4.0+ merge window

2015-06-22 Thread James Bottomley
This is the usual grab bag of driver updates (lpfc, hpsa, megaraid_sas, cxgbi, be2iscsi) plus an assortment of minor updates. There are also two new drivers: the Cisco snic and the IBM cxlflash; the advansys driver has been rewritten to get rid of the warning about converting it to the DMA API, th

[PATCH 1/1] ipr: Fix incorrect trace indexing

2015-06-22 Thread Brian King
James, One more ipr patch to go on top of my previous series I sent. This one fixes a pretty nasty bug that can cause us to go writing in memory that is not ours. 8< When ipr's internal driver trace was changed to an atomic, a signed/unsigned bug slipped in which results in us indexing backward

Re: [GIT PULL] SCSI updates for the 4.0+ merge window

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 14:31 -0700, James Bottomley wrote: > This is the usual grab bag of driver updates (lpfc, hpsa, megaraid_sas, > cxgbi, be2iscsi) plus an assortment of minor updates. There are also > two new drivers: the Cisco snic and the IBM cxlflash; the advansys > driver has been rewritte

[GIT PULL v2] SCSI updates for the 4.1+ merge window

2015-06-22 Thread James Bottomley
This is a resend of the original tree with the tag attached at original commit c8806b6 snic: driver for Cisco SCSI HBA --- This is the usual grab bag of driver updates (lpfc, hpsa, megaraid_sas, cxgbi, be2iscsi) plus an assortment of minor updates. There are also one new driver: the Cisco snic; t

[PATCH 1/1] scsi: remove redundant NULL check before kfree

2015-06-22 Thread Maninder Singh
There is no need of NULL check before kfree, So removing the same. Signed-off-by: Maninder Singh Reviewed-by: Rohit Thapliyal --- drivers/scsi/aic94xx/aic94xx_init.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic9

Re: [PATCH 1/1] scsi: remove redundant NULL check before kfree

2015-06-22 Thread Hannes Reinecke
On 06/23/2015 05:42 AM, Maninder Singh wrote: > There is no need of NULL check before kfree, > So removing the same. > > Signed-off-by: Maninder Singh > Reviewed-by: Rohit Thapliyal If you insist ... Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke