Re: optimal io size / custom alignment

2015-06-16 Thread Tom Yan
I heard about that it matters for RAID but since I don't really know about RAID so I can't comment. I do wonder whether the scsi disk driver should derive minimum/optimal i/o size from VPD at all then. It might still be "tolerable" if it's the limit of WRITE SAME(10), but definitely not if it's th

how to "decode" SG_IO: bad/missing sense data?

2015-06-16 Thread Tom Yan
When I "ATA Secure Erase" a USB Flash Drive, I got: SG_IO: bad/missing sense data, sb[]: f0 00 01 00 50 40 00 0a 00 00 00 00 00 1d 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 While the erase seems to work without bricking the device (multiple trials with shred and hexdump), this messag

Re: how to "decode" SG_IO: bad/missing sense data?

2015-06-16 Thread Douglas Gilbert
On 15-06-16 01:05 PM, Tom Yan wrote: When I "ATA Secure Erase" a USB Flash Drive, I got: SG_IO: bad/missing sense data, sb[]: f0 00 01 00 50 40 00 0a 00 00 00 00 00 1d 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 While the erase seems to work without bricking the device (multiple tria

Re: [Patch V2 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:23PM -0700, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > Driver sends the right size of the response buffer. > > Signed-off-by: Rajinikanth Pandurangan > --- > drivers/scsi/aacraid/aachba.c | 4 ++-- > 1 file ch

Re: [Patch V2 3/9] [SCSI] aacraid: Enable MSI interrupt for series-6 controller

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:25PM -0700, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > Enable MSI interrupt mode for series-6 controller. > > Signed-off-by: Rajinikanth Pandurangan > --- > drivers/scsi/aacraid/src.c | 2 +- > 1 file changed,

Re: [Patch V2 6/9] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:28PM -0700, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > Reset irq affinity hints before releasing IRQ > Removed duplicate code of IRQ acquire/release > > Signed-off-by: Rajinikanth Pandurangan > --- >

Re: [Patch V2 7/9] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:29PM -0700, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > Driver blocks ioctls once it received shutdown/suspend request during > suspend/hybernation. This patch unblocks ioctls on resume path. > > Signed-off

Re: [Patch V2 9/9] [SCSI] aacraid: Update driver version

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:31PM -0700, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Signed-off-by: Rajinikanth Pandurangan > --- > drivers/scsi/aacraid/aacraid.h | 2 +- > drivers/scsi/aacraid/linit.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-

Re: [PATCH 1/4] ipr: Fix locking for unit attention handling

2015-06-16 Thread Gabriel Krisman Bertazi
Brian King writes: > Make sure we have the host lock held when calling scsi_report_bus_reset. Fixes > a crash seen as the __devices list in the scsi host was changing as we were > iterating through it. Brian, The patch series look good to me as a whole, thanks for doing that. Please add the tag

Re: how to "decode" SG_IO: bad/missing sense data?

2015-06-16 Thread Tom Yan
I knew both sg_decode_sense and the SAT spec, but I didn't think of using them together to decode this. (Didn't bother to download the spec as well because it requires a bit of "registration" :P) Thanks for the pointer. According to the latest draft, if "CK_COND" is set to 1, the sense data return

Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-16 Thread Tomas Henzl
On 06/12/2015 11:42 AM, Sreekanth Reddy wrote: > Driver initialization fails if driver tries to send IOC facts request message > when the IOC is in reset or in a fault state. > > This patch will make sure that > 1.Driver to send IOC facts request message only if HBA is in operational or > ready

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-16 Thread Timothy Pearson
On 06/12/2015 05:05 PM, Timothy Pearson wrote: The mpt2sas driver crashes if the BIOS does not set up at least one memory I/O resource. This failure can happen if the device is too slow to respond during POST and is missed by the BIOS, but Linux then detects the device later in the boot process.

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-16 Thread Joe Lawrence
On 06/16/2015 12:28 PM, Timothy Pearson wrote: > On 06/12/2015 05:05 PM, Timothy Pearson wrote: >> The mpt2sas driver crashes if the BIOS does not set up at least one >> memory I/O resource. This failure can happen if the device is too >> slow to respond during POST and is missed by the BIOS, but L

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-16 Thread Timothy Pearson
On 06/16/2015 12:42 PM, Joe Lawrence wrote: On 06/16/2015 12:28 PM, Timothy Pearson wrote: On 06/12/2015 05:05 PM, Timothy Pearson wrote: The mpt2sas driver crashes if the BIOS does not set up at least one memory I/O resource. This failure can happen if the device is too slow to respond during

Re: optimal io size / custom alignment

2015-06-16 Thread Tom Yan
On 17 June 2015 at 01:08, Martin K. Petersen wrote: > The two values have nothing to do with each other. They just happen to > be the same in your case (65535 is the maximum block count for the WRITE > SAME(10) command). > > Your device sets the transfer length granularity to 1 logical block and >

Re: optimal io size / custom alignment

2015-06-16 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> All drives I have are flash drives so none of them reports 4k Tom> physical sectors. There are plenty of SSDs that report 4K physical sectors, fwiw. Tom> The usb-storage driver does not read vpd so it won't be a thing, Tom> but the the uas driver does. We ga

Re: [PATCH 1/1] [PATCH] block: Add blk_max_rw_sectors limit

2015-06-16 Thread Martin K. Petersen
Brian, I only have minor nits wrt. your patch since you did what I asked. However, now that I'm less jet lagged and blurry eyed I wonder if the tweak below wouldn't suffice? sd: Fix maximum I/O size for BLOCK_PC requests Commit bcdb247c6b6a ("sd: Limit transfer length") clamped the maximum

[PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

2015-06-16 Thread Chris Leech
The iSCSI session recovery_tmo setting is writeable in sysfs, but it's also set every time a connection is established when parameters are set from iscsid over netlink. That results in the timeout being reset to the default value after every recovery. The DM multipath tools want to use the sysfs

Re: [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs

2015-06-16 Thread Nicholas A. Bellinger
Hey Hannes, Apologies for the delayed follow-up on these, one comment below. On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: > We need to use 'se_dev_entry' as argument when allocating > UAs, otherwise we'll never see any UAs for an implicit > ALUA state transition triggered from usersp

[PATCH] mpt2sas: setpci reset kernel panic fix

2015-06-16 Thread Nagarajkumar Narayanan
Problem Description: https://bugzilla.kernel.org/show_bug.cgi?id=95101 Due to lack of synchronization between ioctl, BRM status access, pci resource removal kernel oops happen as ioctl path and BRM status access path still tries to access the removed resources kernel: BUG: unable to handle kerne

Re: [PATCH 0/6] target: Update UA handling

2015-06-16 Thread Nicholas A. Bellinger
On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: > Hi Nic, > > lio-target is very minimalistic when it comes to generate UAs; > primarily they are generated for persistent reservations, but > generic changes tend to be ignored. > > This patchset updates the UA handling and generates UA f

Re: [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs

2015-06-16 Thread Hannes Reinecke
On 06/17/2015 08:06 AM, Nicholas A. Bellinger wrote: > Hey Hannes, > > Apologies for the delayed follow-up on these, one comment below. > > On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: >> We need to use 'se_dev_entry' as argument when allocating >> UAs, otherwise we'll never see any

Re: [PATCH 0/6] target: Update UA handling

2015-06-16 Thread Hannes Reinecke
On 06/17/2015 08:10 AM, Nicholas A. Bellinger wrote: > On Thu, 2015-06-11 at 10:01 +0200, Hannes Reinecke wrote: >> Hi Nic, >> >> lio-target is very minimalistic when it comes to generate UAs; >> primarily they are generated for persistent reservations, but >> generic changes tend to be ignored. >>

Re: [PATCH] mpt2sas: setpci reset kernel panic fix

2015-06-16 Thread Johannes Thumshirn
On Wed, Jun 17, 2015 at 11:37:53AM +0530, Nagarajkumar Narayanan wrote: > Problem Description: > > https://bugzilla.kernel.org/show_bug.cgi?id=95101 > > Due to lack of synchronization between ioctl, BRM status access, pci > resource removal kernel oops happen as ioctl path and BRM status > access