Re: [PATCH 7/7] block: allocate block_pc data separate from struct request

2015-05-11 Thread Christoph Hellwig
On Wed, May 06, 2015 at 02:46:18PM +0300, Boaz Harrosh wrote: > > - memset(rq->__cmd, 0, sizeof(rq->__cmd)); > > + > > + rq->block_pc = kzalloc(sizeof(*rq->block_pc) + cmd_len, gfp); > > I wish you would not embed a dynamic allocation here for any > driver regardless. This extra allocation doe

Re: [PATCH 02/17] scsi_dh_alua: Disable ALUA handling for non-disk devices

2015-05-11 Thread Hannes Reinecke
On 05/11/2015 08:46 AM, Christoph Hellwig wrote: > On Mon, May 04, 2015 at 02:42:08PM +0200, Hannes Reinecke wrote: >> Non-disk devices should be ignored when detecting >> ALUA capabilities. > > Hmm. I don't think we should even attach the alua handler in this case, > e.g. refine the check in scs

[PATCH v1 2/2] phy: update obsolete configuration of ARCH_MSM into ARCH_QCOM

2015-05-11 Thread Yaniv Gardi
Since ARCH_MSM is no longer supported as configuration definition, it should be modified into ARCH_QCOM in order to add support for Qualcomm platforms. Signed-off-by: Yaniv Gardi --- drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/Kconfig b/dr

Re: [PATCH v1 2/2] phy: update obsolete configuration of ARCH_MSM into ARCH_QCOM

2015-05-11 Thread Stephen Boyd
On 05/11/15 08:15, Yaniv Gardi wrote: > Since ARCH_MSM is no longer supported as configuration definition, > it should be modified into ARCH_QCOM in order to add support for > Qualcomm platforms. > > Signed-off-by: Yaniv Gardi > > --- I've already sent this patch[1]. Can you please ack it? [1] h

Re: [PATCH v5 8/9] snic:Add event tracing to capture IO events.

2015-05-11 Thread Hannes Reinecke
On 04/22/2015 11:24 AM, Narsimhulu Musini wrote: > snic_trc.h contains global trace structure definitions for snic driver > > snic_trc.c adds tracing functionality to capture various IO events. > It maintains global trace buffer to maintain recent history of IO events. > It helps to understand the