Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-27 Thread Hannes Reinecke
On 04/26/2015 08:52 PM, James Bottomley wrote: > On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: >> On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: >>> Ancient, and pretty much obsolete by now. >>> >>> Signed-off-by: Hannes Reinecke >>> --- >>> drivers/scsi/advansys.c | 18 -

[PATCH] sd: Fixup capacity for standby ports

2015-04-27 Thread Hannes Reinecke
If a target port is in ALUA 'standby' state it does not need to respond to a 'READ CAPACITY' command. So fixup the initialization for these cases. Signed-off-by: Hannes Reinecke --- drivers/scsi/sd.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/sc

[PATCH] sd: always retry READ CAPACITY for ALUA state transition

2015-04-27 Thread Hannes Reinecke
During ALUA state transitions the device might return a sense code 02/04/0a (Logical unit not accessible, asymmetric access state transition). As this is a transient error we should just retry the READ CAPACITY call until the state transition finishes and the correct capacity can be returned. Sign

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-27 Thread Tomas Henzl
On 04/26/2015 11:27 AM, Greg KH wrote: > On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: >> On 04/11/2015 12:45 AM, Vinson Lee wrote: >>> On Tue, Jan 27, 2015 at 4:18 PM, Greg KH wrote: On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: > On 01/05/2015 07:41 PM, Mas

Re: [PATCH v3 1/5] target: ensure se_cmd->t_prot_sg is allocated when required

2015-04-27 Thread Akinobu Mita
2015-04-26 18:44 GMT+09:00 Sagi Grimberg : >>> @@ -2181,6 +2182,12 @@ static inline void >>> transport_reset_sgl_orig(struct se_cmd *cmd) >>> >>> static inline void transport_free_pages(struct se_cmd *cmd) >>> { >>> +if (!(cmd->se_cmd_flags & SCF_PASSTHROUGH_PROT_SG_TO_MEM_NOALLOC)) { >>> +

[PATCH v2] virtio_scsi: don't select CONFIG_BLK_DEV_INTEGRITY

2015-04-27 Thread Christoph Hellwig
T10 PI is just another optional feature, LLDDs should work without the infrastructure. Signed-off-by: Christoph Hellwig --- drivers/scsi/Kconfig | 1 - drivers/scsi/virtio_scsi.c | 11 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/Kconfig b/drive

Re: [PATCH v3 4/5] target: Fix sbc_dif_generate() and sbc_dif_verify() for WRITE SAME

2015-04-27 Thread Akinobu Mita
2015-04-26 18:53 GMT+09:00 Sagi Grimberg : > On 4/25/2015 5:33 PM, Akinobu Mita wrote: >> >> For WRITE SAME, data transfer memory only contains a single block but >> protection information is required for all blocks that are written by >> the command. >> >> This makes sbc_dif_generate() and sbc_dif

Re: [PATCH v2] virtio_scsi: don't select CONFIG_BLK_DEV_INTEGRITY

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 14:56, Christoph Hellwig wrote: > T10 PI is just another optional feature, LLDDs should work without > the infrastructure. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/Kconfig | 1 - > drivers/scsi/virtio_scsi.c | 11 ++- > 2 files changed, 10 insertio

Re: [PATCH v3 5/5] target/file: enable WRITE SAME when protection info is enabled

2015-04-27 Thread Akinobu Mita
2015-04-26 18:58 GMT+09:00 Sagi Grimberg : > On 4/25/2015 5:33 PM, Akinobu Mita wrote: >> >> Now we can generate correct PI for WRITE SAME command, so it is >> unnecessary to disallow WRITE SAME when protection info is enabled. >> >> Signed-off-by: Akinobu Mita >> Cc: Nicholas Bellinger >> Cc: Sa

Re: [PATCH v3 3/5] target: handle odd SG mapping for data transfer memory

2015-04-27 Thread Akinobu Mita
2015-04-26 19:07 GMT+09:00 Sagi Grimberg : > On 4/25/2015 5:33 PM, Akinobu Mita wrote: >> >> sbc_dif_generate() and sbc_dif_verify() currently assume that each >> SG element for data transfer memory doesn't straddle the block size >> boundary. >> >> However, when using SG_IO ioctl, we can choose th

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote: > On 04/26/2015 11:27 AM, Greg KH wrote: > > On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: > >> On 04/11/2015 12:45 AM, Vinson Lee wrote: > >>> On Tue, Jan 27, 2015 at 4:18 PM, Greg KH wrote: > On Tue, Jan 06, 2015 at

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-27 Thread Tomas Henzl
On 04/27/2015 02:55 PM, Greg KH wrote: > On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote: >> On 04/26/2015 11:27 AM, Greg KH wrote: >>> On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: On 04/11/2015 12:45 AM, Vinson Lee wrote: > On Tue, Jan 27, 2015 at 4:18 PM, Greg

Re: [PATCH v3 1/5] target: ensure se_cmd->t_prot_sg is allocated when required

2015-04-27 Thread Sagi Grimberg
On 4/27/2015 3:57 PM, Akinobu Mita wrote: 2015-04-26 18:44 GMT+09:00 Sagi Grimberg : @@ -2181,6 +2182,12 @@ static inline void transport_reset_sgl_orig(struct se_cmd *cmd) static inline void transport_free_pages(struct se_cmd *cmd) { +if (!(cmd->se_cmd_flags & SCF_PASSTHROUGH_PROT_SG_

Re: BUG: unable to handle kernel NULL pointer deref, bisected to 746650160

2015-04-27 Thread Torsten Luettgert
On Wed, 22 Apr 2015 10:45:19 +0200 Torsten Luettgert wrote: > I'll keep this running, and if - when - it has been going for a week > (3 times the max uptime without the patch) - I'll give a final notice. So here it is, the final notice: 17:16:36 up 7 days, 4:07, 2 users, load average: 3.64, 3

Re: [PATCH v2] virtio_scsi: don't select CONFIG_BLK_DEV_INTEGRITY

2015-04-27 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> T10 PI is just another optional feature, LLDDs should work Christoph> without the infrastructure. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu