On Fri, Apr 24, 2015 at 04:33:55PM -0700, K. Y. Srinivasan wrote:
> Set the SRB flags correctly when there is no data transfer.
>
What are the user visible effects of this bug? We transfer bogus data?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scs
Even if the device backend is initialized with protection info is
enabled, some requests don't have the protection info attached for
WRITE SAME command issued by block device helpers, WRITE command with
WRPROTECT=0 by SG_IO ioctl, etc.
So when TCM loopback fabric module is used, se_cmd->t_prot_sg
Now we can generate correct PI for WRITE SAME command, so it is
unnecessary to disallow WRITE SAME when protection info is enabled.
Signed-off-by: Akinobu Mita
Cc: Nicholas Bellinger
Cc: Sagi Grimberg
Cc: "Martin K. Petersen"
Cc: Christoph Hellwig
Cc: "James E.J. Bottomley"
Cc: target-de...@
For WRITE SAME, data transfer memory only contains a single block but
protection information is required for all blocks that are written by
the command.
This makes sbc_dif_generate() and sbc_dif_verify() work for WRITE_SAME.
Signed-off-by: Akinobu Mita
Cc: Nicholas Bellinger
Cc: Sagi Grimberg
sbc_dif_generate() and sbc_dif_verify() currently assume that each
SG element for data transfer memory doesn't straddle the block size
boundary.
However, when using SG_IO ioctl, we can choose the data transfer
memory which doesn't satisfy that alignment requirement.
In order to handle such cases
Some architectures enable sg chaining option while others do not.
The requirement to enable sg chaining is that pages must be aligned
at a 32-bit boundary in order to overload the LSB of the pointer.
Regardless of whether ARCH_HAS_SG_CHAIN is defined or not, the above
requirement is always chacked
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Saturday, April 25, 2015 12:05 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@inf
7 matches
Mail list logo