The driver has now been converted to DMA-API, so we should
increase the version number and remove the compilation
warning.
Signed-off-by: Hannes Reinecke
---
MAINTAINERS | 1 +
drivers/scsi/Kconfig| 2 +-
drivers/scsi/advansys.c | 25 +
3 files changed,
Use 'bool' type instead.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 79 -
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index bf97af3..9482d4e 100644
--- a/driver
The 'data_addr' field is accessed by the board, and needs
to be kept in little endian format.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9e09008..d9
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 98efd41..424a08d 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -884,16 +884,6 @@ typedef struct
These definitions are only ever used for the wide-scsi board,
so they should be prefixed with 'ADV', not 'ASC'.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi
Unused, so remove it.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index ec77161..98efd41 100644
--- a/drivers/scsi/advansys.c
+++
Removed unused structure ASC_SCSI_REQ_Q and update the
comments to 'ADV_SCSI_REQ_Q'.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
AscIsrChipHalted will only ever return '0', so make it
a void function.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9d78faa.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index b4a7a67..52e2afd 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advans
Was uncommented in the original driver, and I'm too lazy to
figure out the conversion.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 243 +---
1 file changed, 5 insertions(+), 238 deletions(-)
diff --git a/drivers/scsi/advansys.c b/driv
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 35 +--
1 file changed, 13 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 54e8d89..9e09008 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/adv
Ancient, and pretty much obsolete by now.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 424a08d..4f9392d 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/sc
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't made this warning go away.
So here's a patchset to update the advansys driver to current
standards and use the D
On 23/04/2015 20:10, Christoph Hellwig wrote:
> T10 PI is just another optional feature, LLDDs should work without
> the infrastructure.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/Kconfig | 1 -
> drivers/scsi/virtio_scsi.c | 11 ++-
> 2 files changed, 10 insertio
On Fri, Apr 24, 2015 at 10:32:54AM +0200, Hannes Reinecke wrote:
> Ancient, and pretty much obsolete by now.
And still doesn't address the fixme. You probably should remove the
cmd_per_lun setting entirely.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
> config SCSI_ADVANSYS
> tristate "AdvanSys SCSI support"
> - depends on SCSI && VIRT_TO_BUS && !ARM
> + depends on SCSI && !ARM
Care to remove the bogus call to dma_cache_sync and allow compiling on
arm as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-scs
On 04/24/2015 11:41 AM, Christoph Hellwig wrote:
> On Fri, Apr 24, 2015 at 10:32:54AM +0200, Hannes Reinecke wrote:
>> Ancient, and pretty much obsolete by now.
>
> And still doesn't address the fixme. You probably should remove the
> cmd_per_lun setting entirely.
>
Okay, will do.
Cheers,
Hann
On 04/24/2015 11:42 AM, Christoph Hellwig wrote:
>> config SCSI_ADVANSYS
>> tristate "AdvanSys SCSI support"
>> -depends on SCSI && VIRT_TO_BUS && !ARM
>> +depends on SCSI && !ARM
>
> Care to remove the bogus call to dma_cache_sync and allow compiling on
> arm as well?
>
Sure, no pr
Driver was not freeing the DMA memory allocated for EQ/CQ in the
unload path. This patch frees the DMA memory during the driver unload.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_main.c | 18 --
1 files changed, 12 insertion
Increment the retry count to get the boot target info when
port async event is received by the driver. Update sysfs enteries
with the boot target parameters.
Signed-off-by: Minh Tran
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_cmds.c |4
The patchset updates be2iscsi driver to 10.6.0.0 version.
These patches are generated aganist scsi for-next branch
John Soni Jose (7):
be2iscsi : Fix the retry count for boot targets
be2iscsi : Fix the PCI request region reserving.
be2iscsi : Fix memory leak in the unload path
be2iscsi :
Bump the driver version
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_main.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index 3ddde6f..b4108f8 100644
Reserve device PCI I/O and Memory resources.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_main.c | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2isc
Check DMA memory before it is unmapped.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_main.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be.h |2 +-
drivers/scsi/be2iscsi/be_cmds.c |2 +-
drivers/scsi/be2iscsi/be_cmds.h |2 +-
drivers/scsi/be2iscsi/be_iscsi.c |2 +-
drivers/scsi/be2iscsi/be_iscsi.h |2 +-
drivers
Once be2iscsi driver is loaded and operational close Boot
session established by FW.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
---
drivers/scsi/be2iscsi/be_cmds.h | 12 +++
drivers/scsi/be2iscsi/be_main.c |3 ++
drivers/scsi/be2iscsi/be_mgmt.c | 69 +
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 236 +---
1 file changed, 103 insertions(+), 133 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index dba8c1a..f3fecd5 100644
--- a/drivers/scsi/advansys.c
+++ b/
Convert to use a shared host tag map for command lookup. This
saves us having an internal structure and avoid the command
pointer abuse.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 225 +---
1 file changed, 79 insertions(+), 146 deleti
Unused, so remove it.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index f01839b..be89245 100644
--- a/drivers/scsi/advansys.c
+++
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 973c3d8..35fc291 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -78,7 +78,6 @@
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 35 +--
1 file changed, 13 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 23a4a7d..ad5c5f9 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/adv
No point in defining our own.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 172 +++-
1 file changed, 66 insertions(+), 106 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index b02c999c..1f9d6464 100644
---
Use 'bool' type instead.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 79 -
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 1f9d6464..973c3d8 100644
--- a/drive
The driver has now been converted to DMA-API, so we should
increase the version number and remove the compilation
warning.
Signed-off-by: Hannes Reinecke
---
MAINTAINERS | 1 +
drivers/scsi/Kconfig| 2 +-
drivers/scsi/advansys.c | 27 +++
3 files changed
Hi all,
it has been bugged me for ages that the advansys driver always
reported a compilation warning about not having been converted
to the DMA-API.
And even aggressive waiting hasn't made this warning go away.
So here's a patchset to update the advansys driver to current
standards and use the D
Removed unused structure ASC_SCSI_REQ_Q and update the
comments to 'ADV_SCSI_REQ_Q'.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index b8b5985..b02c999c 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advan
AscIsrChipHalted will only ever return '0', so make it
a void function.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 35fc291.
The driver has now been converted to DMA-API, so we should
increase the version number and remove the compilation
warning.
Signed-off-by: Hannes Reinecke
---
MAINTAINERS | 1 +
drivers/scsi/Kconfig| 2 +-
drivers/scsi/advansys.c | 25 +
3 files changed,
Ancient, and pretty much obsolete by now.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 74e5518..5a55272 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/
The advansys_reset() function is actually a host reset, not a
bus reset. And there is no need to have a 'last_reset'
value; the same value exists in struct Scsi_Host.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 27 +++
1 file changed, 11 insertions(+), 16
The sg elements should be allocated from a dma pool.
And rename the structure to 'adv_sg_block' as they
are only used by the wide board.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 108
1 file changed, 45 insertions(+), 63 deletio
On 04/24/2015 01:18 PM, Hannes Reinecke wrote:
> The driver has now been converted to DMA-API, so we should
> increase the version number and remove the compilation
> warning.
>
> Signed-off-by: Hannes Reinecke
> ---
Gnaa. Slipped in during git-send.
Please ignore.
Cheers,
Hannes
--
Dr. Hannes
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index b595e8b..dba8c1a 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@
We should be using spin_lock_irqsave() when within the
interrupt handler.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 485eaf0..7142a79 100644
--- a/driv
Only required if the dma buffer has been allocated via
dma_alloc_noncoherent(), which this one is not.
With that call removed we can now also compile on ARM.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/Kconfig| 2 +-
drivers/scsi/advansys.c | 10 +-
2 files changed, 6 insertions
Was uncommented in the original driver, and I'm too lazy to
figure out the conversion.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 243 +---
1 file changed, 5 insertions(+), 238 deletions(-)
diff --git a/drivers/scsi/advansys.c b/driv
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 108
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index f3fecd5..9a7018d 100644
--- a/drivers/scsi/advansys.c
+++ b/dr
The 'data_addr' field is accessed by the board, and needs
to be kept in little endian format.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index ad5c5f9..a6
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index be89245..74e5518 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -884,16 +884,6 @@ typedef struct
These definitions are only ever used for the wide-scsi board,
so they should be prefixed with 'ADV', not 'ASC'.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi
DMA mapping might fail, so we need to check for errors here.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 5a55272..485eaf0 100644
On Apr 24, 2015, at 9:46 PM, John Soni Jose wrote:
> The patchset updates be2iscsi driver to 10.6.0.0 version.
> These patches are generated aganist scsi for-next branch
>
> John Soni Jose (7):
> be2iscsi : Fix the retry count for boot targets
> be2iscsi : Fix the PCI request region reserving
Christoph,
We had internal discussion with our engineering and management on this
topic. We are committed to provide bug fixes ( Only bug fixes and no new
features) across both the SAS2 and SAS3 source trees. We prefer the SAS2
and SAS3 drivers to stay separate and the reason is; merging of the
Set the SRB flags correctly when there is no data transfer.
Cc:
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
---
drivers/scsi/storvsc_drv.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index d9dad90..
Andy Grover wrote:
> On 04/12/2015 07:17 AM, Sebastian Herbszt wrote:
> > Add target hooks.
> >
> > Signed-off-by: Sebastian Herbszt
>
> > +#ifdef LPFC_TARGET_MODE
> > +#include "lpfc_target_api.h"
> > +#include "lpfc_target_api_base.h"
> > +#endif
>
> Hi, great to see new fabrics posted.
The c
Set the SRB flags correctly when there is no data transfer.
Cc:
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
---
drivers/scsi/storvsc_drv.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index d9dad90..
Convert to use a shared host tag map for command lookup. This
saves us having an internal structure and avoid the command
pointer abuse.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 225 +---
1 file changed, 79 insertions(+), 146 deleti
No point in defining our own.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 172 +++-
1 file changed, 66 insertions(+), 106 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 52e2afd..bf97af3 100644
--- a/
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index b595e8b..a45e78f 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@
We should be using spin_lock_irqsave() when within the
interrupt handler.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 2c9f9e9..2c4efb4 100644
--- a/driv
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 108
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 25bd17d..03a3829 100644
--- a/drivers/scsi/advansys.c
+++ b/dr
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9482d4e..9d78faa 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -78,7 +78,6 @@
DMA mapping might fail, so we need to check for errors here.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 4f9392d..2c9f9e9 100644
The sg elements should be allocated from a dma pool.
And rename the structure to 'adv_sg_block' as they
are only used by the wide board.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 108
1 file changed, 45 insertions(+), 63 deletio
The advansys_reset() function is actually a host reset, not a
bus reset. And there is no need to have a 'last_reset'
value; the same value exists in struct Scsi_Host.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 27 +++
1 file changed, 11 insertions(+), 16
Signed-off-by: Hannes Reinecke
---
drivers/scsi/advansys.c | 236 +---
1 file changed, 103 insertions(+), 133 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index a45e78f..25bd17d 100644
--- a/drivers/scsi/advansys.c
+++ b/
67 matches
Mail list logo