Re: [PATCH v4 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > Kconfig for kbuild > Makefile to build snic module > > Updated MAINTAINERS file > > Signed-off-by: Narsimhulu Musini > Signed-off-by: Sesidhar Baddela > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

[PATCH v4 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- * v3 - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling debugging functionality. * v2 - Added compile time flags for debugfs depen

Re: [PATCH v4 6/9] snic:Add low level queuing interfaces

Hi Narsimhulu, please find my comment at the bottom. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > These files contain low level queueing interfaces includes > hardware queues, and management of hardware features. > > Signed-off-by: Narsimhulu Musini > Signed-off-by: Sesidhar Baddela > --

Re: [PATCH v4 5/9] snic:add SCSI handling, AEN, and fwreset handling

Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, > and host reset. Also it handles asynchronous event notifications from FW. > > Signed-off-by: Narsimhulu Musini > Signe

Re: [PATCH v4 4/9] snic:Add snic target discovery

Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_disc.h contains snic target structure definition. > > snic_disc.c contains target discovery, setup, lookup, and cleanup > > snic_ctl.c contains retrieval of snic capabilities includes > max

Re: [PATCH v4 3/9] snic:Add meta request, handling of meta requests.

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_io.h contains meta request structure definition > meta request contains high level information about firmware requests. > such as request information, size, SGLs. > > snic_io.c contains interfaces to handle meta request, firmware acknowledgme

Re: [PATCH v4 2/9] snic:Add interrupt, resource firmware interfaces

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_fwint.h contains firmware interface structures. > > snic_res.h contains firmware request initialization > > snic_res.c contains retrieval of resource configuration, and allocation, > and initialization of HW Queues. > > snic_isr.c contains

[PATCH v4 4/9] snic:Add snic target discovery

snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios, size, SGs per request, and max concurrent requests. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesid

[PATCH v4 1/9] snic: snic module infrastructure

snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_attrs.c contains device attributes to list snic state, link state, a

[PATCH v4 0/9] snic:initial submission of snic driver for Cisco SCSI HBA

The following patch series adds snic driver for Cisco SCSI HBA Cisco has developed a new PCI HBA interface called sNIC, which stands for SCSI NIC. This is a new storage feature supported on specialized network adapter. The new PCI function provides a uniform host interface and abstracts backend s

[PATCH v4 3/9] snic:Add meta request, handling of meta requests.

snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment, and high level generic queueing interface. Signed-off-

[PATCH v4 6/9] snic:Add low level queuing interfaces

These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- * v3 - Cleaned up unused functions. * v2 - driver supports x86-64 arch, so removed cpu_to_XX API to maintain cons

[PATCH v4 5/9] snic:add SCSI handling, AEN, and fwreset handling

snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- * v2 - Changed queuecommand to lock-free version. - Converted custom error cod

[PATCH v4 2/9] snic:Add interrupt, resource firmware interfaces

snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains interrupt request, release, and handling Signed-off-by: Narsimhu

[PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection for ISP27XX.

For ISP27XX, driver will capture new firmware dump even if there is one already collected. Prevent this from happening by checking fw_dumped flag. Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c |

[PATCH 06/14] qla2xxx: Add message for sucessful FW dump collected for ISP27XX.

o Added message indicating firmware dump was sucessfully collected for ISP27XX. o Improve logging to help debug firmware dump process for ISP27XX. Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c |

[PATCH 10/14] qla2xxx: Disable Interrupt handshake for ISP27XX.

Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 222d70a..9a8aa11 100644 --- a/drivers/scsi/qla2xxx/

[PATCH 03/14] qla2xxx: Increase the wait time for firmware to be ready for P3P.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index e59f25b..cb294e5 100644 --- a/

re: ufs: add ioctl interface for query request

Hello Dolev Raviv, The patch 4aca8e8975db: "ufs: add ioctl interface for query request" from Mar 12, 2015, leads to the following Smatch warning: drivers/scsi/ufs/ufshcd.c:4386 ufshcd_query_ioctl() warn: maybe return -EFAULT instead of the bytes remaining? drivers/scsi/ufs/ufshcd

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

> "James" == James Smart writes: James> fyi - in the v3 of the lpfc 10.5.0.0 patches I just posted, I James> pulled the patch. We will see what to do with it. We may come James> back with a set of generic midlayer patches. We already have a DIF blacklist. We could have an explicit whitelist

Re: [PATCH] scsi_transport_fc: Add support for 25Gbit speed

On 04/02/2015 09:50 PM, James Smart wrote: > Add FC transport support for 25Gbit speed > > Signed-off-by: James Smart Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 68

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

> It doesn't really matter that the error codes are different, it matters > that they are meaningful. As much as possible you should pass error > codes from the lower layers. parport_claim_or_block() and > i2c_bit_add_bus() return proper error codes so you should record and > transmit them. Oh, s

Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver

On Thu, 2015-03-26 at 11:23 -0500, Brian King wrote: > From: Wen Xiong > > This patch implements raw mode support for AF DASD in ipr driver > which allows for tools to send commands directly to physical > devices which are members of RAID arrays when enabled in the firmware. > > Signed-off-by: W

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

On Thu, 9 Apr 2015 09:13:07 +0200, Wolfram Sang wrote: > On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: > > now that we are monitoring the return value from attach, make the > > required changes to return proper value from its attach function. > > > > Signed-off-by: Sudip Mukherj

[PATCH 08/14] qla2xxx: Add serdes read/write support for ISP27XX

From: Andrew Vasquez Signed-off-by: Andrew Vasquez Signed-off-by: Harish Zunjarrao Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/q

[PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX.

Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c index a8c0c73..7a92f60 100644 --- a/drivers/scsi/qla2xx

[PATCH 00/14] qla2xxx: Patches for scsi "misc" branch.

Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, Himanshu Andrew Vasquez (1): qla2xxx: Add serdes read/write support for ISP27XX Chad Dupuis (1): qla2xxx: Increase the wait time for firmware t

[PATCH 07/14] qla2xxx: Add udev notification to save fw dump for ISP27XX

Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c index 1437fce..7f67fb2 100644 --- a/drivers/scsi/qla

[PATCH 05/14] qla2xxx: Add support to load firmware from file for ISP 26XX/27XX.

From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/Kconfig |3 +++ drivers/scsi/qla2xxx/qla_os.c |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig in

[PATCH 04/14] qla2xxx: Fix beacon blink for ISP27XX.

From: Nigel Kirkland Signed-off-by: Nigel Kirkland Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_sup.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index b656a05..028e8c8 100644

[PATCH 13/14] qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port.

From: Sawan Chandak For FA-WWPN is enabled port, if NPIV created on that port and, if port link is brought down, then WWPN was restored from flash for both physical and NPIV port. This will result in NPIV port and physical port sharing same WWPN. Any application refreshing ports information will

[PATCH v4 7/9] snic:Add sysfs entries to list stats and trace data

snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela -

Re: [PATCH v4 7/9] snic:Add sysfs entries to list stats and trace data

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_stats.h contains stats structre definitions for various events > in snic driver. > > snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, > resetting stats, enabling/disabling trace, and listing trace data. > > Signe

[PATCH 12/14] qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled.

From: Sawan Chandak On some vendor switches, when switch port is toggled (down /up), then in some condition driver tries to configure virtual port, before FW is actually in ready state to process any commands on wire. At this time, configuring virtual port can fail. Add fix in driver to make driv

[PATCH 09/14] qla2xxx: Add debugging info for MBX timeout.

Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c |4 +- drivers/scsi/qla2xxx/qla_def.h |2 + drivers/scsi/qla2xxx/qla_init.c | 68 +-- drivers/scsi/qla2xxx/qla_mbx.c | 16 - 4 files chan

[PATCH 14/14] qla2xxx: Update driver version to 8.07.00.18-k

Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index d88b862..2ed9ab9 100644 --- a/drivers/s

[PATCH 01/14] qla2xxx: Fix warnings reported by static checker.

Reported-by: Dan Carpenter Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 5f6b296..cdaf52e

Re: [PATCH] scsi_transport_fc: Add support for 25Gbit speed

On Thu, 2015-04-02 at 15:50 -0400, James Smart wrote: > Add FC transport support for 25Gbit speed > > Signed-off-by: James Smart > --- > drivers/scsi/scsi_transport_fc.c | 1 + > include/scsi/scsi_transport_fc.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/scsi/scsi_transp

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: > now that we are monitoring the return value from attach, make the > required changes to return proper value from its attach function. > > Signed-off-by: Sudip Mukherjee > --- > drivers/i2c/busses/i2c-parport.c | 7 --- > 1 fi

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

fyi - in the v3 of the lpfc 10.5.0.0 patches I just posted, I pulled the patch. We will see what to do with it. We may come back with a set of generic midlayer patches. -- james s On 4/5/2015 12:06 PM, Christoph Hellwig wrote: On Fri, Apr 03, 2015 at 05:13:00PM -0400, James Smart wrote: I

Re: [PATCH v4 1/9] snic: snic module infrastructure

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_main.c contains module load and unload, global driver context, > PCI Registration, PCI probe and remove, SCSI ML registration functionality. > > snic.h contains snic structure definition, snic global context, and > prototypes. > > snic_attrs

Re: [PATCH v4 8/9] snic:Add event tracing to capture IO events.

On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: > snic_trc.h contains global trace structure definitions for snic driver > > snic_trc.c adds tracing functionality to capture various IO events. > It maintains global trace buffer to maintain recent history of IO events. > It helps to understand the

[PATCH v4 8/9] snic:Add event tracing to capture IO events.

snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the sequence of events prior to particular IO event, or hung,