RE: [PATCH v6] st implement tape statistics

2015-03-05 Thread Seymour, Shane M
Retested with patch applied to 4.0.0-rc2-next-20150304 - all successful with no issues found. -Original Message- From: Laurence Oberman [mailto:oberma...@gmail.com] Sent: Thursday, February 26, 2015 5:47 AM To: Seymour, Shane M Cc: Greg KH; linux-scsi@vger.kernel.org; Laurence Oberman (

Re: [PATCH 0/5] Rename regulator_set_optimum_mode

2015-03-05 Thread Mark Brown
On Wed, Feb 25, 2015 at 03:40:31PM -0800, Bjorn Andersson wrote: > Any comments on this? > I'm going to propose a patch to the mmc framework calling this api, so > it would be good to know before I add another consumer of the api. Please don't send content free nags. They just add to the volume

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-03-05 Thread Christoph Hellwig
This is exactly why I didn't want to put this topic onto the LSF agenda. There are tons of very useful fixes and cleanus in Barts series, and I'd really like to get them in ASAP. As Nic pointed out (in a slightly unhelpful tone) we're not interested in adding any hooks for out of tree code. But

Re: [PATCH 1/3] scsi: serialize ->rescan against ->remove

2015-03-05 Thread Christoph Hellwig
Any chance to get reviews for this series? Also we should at least expedite this first patch into 4.0-rc as it fixes scanning races in virtio_scsi. On Mon, Feb 02, 2015 at 02:01:24PM +0100, Christoph Hellwig wrote: > Lock the device embedded in the scsi_device to protect against > concurrent call

[TOPIC] scsi-queue tree past and future

2015-03-05 Thread Christoph Hellwig
For about 8 month I've merged almost every scsi commit through the scsi-queue staging tree, and it seems to have worked out well enough. I've been too busy for the next cycle, so 4.1 will probably have to live without it. I'd like to get feedback on how the tree worked for contributors and driver

Re: [PATCH 01/43] hpsa: add masked physical devices into h->dev[] array

2015-03-05 Thread Christoph Hellwig
On Thu, Feb 26, 2015 at 03:17:38PM +, brace wrote: > Thanks, I corrected the code. Also, I asked Webb about setting up the queue > Depth in slave_alloc. His reply was " We needed to get tagging set up during > allocation so that we could use it in the lead-up to configuration, which is > why

Re: [PATCH] ibmvfc: Fix a locking imbalance

2015-03-05 Thread Brian King
On 03/04/2015 04:03 AM, Bart Van Assche wrote: > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index 057d277..b46257a 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(str

Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-03-05 Thread Paolo Bonzini
On 02/02/2015 14:01, Christoph Hellwig wrote: > This effectively reverts commits 85b6c7 ("[SCSI] sd: fix cache flushing on > module removal (and individual device removal)" and dc4515ea ("scsi: always > increment reference count"). > > We now never call scsi_device_get from the shutdown path, an

Re: [PATCH 1/3] scsi: serialize ->rescan against ->remove

2015-03-05 Thread Paolo Bonzini
On 02/02/2015 14:01, Christoph Hellwig wrote: > Lock the device embedded in the scsi_device to protect against > concurrent calls to ->remove. > > Signed-off-by: Christoph Hellwig > Acked-by: Alan Stern > --- > drivers/scsi/scsi_scan.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletio

Re: [PATCH 1/3] scsi: serialize ->rescan against ->remove

2015-03-05 Thread Paolo Bonzini
On 05/03/2015 14:33, Christoph Hellwig wrote: > Any chance to get reviews for this series? Also we should at least > expedite this first patch into 4.0-rc as it fixes scanning races > in virtio_scsi. I reviewed 1 and 3, but I'm not really qualified for patch 2. Paolo > On Mon, Feb 02, 2015 at

Re: [PATCH for kernel 4.1] Split SCSI header files

2015-03-05 Thread Christoph Hellwig
In general this looks fine, but: - why do you need a separate scsi_lun.h? - I'd really prefer to only have the protocol defintion here, not prototypes for helpers like scsi_device_type, int_to_scsilun and scsilun_to_int. The target code should not depend on the initiator for helpers.

Re: [TOPIC] scsi-queue tree past and future

2015-03-05 Thread James Bottomley
On Thu, 2015-03-05 at 14:31 +0100, Christoph Hellwig wrote: > For about 8 month I've merged almost every scsi commit through the > scsi-queue staging tree, and it seems to have worked out well enough. > > I've been too busy for the next cycle, so 4.1 will probably have to live > without it. I'd l

Re: [PATCH for kernel 4.1] Split SCSI header files

2015-03-05 Thread Bart Van Assche
On 03/05/15 15:26, Christoph Hellwig wrote: > In general this looks fine, but: > > - why do you need a separate scsi_lun.h? > - I'd really prefer to only have the protocol defintion here, >not prototypes for helpers like scsi_device_type, int_to_scsilun >and scsilun_to_int. The target c

use dedicated storage for scsi_debug LUNs

2015-03-05 Thread Olaf Hering
I'm using scsi_debug to implement and test tools for xen-scsiback. Today I discovered that each LUN uses the very same storage, as described in the docs. What would it take to optionally use dedicated storage for each LUN? This is how I load scsi_debug: modprobe scsi_debug add_host=4 dev_size_mb=4

iSCSI bug

2015-03-05 Thread Edgaras Lukoševičius
Hello, we have a problem. iscsi connection is dropping constantly. After enabling iscsi debug following message popped up after iscsi connection got lost: # Kernel 3.18.6-1.el7.elrepo.x86_64 Message from syslogd@storage-1 at Mar 5 15:55:12 ... kernel:NMI watchdog: BUG: soft lockup - CPU#0 stu

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-03-05 Thread Bart Van Assche
On 03/05/15 14:23, Christoph Hellwig wrote: > This is exactly why I didn't want to put this topic onto the LSF agenda. > > There are tons of very useful fixes and cleanus in Barts series, and I'd > really like to get them in ASAP. > > As Nic pointed out (in a slightly unhelpful tone) we're not in

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-03-05 Thread Andy Grover
On 03/05/2015 08:06 AM, Bart Van Assche wrote: If we would do what Nic proposed - modify SCST such that it uses configfs instead of sysfs - then that would result in the removal of at least one SCST feature that is important to its users, namely automatic population of the configuration filesyst

[PATCH 3.4.106] SCSI: libsas: no expander revalidation for SAS_END_DEV

2015-03-05 Thread Praveen Murali
The kernel crashed in mutex_lock called from smp_execute_task. The reason is that the mutex is initialized only for devices with type EDGE_DEV or FANOUT_DEV, but in some cases smp_execute_task gets called in the expander revalidation context for end devices too. Expander revalidation should not be

Re: iSCSI bug

2015-03-05 Thread Nicholas A. Bellinger
Hi Edgaras, Adding target-devel CC. On Thu, 2015-03-05 at 17:56 +0200, Edgaras Lukoševičius wrote: > Hello, > > we have a problem. iscsi connection is dropping constantly. After enabling > iscsi debug following message popped up after iscsi connection got lost: > > # Kernel > 3.18.6-1.el7.elre

Re: use dedicated storage for scsi_debug LUNs

2015-03-05 Thread Douglas Gilbert
On 15-03-05 10:33 AM, Olaf Hering wrote: I'm using scsi_debug to implement and test tools for xen-scsiback. Today I discovered that each LUN uses the very same storage, as described in the docs. What would it take to optionally use dedicated storage for each LUN? This is how I load scsi_debug: m

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-03-05 Thread Dr. Greg Wettstein
On Mar 1, 10:59pm, "Nicholas A. Bellinger" wrote: } Subject: Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target driv Hi, I hope the week is progressing well for everyone. > On Sat, 2015-02-28 at 12:59 +0100, Bart Van Assche wrote: > > On 02/27/15 22:58, Nicholas A. Bellinger wrote: > >

Re: [PATCH 3.4.106] SCSI: libsas: no expander revalidation for SAS_END_DEV

2015-03-05 Thread James Bottomley
On Thu, 2015-03-05 at 18:57 +, Praveen Murali wrote: > The kernel crashed in mutex_lock called from smp_execute_task. The reason > is that the mutex is initialized only for devices with type EDGE_DEV or > FANOUT_DEV, but in some cases smp_execute_task gets called in the expander > revalidation

[PATCH] drivers: scsi: Remove null check on sdkp

2015-03-05 Thread Tapasweni Pathak
Remove null check on sdkp as it won't be null at this line. Signed-off-by: Tapasweni Pathak Acked-by; Julia Lawall --- drivers/scsi/sd_dif.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c index 14c7d42..2190639 100644 --- a/drivers/scsi/sd

[PATCH] sd, mmc, virtio_blk, string_helpers: fix block size units

2015-03-05 Thread James Bottomley
From: James Bottomley The current string_get_size() overflows when the device size goes over 2^64 bytes because the string helper routine computes the suffix from the size in bytes. However, the entirety of Linux thinks in terms of blocks, not bytes, so this will artificially induce an overflow

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-03-05 Thread Bart Van Assche
On 03/05/15 19:39, Andy Grover wrote: > On 03/05/2015 08:06 AM, Bart Van Assche wrote: >> If we would do what Nic proposed - modify SCST such that it uses >> configfs instead of sysfs - then that would result in the removal of at >> least one SCST feature that is important to its users, namely auto