[PATCH] be2iscsi: Fix kernel panic when device initialization fails

2015-02-11 Thread John Soni Jose
Kernel panic was happening as iscsi_host_remove() was called on a host which was not yet added. Signed-off-by: John Soni Jose --- drivers/scsi/be2iscsi/be_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be

[PATCH] lpfc: Use setup_timer

2015-02-11 Thread Vaishali Thakkar
This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/scsi/lpfc/lpfc_init.c |

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-11 Thread Bryn M. Reeves
On Wed, Feb 11, 2015 at 06:30:27AM +0800, Greg KH wrote: > On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: > > On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: > > > > $ cat /sys/fs/selinux/avc/cache_stats > > lookups hits misses allocations reclaims frees > > 18938916 189

Re: CONFIG_SCSI_MQ_DEFAULT cause slow direct write speed to usb stick

2015-02-11 Thread Andrej Gelenberg
Hi, my problem was, that write speed to the device is got really slow from 7 Mb/s to 250 Kb/s, so 16.76 Mb/sec is probably the speed limitation of the uSD Card or is close to that. Do you activated blk-mq for scsi in kernel config or in boot parameters? Regards, Andrej On Tue, 10 Feb 2015 17:10:

[PATCH] [SCSI] sg: fix unkillable I/O wait deadlock with scsi-mq

2015-02-11 Thread Tony Battersby
When using the write()/read() interface for submitting commands, the SCSI generic driver does not call blk_put_request() on a completed SCSI command until userspace calls read() to get the command completion. Since scsi-mq uses a fixed number of preallocated requests, this makes it possible for us

[PATCH] [SCSI] sg: fix read() error reporting

2015-02-11 Thread Tony Battersby
Fix SCSI generic read() incorrectly returning success after detecting an error. Cc: Signed-off-by: Tony Battersby --- For inclusion in kernel 3.20. --- linux-3.19.0/drivers/scsi/sg.c.orig 2015-02-08 21:54:22.0 -0500 +++ linux-3.19.0/drivers/scsi/sg.c 2015-02-10 09:26:09.0

[PATCH] [SCSI] bsg: fix unkillable I/O wait deadlock with scsi-mq

2015-02-11 Thread Tony Battersby
When using the write()/read() interface for submitting commands, the bsg driver does not call blk_put_request() on a completed SCSI command until userspace calls read() to get the command completion. Since scsi-mq uses a fixed number of preallocated requests, this makes it possible for userspace t

[PATCH] blk-mq: fix double-free in error path

2015-02-11 Thread Tony Battersby
If the allocation of bt->bs fails, then bt->map can be freed twice, once in blk_mq_init_bitmap_tags() -> bt_alloc(), and once in blk_mq_init_bitmap_tags() -> bt_free(). Fix by setting the pointer to NULL after the first free. Cc: Signed-off-by: Tony Battersby --- For inclusion in kernel 3.20.

Re: [PATCH] blk-mq: fix double-free in error path

2015-02-11 Thread Jens Axboe
On 02/11/2015 09:32 AM, Tony Battersby wrote: If the allocation of bt->bs fails, then bt->map can be freed twice, once in blk_mq_init_bitmap_tags() -> bt_alloc(), and once in blk_mq_init_bitmap_tags() -> bt_free(). Fix by setting the pointer to NULL after the first free. Cc: Signed-off-by: Ton

Re: [PATCH] [SCSI] sg: fix read() error reporting

2015-02-11 Thread Douglas Gilbert
On 15-02-11 11:32 AM, Tony Battersby wrote: Fix SCSI generic read() incorrectly returning success after detecting an error. Cc: Signed-off-by: Tony Battersby --- For inclusion in kernel 3.20. --- linux-3.19.0/drivers/scsi/sg.c.orig 2015-02-08 21:54:22.0 -0500 +++ linux-3.19.0/drivers

Re: [PATCH] [SCSI] sg: fix read() error reporting

2015-02-11 Thread Tony Battersby
On 02/11/2015 12:45 PM, Douglas Gilbert wrote: > On 15-02-11 11:32 AM, Tony Battersby wrote: >> Fix SCSI generic read() incorrectly returning success after detecting an >> error. >> >> Cc: >> Signed-off-by: Tony Battersby >> --- >> >> For inclusion in kernel 3.20. >> >> --- linux-3.19.0/drivers/s

[LSF/MM ATTEND]

2015-02-11 Thread Chad Dupuis
I'd like to attend LSF. I'm currently helping to maintain the qla2xxx and bnx2fc drivers. I have been developing for low level Linux SCSI drivers for the last 5 years and have been working with the Linux storage stack for over 10. Speicially, I'd like to be included in the discussions about

Kernel crash on usb-storage disconnect, multiqueue in use

2015-02-11 Thread Bruno Prémont
Hi, Since 3.19-rcX kernel crashes when I disconnect an external HDD drive (not sure since which kernel revision tough early 3.19-rcs possibly are not affected). To reproduce I do: - connect my disk - use disk with LUKS (luksOpen) - stop using disk (luksClose) - sdparm -C stop /dev/sgX(sg devi

[PATCH 0/5] Rename regulator_set_optimum_mode

2015-02-11 Thread Bjorn Andersson
Changing the name of the regulator_set_optimum_mode() to regulator_set_load() better reflects that the API is doing. This series does the name change and move the current consumers over. Bjorn Andersson (5): regulator: s/regulator_set_optimum_mode/regulator_set_load/ ufs: Rename of regulator_

[PATCH 2/5] ufs: Rename of regulator_set_optimum_mode

2015-02-11 Thread Bjorn Andersson
The function regulator_set_optimum_mode() is changing name to regulator_set_load(), so update the code accordingly. Also cleaned up ufshcd_config_vreg_load() while touching the code. Signed-off-by: Bjorn Andersson --- drivers/scsi/ufs/ufshcd.c | 27 +++ 1 file changed, 7

Re: Kernel crash on usb-storage disconnect, multiqueue in use

2015-02-11 Thread Bart Van Assche
On 02/11/15 22:25, Bruno Prémont wrote: > Since 3.19-rcX kernel crashes when I disconnect an external > HDD drive (not sure since which kernel revision tough early > 3.19-rcs possibly are not affected). > > It looks like this crash is related to the fact that I enable > multiqueue (CONFIG_SCSI_MQ_

[PATCH] pm80xx: Added pm8006 controller support

2015-02-11 Thread Suresh Thiagarajan
Added the pm8006 controller id in pci table Signed-off-by: Suresh Thiagarajan Signed-off-by: Viswas G --- drivers/scsi/pm8001/pm8001_defs.h |3 ++- drivers/scsi/pm8001/pm8001_init.c |5 - 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_defs.

Re: General protection fault in iscsi_rx_thread_pre_handler

2015-02-11 Thread Nicholas A. Bellinger
Hi Gavin, On Tue, 2015-02-03 at 08:28 +0800, Gavin Guo wrote: > Hi Nicholas, > > On Sun, Feb 1, 2015 at 11:47 AM, Gavin Guo wrote: > > Hi Nicholas, > > > > On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinger > > wrote: > >> On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote: > >>> Hi Nichola