Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-02-03 Thread Athlion
On Mon, Feb 2, 2015 at 7:27 PM, Alan Stern wrote: > Had you made any changes to the runtime suspend settings? > blk_post_runtime_resume wouldn't be called unless the drive had gone > into runtime suspend. And even then, it's not likely to be called > after you unplug the USB cable. > > Alan Ster

Re: [PATCH-v3 1/9] vhost/scsi: Convert completion path to use copy_to_iser

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:29:55AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Required for ANY_LAYOUT support when the incoming virtio-scsi response > header + fixed size sense buffer payload may span more than a single > iovec entry. > > This changes existing code to s

[PATCH RESEND 0/4] bfa: Patches for scsi "misc" branch

2015-02-03 Thread anil.gurumurthy
Hi James, Christoph, Re-sending the patches to move user visible strings to a separate patch. Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, Anil Anil Gurumurthy (4): bfa:Updating copyright messages bfa:Fix for crash when bfa_itnim is

[PATCH RESEND 3/4] bfa:File header and user visible string changes

2015-02-03 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |2 +- drivers/scsi/bfa/bfa_core.c |2 +- drivers/scsi/bfa/bfa_cs.h|2 +- drivers/scsi/bfa/bfa_defs.h |2 +- drivers/scsi/bfa/bfa

[PATCH RESEND 2/4] bfa:Fix for crash when bfa_itnim is NULL

2015-02-03 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad_im.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c index 575efdc.

[PATCH RESEND 4/4] bfa:Update driver version to 3.2.25.0

2015-02-03 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bfa/bfad_drv.h b/drivers/scsi/bfa/bfad_drv.h index 8001459..f9e8620 100644 --- a/drivers/

[PATCH RESEND 1/4] bfa:Updating copyright messages

2015-02-03 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |5 +++-- drivers/scsi/bfa/bfa_core.c |5 +++-- drivers/scsi/bfa/bfa_cs.h|5 +++-- drivers/scsi/bfa/bfa_defs.h |5 +++-- drivers/scsi/bfa

Re: [PATCH-v3 4/9] vhost/scsi: Add ANY_LAYOUT iov -> sgl mapping prerequisites

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:29:58AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds ANY_LAYOUT prerequisites logic for accepting a set of > protection + data payloads via iov_iter. Also includes helpers for > calcuating SGLs + invoking vhost_scsi_map_to_sgl() wi

Re: [PATCH-v3 0/9] vhost/scsi: Add ANY_LAYOUT + VERSION_1 support

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:29:54AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi MST, Paolo, Al & Co, > > Here is -v3 for adding vhost/scsi ANY_LAYOUT + VERSION_1 host feature > bit support. > > It adds a new vhost_virtqueue ->handle_kick() callback to determine the > st

Re: [PATCH-v3 7/9] vhost/scsi: Drop legacy pre virtio v1.0 !ANY_LAYOUT logic

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:30:01AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > With the new ANY_LAYOUT logic in place for vhost_scsi_handle_vqal(), > there is no longer a reason to keep around the legacy code with > !ANY_LAYOUT assumptions. > > Go ahead and drop the pre vi

Re: [PATCH-v3 8/9] vhost/scsi: Drop left-over scsi_tcq.h include

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:30:02AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > With the recent removal of MSG_*_TAG defines in commit 68d81f40, > vhost-scsi is now using TCM_*_TAG and doesn't depend upon host > side scsi_tcq.h definitions anymore. > > Cc: Michael S. Tsirki

Re: [PATCH-v3 6/9] vhost/scsi: Set VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:30:00AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Signal support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits > required for virtio-scsi 1.0 spec layout requirements. > > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Signed-off-by:

Re: [PATCH-v3 9/9] vhost/scsi: Global tcm_vhost -> vhost_scsi rename

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:30:03AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > There is a large amount of code that still references the original > 'tcm_vhost' naming conventions, instead of modern 'vhost_scsi'. > > Go ahead and do a global rename to make the usage consist

Re: [PATCH-v3 5/9] vhost/scsi: Add ANY_LAYOUT vhost_virtqueue callback

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 06:29:59AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds ANY_LAYOUT support with a new vqs[].vq.handle_kick() > callback in vhost_scsi_handle_vqal(). > > It calculates data_direction + exp_data_len for the new tcm_vhost_cmd > descripto

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

2015-02-03 Thread Dr. Greg Wettstein
On Jan 19, 1:21am, Christoph Hellwig wrote: } Subject: Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target driv Hi, I hope the week is going well for everyone. I'm a bit behind on e-mail and getting ready for travel but wanted to reply back to this thread because of our involvement and

[PATCH] csiostor:Use firmware version from cxgb4/t4fw_version.h

2015-02-03 Thread Praveen Madhavan
This patch is to use firmware version macros from t4fw_version.h and also enables 40g T5 adapter. Signed-off-by: Praveen Madhavan --- drivers/scsi/csiostor/csio_hw.c | 6 -- drivers/scsi/csiostor/csio_hw_chip.h | 6 +- drivers/scsi/csiostor/csio_mb.c | 3 ++- 3 files changed, 7

Re: [PATCH-v3 5/9] vhost/scsi: Add ANY_LAYOUT vhost_virtqueue callback

2015-02-03 Thread Michael S. Tsirkin
> + * copy_from_iter() is modifying the iovecs as copies over > + * req_size bytes into req, so the returned out_iter.iov[0] > + * will contain the correct start + offset of the outgoing > + * WRITE payload, if DMA_TO_DEVICE is set. > +

[PATCH v3] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-02-03 Thread Nicholas Mc Guire
NFIG_SCSI_LOWLEVEL=y, CONFIG_SCSI_GENERIC_NCR5380=m CONFIG_SCSI_DMX3191D=m, CONFIG_SCSI_DTC3280=m CONFIG_SCSI_GENERIC_NCR5380=m, CONFIG_SCSI_GENERIC_NCR5380_MMIO=m CONFIG_SCSI_PAS16=m, CONFIG_SCSI_T128=m Patch is against 3.19.0-rc7 (localversion-next = -next-20150203) drivers/scsi/NCR5380.c | 10

[PATCH v1 0/4] Add ioctl and debug utilities to UFS driver

2015-02-03 Thread Gilad Broner
This patch series introduces in the first change a new UFS ioctl, allowing user-space to send UFS queries and retrieve information from them. In addition, the other three patches add utilities to support debugging efforts and supply information that will help analysis of issue: UFS trace events, du

[PATCH v1 2/4] scsi: ufs: add debugfs for ufs

2015-02-03 Thread Gilad Broner
From: Lee Susman Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during runtime - Change UFS power m

[PATCH v1 1/4] scsi: ufs: add ioctl interface for query request

2015-02-03 Thread Gilad Broner
From: Dolev Raviv This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-off-by: Raviv Shvili Signed-off-by: Ya

[PATCH v1 4/4] scsi: ufs: inject errors to verify error handling

2015-02-03 Thread Gilad Broner
From: Sujit Reddy Thumma Use fault-injection framework to simulate error conditions in the controller and verify error handling mechanisms implemented in UFS host controller driver. This is used only during development and hence guarded by CONFIG_UFS_FAULT_INJECTION debug config option. Signed-

[PATCH v1 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-03 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-02-03 Thread Alan Stern
On Tue, 3 Feb 2015, Athlion wrote: > On Mon, Feb 2, 2015 at 7:27 PM, Alan Stern wrote: > > > Had you made any changes to the runtime suspend settings? > > blk_post_runtime_resume wouldn't be called unless the drive had gone > > into runtime suspend. And even then, it's not likely to be called >

Re: [PATCH v3] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

2015-02-03 Thread Suman Tripathi
Ugh, please avoid using HTML when posting to the lists hosted on vger.kernel.org -- it's configured to ignore such mails AFAIK. Yeah forgot to set the plain text mode. Sorry for that >>> This patch addresses the issue with ATA_CMD_SMART pio mode >>> command for enumeration and device de

Re: [PATCH v3] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

2015-02-03 Thread Tejun Heo
On Mon, Feb 02, 2015 at 11:37:19PM +0530, Suman Tripathi wrote: > This patch addresses the issue with ATA_CMD_SMART pio mode > command for enumeration and device detection with ATA devices. > The X-Gene AHCI controller has an errata in which it cannot clear > the BSY bit after the PIO setup FIS. Th

Re: [PATCH v1 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-03 Thread Steven Rostedt
On Tue, 3 Feb 2015 17:37:19 +0200 Gilad Broner wrote: > Add trace events to driver to allow monitoring and profilig > of activities such as PM suspend/resume, hibernate enter/exit, > clock gating and clock scaling up/down. > In addition, add UFS host controller register dumps to provide > detail

Re: [PATCH 1/1] scsi: Fix max transfer length for 4k disks

2015-02-03 Thread Venkatesh Srinivas
On Thu, Jan 29, 2015 at 1:54 PM, Brian King wrote: > > The following patch fixes an issue observed with 4k sector disks > where the max_hw_sectors attribute was getting set too large in > sd_revalidate_disk. Since sdkp->max_xfer_blocks is in units > of SCSI logical blocks and queue_max_hw_sectors

Re: [PATCH-v3 5/9] vhost/scsi: Add ANY_LAYOUT vhost_virtqueue callback

2015-02-03 Thread Al Viro
On Tue, Feb 03, 2015 at 06:29:59AM +, Nicholas A. Bellinger wrote: > + * Copy over the virtio-scsi request header, which when > + * ANY_LAYOUT is enabled may span multiple iovecs, or a > + * single iovec may contain both the header + outgoing > +

[PATCH 1/1] Sync iscsi fw boot flags

2015-02-03 Thread michaelc
From: Mike Christie iBFT and non-iBFT drivers use the same iscsi boot sysfs interface. For iBFT we just directly export whatever is left by the FW. For non-iBFT drivers we do vendor specific commands to get the info or its just hard coded. This patch syncs up how non-iBFT drivers export boot fla

[PATCH] scsi: Remove use of struct timeval

2015-02-03 Thread Tina Ruchandani
Function stex_gettime uses 'struct timeval' whose tv_sec value will overflow on 32-bit systems in year 2038 and beyond. This patch replaces the use of struct timeval and do_gettimeofday with ktime_get_real_seconds, which returns a 64-bit seconds value. Signed-off-by: Tina Ruchandani --- drivers/

[PATCH] scsi: Remove usage of struct timeval

2015-02-03 Thread Tina Ruchandani
struct timeval will have its tv_sec field overflow on 32-bit systems in year 2038 and beyond. This patch removes the usage of struct timeval and instead uses 64-bit ktime_t to get the current milliseconds to populate pmcraid_timestamp_data. Signed-off-by: Tina Ruchandani --- drivers/scsi/pmcraid

[PATCH] [SCSI] bfa: Remove use of struct timeval

2015-02-03 Thread Tina Ruchandani
struct timeval will have its tv_sec field overflow on 32-bit systems in year 2038 and beyond. This patch removes the usage of struct timeval and instead uses ktime_get_real_seconds() which returns 64-bit wall-clock seconds. Signed-off-by: Tina Ruchandani --- drivers/scsi/bfa/bfa_svc.c | 12 +++--

[PATCH] mpt3sas: Remove usage of 'struct timeval'

2015-02-03 Thread Tina Ruchandani
'struct timeval' will have its tv_sec value overflow on 32-bit systems in year 2038 and beyond. This patch replaces the use of struct timeval for computing mpi_request.TimeStamp, and instead uses ktime_t which provides 64-bit seconds value. The timestamp computed remains unaffected (milliseconds si

[PATCH] mpt2sas: Remove usage of 'struct timeval'

2015-02-03 Thread Tina Ruchandani
'struct timeval' will have its tv_sec value overflow on 32-bit systems in year 2038 and beyond. This patch replaces the use of struct timeval for computing mpi_request.TimeStamp, and instead uses ktime_t which provides 64-bit seconds value. The timestamp computed remains unaffected (milliseconds si

[PATCH] scsi_logging: return void for dev_printk() functions

2015-02-03 Thread Hannes Reinecke
dev_printk() is now a void function, so the related functions scmd_printk() and sdev_prefix_printk() should be made void, too. Reported-by: Stephen Rothwell Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_logging.c | 22 +- include/scsi/scsi_device.h | 4 ++-- 2 files

Re: [PATCH-v3 5/9] vhost/scsi: Add ANY_LAYOUT vhost_virtqueue callback

2015-02-03 Thread Michael S. Tsirkin
On Tue, Feb 03, 2015 at 11:56:16PM +, Al Viro wrote: > On Tue, Feb 03, 2015 at 06:29:59AM +, Nicholas A. Bellinger wrote: > > +* Copy over the virtio-scsi request header, which when > > +* ANY_LAYOUT is enabled may span multiple iovecs, or a > > +* single