[PATCH v2] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-01-31 Thread Nicholas Mc Guire
This is only an API consolidation to make things more readable. Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire v2: the original patch was not taking care of all the dependencies as reported by Finn Thain - this version now uses th

Re: [PATCH v2] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-01-31 Thread Finn Thain
On Sat, 31 Jan 2015, Nicholas Mc Guire wrote: > This is only an API consolidation to make things more readable. > > Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). ... and some instances of "value" are replaced by "msecs_to_jiffies(value)" which seems to be completely wro

Re: General protection fault in iscsi_rx_thread_pre_handler

2015-01-31 Thread Gavin Guo
Hi Nicholas, On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinger wrote: > On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote: >> Hi Nicholas, >> >> On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger >> wrote: >> > On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote: >> >> Hi Nicolas, >> >>

Re: [PATCH v2] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-01-31 Thread Michael Schmitz
Finn, Nicholas, On Sat, 31 Jan 2015, Nicholas Mc Guire wrote: This is only an API consolidation to make things more readable. Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). ... and some instances of "value" are replaced by "msecs_to_jiffies(value)" which seems to b

Re: [PATCH v2] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-01-31 Thread Finn Thain
On Sun, 1 Feb 2015, Michael Schmitz wrote: > Finn, Nicholas, > > > On Sat, 31 Jan 2015, Nicholas Mc Guire wrote: > > > > > This is only an API consolidation to make things more readable. > > > > > > Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). > > > > ... and some instance

Re: [PATCH v2] scsi: NCR5380: use msecs_to_jiffies for conversions

2015-01-31 Thread Nicholas Mc Guire
On Sun, 01 Feb 2015, Michael Schmitz wrote: > Finn, Nicholas, > >> On Sat, 31 Jan 2015, Nicholas Mc Guire wrote: >> >>> This is only an API consolidation to make things more readable. >>> >>> Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). >> >> ... and some instances of "va

Re: [PATCH 1/8] lib/iovec: Add memcpy_fromiovec_out library function

2015-01-31 Thread Nicholas A. Bellinger
On Fri, 2015-01-30 at 10:33 +0100, Paolo Bonzini wrote: > > On 30/01/2015 09:12, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds a new memcpy_fromiovec_out() library function which modifies > > the passed *iov following memcpy_fromiovec(), but also returns the n

Re: [PATCH 4/8] vhost/scsi: Change vhost_scsi_map_to_sgl to accept iov ptr + len

2015-01-31 Thread Nicholas A. Bellinger
On Fri, 2015-01-30 at 12:51 +0200, Michael S. Tsirkin wrote: > On Fri, Jan 30, 2015 at 08:12:28AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch changes vhost_scsi_map_to_sgl() parameters to accept virtio > > iovec ptr + len when determing pages_nr. > > > > T