Re: module: fix module_refcount() return when running in a module exit routine

On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote: > The first one I think should be eliminated, and the second one is simply > an assertion before calling module_put() (which should probably be > eliminated). The others are just printing information. FYI, I've got a pathcset to elimi

Re: [RFC PATCH] aha1542: Stop using scsi_module.c

On Fri, Jan 16, 2015 at 11:31:29PM +0100, Ondrej Zary wrote: > Convert aha1542 to use scsi_add_host instead of scsi_module.c > Use pnp_driver and isa_driver to manage cards. > > I hope that the PnP code is OK, don't have a PnP card to test. > > The code needs much more work, there's a lot of thin

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

On Thu, Jan 15, 2015 at 05:13:00PM +0100, Bart Van Assche wrote: > My goal is to realize this proposal without adding hooks for out-of-tree > code in the upstream kernel. What I had in mind is to raise the > abstraction level of the API between LIO core and target drivers a > little bit (e.g. by us

Re: [Lsf-pc] [LSF/MM TOPIC] Unifying the LIO and SCST target drivers

On 01/19/15 10:22, Christoph Hellwig wrote: > On Thu, Jan 15, 2015 at 05:13:00PM +0100, Bart Van Assche wrote: >> My goal is to realize this proposal without adding hooks for out-of-tree >> code in the upstream kernel. What I had in mind is to raise the >> abstraction level of the API between LIO c

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

Sorry for taking so long to get back to you guys about this (the 3.19-rc series has been problematic for me in a couple of areas, so I'd let it go for a while): On Mon, 5 Jan 2015, Alan Stern wrote: > The patch I posted sets a general limit of 32 MB for USB drives that > don't have a quirk flag

Re: [PATCH v4] virtio-scsi: Fix the race condition in virtscsi_handle_event

Michael, are you fine with this version? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Interesse

Jeg vil foreslå relasjoner som er av felles interesse. Det er overføring av en stor sum penger.Jeg skriver til deg fordi du har blitt anbefalt til meg som en som kan være egnet for mitt prosjekt. Ta kontakt med meg på min personlige e-postadresse; en rask respons, ville jeg stor pris på det. Med v

Re: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host

On Mon, Jan 19, 2015 at 12:05:58AM +0900, Akinobu Mita wrote: > While accessing a scsi_device, the use count of the underlying LLDD > module is incremented. The module reference is retrieved through > .module field of struct scsi_host_template. > > This mapping between scsi_device and underlying

[patch] sd: fix an error return in probe()

If device_add() fails then it should return the error code but instead the current code returns success. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index ebf35cb6..75a0b55 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3019,7 +3019,8 @@ static int

[patch] be2iscsi: return correct error code in beiscsi_init_port()

If hba_setup_cid_tbls() fails then this code should return an error code but instead the current code returns zero (success). Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index f319340..fe59ae6 100644 --- a/drivers/scsi/be2iscsi/be_m

[patch] [SCSI] mvumi: return a correct error code

If kthread_create() fails then this should return an error code but the current code returns zero instead. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 3e6b866..586f72b 100644 --- a/drivers/scsi/mvumi.c +++ b/drivers/scsi/mvumi.c @@ -2477,6 +2477,7

Re: [PATCH 1/4] scsi: always use format argumets for dev_printk

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/scsi_logging.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c > index 6128303..ec

Re: [PATCH 2/4] scsi: annotate sdev_prefix_printk and scmd_printk as printf-like

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > include/scsi/scsi_device.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h > index d1aad4d..2e0281e 100

Re: [PATCH 3/4] ch: remove debug noise in ch_do_scsi

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: > The midlayer logging already prints the cdb details if the logging > level is high enough, no need to duplicate this in the ch driver. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/ch.c | 8 > 1 file changed, 8 de

Re: [PATCH 4/4] sr: reduce debug noise in sr_do_ioctl

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: > The midlayer scsi logging already logs the command and sense code > if the logging level is high enough, no need to duplicate that > in the sr driver. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/sr_ioctl.c | 18 -

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

On Mon, 19 Jan 2015, Kenneth R. Crudup wrote: > Sorry for taking so long to get back to you guys about this (the 3.19-rc > series has been > problematic for me in a couple of areas, so I'd let it go for a while): > > On Mon, 5 Jan 2015, Alan Stern wrote: > > > The patch I posted sets a general

[PATCHv2] libata: fixup oops in ata_eh_link_report()

We should only try to evaluate the cdb if this is an ATAPI device, for any other device the 'cdb' field and the cdb_len has no meaning. Fixes: cbba5b0ee4c6c2fc8b78a21d0900099d480cf2e9 Reported-by: Sergey Senozhatsky Signed-off-by: Hannes Reinecke Reviewed-by: Tejun Heo Tested-by: Sergey Senozha

Re: module: fix module_refcount() return when running in a module exit routine

On Mon, 2015-01-19 at 00:28 -0800, Christoph Hellwig wrote: > On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote: > > The first one I think should be eliminated, and the second one is simply > > an assertion before calling module_put() (which should probably be > > eliminated). The othe

Re: module: fix module_refcount() return when running in a module exit routine

On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: > Masami Hiramatsu writes: > > (2015/01/19 1:55), James Bottomley wrote: > >> From: James Bottomley > >> > >> After e513cc1 module: Remove stop_machine from module unloading, > >> module_refcount() is returning (unsigned long)-1 when called

Re: [PATCHv2] libata: fixup oops in ata_eh_link_report()

Hello. On 01/19/2015 06:55 PM, Hannes Reinecke wrote: We should only try to evaluate the cdb if this is an ATAPI device, for any other device the 'cdb' field and the cdb_len has no meaning. Fixes: cbba5b0ee4c6c2fc8b78a21d0900099d480cf2e9 According to Documentation/SubmittingPatches, 12

RE: [PATCH v2 1/1] be2iscsi: add block valid bit to iBFT flag

>From: Mike Christie [mailto:micha...@cs.wisc.edu] >Sent: Friday, January 16, 2015 4:35 PM >To: Minh Duc Tran >Cc: linux-scsi@vger.kernel.org; Jayamohan Kallickal >Subject: Re: [PATCH v2 1/1] be2iscsi: add block valid bit to iBFT flag >On 01/16/2015 01:44 PM, Minh Duc Tran wrote: >>> From: Michae

Re: [PATCH v2 0/2] csiostor:Remove T4 FCoE support

From: Praveen Madhavan Date: Fri, 16 Jan 2015 21:30:18 +0530 > We found a subtle issue with FCoE on T4 very late in the game > and decided not to productize FCoE on T4 and therefore there > are no customers that will be impacted by this change. FCoE is > supported on T5 cards. > > Please apply o

[PATCH 06/13] aha1542: Use u8 instead of unchar

Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 50 drivers/scsi/aha1542.h | 42 2 files changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c i

[PATCH 01/13] aha1542: Stop using scsi_module.c

Convert aha1542 to use scsi_add_host instead of scsi_module.c Use pnp_driver and isa_driver to manage cards. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 300 +++- drivers/scsi/aha1542.h |2 +- 2 files changed, 169 insertions(+), 133 de

[PATCH 03/13] aha1542: Remove SCSI_BUF_PA, SCSI_SG_PA, AHA1542_SCATTER and AHA1542_CMDLUN

Remove SCSI_BUF_PA, SCSI_SG_PA, AHA1542_SCATTER and AHA1542_CMDLUN macros Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 23 ++- drivers/scsi/aha1542.h |2 -- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi

[PATCH 05/13] aha1542: Convert aha1542_intr_reset to function

Convert aha1542_intr_reset macro to inline function Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index ebf54b5..2a6308f 100644 --- a/drivers/scsi/aha1542.c +++ b/dr

[PATCH 04/13] aha1542: Remove HOSTDATA macro

Remove HOSTDATA macro and use shost_priv instead Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 114 +++- 1 file changed, 55 insertions(+), 59 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 197480d..ebf54b5 1

[PATCH 09/13] aha1542: Use BIT() macro

Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.h | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h index f0b862b..1333a23 100644 --- a/drivers/scsi/aha1542.h +++ b/drivers/scsi/aha1542

[RFC PATCH 0/13] aha1542: Various improvements

This (incomplete) patch series updates aha1542 driver to not use deprecated initialization, removes dead code, ugly macros and simplifies the code. It's probably not checkpatch-clean yet. aha1542.c | 984 ++ aha1542.h | 99 ++ 2

[PATCH 07/13] aha1542: Reorder functions to remove forward declarations

Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 51 +++- drivers/scsi/aha1542.h | 12 2 files changed, 24 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 8851719..af1e8fa 100644

[PATCH 08/13] aha1542: remove empty aha1542_stat

Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index af1e8fa..ebc5476 100644 --- a/drivers/scsi/aha1542.c +++ b/drivers/scsi/aha1542.c @@ -154,12 +154,6 @@

[PATCH 02/13] aha1542: remove dead code

Remove dead code. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 243 +--- drivers/scsi/aha1542.h |6 -- 2 files changed, 1 insertion(+), 248 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index b7a62da..506e33

[PATCH 13/13] aha1542: Remove unneeded gotos

Remove gotos that are no longer needed. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 58 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 7bf4604..af2c69e 100644 ---

[PATCH 11/13] aha1542: Unify aha1542_in and aha1542_in1

Unify aha1542_in and aha1542_in1 functions, they differ only in timeout and printk. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index

[PATCH 12/13] aha1542: Split aha1542_out

aha1542_out are in fact two separate functions. Split them into aha1542_out and aha1542_outb to simplify the code. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 75 ++-- 1 file changed, 35 insertions(+), 40 deletions(-) diff --git a/driver

[PATCH 10/13] aha1542: Remove WAIT and WAITd macros

Convert the ugly WAIT and WAITd macros into wait_mask function. Signed-off-by: Ondrej Zary --- drivers/scsi/aha1542.c | 104 ++-- 1 file changed, 57 insertions(+), 47 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index ebc

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

On Mon, 19 Jan 2015, Alan Stern wrote: > Are you certain the patch had been applied to the kernel you were testing? Yeah, I definitely remember the result of "git status" having the patch ready for commit at the time of build. I'll test it again later tonight. > Maybe you can add a printk statem

Re: module: fix module_refcount() return when running in a module exit routine

James Bottomley writes: > On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: >> Masami Hiramatsu writes: >> > (2015/01/19 1:55), James Bottomley wrote: >> >> From: James Bottomley >> >> >> >> After e513cc1 module: Remove stop_machine from module unloading, >> >> module_refcount() is return

Re: [PATCH v2] scsi: Avoid crashing if device uses DIX but adapter does not support it

> "Ewan" == Ewan D Milne writes: Ewan> This can happen if a multipathed device uses DIX and another path Ewan> is added via an adapter that does not support it. Multipath Ewan> should not allow this path to be added, but we should not depend Ewan> upon that to avoid crashing. Reviewed-by: M

Re: module: fix module_refcount() return when running in a module exit routine

(2015/01/20 9:45), Rusty Russell wrote: > James Bottomley writes: >> On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: >>> Masami Hiramatsu writes: (2015/01/19 1:55), James Bottomley wrote: > From: James Bottomley > > After e513cc1 module: Remove stop_machine from module u