[PATCH 1/2] xhci: Add broken-streams quirk for Fresco Logic FL1000G xhci controllers

2014-12-05 Thread Hans de Goede
Streams do not work reliabe on Fresco Logic FL1000G xhci controllers, trying to use them results in errors like this: 21:37:33 kernel: xhci_hcd :04:00.0: ERROR Transfer event for disabled endpoint or incorrect stream ring 21:37:33 kernel: xhci_hcd :04:00.0: @368b3570 9067b000

[PATCH 2/2] uas: Add US_FL_NO_ATA_1X for Seagate devices with usb-id 0bc2:a013

2014-12-05 Thread Hans de Goede
This is yet another Seagate device which needs the US_FL_NO_ATA_1X quirk Reported-by: Marcin ZajÄ…czkowski Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_u

Re: [PATCH 1/2] xhci: Add broken-streams quirk for Fresco Logic FL1000G xhci controllers

2014-12-05 Thread Sergei Shtylyov
Hello. On 12/5/2014 1:11 PM, Hans de Goede wrote: Streams do not work reliabe on Fresco Logic FL1000G xhci controllers, s/reliabe/reliably/? trying to use them results in errors like this: 21:37:33 kernel: xhci_hcd :04:00.0: ERROR Transfer event for disabled endpoint or incorrect

[PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
The commit 7985090aa0201(sd: Disable discard_zeroes_data for UNMAP) introduces regresion for QEMU SCSI. QEMU SCSI device claims to support UNMAP, WRITE SAME and WRITE SAME 16 in LBP VPD page, but only provides "Maximum unmap LBA count" in block limits VPD page, and "Maximum write same length" isn'

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: Ming, Ming> QEMU SCSI device claims to support UNMAP, WRITE SAME and WRITE Ming> SAME 16 in LBP VPD page, but only provides "Maximum unmap LBA Ming> count" in block limits VPD page, and "Maximum write same length" Ming> isn't set. That really sounds like a probl

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
On Fri, Dec 5, 2014 at 8:56 PM, Martin K. Petersen wrote: >> "Ming" == Ming Lei writes: > > Ming, > > Ming> QEMU SCSI device claims to support UNMAP, WRITE SAME and WRITE > Ming> SAME 16 in LBP VPD page, but only provides "Maximum unmap LBA > Ming> count" in block limits VPD page, and "Maximu

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: >> There is absolutely no correlation between max write same blocks and >> max unmap blocks. They are two entirely different commands. If QEMU >> SCSI Ming> Do you have any better idea for the problem? Does QEMU SCSI set LBPRZ? -- Martin K. Petersen Oracl

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
On Fri, Dec 5, 2014 at 9:22 PM, Martin K. Petersen wrote: >> "Ming" == Ming Lei writes: > >>> There is absolutely no correlation between max write same blocks and >>> max unmap blocks. They are two entirely different commands. If QEMU >>> SCSI > > Ming> Do you have any better idea for the pro

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: Ming> It isn't set in LBP VPG page. What about in READ CAPACITY(16)? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
On Fri, Dec 5, 2014 at 9:38 PM, Martin K. Petersen wrote: >> "Ming" == Ming Lei writes: > > Ming> It isn't set in LBP VPG page. > > What about in READ CAPACITY(16)? It isn't set too. Thanks, Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: >> What about in READ CAPACITY(16)? Ming> It isn't set too. Please try the following patch: [SCSI] sd: Tweak discard heuristics to work around QEMU SCSI issue 7985090aa020 changed the discard heuristics to give preference to the WRITE SAME commands that (unli

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
On Fri, Dec 5, 2014 at 9:58 PM, Martin K. Petersen wrote: >> "Ming" == Ming Lei writes: > >>> What about in READ CAPACITY(16)? > > Ming> It isn't set too. > > Please try the following patch: > > > [SCSI] sd: Tweak discard heuristics to work around QEMU SCSI issue > > 7985090aa020 changed the

Re: [PATCH v4] scsi: ufs: add support of generic PHY and ICE in Qualcomm chips

2014-12-05 Thread Kishon Vijay Abraham I
On Thursday 04 December 2014 09:24 PM, Christoph Hellwig wrote: > On Thu, Nov 27, 2014 at 05:59:58PM +0200, Yaniv Gardi wrote: >> In this change we add support to the generic PHY framework. >> Two UFS phys are implemented: >> qmp-20nm and qmp-28nm. >> >> Also, the files in this change implement t

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Paolo Bonzini
On 05/12/2014 14:58, Martin K. Petersen wrote: >> "Ming" == Ming Lei writes: > >>> What about in READ CAPACITY(16)? > > Ming> It isn't set too. > > Please try the following patch: > > > [SCSI] sd: Tweak discard heuristics to work around QEMU SCSI issue > > 7985090aa020 changed the disc

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Paolo Bonzini
On 05/12/2014 14:05, Ming Lei wrote: > > [ 50.112885] sd 0:0:1:0: [sda] FAILED Result: hostbyte=DID_OK > driverbyte=DRIVER_SENSE > [ 50.113859] sd 0:0:1:0: [sda] Sense Key : Illegal Request [current] > [ 50.113859] sd 0:0:1:0: [sda] Add. Sense: Invalid field in cdb > [ 50.113859] sd 0:0:

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-05 Thread Ming Lei
On Fri, Dec 5, 2014 at 11:49 PM, Paolo Bonzini wrote: > > > On 05/12/2014 14:05, Ming Lei wrote: >> >> [ 50.112885] sd 0:0:1:0: [sda] FAILED Result: hostbyte=DID_OK >> driverbyte=DRIVER_SENSE >> [ 50.113859] sd 0:0:1:0: [sda] Sense Key : Illegal Request [current] >> [ 50.113859] sd 0:0:1:0:

Re: [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM

2014-12-05 Thread Paolo Bonzini
On 07/11/2014 06:08, Martin K. Petersen wrote: > The whitelist is only meant as a starting point and is by no means > comprehensive: > >- All intel SSD models except for 510 >- Micron M5* >- Samsung SSDs >- Seagate SSDs > > Signed-off-by: Martin K. Petersen > --- > drivers/ata

Re: [PATCH 2/4] [SCSI] Blacklist RSOC for Microsoft iSCSI target devices

2014-12-05 Thread Mike Christie
On 12/4/14, 8:17 PM, Martin K. Petersen wrote: "Mike" == Mike Christie writes: Mike> In case other people test this patch, I wanted to warn people that Mike> the MS iSCSI target does the same sequence (sends reject PDU then Mike> drops the connection on us) for any command it does not Mike> su

Re: [PATCH] scsi_scan: Send TEST UNIT READY to LUN0 before LUN scanning

2014-12-05 Thread Hannes Reinecke
On 12/05/2014 12:43 AM, Sebastian Herbszt wrote: > Hannes Reinecke wrote: >> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c >> index 49014a1..4f446e3 100644 >> --- a/drivers/scsi/scsi_devinfo.c >> +++ b/drivers/scsi/scsi_devinfo.c >> @@ -166,6 +166,7 @@ static struct { >>

Re: [PATCH] scsi_scan: Send TEST UNIT READY to LUN0 before LUN scanning

2014-12-05 Thread Hannes Reinecke
On 12/05/2014 01:19 AM, James Bottomley wrote: > On Thu, 2014-12-04 at 17:39 +0100, Hannes Reinecke wrote: > [...] >> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c >> index 0af7133..ca39e32 100644 >> --- a/drivers/scsi/scsi_scan.c >> +++ b/drivers/scsi/scsi_scan.c >> @@ -119,6 +1

[PATCH V5 0/3] scsi: Configure number of LUs reported by 'report-luns'

2014-12-05 Thread Rob Evers
This patch set retrieves the number of LUs available on a target using the report-luns command by re-sizing the returned data buffer and retrying report luns. A minor bug fix is included. scsi_mod parameter max_report_luns is no longer used and is removed. Changes from previous posting: - simp

[PATCH V5 1/3] scsi: Avoid unnecessary GFP_ATOMIC allocation in scsi_report_lun_scan

2014-12-05 Thread Rob Evers
Signed-off-by: Rob Evers --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index ba3f1e8..e460b35 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1408,7 +1408,7 @@ static in

[PATCH V5 2/3] scsi: Use set/get_unaligned_be32 in report_luns

2014-12-05 Thread Rob Evers
--- drivers/scsi/scsi_scan.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index e460b35..8db1f6f 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -34,6 +34,7 @@ #include #include #inc

[PATCH V5 3/3] scsi: Retry report-luns when reported LU count requres more memory

2014-12-05 Thread Rob Evers
Update scsi_report_lun_scan to initially always report up to 511 LUs, as the previous default max_report_luns did. Retry in a loop if not enough memory is available for the number of LUs reported. Parameter max_report_luns is removed as it is no longer used. --- drivers/scsi/scsi_scan.c | 43 +++

RE: [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM

2014-12-05 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Thursday, 06 November, 2014 11:08 PM > To: linux-scsi@vger.kernel.org; linux-...@vger.kernel.org; linux- > fsde...@vger.kernel.org; ne...@suse

[PATCH RESEND 2/5] SES: generate KOBJ_CHANGE on enclosure attach

2014-12-05 Thread Song Liu
From: Dan Williams In support of a /dev/disk/by-slot populated with data from the enclosure and ses modules udev needs notification when the new interface files/links are available. Otherwise, any udev rules specified for the disk cannot assume that the enclosure topology has settled. Signed

[PATCH RESEND 3/5] SES: add enclosure logical id

2014-12-05 Thread Song Liu
From: Dan Williams Export the NAA logical id for the enclosure. This is optionally available from the sas_transport_class, but it is really a property of the enclosure. Signed-off-by: Dan Williams Signed-off-by: Song Liu Reviewed-by: Jens Axboe Cc: Hannes Reinecke --- drivers/misc/enclosu

[PATCH RESEND 4/5] SES: add reliable slot attribute

2014-12-05 Thread Song Liu
From: Dan Williams The name provided by firmware is in a vendor specific format, publish the slot number to have a reliable mechanism for identifying slots across firmware implementations. If the enclosure does not provide a slot number fallback to the component number which is guaranteed uni

[PATCH RESEND 0/5] Feature enhancements for ses module

2014-12-05 Thread Song Liu
These patches include a few enhancements to ses module: 1: close potential race condition by at enclosure race condition 2,3,4: add enclosure id and device slot, so we can create symlink in /dev/disk/by-slot: # ls -d /dev/disk/by-slot/* /dev/disk/by-slot/enclosure-0x5000ae41fc1310ff-

[PATCH RESEND 5/5] SES: Add power_status to SES enclosure component

2014-12-05 Thread Song Liu
Add power_status to SES enclosure component, so we can power on/off the HDDs behind the enclosure. Check firmware status in ses_set_* before sending control pages to firmware. Signed-off-by: Song Liu Acked-by: Dan Williams Reviewed-by: Jens Axboe Cc: Hannes Reinecke --- drivers/misc/enclosu

[PATCH RESEND 1/5] SES: close potential registration race

2014-12-05 Thread Song Liu
From: Dan Williams The slot and address fields have a small window of instability when userspace can read them before initialization. Separate enclosure_component allocation from registration. Signed-off-by: Dan Williams Signed-off-by: Song Liu Reviewed-by: Jens Axboe Cc: Hannes Reinecke -

drivers:scsi:storvsc: Fix a bug in handling ring buffer failures that may result in I/O freeze

2014-12-05 Thread Long Li
When ring buffer returns an error indicating retry, storvsc may not return a proper error code to SCSI when bounce buffer is not used. This has introduced I/O freeze on RAID running atop storvsc devices. This patch fixes it by always returning a proper error code. Signed-off-by: Long Li Review

RE: drivers:scsi:storvsc: Fix a bug in handling ring buffer failures that may result in I/O freeze

2014-12-05 Thread KY Srinivasan
> -Original Message- > From: Long Li [mailto:lon...@microsoft.com] > Sent: Friday, December 5, 2014 7:38 PM > To: linux-scsi@vger.kernel.org > Cc: KY Srinivasan; Haiyang Zhang; jbottom...@parallels.com; > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Long Li > Subject: drive