On Tue, Nov 18, 2014 at 06:14:30PM +, Bart Van Assche wrote:
> > -
> > - memset(&cmd->sdb, 0, sizeof(cmd->sdb));
> > -
> > - if (scsi_prot_sg_count(cmd))
> > - scsi_free_sgtable(cmd->prot_sdb, false);
> > -}
>
> Hello Christoph,
>
> Since I'm traveling I'm using a laptop with a
On 20/11/14 06:34, Christoph Hellwig wrote:
> Wakko, any chance you could resend a patch to remove the mutex from the
> ioctl path?
I'm trying out some local changes which removes the ex-BKL mutex from
sr_block_ioctl() in sr.c, and instead uses a per-drive mutex which I've
added to cdrom_device_in
This could use a better description like:
scsi: avoid unessecary GFP_ATOMIC allocation in scsi_report_lun_scan
On Mon, Nov 17, 2014 at 10:22:06AM -0500, Rob Evers wrote:
> ===
And what's this supposed to be?
--
To unsubscri
What are the chances that the sequential scan will succeed when we
failed to allocate memory for report luns?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
> +int scsi_do_report_luns(struct scsi_device *sdev, int length,
> + struct scsi_lun *lun_data, char *devname)
I would skip the do and call this scsi_report_luns. Also shouldn't this
function be marked static?
--
To unsubscribe from this list: send the line "unsubscribe linux
Hi,
Please consider this patch as Acked-by: "Sreekanth Reddy"
.
Regards,
Sreekanth.
On Fri, Nov 7, 2014 at 6:20 AM, Alex Pilon wrote:
> Fix 'ioctl' spelling.
>
> Signed-off-by: Alex Pilon
> ---
> drivers/scsi/mpt2sas/mpt2sas_ctl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
> +++ b/drivers/scsi/scsi_scan.c
> @@ -105,12 +105,13 @@ MODULE_PARM_DESC(scan, "sync, async or none");
> * in practice, the maximum number of LUNs suppored by any device
> * is about 16k.
> */
> -static unsigned int max_scsi_report_luns = 511;
> +static unsigned int max_scsi_report_luns = 16
In some cases, the fcoe_rx_list may contains multiple instances
of the same skb (the so called "shared skbs").
the bnx2fc_l2_rcv thread is a loop that extracts a skb from the list,
modifies (and destroys) its content and then proceed to the next one.
The problem is that if the skb is shared, the r
Hello,
On Wed, 19 Nov 2014 22:46:06 -0800, Christoph Hellwig wrote:
Looks reasonable. Btw, that is the Intel Multi-Flex? A search seems to
b pointing to ethernet switches..
it's a volume manager / multiplexer that comes with the Intel Modular
Server Chassis (MFSYS25 / MFSYS35 / MFSYS25V2). It
> On Sun, Oct 26, 2014 at 11:04:06AM -, Dolev Raviv wrote:
>> > Btw, MAINTAINERS doesn't mention you for the ufs driver, should it?
>>
>> No it shouldn't.
>
> It seems like I'm getting a lot of the series from you and your signoff,
> why shouldn't you be listed in MAINTAINERS? From the list a
Reviewed-by: Maya Erez
> Contains a couple of bug fixes reported by Akinobu Mita, In adition to
> "static checker" warnings reported by Dan Carpenter.
>
> Akinobu Mita (1):
> scsi: ufs: fix reference counting of W-LUs
>
> Dolev Raviv (4):
> scsi: ufs: fix static checker errors in ufshcd_syste
Hi Chris and Mita,
We will review and test the below patches early next week.
Thanks,
Maya
> On Tue, Nov 18, 2014 at 11:02:44PM +0900, Akinobu Mita wrote:
>> This patch series includes two fixes for UFS driver.
>>
>> The first patch already got reviewed and it was a part of Dolev's
>> various
>>
Thanks. This should go into 3.18 and -stable, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 20, 2014 at 12:10:58PM +0100,
christian.suenkenb...@hfg-karlsruhe.de wrote:
> Hello,
>
> On Wed, 19 Nov 2014 22:46:06 -0800, Christoph Hellwig wrote:
> >Looks reasonable. Btw, that is the Intel Multi-Flex? A search seems to
> >b pointing to ethernet switches..
>
> it's a volume mana
On Wed, 19 Nov 2014, Christoph Hellwig wrote:
> On Sat, Nov 15, 2014 at 08:14:57PM -0500, Jeff DeFouw wrote:
> > Kernel 3.16 includes commit
> > 89fb4cd1f717a871ef79fa7debbe840e3225cd54
> > scsi: handle flush errors properly
> >
> > I have an old USB backup drive that indicates a write cache but
Thanks, applied all three patches to drivers-for-3.19.
Any reason you update the version number for every single patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/maj
Thanks, applied to drivers-for-3.19.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I've applied all patches to drivers-for-3.19.
If you could do me two favours:
- please look into sparse endianess warnings. This series introduces
a few new ones, but given that the area around it was full of it
I didn't pull it for that for now.
- please review the various hpsa fixes To
Thanks, applied to drivers-for-3.19.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks, I've applied all patches to the drivers-for-3.19 branch.
I had a few rejects due to Hannes logging changes. I think I've fixed
them properly, but please verify it.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.or
Thanks, applied all three patches to drivers-for-3.19
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied to drivers-for-3.18 as these are small self-contained and
important fixes for new code introduced in this merged window.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vg
From: Markus Elfring
Date: Thu, 20 Nov 2014 18:11:28 +0100
The put_disk() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/
Hello Christoph,
I tested your patch, it works, the bug is gone with your patch, it's a
good news,
I notice that my motherboard doesn't support "AHCI" mode, my motherboard
uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the
technical specifications of this controler,
it seems t
On Thu, Nov 20, 2014 at 06:44:32PM +0100, Barto wrote:
> I notice that my motherboard doesn't support "AHCI" mode, my motherboard
> uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the
> technical specifications of this controler,
>
> it seems that my bios treats SATA devices like
From: Markus Elfring
Date: Thu, 20 Nov 2014 18:48:52 +0100
The put_device() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
https://bugzilla.kernel.org/show_bug.cgi?id=88591
Bug ID: 88591
Summary: SCSI_IOCTL_GET_IDLUN only returns 8 bits for the SCSI
Target value
Product: SCSI Drivers
Version: 2.5
Kernel Version: 3.14.22
Hardware: All
Hello,
here is the result of the command :
$ for i in /sys/class/scsi_host/*; do cat $i/can_queue; done
1
1
1
1
1
1
31
31
but the sata DVD burner is now connected on a Jmicron sata PCIe card (
with this configuration the bug doesn't occur ), I don't know if this
change can modify the result of y
On 11/17/2014 10:22 AM, Rob Evers wrote:
This patch set retrieves the number of LUs available on a target
using the report-luns command. The initial size of the report-luns
command is 512 entries, as the previous default initial number was.
If more LUs than 511 are present on a target, the repor
From: Markus Elfring
Date: Thu, 20 Nov 2014 20:10:19 +0100
The fc_fcp_ddp_done() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
d
Looks fine
Acked-by: James Smart
-- james s
On 11/13/2014 12:59 PM, Christoph Hellwig wrote:
James Smart said the userspace to consume these events never emerged. Given
that these get in the way of the following patches remove support for them.
Signed-off-by: Christoph Hellwig
---
dr
From: Markus Elfring
Date: Thu, 20 Nov 2014 20:37:30 +0100
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drive
On 14-11-20 12:55 PM, bugzilla-dae...@bugzilla.kernel.org wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=88591
Bug ID: 88591
Summary: SCSI_IOCTL_GET_IDLUN only returns 8 bits for the SCSI
Target value
Product: SCSI Drivers
https://bugzilla.kernel.org/show_bug.cgi?id=88591
--- Comment #1 from d gilbert ---
On 14-11-20 12:55 PM, bugzilla-dae...@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=88591
>
> Bug ID: 88591
> Summary: SCSI_IOCTL_GET_IDLUN only returns 8 bits f
From: Markus Elfring
Date: Thu, 20 Nov 2014 23:18:56 +0100
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scs
From: Markus Elfring
Date: Thu, 20 Nov 2014 23:43:17 +0100
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scsi/bfa/bfad_debugfs.c |
I was wondering if anyone had a chance to review the patch? Comments are
appreciated and I'm more than happy to make changes that will allow it to be
accepted.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More major
Hi Shane,
I was actually about to pull this patch and test it.
Lots of changes and a big patch so going to create a another driver as
a tape stats driver for now for testing.
Will exercise this fully and provide feedback to the list.
Regards
Laurence Oberman
On Thu, Nov 20, 2014 at 6:49 PM, Seymo
Patch looks good.
Thanks!
Acked-by: Anil Gurumurthy
-Original Message-
From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net]
Sent: 21 November 2014 04:17
To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi
Cc: linux-kernel; kernel-janit...@vger.kernel.org;
On Thu, 20 Nov 2014, Christoph Hellwig wrote:
> Thanks, I've applied all patches to the drivers-for-3.19 branch.
>
> I had a few rejects due to Hannes logging changes. I think I've fixed
> them properly, but please verify it.
The merge looks good, thanks.
--
--
To unsubscribe from this list:
Hi Linus,
Here are the target-pending fixes queued for v3.18-rc6. Please go ahead
and pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
The highlights include:
- target-core OOPs fix with tcm_qla2xxx + vxworks FC initiators + zero length
SCSI command
Hi Linus,
Here are the target-pending fixes queued for v3.18-rc6. Please go ahead
and pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
The highlights include:
- target-core OOPs fix with tcm_qla2xxx + vxworks FC initiators + zero length
SCSI command
Hi,
This series continues to cleanup all the macros/register defines related to
filter, port, VI, queue, RSS, LDST, firmware, etc that are defined in t4fw_api.h
and the affected files.
Will post few more series so that we can cover all the macros so that they all
follow the same style to be consi
This patch cleanups all filter related macros/register defines that are defined
in t4fw_api.h and the affected files.
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/cm.c| 14 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 68 ++--
drivers/net/ethernet/
This patch cleanups PF/VF and LDST related macros/register defines that are
defined in t4fw_api.h and the affected files.
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/cm.c |2 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 61 +++--
drivers/ne
This patch cleanups all queue related macros/register defines that are defined
in t4fw_api.h and the affected files.
Signed-off-by: Hariprasad Shenai
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 115 ++--
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 32 +-
drivers/net/ethernet/che
This patch cleanups all PCIE, RSS & FW related macros/register defines that are
defined in t4fw_api.h and the affected files.
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/provider.c |8 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |8 +-
drivers/n
This patch cleanups all port and VI related macros/register defines that are
defined in t4fw_api.h and the affected files.
Signed-off-by: Hariprasad Shenai
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 14 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.h |4 +-
drivers/net/ethern
On Fri, 2014-11-21 at 12:52 +0530, Hariprasad Shenai wrote:
> This patch cleanups all filter related macros/register defines that are
> defined
> in t4fw_api.h and the affected files.
Is there any real value in the FW_FILTER_WR_ prefix?
Does it need to be so long?
Perhaps it'd be nicer to read i
49 matches
Mail list logo
