Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Barto
Hello, I solved the mystery, I found that the element who triggers the bug ( random hang at boot with kernel 3.17 and 3.18 ) is the combination of 3 elements : - the use of a SATA DVD burner ( Liteon iHAS124 C ) on a ICH7 Sata controler - the use of a gigabyte motherboard GA-P31-DSL3 ( bios F10A

Re: [PATCH net] cxgb4i : Don't block unload/cxgb4 unload when remote closes TCP connection

2014-11-19 Thread David Miller
From: Anish Bhatt Date: Tue, 18 Nov 2014 19:09:51 -0800 > cxgb4i was returning wrong error and not releasing module reference if remote > end abruptly closed TCP connection. This prevents the cxgb4 network module > from > being unloaded, further affecting other network drivers dependent on cxgb4

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-19 Thread Christoph Hellwig
On Sat, Nov 15, 2014 at 08:31:00AM -0700, Jens Axboe wrote: > My next move would be to add more debug to the CPU map setup and teardown, > so that we can verify that the map that is being used above has indeed been > setup. Unless Christoph has any ideas on what is going on here? No good idea, but

Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Christoph Hellwig
I Hi Barto, sorry for the late reply, and thanks for drilling down the exact conditions. I think we have some issues with the lack of the host lock vs error handling, but I still don't undertand the details. I've got a test patch for you that just adds the host lock back in a few places while k

Re: split ->change_queue_depth

2014-11-19 Thread Christoph Hellwig
Any chance to get some reviews for this series? I'd like to get it in for the 3.19 window to avoid two related API changes in two consecutive releases. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: Very slow throughput when using cdparanoia on two SATA CDROM drives with /dev/sr but not /dev/sg

2014-11-19 Thread Christoph Hellwig
Wakko, any chance you could resend a patch to remove the mutex from the ioctl path? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: remove scsi_driver owner field

2014-11-19 Thread Christoph Hellwig
Any chance to get a second review for this one? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bnx2fc: do not add shared skbs to the fcoe_rx_list

2014-11-19 Thread Christoph Hellwig
On Tue, Nov 18, 2014 at 04:50:56PM +0100, Maurizio Lombardi wrote: > Hi Chad, > Thanks. > > CC James and Christoph Can you send me a patch against the current tree with all the signoffs and review tags? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: 3.16 commit 89fb4cd errors on drives without SYNC CACHE

2014-11-19 Thread Christoph Hellwig
On Sat, Nov 15, 2014 at 08:14:57PM -0500, Jeff DeFouw wrote: > Kernel 3.16 includes commit > 89fb4cd1f717a871ef79fa7debbe840e3225cd54 > scsi: handle flush errors properly > > I have an old USB backup drive that indicates a write cache but does not > support Synchronize Cache(10). The request err

Re: [GIT PULL] SCSI fixes for 3.18-rc4

2014-11-19 Thread Christoph Hellwig
On Sun, Nov 16, 2014 at 08:17:32AM -0800, James Bottomley wrote: > This is a set of six fixes and a MAINTAINER update. The fixes are two > multipath (one in Test Unit Ready handling for the path checkers and one > in the section of code that sends a start unit after failover; both of > these were p

Re: [PATCH] scsi: Add Intel Multi-Flex to scsi scan blacklist

2014-11-19 Thread Christoph Hellwig
Looks reasonable. Btw, that is the Intel Multi-Flex? A search seems to b pointing to ethernet switches.. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

Re: [PATCH 0/2] UFS driver fixes for v3.18

2014-11-19 Thread Christoph Hellwig
On Tue, Nov 18, 2014 at 11:02:44PM +0900, Akinobu Mita wrote: > This patch series includes two fixes for UFS driver. > > The first patch already got reviewed and it was a part of Dolev's various > fixes for UFS-PM series (http://marc.info/?l=linux-scsi&m=141405993104015), > but they are not merged

[PATCH 08/22] [SCSI] mpt2sas, mpt3sas: Update Attribution Language to Avago

2014-11-19 Thread Sreekanth Reddy
Copyright, Trademark & Confidentiality legal statements throughout source code changed from LSI to Avago. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.c | 3 ++- drivers/scsi/mpt2sas/mpt2sas_base.h | 5 +++-- drivers/scsi/mpt2sas/mpt2sas_config.c |

[PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2014-11-19 Thread Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081 then that command will be completed with DID_RESET host status. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_scsih.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2014-11-19 Thread Sreekanth Reddy
Added a support to set cpu affinity mask for each MSIX vector enabled by the HBA, So that by runnig the irqbalancer, interrupts can be balanced among the cpus. Change_set: 1. Call the API irq_set_affinity_hint for each MSIX vector to affiniate it with avalibale online cpus at driver inilization

[PATCH 17/22] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2014-11-19 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index dba4d66..4c07f17 100644 ---

[PATCH 01/22] [SCSI] mpt2sas: MPI2 Rev AA (2.00.19) specifications

2014-11-19 Thread Sreekanth Reddy
Below is the changeset from the MPI specification and 2.00.34 header files 1) Defined additional bits in the BiosOptions field of BIOS Page 1 to allow for finer control of X86 BIOS and UEFI BSD. 2) For the Clean Tool, reserved bit 26 of the Flags field for product specific use. Signed-off-by: Sr

[PATCH 15/22] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2014-11-19 Thread Sreekanth Reddy
Update MPI 2.5 Release: MPI 2.5 Rev I (2.5.4) specification and 2.00.33 header files Below is the change set from the MPI specification for I Rev 1) Added Base Enclosure Level bit to the Flags field of Manufacturing Page 7. 2) Updated description of the MaxTargetPortConnectTime field of SAS IO U

[PATCH 10/22] [SCSI] mpt2sas: Bump driver version to 20.100.00.00

2014-11-19 Thread Sreekanth Reddy
Bump mpt2sas driver version to 20.100.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h index 72bffec..ed14084 100644 ---

[PATCH 11/22] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2014-11-19 Thread Sreekanth Reddy
In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. Support this feature only for SAS3 C0 cards and also only when reply post free queue count is greater than 8. 2. Instead of using single ReplyPostHostInde

[PATCH 04/22] [SCSI] mpt2sas: Bump driver version to 19.100.00.00

2014-11-19 Thread Sreekanth Reddy
Bump driver version to 19.100.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h index 8a41a4e..3faad45 100644 --- a/drive

[PATCH 12/22] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2014-11-19 Thread Sreekanth Reddy
Driver initialization fails if driver tries to send IOC facts request message when the IOC is in reset or in a fault state. This patch will make sure that 1.Driver to send IOC facts request message only if HBA is in operational or ready state. 2.If IOC is in fault state, a diagnostic reset wou

[PATCH 16/22] [SCSI] mpt3sas: Provides the physical location of sas drives

2014-11-19 Thread Sreekanth Reddy
This Patch will provide more details of the devices such as slot number, enclosure logical id, enclosure level & connector name in the following scenarios, - When end device is added in the topology, - When the end device is removed from the setup, - When the SCSI mid layer issues TASK ABORT/ DE

[PATCH 02/22] [SCSI] mpt2sas, mpt3sas: Added support to log message when Temperature Threshold exceeds for any Sensor

2014-11-19 Thread Sreekanth Reddy
This patch will log a message when driver receives "Temperature Threshold exceeded" event from any temperature sensor. The message will look similar to like mpt3sas0: Temperature Threshold flags a b c d exceeded for Sensor: x !!! mpt3sas0: Current Temp In Celsius: y where a b c d are threshold f

[PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries

2014-11-19 Thread Sreekanth Reddy
1. Removed the upper boundary restriction for the module parameter max_sgl_entries. Earlier, the max_sgl_entries was capped at the SCSI_MAX_SG_SEGMENTS kernel definition. With this change, the user would be able to set the max_sgl_entries to any value. 2. Added a print for the message log whenev

[PATCH 14/22] [SCSI] mpt2sas, mpt3sas: Remove redundancy code while freeing the controller resources.

2014-11-19 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.c | 49 ++- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 + 2 files changed, 61 insertions(+), 45 d

[PATCH 22/22] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2014-11-19 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 9608e3a..035a244 100644 ---

[PATCH 18/22] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2014-11-19 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index

[PATCH 20/22] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2014-11-19 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding String 0x10000x0097 0x1028 0x1F46DELL 12Gbps HBA Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt

[PATCH 21/22] mpt3sas: Add branding string support for OEM custom HBA

2014-11-19 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-off-by: Sreekanth Reddy --- drivers/scsi/m

[PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches

2014-11-19 Thread Sreekanth Reddy
Please consider this Patch set for next kernel release. Highlights of this patch set: - 96 MSIX vector support for SAS3 HBA's, - Log Temperature threshold exceeds message for any temperature sensor, - Updating the copy right information, - Provide physical location of target drives by printing Enc

[PATCH 19/22] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2014-11-19 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 14 +

[PATCH 05/22] [SCSI] mpt2sas: MPI2 Rev BB (2.00.20) specification and 2.00.35 header files

2014-11-19 Thread Sreekanth Reddy
Change List in this MPI2 specification, 1. Added SSUTimeout field to MPI2_CONFIG_PAGE_BIOS_1, and more defines for the BiosOptions field. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt2sas/mpi/mpi2_cnfg.h | 17 ++--- 2 files c

[PATCH 03/22] [PATCH] mpt2sas, mpt3sas: Fail the host reset initiated due to discovery related I/O timeouts at driver load time

2014-11-19 Thread Sreekanth Reddy
When a flaky disk is there in a topology then during driver load, discovery related I/O times out; which results in SCSI error recovery initiating host reset and then the controller won't see any disk. In this patch, The driver would return FAILED status to the host reset initiated due to discover

[PATCH 13/22] [SCSI] mpt3sas: Added module parameter 'unblock_io' to unblock IO's during disk addition

2014-11-19 Thread Sreekanth Reddy
During hot-plugging of a disk(having a flaky link), the disk addition stops and any further disk addition or removal doesn't happen on that controller. This is because, when driver receives DELAY_NOT_RESPONDING for a disk when it is undergoing addition in the SCSI Mid layer, the driver would blo

Re: [PATCH 1/7] lpfc: remove queue_depth events

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > James Smart said the userspace to consume these events never emerged. Given > that these get in the way of the following patches remove support for them. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/lpfc/lpfc_scsi.c | 66 > ---

Re: [PATCH 2/7] scsi: avoid ->change_queue_depth indirection for queue full tracking

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > All drivers use the implementation for ramping the queue up and down, so > instead of overloading the change_queue_depth method call the > implementation diretly if the driver opts into it by setting the > track_queue_depth flag in the host templat

Re: [PATCH 3/7] scsi: don't allow setting of queue_depth bigger than can_queue

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > We won't ever queue more commands than the host allows. Instead of > letting drivers either reject or ignore this case handle it in > common code. Note that various driver use internal constant or > variables that are assigned to both shost->can_

Re: [PATCH 4/7] scsi: drop reason argument from ->change_queue_depth

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > Drop the now unused reason argument from the ->change_queue_depth method. > Also add a return value to scsi_adjust_queue_depth, and rename it to > scsi_change_queue_depth now that it can be used as the default > ->change_queue_depth implementation.

Re: [PATCH 5/7] mpt2sas: simplify ->change_queue_depth

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > Merge two functions, and remove overly verbose debugging output that pokes > into mid-layer internal structures. > > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH 6/7] mpt3sas: simplify ->change_queue_depth

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > Merge two functions, and remove overly verbose debugging output that pokes > into mid-layer internal structures. > > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH 7/7] vmw_pscsi: simplify ->change_queue_depth

2014-11-19 Thread Hannes Reinecke
On 11/13/2014 06:59 PM, Christoph Hellwig wrote: > Remove overly verbose debugging output that pokes into mid-layer internal > structures that looks like copy & paste from the mpt2/3 drivers. > > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinec