Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

On Wed, Sep 24, 2014 at 09:41:25AM -0400, Joe Lawrence wrote: > Hi Saurav, > > Will these changes conflict with those submitted in August [1] to > Christoph's drivers-for-3.18 branch? It does cause conflicts when applying the patch at least. Chad, can you please resend the series against the dri

[PATCH 00/19] qla2xxx/target: Target bug fixes and enchancements.

Hi Nicholas/Christoph, Please apply the following patches at your earliest convenience. Thanks, ~Saurav Arun Easi (6): qla2xxx: Use correct offset to req-q-out for reserve calculation qla2xxx: Remove verbose messages in target mode. qla2xxx: Enable SLER conditionally in target mode. qla2

[PATCH 01/19] qla2xxx: Fix sparse warnings in tcm_qla2xxx.c

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index e2beab9

[PATCH 03/19] qla2xxx: Use correct offset to req-q-out for reserve calculation

From: Arun Easi Cc: Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index e44fcb5..bcc449a 100644 ---

[PATCH 17/19] qla2xxx: Add memory barrier before ringing doorbell.

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 137ad

[PATCH 08/19] qla2xxx: fix crash due to task mgmt cmd type

From: Himanshu Madhani tcm_qla2xxx_get_task_tag incorrectly assume command is qla_tgt_cmd. Add check to see if it's a scsi cmd or task mgmt command. Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/tcm_qla2xxx.c |9 +++-- 1 files changed, 7 insertions(

[PATCH 09/19] qla2xxx: Add Host reset handling in target mode.

From: Arun Easi Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_gbl.h|1 + drivers/scsi/qla2xxx/qla_os.c |2 + drivers/scsi/qla2xxx/qla_target.c | 74 + 4 file

[PATCH 06/19] qla2xxx: Enable SLER conditionally in target mode.

From: Arun Easi Sequence level error recovery (aka FC Tape) is not really required for disk devices. On heavily loaded system, with slow turn around, a bunch of status enquiries using REC puts additional burden to the target, so just turn off SLER by default. Signed-off-by: Arun Easi Signed-off

[PATCH 18/19] Target/transport: SCSI Status Respond being sent to Initiator twice.

From: Quinn Tran During temporary resource starvation at lower transport layer, command is placed on queue full retry path, which expose this problem. The TCM Qfull handling send the same cmd twice to lower layer. The 1st time led to cmd normal free path. The 2nd time cause Null pointer access

[PATCH 14/19] qla2xxx: Do not send SS_RESIDUAL_UNDER with SAM_STAT_BUSY

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index fed7fef..b07b180

[PATCH 10/19] qla2xxx: Handle chip reset in target mode.

From: Arun Easi A chip reset can occur after driver submits command to the stack. Abort command processing if a chip reset has occurred or in progress when you get a follow up for a command. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h|1 +

[PATCH 19/19] target: Implement report lun data change unit attention.

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/target/target_core_fabric_configfs.c | 28 ++ 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_con

[PATCH 15/19] qla2xxx: Fix hang due to cmd_kref not decrementing

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 18 ++ drivers/scsi/qla2xxx/qla_target.h |1 + 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scs

[PATCH 12/19] qla2xxx: Increase the request queue size to 8K for ISP2031

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_os.c |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index c9fe4cf..6e3b

[PATCH 13/19] qla2xxx: Add support for QFull throttling and Term Exchange retry

From: Quinn Tran Through the qla target code, the qlt_send_term_exchange() routine is used in various different places to cleanup an exchange. For the case of IOCB request queue is full, the exchange is left unhandled/ dangling. Existing code does not have re-try logic to cleanup the exchange. Th

[PATCH 07/19] qla2xxx: Add counter for message

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 2d4003f..4989bf7 100644 --- a/driver

[PATCH 05/19] qla2xxx: Remove verbose messages in target mode.

From: Arun Easi Turning logging bits for target mode ON dumps quite a lot verbose messages, remove those and change some of the IO path logging to use IO bits. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 154 -

[PATCH 04/19] qla2xxx: Increase room in request queue for sending priority packets

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_iocb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 6a6867d..c787847 100644 -

[PATCH 16/19] qla2xxx: Add flags for tracing the target commands.

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 30 ++ drivers/scsi/qla2xxx/qla_target.h | 24 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 24 3 files changed, 74

[PATCH 02/19] qla2xxx: fix kernel NULL pointer access

From: Himanshu Madhani This patch is to fix regression added by commit id 51a07f84649d2be206c4c2ad9a612956db0c2f8c. When allocating memory for new session original patch does not assign vha to op->vha resulting into NULL pointer access during qlt_create_sess_from_atio(). Cc: Signed-off-by: Him

[PATCH 11/19] qla2xxx: Host reset handling in ABTS path.

From: Arun Easi ABTS path takes path similar to regular task management, but reset_count was not initialized when allocating mcmd causing the response to get dropped in qlt_xmit_tm_rsp. Fix this by initializing reset_count correctly. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap ---

Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

Hi Christoph, I will rebase and send an updated patch set soon. Thanks, ~Saurav >On Wed, Sep 24, 2014 at 09:41:25AM -0400, Joe Lawrence wrote: >> Hi Saurav, >> >> Will these changes conflict with those submitted in August [1] to >> Christoph's drivers-for-3.18 branch? > >It does cause conflicts

Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

On Thu, Sep 25, 2014 at 08:57:18AM +, Saurav Kashyap wrote: > Hi Christoph, > I will rebase and send an updated patch set soon. Thanks. Did you verify the target side series sits nicely on top of this one as well? I'd like to slurp in the qla2xxx patches as well if Nick is fine with them, al

Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

>On Thu, Sep 25, 2014 at 08:57:18AM +, Saurav Kashyap wrote: >> Hi Christoph, >> I will rebase and send an updated patch set soon. > >Thanks. Did you verify the target side series sits nicely on top of this >one as well? I'd like to slurp in the qla2xxx patches as well if Nick >is fine with

[PATCH RESEND 11/35] qla2xxx: ISPFX00 avoid writing semaphore register in request_irqs().

From: Joe Carnuccio Semaphore register does not exist for ISPFx00. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_isr.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/q

[PATCH RESEND 04/35] qla2xxx: ISP27xx fwdump template fix insertbuf() routine.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_tmpl.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c index 6da9dd2..6f2f7b2 10064

[PATCH RESEND 22/35] qla2xxx: Declaration error cause stack corruption.

From: Quinn Tran Declaration error of mb array in qla2x00_iidma_fcport cause data to be written beyond the array. This ends up causing stack corruption. Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH RESEND 28/35] qla2xxx: Honor FCP_RSP retry delay timer field.

From: Chad Dupuis Parse the retry delay timer field from the FCP response data and if: - It is not zero - The SCSI status is busy or queue full return SCSI_MLQUEUE_TARGET_BUSY for the number of milliseconds specified in the retry delay timer field. Signed-off-by: Chad Dupuis Signed-off-by: Sa

[PATCH RESEND 08/35] qla2xxx: ISP25xx multiqueue shadow register crash fix.

From: Joe Carnuccio When creating request/response queues from qla25xx_setup_mode(), the shadow index register pointers were not being initialized to point at the registers. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mid.c |2 ++ 1 files change

[PATCH RESEND 07/35] qla2xxx: Add endianizer to max_payload_size modifier.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_fw.h |2 +- drivers/scsi/qla2xxx/qla_init.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx

[PATCH RESEND 31/35] qla2xxx: Disable PCI device in shutdown handler.

From: Chad Dupuis Disable the PCI device during shutdown to prevent any races with other PCI code such as the AER handling code. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH RESEND 23/35] qla2xxx: Enable diagnostic port using NVRAM parameters.

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_init.c |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/q

[PATCH RESEND 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

From: Arun Easi Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 0f9dcf6..4880f0b 100644 --- a/drivers/scsi/ql

[PATCH RESEND 02/35] qla2xxx: ISP27xx optimize fwdump entry table lookup.

From: Joe Carnuccio Since the entry call array is sorted in order of entry type opcode, the search can be terminated as soon as the search key is exceeded. Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_tmpl.c | 10 ++ 1 files changed, 6 inse

[PATCH RESEND 27/35] qla2xxx: Add missing ISP27xx checks to optrom code.

From: Alex Vechersky Signed-off-by: Alex Vechersky Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |3 ++- drivers/scsi/qla2xxx/qla_bsg.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_

[PATCH RESEND 05/35] qla2xxx: Add ISP27xx fwdump template entry T275 (insert buffer).

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |7 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 27 +++ drivers/scsi/qla2xxx/qla_tmpl.h |6 ++ 3 files changed, 36 insertions(+), 4 deletions(-

[PATCH RESEND 06/35] qla2xxx: Enable fast flash access for ISP83xx.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_sup.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index bca173e..04b3701 100644 --- a/drivers/s

[PATCH RESEND 09/35] qla2xxx: ISP27xx fwdump template error print simplification.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |3 +++ drivers/scsi/qla2xxx/qla_tmpl.c | 31 --- drivers/scsi/qla2xxx/qla_tmpl.h |2 ++ 3 files changed, 9 insertions(+), 27 deletions(-) d

[PATCH RESEND 18/35] qla2xxx: Fix driver version string message.

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_sup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index 4788ecd0..b656a05 100644 --- a

[PATCH RESEND 13/35] qla2xxx: Incorrect linked list semantic in qlafx00_get_fcport().

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 8ecf6de..620e60a 100644 --- a/driver

[PATCH RESEND 30/35] qla2xxx: Mark port lost when we receive an RSCN for it.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_isr.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 696e4a2..a04a1b1 100644

[PATCH RESEND 16/35] qla2xxx: Add FA-WWN functionality.

From: Joe Carnuccio Add support for the FA-WWN (fabric assigned wwn) fabric switch feature. (Fabric Assigned World Wide Port Name) Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |7 ++- drivers/scsi/qla2xxx/qla_fw.h |2 +- drivers/s

[PATCH RESEND 03/35] qla2xxx: ISP27xx fwdump template remove high frequency debug logs.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c | 17 - 2 files changed, 1 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/

[PATCH RESEND 29/35] qla2xxx: Restore WWPN in case of Loop Dead.

From: Himanshu Madhani For FA-WWPN capable device, ISP2031 and ISP27XX, when loop dead is detected by a driver, restore WWPN from NVRAM. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |3 +-- drivers/scsi/qla2xxx/qla_def.h |3 ++- dr

[PATCH RESEND 12/35] qla2xxx: Incorrect debug level on mailbox command print 0x1111.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mbx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index a7a373f..ca7f4f0 100644 --- a/driver

[PATCH RESEND 10/35] qla2xxx: Fix potential return count bug in qla2xxx_get_vpd_field().

From: Joe Carnuccio Call scnprintf() instead of snprintf() since the latter may return an incorrect count in cases where the write is truncated to fit. scnprintf() returns the count of what was actually written; snprintf() returns the count of what would have been written. Signed-off-by: Joe Ca

[PATCH RESEND 14/35] qla2xxx: ISPFx00 unexpected resets during adapter boot sequence.

From: Jan Kulich Signed-off-by: Jan Kulich Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 620e60a..c54a53d 100644 --- a/drivers/scsi

[PATCH RESEND 26/35] qla2xxx: Force use of mailbox interface for flash access commands for ISP27xx.

From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_init.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 1b91771..51cabb9 100644 --- a/drive

[PATCH RESEND 00/35] qla2xxx: Patches for 3.18 scsi "misc" branch.

Hi James, Christoph, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. This patch set is rebased on drivers-for-3.18 branch of git://git.infradead.org/users/hch/scsi-queue.git. Thanks, ~Saurav Alex Vechersky (1): qla2xxx: Add missing ISP27xx checks

[PATCH RESEND 32/35] qla2xxx: Fail adapter initialization on load ram failure.

From: Chad Dupuis If we fail to load one of the segments of firmware fail the operation instead of trying to continue which will lead to a system crash since the pointers to the next segment will not be updated correctly. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/sc

[PATCH RESEND 01/35] qla2xxx: ISP27xx add tests for incomplete template.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_tmpl.c |9 + 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/

[PATCH RESEND 17/35] qla2xxx: Add diagnostic port functionality.

From: Joe Carnuccio Add support for the D-port (diagnostic port) fabric switch feature. (Fabric Switch initiates loopback style port testing) Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |6 +++--- drivers/scsi/qla2xxx/qla_dbg.c |2 +

[PATCH RESEND 19/35] qla2xxx: Allow user to change ql2xfdmienable value.

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 1b9864c..0f9dcf6 100644 --- a/dri

[PATCH RESEND 24/35] qla2xxx: Disable laser for ISP2031 while unloading driver.

From: Himanshu Madhani Nameserver data on FC switch is not refreshed when qla2xxx driver is unloaded. Disabling laser for ISP2031 will force FC switch to rescan ports and clear fdmi entries from Nameserver. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx

[PATCH RESEND 21/35] qla2xxx: Add fix in driver unload for pending activity.

From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 4880f0b..72b94f9 100644 --- a/drive

[PATCH RESEND 35/35] qla2xxx: Update the driver version to 8.07.00.16-k.

Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 4d2c98c..d88b862 100644 --- a/drivers/scs

[PATCH RESEND 33/35] qla2xxx: Move warning message to debug level.

From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_nx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 2562600..54cb2ac 100644 --- a/drivers/s

[PATCH RESEND 34/35] qla2xxx: Fix sparse warning in qla_iocb.c file.

From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_iocb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 150529d..6a6867d 100644 --- a/dri

[PATCH RESEND 15/35] qla2xxx: Add FDMI-2 functionality.

From: Himanshu Madhani Add support for the FDMI-2 fabric switch feature. Since FDMI-2 uses code from FDMI-1, some of the existing code needed to be repaired to prevent fields from being overflowed. Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_att

[PATCH RESEND 25/35] qla2xxx: Free sysfs attributes for ISP27xx.

From: Nigel Kirkland Signed-off-by: Nigel Kirkland Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 677239f..9391e4b 100644 --- a/d

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

On Wed, 2014-09-24 at 17:48 +0200, Tomas Henzl wrote: > On 09/24/2014 11:33 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is relative to: > > http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr > > > > change in v5: > > 1. rename firstinde

Re: [PATCH 06/19] qla2xxx: Enable SLER conditionally in target mode.

On Thu, Sep 25, 2014 at 04:09:59AM -0400, Saurav Kashyap wrote: > From: Arun Easi > > Sequence level error recovery (aka FC Tape) is not really required > for disk devices. On heavily loaded system, with slow turn around, > a bunch of status enquiries using REC puts additional burden to the > tar

Re: [PATCH 06/19] qla2xxx: Enable SLER conditionally in target mode.

Hi Christoph, Thanks for the feedback. Let me make necessary changes and resubmit the patch set. As suggested by you, I will also do the separate submission for qla2xxx and tcm-lio. Thanks, ~Saurav >On Thu, Sep 25, 2014 at 04:09:59AM -0400, Saurav Kashyap wrote: >> From: Arun Easi >> >> Sequenc

Re: [PATCH V5 11/17] scsi: ufs: add UFS power management support

Thanks Mita, You are right these are careless mistakes. I will fix all of them and upload a new version shortly. > __ufshcd_send_uic_cmd() is called with host_lock held here, but > host_lock is acquired again in __ufshcd_send_uic_cmd(). So it causes > recursive deadlock. Correct I forgot to comp

[Bug 85101] hpsa + P410 does not show connected HP SAS port expanders

https://bugzilla.kernel.org/show_bug.cgi?id=85101 --- Comment #4 from linux-...@crashplan.pro --- @Robert Elliott Thanks for all your help. The issue turns out not to be the HP P410 controller. Using another mainboard the same HP P410 controller is ok. -- You are receiving this mail because: You

[PATCH RESEND 02/17] qla2xxx: fix kernel NULL pointer access

From: Himanshu Madhani This patch is to fix regression added by commit id 51a07f84649d2be206c4c2ad9a612956db0c2f8c. When allocating memory for new session original patch does not assign vha to op->vha resulting into NULL pointer access during qlt_create_sess_from_atio(). Cc: Signed-off-by: Him

[PATCH RESEND 01/17] qla2xxx: Fix sparse warnings in tcm_qla2xxx.c

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index e2beab9

[PATCH RESEND 04/17] qla2xxx: Increase room in request queue for sending priority packets

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_iocb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 6a6867d..c787847 100644 -

[PATCH RESEND 13/17] qla2xxx: Add support for QFull throttling and Term Exchange retry

From: Quinn Tran Through the qla target code, the qlt_send_term_exchange() routine is used in various different places to cleanup an exchange. For the case of IOCB request queue is full, the exchange is left unhandled/ dangling. Existing code does not have re-try logic to cleanup the exchange. Th

[PATCH RESEND 06/17] qla2xxx: Enable SLER conditionally in target mode.

From: Arun Easi Sequence level error recovery (aka FC Tape) is not really required for disk devices. On heavily loaded system, with slow turn around, a bunch of status enquiries using REC puts additional burden to the target, so just turn off SLER by default. Signed-off-by: Arun Easi Signed-off

[PATCH RESEND 15/17] qla2xxx: Fix hang due to cmd_kref not decrementing

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 18 ++ drivers/scsi/qla2xxx/qla_target.h |1 + 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scs

[PATCH RESEND 12/17] qla2xxx: Increase the request queue size to 8K for ISP2031

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_os.c |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index e3643df..b048

[PATCH RESEND 10/17] qla2xxx: Handle chip reset in target mode.

From: Arun Easi A chip reset can occur after driver submits command to the stack. Abort command processing if a chip reset has occurred or in progress when you get a follow up for a command. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_def.h|1 +

[PATCH RESEND 17/17] qla2xxx: Add memory barrier before ringing doorbell.

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index f3287

[PATCH RESEND 09/17] qla2xxx: Add Host reset handling in target mode.

From: Arun Easi Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_gbl.h|1 + drivers/scsi/qla2xxx/qla_os.c |2 + drivers/scsi/qla2xxx/qla_target.c | 74 + 4 file

[PATCH RESEND 11/17] qla2xxx: Host reset handling in ABTS path.

From: Arun Easi ABTS path takes path similar to regular task management, but reset_count was not initialized when allocating mcmd causing the response to get dropped in qlt_xmit_tm_rsp. Fix this by initializing reset_count correctly. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap ---

[PATCH RESEND 07/17] qla2xxx: Add counter for message

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 85587fc..1a546bc 100644 --- a/driver

[PATCH RESEND 14/17] qla2xxx: Do not send SS_RESIDUAL_UNDER with SAM_STAT_BUSY

From: Himanshu Madhani Signed-off-by: Himanshu Madhani Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 9f248e7..94b726e

[PATCH RESEND 16/17] qla2xxx: Add flags for tracing the target commands.

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 30 ++ drivers/scsi/qla2xxx/qla_target.h | 24 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 24 3 files changed, 74

[PATCH RESEND 08/17] qla2xxx: fix crash due to task mgmt cmd type

From: Himanshu Madhani tcm_qla2xxx_get_task_tag incorrectly assume command is qla_tgt_cmd. Add check to see if it's a scsi cmd or task mgmt command. Signed-off-by: Quinn Tran Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/tcm_qla2xxx.c |9 +++-- 1 files changed, 7 insertions(

[Bug 85101] hpsa + P410 does not show connected HP SAS port expanders

https://bugzilla.kernel.org/show_bug.cgi?id=85101 linux-...@crashplan.pro changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH RESEND 00/17] qla2xxx: Target bug fixes and enchancements.

Hi Nicholas/Christoph, Please apply the following patches at your earliest convenience. This patchset have target related changes to qla2xxx. I will submit the target (TCM-LIO) patches in different patch set. Thanks, ~Saurav Arun Easi (6): qla2xxx: Use correct offset to req-q-out for reserve

[PATCH RESEND 05/17] qla2xxx: Remove verbose messages in target mode.

From: Arun Easi Turning logging bits for target mode ON dumps quite a lot verbose messages, remove those and change some of the IO path logging to use IO bits. Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 154 -

[PATCH RESEND 03/17] qla2xxx: Use correct offset to req-q-out for reserve calculation

From: Arun Easi Cc: Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 43f9177..2fe6da3 100644 ---

[PATCH RESEND 0/2] target: target bug fix and enchancement.

Hi Nicholas/Christoph, Please apply the following patches at your earliest convenience. Thanks, ~Saurav Quinn Tran (1): Target/transport: SCSI Status Respond being sent to Initiator twice. Saurav Kashyap (1): target: Implement report lun data change unit attention. drivers/target/target_c

[PATCH RESEND 2/2] target: Implement report lun data change unit attention.

Signed-off-by: Saurav Kashyap Signed-off-by: Giridhar Malavali --- drivers/target/target_core_fabric_configfs.c | 28 ++ 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_con

[PATCH RESEND 1/2] Target/transport: SCSI Status Respond being sent to Initiator twice.

From: Quinn Tran During temporary resource starvation at lower transport layer, command is placed on queue full retry path, which expose this problem. The TCM Qfull handling send the same cmd twice to lower layer. The 1st time led to cmd normal free path. The 2nd time cause Null pointer access

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

Review ping again? While I think the shutdown code in scsi_debug needs a bit more of an overhault I'd really like to include the fix at least for 3.18 and 3.17-stable now that we have missed the 3.17 window. On Sun, Aug 31, 2014 at 07:09:59PM -0400, Douglas Gilbert wrote: > A deadlock has been re

Re: [PATCH] hpsa: add missing pci_set_master in kdump path

Tomas, can you also give me a signed-off-by for this one? On Fri, Sep 12, 2014 at 02:44:15PM +0200, Tomas Henzl wrote: > Add a call to pci_set_master(...) missing in the previous > patch "hpsa: refine the pci enable/disable handling". > Found thanks to Rob Elliot. > --- > drivers/scsi/hpsa.c | 2

[PATCH/RESEND V6 00/18] UFS: Power management support

This patch seies introduces support for power management in the driver as well as vendor specific initialization - registers, clocks, voltage regulators etc. It includes also a rework for the init sequence and other PM pre-requisite such as write protection support, handling well-known LUN, erro

[PATCH V6 01/18] scsi: fixing the "type" for well known LUs

From: Subhash Jadavani Some devices may respond with wrong type for well-known logical units. This patch forces well-known type for devices which doesn't report it correct. Signed-off-by: Subhash Jadavani Signed-off-by: Sujit Reddy Thumma Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/

[PATCH V6 02/18] scsi: sysfs: don't add scsi_device if its already added

From: Subhash Jadavani If LLD has added scsi device (by calling scsi_add_device) before scheduling async scsi_scan_host then scsi_finish_async_scan() will end up calling scsi_sysfs_add_sdev for scsi device which was already added by LLD. This patch fixes this issue by skipping the call to scsi_sy

[PATCH/RESEND V6 04/18] scsi: ufs: Add regulator enable support

From: Sujit Reddy Thumma UFS devices are powered by at most three external power supplies - - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V - VCCQ - The controller and I/O power supply, 1.1V to 1.3V - VCCQ2 - Secondary controller and/or I/O power supply, 1.65V to 1.95V

[PATCH/RESEND V6 06/18] scsi: ufs: add voting support for host controller power

From: Raviv Shvili Add the support for voting of the regulator powering the host controller logic. Signed-off-by: Raviv Shvili Signed-off-by: Subhash Jadavani Signed-off-by: Dolev Raviv diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/

[PATCH/RESEND V6 07/18] scsi: ufs: refactor query descriptor API support

From: Subhash Jadavani Currently reading query descriptor is more tightened to each descriptor type. This patch generalize the approach and allows reading any parameter from any query descriptor. Signed-off-by: Subhash Jadavani Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufs.h b/

[PATCH/RESEND V6 05/18] scsi: ufs: Add clock initialization support

From: Sujit Reddy Thumma Add generic clock initialization support for UFSHCD platform driver. The clock info is read from device tree using standard clock bindings. A generic max-clock-frequency-hz property is defined to save information on maximum operating clock frequency the h/w supports. Sig

[PATCH/RESEND V6 03/18] scsi: ufs: Allow vendor specific initialization

From: Sujit Reddy Thumma Some vendor specific controller versions might need to configure vendor specific - registers, clocks, voltage regulators etc. to initialize the host controller UTP layer and Uni-Pro stack. Provide some common initialization operations that can be used to configure vendor

[PATCH/RESEND V6 14/18] scsi: ufs: Add support for clock gating

From: Sahitya Tummala The UFS controller clocks can be gated after certain period of inactivity, which is typically less than runtime suspend timeout. In addition to clocks the link will also be put into Hibern8 mode to save more power. The clock gating can be turned on by enabling the capabilit

[PATCH/RESEND V6 13/18] scsi: ufs: refactor configuring power mode

Sometimes, the device shall report its maximum power and speed capabilities, but we might not wish to configure it to use those maximum capabilities. This change adds support for the vendor specific host driver to implement power change notify callback. To enable configuring different power modes

[PATCH/RESEND V6 18/18] scsi: ufs: definitions for phy interface

- Adding some of the definitions missing in unipro.h, including power enumeration. - Read Modify Write Line helper function - Indication for the type of suspend Signed-off-by: Dolev Raviv Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi diff --git a/drivers/scsi/ufs/ufshcd.c b/driv

  1   2   >