Re: [PATCH 1/2] scsi_scan: Send TEST UNIT READY to the LUN before scanning

2014-09-14 Thread Hannes Reinecke
On 09/07/2014 06:24 PM, Christoph Hellwig wrote: Looks like you put a version into the SuSE tree with a blacklist entry just for the Fujitsu array that requires the TEST UNIT READY. Can you send that version upstream as well? I've just had reports that this is required, as it interferes with N

Re: [PATCH v2 10/24] uas: zap_pending: data urbs should have completed at this time

2014-09-14 Thread Hans de Goede
Hi, On 09/13/2014 09:31 PM, Sergei Shtylyov wrote: > Hello. > > On 9/13/2014 1:26 PM, Hans de Goede wrote: > >> The data urbs are all killed before calling zap_pending, and their completion >> handler should have cleared their inflight flag. > >> Do not 0 the data inflight flags, and add a chec

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-14 Thread Tejun Heo
Hello, On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote: > We can maintain same piece (IS_ERR(ctx->csr_mux)), then we can do the > below instead of NULL ?? > > ctx->csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL); Setting it to NULL on failure would probably mak

Re: [PATCH fix for 3.17 v2] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-14 Thread Hans de Goede
Hi, On 09/13/2014 10:27 PM, Sergei Shtylyov wrote: > Hello. > > On 9/13/2014 10:21 PM, Thomas Backlund wrote: > >>> And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one >>> seems to hang upon receiving an ATA_12 or ATA_16 command. > >>> https://bugzilla.kernel.org/show_bug

Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

2014-09-14 Thread Hans de Goede
Hi, On 09/13/2014 07:50 PM, Christoph Hellwig wrote: > On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote: >> Yes this one does the trick and fixes things. Note the git tree I used for >> testing also had your previous fix to split up the blk_tcq union in 2 >> separate struct members. L

[PATCH fix for 3.17 v3] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-14 Thread Hans de Goede
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command. https://bugzilla.kernel.org/show_bug.cgi?id=79511 While at it also add missing documentation for the u value for usb-storage quirks. Cc: sta...@vger.kernel.org # 3

Re: [PATCH v2 10/24] uas: zap_pending: data urbs should have completed at this time

2014-09-14 Thread James Bottomley
On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote: > Hi, > > On 09/13/2014 09:31 PM, Sergei Shtylyov wrote: > > Hello. > > > > On 9/13/2014 1:26 PM, Hans de Goede wrote: > > > >> The data urbs are all killed before calling zap_pending, and their > >> completion > >> handler should have cle

Re: [PATCH v2 10/24] uas: zap_pending: data urbs should have completed at this time

2014-09-14 Thread Hans de Goede
Hi, On 09/14/2014 12:29 PM, James Bottomley wrote: > On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote: >> Hi, >> >> On 09/13/2014 09:31 PM, Sergei Shtylyov wrote: >>> Hello. >>> >>> On 9/13/2014 1:26 PM, Hans de Goede wrote: >>> The data urbs are all killed before calling zap_pending, a

Re: [PATCH v2 10/24] uas: zap_pending: data urbs should have completed at this time

2014-09-14 Thread James Bottomley
On Sun, 2014-09-14 at 12:32 +0200, Hans de Goede wrote: > Hi, > > On 09/14/2014 12:29 PM, James Bottomley wrote: > > On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 09/13/2014 09:31 PM, Sergei Shtylyov wrote: > >>> Hello. > >>> > >>> On 9/13/2014 1:26 PM, Hans de Goed

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-14 Thread Hannes Reinecke
On 09/13/2014 03:07 AM, Elliott, Robert (Server Storage) wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, 05 September, 2014 7:33 PM Subject: Re: [PATCH 20/20] scsi_error: format abort

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-14 Thread Christoph Hellwig
On Sat, Sep 13, 2014 at 01:07:11AM +, Elliott, Robert (Server Storage) wrote: > > I've not seen an answer to my question in reply to the previous version > > of this. Why would you do pretty printing of a variable that can just > > return SUCCESS or FAILURE? > > Is there anything prohibiting

[PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
I have revamped the code so it becomes both more effective and far more clear. Signed-off-by: Rickard Strandqvist --- drivers/scsi/scsi_devinfo.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scs

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Rickard Strandqvist ... > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c ... > static void scsi_strcpy_devinfo(char *name, char *to, size_t to_l

[PATCH] scsi: qla2xxx: qla_gs.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist --- drivers/scsi/qla2xxx/qla_gs.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/

[PATCH] scsi: qla2xxx: qla_mr.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist --- drivers/scsi/qla2xxx/qla_mr.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index

Re: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
2014-09-14 23:34 GMT+02:00 Elliott, Robert (Server Storage) : > > >> -Original Message- >> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >> ow...@vger.kernel.org] On Behalf Of Rickard Strandqvist > ... >> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c >

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] > How do you mean? > > strncpy zeroes throughout the remainder of the string "from" until the > length off to_length, or otherwise guaranteed trailing zero characters > and a warning is print

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: > On 09/12/2014 09:29 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is to modify previous patch 13/17 and it is relative to > > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr > > >

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: > On 09/12/2014 10:22 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is to modify previous patch 16/17 and it is relative to > > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr > > >

[PATCH] xen: make pvscsi frontend dependant on xenbus frontend

2014-09-14 Thread Juergen Gross
The pvscsi frontend driver requires the xenbus frontend driver. Reflect this in Kconfig. Signed-off-by: Juergen Gross --- drivers/scsi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 9130df1..ff62dc1 100644 --- a/drivers/scsi/Kconfig

Re: [PATCH 2/6] blk-mq: call blk_mq_start_request from ->queue_rq

2014-09-14 Thread Ming Lei
On Sun, Sep 14, 2014 at 7:40 AM, Christoph Hellwig wrote: > When we call blk_mq_start_request from the core blk-mq code before calling > into > ->queue_rq there is a racy window where the timeout handler can hit before > we've > fully set up the driver specific part of the command. It is quite