Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-06 Thread Hannes Reinecke
On 09/06/2014 01:42 AM, Tejun Heo wrote: Hello, Hannes. Sorry about the delay. On Wed, Jul 30, 2014 at 09:55:08AM +0200, Hannes Reinecke wrote: ata_dev_classify() just uses the 'lbah' and 'lbam' fields from the taskfile, so we can as well use those as arguments and rip out the custom code from

Re: [PATCH 1/4] libata: consolidate ata_dev_classify()

2014-09-06 Thread Tejun Heo
Hello, On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote: > Well, yes, in principle. I was looking into that, too. > But then I figured that moving to ata_taskfile would be a major overhaul for > libsas, which would be quite beyond scope here. > And all for a puny little patch. Hmm?

[PATCH 00/11] megaraid_sas : Description Patch

2014-09-06 Thread Sumit.Saxena
MegaRaid driver changes. Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- [PATCH 00/11] megaraid_sas : Description Patch [PATCH 01/11] megaraid_sas : Do not scan non syspd drives. [PATCH 02/11] megaraid_sas : Use writeq for 6

[PATCH 02/11] megaraid_sas : Use writeq for 64bit pci write to avoid spinlock overhead

2014-09-06 Thread Sumit.Saxena
Use writeq() for 64bit PCI write instead of writel() to avoid additional lock overhead. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion

[PATCH 10/11] megaraid_sas : MFI MPT linked list corruption fix

2014-09-06 Thread Sumit.Saxena
Problem statement: MFI link list in megaraid_sas driver is used from mfi-mpt pass-through commands. This list can be corrupted due to many possible race conditions in driver and eventually we may see kernel panic. One example - MFI frame is freed from calling process as driver send command vi

[PATCH 08/11] megaraid_sas : Add module parameter to disable IRQ-CPU affinity hint

2014-09-06 Thread Sumit.Saxena
For certain deployment, we may need to disable irq cpu affinity hint. This module parameter provides option for use to disable irq cpu affinity hint and allow irqbalancer to handle the rest. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 04/11] megaraid_sas : Firmware crash dump feature support

2014-09-06 Thread Sumit.Saxena
This feature will provide similar interface as kernel crash dump feature. When megaraid firmware encounter any crash, driver will collect the firmware raw image and dump it into pre-configured location. Driver will allocate two different segment of memory. #1 Non-DMA able large buffer (will be

[PATCH 06/11] megaraid_sas : Host lock less mode to enabled asynchronous IO submission

2014-09-06 Thread Sumit.Saxena
Megaraid_sas driver can now work in host lock less mode. Remove host lock less as megaraid_sas driver will have safer access to raid map as described in earlier patch. We now keep Driver Raid map copy, which will make sure that driver will always have old or new map Driver raid map will be repl

[PATCH 11/11] megaraid_sas : Driver version update

2014-09-06 Thread Sumit.Saxena
Driver version upgrade patch. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h | 6 +++--- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH 05/11] megaraid_sas : Extended VD support

2014-09-06 Thread Sumit.Saxena
Current MegaRAID firmware and hence the driver only supported 64VDs. E.g: If the user wants to create more than 64VD on a controller, it is not possible on current firmware/driver. New feature and requirement to support upto 256VD, firmware/driver/apps need changes. In addition to that ther

[PATCH 03/11] megaraid_sas : Update threshold based reply post host index register

2014-09-06 Thread Sumit.Saxena
Current driver updates reply post host index to let firmware know that replies are processed, while returning from ISR function, only if there is no oustanding replies in reply queue. Driver will free the request frame immediately from ISR but reply post host index is not yet updated. It means

[PATCH 07/11] megaraid_sas : Round down max sge supported by controller to power of two

2014-09-06 Thread Sumit.Saxena
Round down the max sge to power of two. Earlier max sge limit is 70 SGE, which will allow block layer to send 280K IO frame. It is optimal to provide max IO size aligned to the smallest possible stripe size. E.a Consider that we have configured RAID Volumes which does not allow Fast Path acro

[PATCH 09/11] megaraid_sas : N-drive primary raid level 1 load balancing

2014-09-06 Thread Sumit.Saxena
Current driver does fast path read load balancing between arm and mirror disk for two Drive Raid-1 configuration only. Now, Driver support fast path read load balancing for all (any number of disk) Raid-1 configuration. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/sc

[PATCH 01/11] megaraid_sas : Do not scan non syspd drives

2014-09-06 Thread Sumit.Saxena
Current driver allow device scan for all the devices on channel 0 and 1. E.a If we have two single drive raid volumes, we may see prints like below. First two prints are for physical device which are used to form VD. Prints like this creates confusion as it is really not required to scan any hidde

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-09-06 Thread Douglas Gilbert
On 14-09-05 11:25 AM, Bart Van Assche wrote: On 09/05/14 15:56, Douglas Gilbert wrote: With scsi-mq I think many LLDs probably have a new race possibility between a surprise rmmod of the LLD and another thread presenting a new command at about the same time (or another thread's command completin

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-09-06 Thread Christoph Hellwig
On Sat, Sep 06, 2014 at 10:40:06AM -0400, Douglas Gilbert wrote: > And they do call scsi_remove_host(). But they do that toward > the end of their clean-up. The problem that I observed has > already happened before that. > > IOW I think the QUEUE_FLAG_DYING state needs to be set and > acknowledged

[PATCH] block: remove artifical max_hw_sectors cap

2014-09-06 Thread Christoph Hellwig
Set max_sectors to the value the drivers provides as hardware limit by default. Linux had proper I/O throttling for a long time and doesn't rely on a artifically small maximum I/O size anymore. By not limiting the I/O size by default we remove an annoying tuning step required for most Linux insta

RE: [PATCH V2] hpsa: refine the pci enable/disable handling

2014-09-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Tomas Henzl ... > + /* kdump kernel is loading, we don't know in which state is > + * the pci interface. The dev->enable_cnt is equal zero > + * so we cal