[PATCH v3 8/17] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-08-19 Thread Ching Huang
From: Ching Huang Remove calling arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:39:06.0 +0800 +++ b/drivers/scsi/arcmsr/

[PATCH v3 9/17] arcmsr: modify printing adapter model number and F/W messages

2014-08-19 Thread Ching Huang
From: Ching Huang Adjust printing order of adapter model name and firmware version. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:39:48.0 +0800 +++ b/drivers/scsi/arc

[PATCH v3 10/17] arcmsr: clear outbound doorbell buffer completely

2014-08-19 Thread Ching Huang
From: Ching Huang Clear outbound doorbell buffer completely for adapter type C. This is to prevent getting bad data input from IOP before ioctl command beginning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi

[PATCH v3 11/17] arcmsr: rename function and variable

2014-08-19 Thread Ching Huang
From: Ching Huang Rename some variable and function name for readability and consistency. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:27:14.0 +0800 +++ b/drivers/scsi/arcms

[PATCH v3 12/17] arcmsr: revise allocation of second dma_coherent_handle for type B

2014-08-19 Thread Ching Huang
From: Ching Huang This modification is for consistency with upcoming adapter type D. Both adapter type B and D have similar H/W and S/W structure. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 201

[PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-19 Thread Ching Huang
From: Ching Huang Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr

[PATCH v3 14/17] arcmsr: fix sparse warning and error

2014-08-19 Thread Ching Huang
From: Ching Huang Fix sparse utility checking error and warning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:40:48.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2

[PATCH v3 15/17] arcmsr: modify some character string

2014-08-19 Thread Ching Huang
From: Ching Huang Revise comment and some character strings. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:41:02.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-

[PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-19 Thread Ching Huang
From: Ching Huang Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29:54.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.

[PATCH v3 17/17] arcmsr: modify calling scsi_scan_host after all initialization done

2014-08-19 Thread Ching Huang
From: Ching Huang Modify calling scsi_scan_host until all initialization done. And fix error path of free allocation resource. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:3

Re: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-19 Thread gre...@linuxfoundation.org
On Tue, Aug 19, 2014 at 06:33:04AM +, Sharma, Sanjeev wrote: > Hi Greg, > > Any feedback on this patch ? The merge window ended 2 days ago, _and_ I'm at the kernel summit this week, _and_ my queue is currently sitting at: $ mdfrm -c ~/mail/todo/ 1317 messages in /home/gregkh/m

RE: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-19 Thread Sharma, Sanjeev
Thanks for letting me know. Sanjeev Sharma -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tuesday, August 19, 2014 3:01 PM To: Sharma, Sanjeev Cc: kra...@redhat.com; mdharm-...@one-eyed-alien.net; linux-...@vger.kernel.org; linux-ker...@vge

Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Meelis Roos
3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection might be nontrivial, because of sparc64 changes that are OK on 3.17-rc1 again - but

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread James Bottomley
On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc > 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection > might be nontrivial, b

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Meelis Roos
> > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc > > 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection > > might be nontrivial, because of sparc64 changes that are OK on 3.17-

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Meelis Roos
> On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc > > 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection > > might be non

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread James Bottomley
On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote: > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > > > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc > > > 53c1010 and all behave the s

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-19 Thread Christoph Hellwig
Hi Ching, I've fixed up various checkpatch errors and fixed up some descriptions and applied the patches to a branch. This includes patch 4, so please send a fix for this and any other patches relative to the branch. Please find the branch at git://git.infradead.org/users/hch/scsi-queue

Re: [PATCH v7 2/3] ahci_xgene: Skip the PHY and clock initialization if already configured by the firmware.

2014-08-19 Thread Tejun Heo
On Tue, Aug 19, 2014 at 12:01:50PM +0530, Suman Tripathi wrote: > This patch implements the feature to skip the PHY and clock > initialization if it is already configured by the firmware. > > Signed-off-by: Loc Ho > Signed-off-by: Suman Tripathi ... > +static int xgene_ahci_is_memram_inited(stru

Question about scsi error handling and LLD

2014-08-19 Thread scameron
Is it permitted for a LLD to call scsi_done() for a command which has been or is attempting to be aborted via the LLD abort error handler function? I am looking at the scsi mid layer code, and I'm a bit confused. There seem to be a few ways the LLD abort handler function can get called. One pa

Re: [PATCH v7 3/3] ahci_xgene: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-08-19 Thread Tejun Heo
On Tue, Aug 19, 2014 at 12:01:51PM +0530, Suman Tripathi wrote: > The link down issue in first attempt happens due to 2 H/W errata below: > > 1. Due to HW errata, during speed negotiation, sometimes controller > is not able to detect ALIGN at GEN3(6Gbps) within 54.6us results in > a timeout. This

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
On Tue, Aug 19, 2014 at 3:51 AM, Kashyap Desai wrote: > > > -Original Message- > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > > Sent: Friday, July 18, 2014 3:43 PM > > To: James Bottomley; linux-scsi@vger.kernel.or

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Christoph Hellwig
On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: > I read this comment and find that very few drivers are using this > cmd_list. I think if we remove this cmd_list, performance will scale as I > am seeing major contention in this lock. > Just thought to ping you to see if this is kn

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
On Tue, Aug 19, 2014 at 9:36 PM, Christoph Hellwig wrote: > On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: >> I read this comment and find that very few drivers are using this >> cmd_list. I think if we remove this cmd_list, performance will scale as I >> am seeing major contenti

Re: [PATCH] drivers: message: fusion: Simplify rounding

2014-08-19 Thread Christoph Hellwig
On Tue, Jul 01, 2014 at 02:56:20PM +0200, Rasmus Villemoes wrote: > Rounding up to a multiple of 4 should be done using the ALIGN > macro. As a bonus, this also makes the generated code smaller. > > In GetIocFacts(), sz is assigned to a few lines below without being > read in the meantime, so it i

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-19 Thread Christoph Hellwig
Can I get a review for this one, please? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 00/13] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-19 Thread Christoph Hellwig
Thanks, I've applied patches 1 to 7 to the drivers-for-3.18 branch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Question about scsi error handling and LLD

2014-08-19 Thread James Bottomley
On Tue, 2014-08-19 at 10:30 -0500, scame...@beardog.cce.hp.com wrote: > > Is it permitted for a LLD to call scsi_done() for a command which > has been or is attempting to be aborted via the LLD abort error handler > function? > > I am looking at the scsi mid layer code, and I'm a bit confused. H

Re: [PATCH/RFC V2 07/16] scsi: support well known logical units

2014-08-19 Thread Christoph Hellwig
On Thu, Aug 14, 2014 at 04:30:58PM +0300, Dolev Raviv wrote: > From: Subhash Jadavani > > REPORT LUNS command has "SELECT REPORT" field which controls what type of > logical units to be reported by device server. According to UFS device > standard, if this field is set to 0, REPORT LUNS would rep

Re: [PATCH V2] hpsa: refine the pci enable/disable handling

2014-08-19 Thread Christoph Hellwig
Thanks, applied to the drivers-for-3.18 branch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pm8001: Update nvmd response data to request buffer

2014-08-19 Thread Christoph Hellwig
Thanks, applied to the drivers-for-3.18 branch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/15] scsi: fix decimal printf format specifiers prefixed with 0x

2014-08-19 Thread Christoph Hellwig
Thanks, applied to the drivers-for-3.18 tree. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

2014-08-19 Thread Christoph Hellwig
Thanks, applied the whole series to the drivers-for-3.18 tree. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: fix various kernel-doc problems in scsi_error.c

2014-08-19 Thread Christoph Hellwig
Thanks, I've applied both docbook fixups to the drivers-for-3.18 and also addressed the addition nitpicks from Ewan. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [RFC 09/10] scsi: sd: Avoid sending medium write commands if device is write protected

2014-08-19 Thread Christoph Hellwig
This looks reasonable to me. Martin, and objections? On Mon, Aug 11, 2014 at 03:40:37PM +0300, Dolev Raviv wrote: > From: Sujit Reddy Thumma > > The SYNCHRONIZE_CACHE command is a medium write command and hence can > fail when the device is write protected. Avoid sending such commands by > maki

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-19 Thread Christoph Hellwig
James, can you please send this on ASAP? Sitting for oever a week on a boot regression that comes with a patch isn't reasonable. On Sun, Aug 10, 2014 at 05:54:25AM -0700, Guenter Roeck wrote: > The latest kernel fails to boot qemu arm images when using scsi > for disk access. Boot gets stuck afte

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-19 Thread Christoph Hellwig
On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: > The host asks the guest to scan when a LUN is removed or added. > The only way a guest can identify the removed LUN is when an I/O is > attempted on a removed LUN - the SRB status code indicates that the LUN > is invalid. We curren

Re: [RFC 09/10] scsi: sd: Avoid sending medium write commands if device is write protected

2014-08-19 Thread Venkatesh Srinivas
On Mon, Aug 11, 2014 at 5:40 AM, Dolev Raviv wrote: > From: Sujit Reddy Thumma > > The SYNCHRONIZE_CACHE command is a medium write command and hence can > fail when the device is write protected. Avoid sending such commands by > making sure that write-cache-enable is disabled even though the devi

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-19 Thread Christoph Hellwig
On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: > > On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: > > > > I doubt either of them forces users to hack up flags for these cases. > > > > > > Why was this change needed in the first place? There's no explanation > > > in the

Re: [PATCH 0/3] scsi_debug: review fixes for scsi-mq changes

2014-08-19 Thread Christoph Hellwig
Thanks, I've applied all three patches to the driver-for-3.18 branch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Question about scsi error handling and LLD

2014-08-19 Thread scameron
On Tue, Aug 19, 2014 at 12:16:12PM -0500, James Bottomley wrote: > On Tue, 2014-08-19 at 10:30 -0500, scame...@beardog.cce.hp.com wrote: > > > > Is it permitted for a LLD to call scsi_done() for a command which > > has been or is attempting to be aborted via the LLD abort error handler > > functio

Re: Bad tag value in scsi-mq.4

2014-08-19 Thread h...@infradead.org
On Tue, Aug 05, 2014 at 07:47:12PM +, Handzik, Joe wrote: > Yeah, we thought about that one. We call scsi_activate_tcq if our scsi_device > has tagged_supported set within hpsa_change_queue_type (our > .change_queue_type entry into the scsi_host_template). Also made sure I was > booting with

Re: [PATCH] scsi/arcmsr: Add timeout module parameter

2014-08-19 Thread Christoph Hellwig
On Tue, Aug 05, 2014 at 04:10:08PM +0300, Ari Sundholm wrote: > > On Mon, 4 Aug 2014, Christoph Hellwig wrote: > > > To modify the timeout on a queue please use blk_queue_rq_timeout in > > the slave_configure method instead of poking directly into the block > > timer, which won't work e.g. for th

RE: Bad tag value in scsi-mq.4

2014-08-19 Thread Handzik, Joe
I may take a look again, but was able to get this working on my Rhel7 box (with the kernel boot parameter present). So I either consistently used an earlier version of GRUB incorrectly (possible, maybe when I double checked my boot parameters in the earlier version I somehow reset to defaults?)

[PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention

2014-08-19 Thread Kashyap.Desai
Add enable_cmd_list flag in shost template to indicate scs.mq stack to keep track of cmd_list per sdev. Default behaviour is not to keep track of cmd_list per sdev, as this may introduce lock contention. (overhead is more on multi-node NUMA.) Patch is tested using megaraid_sas driver with "enab

[GIT PULL] SCSI fixes for 3.17-rc1

2014-08-19 Thread James Bottomley
These are the two bug fixes I mentioned in the final merge window pull. One is a reversed logic check in the device busy tests which can cause a nasty hang and another crash seen in the new SCSI pool support if the use count ever goes to zero. The patch is available here: git://git.kernel.org/pub

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Aaro Koskinen
Hi, On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote: > On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote: > > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > > > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > > > > machines. E220R and E420R are

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Sam Ravnborg
On Tue, Aug 19, 2014 at 11:17:48PM +0300, Aaro Koskinen wrote: > Hi, > > On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote: > > On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote: > > > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > > > > 3.16 scsi worked fine, 3.17-rc

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread James Bottomley
On Tue, 2014-08-19 at 23:17 +0300, Aaro Koskinen wrote: > Hi, > > On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote: > > On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote: > > > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > > > > 3.16 scsi worked fine, 3.17-rc1 misbe

Re: Sym2 scsi hang on boot on sparc64

2014-08-19 Thread Aaro Koskinen
Hi, On Tue, Aug 19, 2014 at 03:37:18PM -0500, James Bottomley wrote: > On Tue, 2014-08-19 at 23:17 +0300, Aaro Koskinen wrote: > > Bisection (on PA-RISC) points to: > > > > 71e75c97f97a9645d25fbf3d8e4165a558f18747 is the first bad commit > > commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 > > Aut