Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Takashi Iwai
At Sat, 16 Aug 2014 04:50:07 +0200, Luis R. Rodriguez wrote: > > On Fri, Aug 15, 2014 at 04:39:02PM +0200, Oleg Nesterov wrote: > > On 08/15, Luis R. Rodriguez wrote: > > > > > > On Wed, Aug 13, 2014 at 07:51:01PM +0200, Oleg Nesterov wrote: > > > > On 08/12, Luis R. Rodriguez wrote: > > > > > > >

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Oleg Nesterov
On 08/17, Takashi Iwai wrote: > > How about just increasing/decreasing the module count for blocking the > exit call? For example: > > #define module_long_probe_init(initfn)\ > static int _long_probe_##initfn(void *arg) \ > {

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Oleg Nesterov
On 08/17, Oleg Nesterov wrote: > > On 08/17, Takashi Iwai wrote: > > > > How about just increasing/decreasing the module count for blocking the > > exit call? For example: > > > > #define module_long_probe_init(initfn) \ > > static int _long_probe_##initfn(void *ar

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Oleg Nesterov
Damn, sorry for noise ;) I was going to suggest to introduce module_put_and_exit() to simplify this and potentially other users, but it already exists. So this code can use it too without additional complications. On 08/17, Oleg Nesterov wrote: > On 08/17, Oleg Nesterov wrote: > > > > On 08/17, T

[PATCH RESEND] libiscsi: Don't retry if xmit_task return a non-transient error code

2014-08-17 Thread Sagi Grimberg
Allow transport callback xmit_task to return a non-transient error code -EINVAL to inform us not to retry the task. For any other error code keep the current retry behavior. Signed-off-by: Sagi Grimberg --- drivers/scsi/libiscsi.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deleti

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Luis R. Rodriguez
On Sun, Aug 17, 2014 at 02:55:05PM +0200, Oleg Nesterov wrote: > Damn, sorry for noise ;) > > I was going to suggest to introduce module_put_and_exit() to simplify > this and potentially other users, but it already exists. So this code > can use it too without additional complications. In the las

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-17 Thread Oleg Nesterov
On 08/17, Luis R. Rodriguez wrote: > > In the last iteration that I have stress tested for corner cases I just > get_task_struct() on the init and then put_task_struct() at the exit, is that > fine too or are there reasons to prefer the module stuff? I am fine either way. I like the Takashi's ide

Hi

2014-08-17 Thread laura wintour
Hello good day, please did you recieve the mail i sent to you? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-17 Thread Yoshihiro YUNOMAE
Hi Ewan, Thank you for your review. (2014/08/16 0:05), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: All bytes in CDB should be output after linebuf is filled because "[%s] CDB: %s\n" message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE Cc: H

Re: Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-17 Thread Yoshihiro YUNOMAE
(2014/08/16 0:08), Ewan Milne wrote: On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: Unrecognized sense data should be output after linebuf is filled because "[%s] Unrecognized sense data (in hex): %s" message is output many times in loop. Signed-off-by: Yoshihiro YUNOMAE Cc: Hanne