On 08/06/2014 06:43 AM, Hans Wennborg wrote:
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.
Found by using regex suggested by Joe Perches.
Signed-off-by: Hans Wennborg
---
drivers/scsi/cxgbi/libcxgbi.c | 2 +-
drivers/scsi/nsp32.c
Joe Lawrence writes:
> On Tue, 1 Jul 2014, Rasmus Villemoes wrote:
>
>> Rounding up to a multiple of 4 should be done using the ALIGN
>> macro. As a bonus, this also makes the generated code smaller.
>>
>> In GetIocFacts(), sz is assigned to a few lines below without being
>> read in the meantim
From: Julia Lawall
Delete NULL test on array (always false).
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r@
type T;
T [] e;
position p;
@@
e ==@p NULL
@ disable fld_to_ptr@
expression e;
identifier f;
position r.p;
@@
* e.
Delete NULL test on array. The complete semantic patch that finds this
problem is as follows: (http://coccinelle.lip6.fr/)
//
@r@
type T;
T [] e;
position p;
@@
(
e ==@p NULL
|
e !=@p NULL
|
!@p e
)
@ disable fld_to_ptr@
expression e;
identifier f;
position r.p;
@@
(
* (e.f) ==@p NULL
|
*
Hi, Dan & James
How about the patches about support for PM?
Two months had passed since I submitted the patches.
Thanks!
-Original Message-
From: Dan Williams [mailto:dan.j.willi...@intel.com]
Sent: 2014年6月4日 0:05
To: Xiangliang Yu
Cc: t...@kernel.org; jbottom...@parallels.com; todd.e.b
On 7/25/2014 11:00 PM, Martin K. Petersen wrote:
For bidirectional commands we need to be able to distinguish between the
in and out scsi_data_buffers when calculating the wire transfer length.
Make scsi_transfer_length() take a scsi_data_buffer argument so the
caller can choose which I/O directi
On 7/27/2014 12:11 PM, Boaz Harrosh wrote:
On 06/25/2014 01:32 PM, Sagi Grimberg wrote:
On 6/25/2014 11:48 AM, Sagi Grimberg wrote:
I made the patch below which should fix both bidi
support in iscsi and also WRITE_SAME (and similar commands) support.
I'm a bit confused, for all commands (
Hi Boaz,
On 7/27/2014 1:08 PM, Boaz Harrosh wrote:
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 26dc005..3f46234 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -338,7 +338,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)
str
On 8/6/2014 3:12 PM, Sagi Grimberg wrote:
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index f2db82beb646..fdea8c1527d4 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -391,7 +391,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct
iscsi_task *task)
if (
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
For commands like REQ_COPY we need a way to pass extra information along
with each bio. Like integrity metadata this information must be
available at the bottom of the stack so bi_private does not suffice.
Rename the existing bi_integrity field to
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
None of the filesystems appear interested in using the integrity tagging
feature. Potentially because very few storage devices actually permit
using the application tag space.
Remove the tagging functions.
Signed-off-by: Martin K. Petersen
Revie
On 08/06/2014 03:43 PM, Sagi Grimberg wrote:
> Hi Boaz,
>
<>
>>
>> I hate that you introduced this new transfer_length variable. It does
>> not exist. In BIDI supporting driver there is out_len and in_len just
>> as original code.
>
> Effectively, out_len and in_len are the same except for the bi
On 14-07-29 05:57 PM, bugzilla-dae...@bugzilla.kernel.org wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=80711
Alan changed:
What|Removed |Added
CC|
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
The protection interval is not necessarily tied to the logical block
size of a block device. Stop using the terms "sector" and "sectors".
Going forward we will use the term "seed" to describe the initial
reference tag value for a given I/O. "Inter
https://bugzilla.kernel.org/show_bug.cgi?id=80711
--- Comment #4 from d gilbert ---
On 14-07-29 05:57 PM, bugzilla-dae...@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=80711
>
> Alan changed:
>
> What|Removed |Added
> ---
On 8/6/2014 4:32 PM, Sagi Grimberg wrote:
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
The protection interval is not necessarily tied to the logical block
size of a block device. Stop using the terms "sector" and "sectors".
Going forward we will use the term "seed" to describe the initial
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
Make the choice of checksum a per-I/O property by introducing a flag
that can be inspected by the SCSI layer. There are several reasons for
this:
1. It allows us to switch choice of checksum without unloading and
reloading the HBA driver.
On 7/25/2014 11:34 PM, Martin K. Petersen wrote:
Now that the protection interval has been detached from the sector size
we need to be able to handle sizes that are different from 4K and
512. Make the interval calculation generic.
Signed-off-by: Martin K. Petersen
---
block/bio-integrity.c |
> "Sagi" == Sagi Grimberg writes:
Sagi> On second thought, since the transfer length is always the command
Sagi> scsi data buffer length, why not keep it as is and if at any point
Sagi> in the future DIF will co-exist with bidi, we can add
Sagi> scsi_bidi_transfer_length which will calculate
> "Sagi" == Sagi Grimberg writes:
>> BTW: When reading DIFF devices, don't you have extra bits to read as
>> well? How does the DIFF read works? Please get me up to speed. I'm
>> not familiar with this protocol? (I'd imagine that if say an app
>> reads X bytes with DIFF info, it wants to re
On 08/05/2014 06:41 PM, Sreekanth Reddy wrote:
> Hi Tomas,
>
> Can you please review this updated patch,
Hi Sreekanth,
the patch is mangled so a resend is needed anyway and I think you will
probably also want implement the changes you were asked for in the
mpt2sas sibling of this patch.
Thanks, To
On Wed, Aug 6, 2014 at 3:50 AM, Xiangliang Yu wrote:
> Hi, Dan & James
> How about the patches about support for PM?
> Two months had passed since I submitted the patches.
> Thanks!
>
Did you address my review comments?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
This patch set consists of the usual driver updates (ufs, storvsc,
pm8001 hpsa). It also has removal of the user space target driver code
(everyone is using LIO now), a partial PCI MSI-X update, more
multi-queue updates, conversion to 64 bit LUNs (so we could
theoretically cope with any LUN return
On Tue, Aug 05, 2014 at 05:02:46PM -0400, Chad Dupuis wrote:
>
>
> On Tue, 5 Aug 2014, Venkatesh Srinivas wrote:
>
>> On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis wrote:
>>> Set this to 1 for now as we've observed crashes when this is set to the
>>> default
>>> value of 0.
>>
>> What sorts of cra
On Wed, Aug 06, 2014 at 03:29:47PM +0200, Douglas Gilbert wrote:
> If not and since I'm told black lists and the like won't
> work, my advice for the record is to use FreeBSD or Windows
> for tools that need this capability.
I doubt either of them forces users to hack up flags for these cases.
At
On Wed, 6 Aug 2014, Christoph Hellwig wrote:
On Tue, Aug 05, 2014 at 05:02:46PM -0400, Chad Dupuis wrote:
On Tue, 5 Aug 2014, Venkatesh Srinivas wrote:
On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis wrote:
Set this to 1 for now as we've observed crashes when this is set to the default
val
On Wed, 6 Aug 2014, Christoph Hellwig wrote:
> On Wed, Aug 06, 2014 at 03:29:47PM +0200, Douglas Gilbert wrote:
> > If not and since I'm told black lists and the like won't
> > work, my advice for the record is to use FreeBSD or Windows
> > for tools that need this capability.
>
> I doubt either
https://bugzilla.kernel.org/show_bug.cgi?id=80711
--- Comment #5 from Alan Stern ---
On Wed, 6 Aug 2014, Christoph Hellwig wrote:
> On Wed, Aug 06, 2014 at 03:29:47PM +0200, Douglas Gilbert wrote:
> > If not and since I'm told black lists and the like won't
> > work, my advice for the record is
Please don't remove names from the CC: list; use Reply-To-All. I had
to go back and add all the names back in.
On Wed, 6 Aug 2014, Tiziano Bacocco wrote:
> Test with alcor based USB flash drives, linux 3.16 will remove the 3 msb of
> the CDB byte when using SG raw
Sure, but isn't that what you
https://bugzilla.kernel.org/show_bug.cgi?id=80711
--- Comment #6 from Alan Stern ---
Please don't remove names from the CC: list; use Reply-To-All. I had
to go back and add all the names back in.
On Wed, 6 Aug 2014, Tiziano Bacocco wrote:
> Test with alcor based USB flash drives, linux 3.16 w
https://bugzilla.kernel.org/show_bug.cgi?id=80711
--- Comment #7 from Tiziano Bacocco ---
Not when issuing vendor specific commands , even if the flash drive has only 1
LUN , there's the need of using these bits with LUN numbers higher than the
reported number of LUNs
--
You are receiving this
Signed-off-by: Anish Bhatt
Signed-off by: Manoj Malvia
Signed-off by: Karen Xie
---
drivers/scsi/libiscsi.c | 61 +++--
drivers/scsi/libiscsi_tcp.c | 296
include/scsi/libiscsi.h | 6 +
include/scsi/libiscsi_tcp.h | 22
4 files c
The following patch adds T10 DIF support to libiscsi. I didn't see any merge
window messages on linux-scsi, I hope I'm not sending this out of sync.
-Anish
Anish Bhatt (1):
libiscsi : Add T10 Data Integrity Feature support
drivers/scsi/libiscsi.c | 61 +++--
drivers/scsi/libiscsi_tcp.
Hi, Dan
I haven't receive your review comments, could you send it to me again, thanks!
PS: I can't login my gmail, so please send mail to this count.
-Original Message-
From: Dan Williams [mailto:dan.j.willi...@intel.com]
Sent: 2014年8月7日 1:22
To: Xiangliang Yu
Cc: jbottom...@parallels.co
On 08/06/2014 05:37 PM, Anish Bhatt wrote
> @@ -436,12 +473,12 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task
> *task)
> /* No unsolicit Data-Out's */
> hdr->flags |= ISCSI_FLAG_CMD_FINAL;
> } else {
> + unsigned in_len = iscs
This patch was made over scsi-devel/master, I'll rebase it to Christoph's tree
-Anish
From: Mike Christie [micha...@cs.wisc.edu]
Sent: Wednesday, August 06, 2014 7:25 PM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; h...@infradead.org; jbottom...@parallels
On xtensa arch there is this warning
drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by
default]
arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the
previous definition
I can remove WSR since it is not being used but more documentation purpo
Can I get another review for this one so I can queue it up for 3.17?
(or v4 if you have a strong preference for it..)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote:
> > I doubt either of them forces users to hack up flags for these cases.
>
> Why was this change needed in the first place? There's no explanation
> in the patch itself.
Which chance? The one to not support SG_FLAG_LUN_INHIBIT?
>
>
On Wed, Aug 06, 2014 at 04:01:12PM -0400, Chad Dupuis wrote:
> This was on RHEL 7. Should we retry the test case with the latest
> mainline?
Yes. Please always test your patches against latest mainline. If that is
for some reason not possible please at least very prominently mention that
the i
Thanks Doug,
all the patches look good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
41 matches
Mail list logo
