[PATCH 0/3] Enable discard on Hyper-V

2014-07-24 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > > I'm not sure this alone will work - won't sdev_bflags/bflags have > > > already been built

Re: megasas: failed to get PD list

2014-07-24 Thread Peter Andersson
So, I'm replying to my own question here. In case someone else experiences the same problems as I did. After I finally got in contact with LSI support it turns out that the 9240 cards don't support newer motherboards. (I'm not sure what the definition of "newer" is in this case.) Apparently th

[PATCH 1/3] [SCSI] Add quirk for forcing logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
Despite supporting modern SCSI features (such an UNMAP) some storage devices continue to claim conformance to an older version of the SPC spec for compatibility with legacy operating systems. Linux by default will not attempt to read VPD pages on devices that claim SPC-2 or older. Introduce a bla

[PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
Microsoft Hyper-V targets currently only claim SPC-2 compliance / no compliance indicated even though they implement post SPC-2 features which means those features are not tested for. Add a blacklist flag to Hyper-V devices that forces said testing. See https://lkml.org/lkml/2014/7/21/627 for the

[PATCH 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
Some block devices (such as Hyper-V passthrough SSDs) support logical block provisioning (e.g. via UNMAP) but don't set lbpme thus disabling discard. If the try_lbp quirk is in use skip lbpme checks that lead up to the logical block provisioning tests. Signed-off-by: Sitsofe Wheeler --- drivers/

[PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
v1 -> v2: Fix incorrectly named variable. Some block devices (such as Hyper-V passthrough SSDs) support logical block provisioning (e.g. via UNMAP) but don't set lbpme thus disabling discard. If the try_lbp quirk is in use skip lbpme checks that lead up to the logical block provisioning tests. Si

Re: mpt2sas and mpt3sas merge (again)

2014-07-24 Thread Sreekanth Reddy
Hi Martin, megaraid driver was a single driver for both SAS2 and SAS3 controller because from day1 it was planned and developed that way. But it also certain cons -Sometimes, there may be different settings needs to be done for IO for different type of controllers. In IO path, adding PNP id based

Re: [PATCH 0/3] Enable discard on Hyper-V

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 08:47:39AM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > > > I'm not sure this

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> Fix incorrectly named variable. Some block devices (such as Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning Sitsofe> (e.g. via UNMAP) but don't set lbpme thus disabling discard. The fix for an SSD that is known to suppor

[Bug 79901] Extremely slow boot on Promise VTrak E610f due to sd_mod RSOC usage

2014-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=79901 --- Comment #1 from Janusz Dziemidowicz --- Created attachment 144101 --> https://bugzilla.kernel.org/attachment.cgi?id=144101&action=edit Patch adding BLIST_NO_RSOC scsi scan flag As discussed on the list, attached simple patch that blacklist

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

2014-07-24 Thread James Bottomley
On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > compliance indicated even though they implement post SPC-2 features > which means those features are not tested for. Add a blacklist flag to > Hyper-V devices that forc

Re: [Bug 79901] Extremely slow boot on Promise VTrak E610f due to sd_mod RSOC usage

2014-07-24 Thread Christoph Hellwig
Thanks, this one looks good to me. Can someone else give me a second review on the attached patch so I can merged it? --- >From 95bc83fa0d6e9a6152cd6fce79ff87c0994e83ed Mon Sep 17 00:00:00 2001 From: Janusz Dziemidowicz Date: Thu, 24 Jul 2014 15:48:46 +0200 Subject: [PATCH] Do not issue SCSI RSO

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Christoph Hellwig
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > I'm very much against short-circuiting the LBP logic in a passthrough > driver because then we might end up in the exact situation we were > trying to avoid with this patch series. Namely sending down commands > unsupported by th

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Christoph Hellwig
On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > I agree - I'd like to pull in KY's simple fix as soon as I get a second > review for it. Ok, looks like I just got that from Hannes. Let's see if there's more to be done for the pass through case, but I'd rather wait for the nex

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Fix incorrectly named variable. Some block devices (such as > Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning > Sitsofe> (e.g. via UNMAP) but don't

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> So we can see it is really a SATA device that announces discard Sitsofe> correctly and supports discard through WRITE_SAME(16). No, that's the SATA device that announces support for DSM TRIM, and as a result the Linux SATL reports support for W

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 08:35:13AM -0700, Christoph Hellwig wrote: > On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > > I agree - I'd like to pull in KY's simple fix as soon as I get a second > > review for it. > > Ok, looks like I just got that from Hannes. Let's see if there

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 02:09:11PM +, James Bottomley wrote: > On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > > compliance indicated even though they implement post SPC-2 features > > which means those feature

[PATCH -next] scsi: fix u14-34f printk format warnings

2014-07-24 Thread Randy Dunlap
Cc: "James E.J. Bottomley" Cc: Christoph Hellwig --- drivers/scsi/u14-34f.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-next-20140724/drivers/scsi/u14-34f.c === --- linux-next-20140724.ori