Re: [PATCH V2] scsi_lib: removes ambiguous "Unhandled error code" messages.

2014-07-08 Thread Maurizio Lombardi
On 07/03/2014 10:41 AM, Christoph Hellwig wrote: > On Wed, Jun 25, 2014 at 08:38:47PM +, Elliott, Robert (Server Storage) > wrote: >> Since the ACTION_FAIL case always prints the sense key >> and additional sense code: > >> perhaps the description string should be removed altogether? > >

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Christoph Hellwig
On Mon, Jul 07, 2014 at 02:42:40PM +0200, Hans de Goede wrote: > > I can't see any sensible way to "fix" the issue. Struct gendisk keeps a > > reference to the requeue_queue, and a struct gendisk reference is held > > as long as the block device is open. So whenever you surprise remove a > > devi

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
On 2014-07-08 11:53, Christoph Hellwig wrote: On Mon, Jul 07, 2014 at 02:42:40PM +0200, Hans de Goede wrote: I can't see any sensible way to "fix" the issue. Struct gendisk keeps a reference to the requeue_queue, and a struct gendisk reference is held as long as the block device is open. So wh

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: > >I've posted the patch in reply to another report and added Jens to the > >Cc list. As the block maintainer he need to review and merge it. > > Which patch is this? This one: --- From: Christoph Hellwig Subject: block: don't assume

RE: [PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-08 Thread Dolev Raviv
> Did you plan to change the arguments to ufshcd_is_device_present in a later > patch? I guess I overlooked it, thanks for bringing it to my attention. I will resend the series without this patch. Thanks, Dolev -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Cod

Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-08 Thread 'Christoph Hellwig'
On Tue, Jul 08, 2014 at 01:18:27PM +0300, Dolev Raviv wrote: > > Did you plan to change the arguments to ufshcd_is_device_present in a later > > patch? > I guess I overlooked it, thanks for bringing it to my attention. > I will resend the series without this patch. If the series works just fine w

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
On 2014-07-08 11:56, Christoph Hellwig wrote: On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another report and added Jens to the Cc list. As the block maintainer he need to review and merge it. Which patch is this? This one: --- From: Christo

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Hans de Goede
Hi, On 07/08/2014 12:35 PM, Jens Axboe wrote: > On 2014-07-08 11:56, Christoph Hellwig wrote: >> On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another report and added Jens to the Cc list. As the block maintainer he need to review and merg

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
On 2014-07-08 13:25, Hans de Goede wrote: Hi, On 07/08/2014 12:35 PM, Jens Axboe wrote: On 2014-07-08 11:56, Christoph Hellwig wrote: On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another report and added Jens to the Cc list. As the block maint

[ANNOUNCE] scsi patch queue tree updated

2014-07-08 Thread Christoph Hellwig
I've pushed out new version of the for-3.17 core and drivers trees: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.17 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 In the core tree the biggest news is the old target infrastructure removal, in addition a few wa

Re: scsi-mq V2

2014-07-08 Thread Christoph Hellwig
On Wed, Jun 25, 2014 at 06:51:47PM +0200, Christoph Hellwig wrote: > Changes from V1: > - rebased on top of the core-for-3.17 branch, most notable the >scsi logging changes > - fixed handling of cmd_list to prevent crashes for some heavy >workloads > - fixed incorrect handling of !target

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

2014-07-08 Thread loody
hi Alan: 2014-07-08 1:02 GMT+08:00 Alan Stern : > On Tue, 8 Jul 2014, loody wrote: > >> > An alternative is to write a positive value, such as 24, to >> > >> > /sys/block/sdX/events_poll_msecs >> > >> > where X is replaced with the proper drive letter. (24 ms = 240 s = >> > 4 m.)

Re: [PATCH v6 0/2] ata: Fix the dma state machine lockup for APM X-Gene SoC

2014-07-08 Thread Tejun Heo
On Mon, Jul 07, 2014 at 10:33:03PM +0530, Suman Tripathi wrote: > This patch addresses the dma state machine lockup for APM X-Gene SoC. > > Signed-off-by: Loc Ho > Signed-off-by: Suman Tripathi Applied to libata/for-3.16-fixes. Thanks. -- tejun -- To unsubscribe from this list: send the line

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

2014-07-08 Thread Alan Stern
On Tue, 8 Jul 2014, loody wrote: > You are correct. > i can see events_poll_msecs when I change my kernel to 3.8.0 > But the device still disconnect. > I have some question. > 1. when I cat /sys/block/sdX/events, I get the answer as media_change. > is there any events type we can choose, such

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

2014-07-08 Thread loody
hi Alan: 2014-07-09 0:00 GMT+08:00 Alan Stern : > On Tue, 8 Jul 2014, loody wrote: > >> You are correct. >> i can see events_poll_msecs when I change my kernel to 3.8.0 >> But the device still disconnect. >> I have some question. >> 1. when I cat /sys/block/sdX/events, I get the answer as media_c

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

2014-07-08 Thread Alan Stern
On Wed, 9 Jul 2014, loody wrote: > there is one thing pop in my mind. > if events_poll_msecs is used for media_change, shouldn't we wrap is READ10? No. Why should media change polling use READ(10)? TEST UNIT READY does a good job of detecting media changes. > the difference seems > 1. change

RE: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, 25 June, 2014 11:52 AM > To: James Bottomley > Cc: Jens Axboe; Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH 03/14] scs

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

2014-07-08 Thread Andy Grover
[re-adding individual CCs that were dropped] On 07/05/2014 04:29 AM, Alex Elsayed wrote: +Device Discovery: + +Other devices may be using UIO besides TCMU. Unrelated user processes +may also be handling different sets of TCMU devices. TCMU userspace +processes must find their devices by scanning

[PATCH 0/8] Drivers: scsi: storvsc: Bug fixes and improvements

2014-07-08 Thread K. Y. Srinivasan
In this patch set I have fixed a few bugs and implemented some enhancements. K. Y. Srinivasan (8): Drivers: scsi: storvsc: Change the limits to reflect the values on the host Drivers: scsi: storvsc: Filter commands based on the storage protocol version Drivers: scsi: storvsc: Fix a

[PATCH 2/8] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

2014-07-08 Thread K. Y. Srinivasan
Going forward it is possible that some of the commands that are not currently implemented will be implemented on future Windows hosts. Make command filtering depend on the host version. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c | 11 --- 1 files changed, 8 ins

[PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

2014-07-08 Thread K. Y. Srinivasan
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storv

[PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-07-08 Thread K. Y. Srinivasan
Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_dr

[PATCH 5/8] Drivers: scsi: storvsc: Fix a bug in the handling of SRB status flags

2014-07-08 Thread K. Y. Srinivasan
SRB status can have additional information. Mask these out before processing SRB status. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index

[PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-08 Thread K. Y. Srinivasan
Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle or pre-win8 and post-win8. Win WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version. Make adjustments to correctly handle this. Signe

[PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-08 Thread K. Y. Srinivasan
Implement a simple abort handler. The host does not support "Abort"; just ensure that all inflight I/Os have been accounted for. Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/s

[PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases

2014-07-08 Thread K. Y. Srinivasan
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the Windows host require this. Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc

[PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-08 Thread K. Y. Srinivasan
Host does not handle WRITE_SAME_16; filter this command out. This patch is required to handle large devices (greater than 2 TB disks). Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/storvsc

Re: uas - kernel panic on drive connection

2014-07-08 Thread Jonathan
Hans, could you comment on this? Thanks. Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] scsi: use 64-bit value for 'max_luns'

2014-07-08 Thread Rusty Russell
Christoph Hellwig writes: > On Tue, Jun 03, 2014 at 10:58:56AM +0200, Hannes Reinecke wrote: >> Now that we're using 64-bit LUNs internally we need to increase >> the size of max_luns to 64 bits, too. >> >> Signed-off-by: Hannes Reinecke >> Reviewed-by: Christoph Hellwig >> Reviewed-by: Ewan Mi

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

2014-07-08 Thread loody
hi Alan: 2014-07-09 3:26 GMT+08:00 Alan Stern : > On Wed, 9 Jul 2014, loody wrote: > >> there is one thing pop in my mind. >> if events_poll_msecs is used for media_change, shouldn't we wrap is READ10? > > No. Why should media change polling use READ(10)? TEST UNIT READY > does a good job of det

[PATCH] fcoe: Reduce max_sectors to 1024

2014-07-08 Thread Hannes Reinecke
The DDP offload on ixgbe is only capable of handling requests up to 1024 sectors. So we should be exposing this to avoid spurious messages about 'not enough user buffers'. Cc: Vasu Dev Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] fcoe: Reduce max_sectors to 1024

2014-07-08 Thread Christoph Hellwig
On Wed, Jul 09, 2014 at 08:16:21AM +0200, Hannes Reinecke wrote: > The DDP offload on ixgbe is only capable of handling requests up > to 1024 sectors. So we should be exposing this to avoid spurious > messages about 'not enough user buffers'. Shouldn't the network driver be able to communicate it'

Re: [PATCH] fcoe: Reduce max_sectors to 1024

2014-07-08 Thread Hannes Reinecke
On 07/09/2014 08:18 AM, Christoph Hellwig wrote: On Wed, Jul 09, 2014 at 08:16:21AM +0200, Hannes Reinecke wrote: The DDP offload on ixgbe is only capable of handling requests up to 1024 sectors. So we should be exposing this to avoid spurious messages about 'not enough user buffers'. Shouldn'

Re: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-08 Thread Christoph Hellwig
On Tue, Jul 08, 2014 at 08:51:30PM +, Elliott, Robert (Server Storage) wrote: > In scsi_lib.c, both scsi_done() and scsi_mq_done() always call > trace_scsi_dispatch_cmd_done(), so trace_scsi_dispatch_cmd_start() > should be called before scsi_done() is called. That way the > trace will always