On Mon, 2014-06-09 at 16:30 +0300, Michael S. Tsirkin wrote:
> On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > Hi MST, MKP, Paolo & Co,
> >
> > Here is the v2 patch series for adding T1O protection information (PI)
> > SGL passthrough s
On Sun, 2014-06-08 at 19:05 +0300, Michael S. Tsirkin wrote:
> On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > Hi MST, MKP, Paolo & Co,
> >
> > Here is the v2 patch series for adding T1O protection information (PI)
> > SGL passthrough s
Il 10/06/2014 09:07, Nicholas A. Bellinger ha scritto:
> OK, finally went over this, looks good to me:
>
> Acked-by: Michael S. Tsirkin
>
> However, we really should stop making more changes
> before fixing ANY_LAYOUT in this driver.
>
> virtio 1.0 should be out soon and that makes ANY_LAYOUT
>
Hi Sagi & Co,
On Sun, 2014-06-08 at 13:27 +0300, Sagi Grimberg wrote:
> In various areas of the code, it is assumed that
> se_cmd->data_length describes pure data. In case
> that protection information exists over the wire
> (protect bits is are on) the target core decrease
> the protection length
Hi MKP + Mike + Roland,
On Sun, 2014-06-08 at 13:27 +0300, Sagi Grimberg wrote:
> At the SCSI transport level, there is no distinction between
> user data and protection information. Thus, iscsi header field
> "expected data transfer length" should include protection
> information.
>
> Patch #1 i
Il 10/06/2014 10:04, Nicholas A. Bellinger ha scritto:
That said, there is one other small qla2xxx change to enable per-session
PI that is currently missing in Quinn's patch in scsi/for-next code.
Sooo, I'll go ahead and include Sagi's patches with the vhost-scsi
change below if there are no ob
On Tue, Jun 10, 2014 at 12:05:12AM -0700, Nicholas A. Bellinger wrote:
> On Mon, 2014-06-09 at 16:30 +0300, Michael S. Tsirkin wrote:
> > On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote:
> > > From: Nicholas Bellinger
> > >
> > > Hi MST, MKP, Paolo & Co,
> > >
> > > Here is
On Wednesday 04 June 2014 17:10:24 H. Peter Anvin wrote:
> On 06/04/2014 12:24 PM, Arnd Bergmann wrote:
> >
> > For other timekeeping stuff in the kernel, I agree that using some
> > 64-bit representation (nanoseconds, 32/32 unsigned seconds/nanoseconds,
> > ...) has advantages, that's exactly the
resent to linux-scsi-ml, without the binary blob(244K).
Firmwares were taken from http://ldriver.qlogic.com/firmware/
Cc: Chad Dupuis
Cc: Andrew Vasquez
Cc: Joe Carnuccio
Cc: Saurav Kashyap
Cc: Qlogic internal list
Cc: Linux Firmware Maintainers
Signed-off-by: Xose Vazquez Perez
---
WHENC
Hello my beloved in the Lord.
I am MRS. FLORENCE EVANS, from republic of Ireland, I am legally married to MR.
JOHN EVANS, a South Africa citizen born brought up in Switzerland, I live in
Switzerland with my husband for 32 years before we move down to south Africa in
1985 after my husband retire
Thanks for the patch.
Acked-by: Sudarsana Kalluru
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Peter Senna Tschudin
Sent: 31 May 2014 18:44
To: Anil Gurumurthy
Cc: kernel-janit...@vger.kernel.org; Sudarsana Kalluru; Jame
On 06/03/14 10:58, Hannes Reinecke wrote:
> + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
> + * returns the integer: 0x0b03d204
> + *
> + * This encoding will return a standard integer LUN for LUNs smaller
> + * than 256, which typically use a single level L
On Mon, Jun 09, 2014 at 03:16:37PM -0400, Neil Horman wrote:
> > Given fcoe is quite mature now and its patches volume is very low, so
> > getting its kernel patches directly to scsi subsystem should work fine
> > and should be okay with James or Christophs to pull into scsi subsystem
> > directly
Hi Michael,
On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" wrote:
>
> So I see two options:
> - I go ahead with my changes and you with yours and let Linus resolve
> the conflict. This means bisect build will be broken since the
> breakage will likely not be noticed until after the
On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> Hi Michael,
>
> On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin"
> wrote:
> >
> > So I see two options:
> > - I go ahead with my changes and you with yours and let Linus resolve
> > the conflict. This means bisect buil
On 14-06-10 07:37 AM, Bart Van Assche wrote:
On 06/03/14 10:58, Hannes Reinecke wrote:
+ * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
+ * returns the integer: 0x0b03d204
+ *
+ * This encoding will return a standard integer LUN for LUNs smaller
+ * than 256
On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote:
> On 06/03/14 10:58, Hannes Reinecke wrote:
> > + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
> > + * returns the integer: 0x0b03d204
> > + *
> > + * This encoding will return a standard integer LUN for L
Use kstrdup when the goal of an allocation is copy a string into the
allocated region.
The Coccinelle semantic patch that makes this change is as follows:
//
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@
- to = kmalloc(strlen(from) + 1,flag);
+ to = kstrdup(from, flag);
...
Use kstrdup when the goal of an allocation is copy a string into the
allocated region.
The semantic patch that makes this change is as follows:
//
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@
- to = kmalloc(strlen(from) + 1,flag);
+ to = kstrdup(from, flag);
... when != \(
Use kstrdup when the goal of an allocation is copy a string into the
allocated region.
The semantic patch that makes this change is as follows:
//
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@
- to = kmalloc(strlen(from) + 1,flag);
+ to = kstrdup(from, flag);
... when != \(f
On 06/10/14 16:06, James Bottomley wrote:
> On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote:
>> On 06/03/14 10:58, Hannes Reinecke wrote:
>>> + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
>>> + * returns the integer: 0x0b03d204
>>> + *
>>> + * This enco
On 14-06-10 10:06 AM, James Bottomley wrote:
On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote:
On 06/03/14 10:58, Hannes Reinecke wrote:
+ * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
+ * returns the integer: 0x0b03d204
+ *
+ * This encoding will retu
On Tue, 2014-06-10 at 16:48 +0200, Bart Van Assche wrote:
> On 06/10/14 16:06, James Bottomley wrote:
> > On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote:
> >> On 06/03/14 10:58, Hannes Reinecke wrote:
> >>> + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function
> >>> +
Hi Michael,
On Tue, 10 Jun 2014 16:02:08 +0300 "Michael S. Tsirkin" wrote:
>
> I don't see how that's possible.
> Here's a point you might have missed.
> Nicholas's patch isn't just introducing a merge conflict.
> It is also buggy.
Ah ha! Indeed that is a different kettle of fish. :-)
--
Chee
On Tue, Jun 10, 2014 at 04:38:41AM -0700, Christoph Hellwig wrote:
> On Mon, Jun 09, 2014 at 03:16:37PM -0400, Neil Horman wrote:
> > > Given fcoe is quite mature now and its patches volume is very low, so
> > > getting its kernel patches directly to scsi subsystem should work fine
> > > and should
On 06/10/14 17:01, James Bottomley wrote:
> On Tue, 2014-06-10 at 16:48 +0200, Bart Van Assche wrote:
>> On 06/10/14 16:06, James Bottomley wrote:
>>> On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote:
On 06/03/14 10:58, Hannes Reinecke wrote:
> + * Given a struct scsi_lun of: d
https://bugzilla.kernel.org/show_bug.cgi?id=77631
Bug ID: 77631
Summary: task scsi_eh_6:537 blocked for more than 120 seconds.
Product: IO/Storage
Version: 2.5
Kernel Version: 3.14.6
Hardware: All
OS: Linux
Tr
>From the trace below, this looks to be a USB issue (USB added to cc):
the scsi error handler thread is waiting for usb storage to complete the
reset. It's a 3.14.5 kernel, so the previous reset hang because of
spurious sense requests should be fixed.
James
On Tue, 2014-06-10 at 16:50 +, bu
On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> > Hi Michael,
> >
> > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin"
> > wrote:
> > >
> > > So I see two options:
> > > - I go ahead with my changes and you
On 06/03/14 10:58, Hannes Reinecke wrote:
> this patchset updates the SCSI stack to support full 64-bit LUNs.
> The first patch is a simple fix; the next patch updates
> the sequential scan logic to be compliant with SPC.
> The third patch addresses a firmware issue with earlier
> qla2xxx HBAs.
> T
On 06/08/2014 05:27 AM, Sagi Grimberg wrote:
> In case protection information exists over the wire
> iscsi header data_length is required to include it.
> Use protection information aware scsi helpers to set
> the correct transfer length.
>
> In order to avoid breakage, remove iser transfer length
On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> > > Hi Michael,
> > >
> > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin"
> > >
> "Sagi" == Sagi Grimberg writes:
+static inline unsigned scsi_prot_length(unsigned data_length,
+ unsigned sector_size)
+{
+ switch (sector_size) {
+ case 512:
+ return (data_length >> 9) * 8;
+ case 1024:
+
On 6/10/2014 10:02 PM, Martin K. Petersen wrote:
"Sagi" == Sagi Grimberg writes:
+static inline unsigned scsi_prot_length(unsigned data_length,
+ unsigned sector_size)
+{
+ switch (sector_size) {
+ case 512:
+ return (data_length >
On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> > > Hi Michael,
> > >
> > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin"
> > >
On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> > > > Hi Michael,
> > > >
On Tue, 2014-06-10 at 22:35 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote:
> > > > Hi Michael,
> > > >
On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote:
> On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> > > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote:
> > > > On Tue, Jun 10, 2014 a
On Tue, Jun 10, 2014 at 10:02 PM, Martin K. Petersen
wrote:
>> "Sagi" == Sagi Grimberg writes:
>
> +static inline unsigned scsi_prot_length(unsigned data_length,
> + unsigned sector_size)
> +{
> + switch (sector_size) {
> + case 512:
> +
> "Or" == Or Gerlitz writes:
Or> Just to make sure, by 3.16 you also mean 3.15.y, right?
Yes.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo in
On Tue, 2014-06-10 at 13:09 -0700, James Bottomley wrote:
> On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote:
> > > > On Tue, 2014-06-10 at 16:
On Tue, 10 Jun 2014, James Bottomley wrote:
> From the trace below, this looks to be a USB issue (USB added to cc):
> the scsi error handler thread is waiting for usb storage to complete the
> reset. It's a 3.14.5 kernel, so the previous reset hang because of
> spurious sense requests should be f
Hello
I am tired of building modules to enable SCSI tape driver debug so I am hoping
this patch is acceptable.
Tested using kernel 3.14.6
Usage example:
modprobe st debug_flag=1
diff -Nur a/st.c b/st.c
--- a/st.c 2014-06-10 16:45:18.522354105 -0400
+++ b/st.c 2014-06-10 16:45:33.95376
https://bugzilla.kernel.org/show_bug.cgi?id=77631
--- Comment #1 from Alan Stern ---
On Tue, 10 Jun 2014, James Bottomley wrote:
> From the trace below, this looks to be a USB issue (USB added to cc):
> the scsi error handler thread is waiting for usb storage to complete the
> reset. It's a 3.1
On Tue, Jun 10, 2014 at 1:25 PM, Nicholas A. Bellinger
wrote:
>
> That would work, or I can simply include a pointer to Stephen's patch in
> the target-pending PULL request after the vhost API changes are merged
> and Linus can apply himself..
Yes. That way I'll include it in the merge, and every
Hello
I am tired of building modules to enable SCSI tape driver debug so I
am hoping this patch is acceptable.
Tested using kernel 3.14.6
Usage example:
modprobe st debug_flag=1
diff -Nur a/st.c b/st.c
--- a/st.c2014-06-10 16:45:18.522354105 -0400
+++ b/st.c2014-06-10 16:45:33.95
All,
Comments inline.
Regards,
Quinn Tran
On 6/10/14 1:04 AM, "Nicholas A. Bellinger" wrote:
>Hi Sagi & Co,
>
>On Sun, 2014-06-08 at 13:27 +0300, Sagi Grimberg wrote:
>> In various areas of the code, it is assumed that
>> se_cmd->data_length describes pure data. In case
>> that protection i
On Tue, 2014-06-10 at 13:56 -0700, Linus Torvalds wrote:
> On Tue, Jun 10, 2014 at 1:25 PM, Nicholas A. Bellinger
> wrote:
> >
> > That would work, or I can simply include a pointer to Stephen's patch in
> > the target-pending PULL request after the vhost API changes are merged
> > and Linus can a
On Fri, 2014-06-06 at 13:05 -0500, shirishpargaon...@gmail.com wrote:
> From: Shirish Pargaonkar
>
>
> Do not log error for netevents that need no action such as
> NETDEV_REGISTER 0x0005, NETDEV_CHANGEADDR, and NETDEV_CHANGENAME.
> It results in logging error messages such as these
>
> [ 35.3
https://bugzilla.kernel.org/show_bug.cgi?id=77631
--- Comment #2 from Mikhail ---
This occurred when I did first reboot after kernel update from 3.14.5 to
3.14.6.
After second reboot I have not seen this issue.
And I did not plug/unplug any USB devices when it occurred.
--
You are receiving thi
On Tue, Jun 10, 2014 at 04:57:06PM -0400, Laurence Oberman wrote:
> I am tired of building modules to enable SCSI tape driver debug so I
> am hoping this patch is acceptable.
> Tested using kernel 3.14.6
>
> Usage example:
> modprobe st debug_flag=1
Missing Signed-off-by :-)
> +module_param_nam
https://bugzilla.kernel.org/show_bug.cgi?id=77631
--- Comment #3 from Mikhail ---
When I reconnect my USB3.0 10 port hub only occurs this:
[ 835.657491] usb 4-3: USB disconnect, device number 3
[ 835.657506] usb 4-3.4: USB disconnect, device number 11
[ 835.658118] usb 4-3.4: Failed to set U1
https://bugzilla.kernel.org/show_bug.cgi?id=77631
--- Comment #4 from Mikhail ---
Created attachment 138991
--> https://bugzilla.kernel.org/attachment.cgi?id=138991&action=edit
kernel log (second reboot) and plug/unplug USB3.0 hub
--
You are receiving this mail because:
You are the assignee f
Hello
Take 2 of this patch, changed module description and subject line.
This patch adds a debug_flag parameter that can be set on module load, and
allows the DEBUG facility without a module recompile.
Usage: mpdprobe st debug_flag=1
Signed-off-by: Laurence Oberman
diff -Nur a/st.c b/st.c
---
On 06/10/2014 07:58 PM, Bart Van Assche wrote:
On 06/03/14 10:58, Hannes Reinecke wrote:
this patchset updates the SCSI stack to support full 64-bit LUNs.
The first patch is a simple fix; the next patch updates
the sequential scan logic to be compliant with SPC.
The third patch addresses a firmw
On 06/11/14 08:34, Hannes Reinecke wrote:
> On 06/10/2014 07:58 PM, Bart Van Assche wrote:
>> Many SCSI LLD's use int_to_scsilun() in the hot path (queuecommand()).
>> This patch series makes the int_to_scsilun() function slightly more
>> expensive. Has it been considered to cache the result of int
56 matches
Mail list logo
