A tester found out that we need add_disk_randomness for my scsi-mq
branch. The patch applied exports add_disk_randomness so that modular
scsi still works with a driver that either uses the low-level I/O
completion routines for the old block layer, or blk-mq, and I'd love
to get this in through Jen
This will be needed for pending changes to the scsi midlayer that now calls
lower level block APIs, as well as any blk-mq driver that wants to contribute
to the random pool.
Signed-off-by: Christoph Hellwig
---
drivers/char/random.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/
When scsi_init_io fails we have to release our device reference, but
we do this trying to reference the just freed command. Add a local
scsi_device pointer to fix this.
Reported-by: Sander Eikelenboom
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c |3 ++-
1 file changed, 2 in
In the kill case of scsi_prep_return we have to release our device
reference, but we do this trying to reference the just freed command.
Use the local sdev pointer instead.
Reported-by: Joe Lawrence
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c |2 +-
1 file changed, 1 insert
Hi Linus, hi James,
these are two simple use after free fixes that fix a regression introduced
by me in the first scsi update for 3.15-rc1.
I've sent them to the scsi list 10 days ago and haven't seen any reply to
them, and I'd hate if they miss -rc3 in addition to -rc2.
--
To unsubscribe from t
On Tue, Apr 22, 2014 at 01:44:16PM +0200, Maurizio Lombardi wrote:
> Signed-off-by: Maurizio Lombardi
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
Looks useful, but why do we have basically two copies of the same
On Thu, Apr 10, 2014 at 04:12:57PM +0200, Hannes Reinecke wrote:
> On 04/10/2014 01:51 PM, Christoph Hellwig wrote:
> >> static int
> >> ch_release(struct inode *inode, struct file *file)
> >> {
> >>scsi_changer *ch = file->private_data;
> >>
> >>scsi_device_put(ch->device);
> >> + ch
On Fri, Apr 25, 2014 at 12:36:37AM -0700, Christoph Hellwig wrote:
> This will be needed for pending changes to the scsi midlayer that now calls
> lower level block APIs, as well as any blk-mq driver that wants to contribute
> to the random pool.
>
> Signed-off-by: Christoph Hellwig
Acked-by: "T
On Fri, Apr 25, 2014 at 12:36:10AM -0700, Christoph Hellwig wrote:
> But this also brings up an interesting question: blk-mq currently
> does not set QUEUE_FLAG_ADD_RANDOM in the default queue flags, so
> simply converting a driver to blk-mq will mean it stops contributing
> to the random pool. D
On 04/25/2014 01:36 AM, Christoph Hellwig wrote:
> A tester found out that we need add_disk_randomness for my scsi-mq
> branch. The patch applied exports add_disk_randomness so that modular
> scsi still works with a driver that either uses the low-level I/O
> completion routines for the old block
On 04/25/2014 08:03 AM, Theodore Ts'o wrote:
> On Fri, Apr 25, 2014 at 12:36:10AM -0700, Christoph Hellwig wrote:
>> But this also brings up an interesting question: blk-mq currently
>> does not set QUEUE_FLAG_ADD_RANDOM in the default queue flags, so
>> simply converting a driver to blk-mq will m
This is a set of seven fixes, three (hpsa) and free'd command references
correcting bugs in the last round of updates and the remaining four
correcting problems within the SCSI error handler that was causing a
deadlock within USB.
The patch is available here:
git://git.kernel.org/pub/scm/linux/ke
On Fri, 2014-04-25 at 13:09 +0200, Christoph Hellwig wrote:
> Hi Linus, hi James,
>
> these are two simple use after free fixes that fix a regression introduced
> by me in the first scsi update for 3.15-rc1.
>
> I've sent them to the scsi list 10 days ago and haven't seen any reply to
> them, and
Hi,
On Fri, Apr 25, 2014 at 03:12:19PM +0200, Christoph Hellwig wrote:
>
> Looks useful, but why do we have basically two copies of the same
> code for different commands? Looking at them in detail they mostly look
> like copies of scsi_execute/scsi_execute_req_flags and should be switched
> to t
On suspend, _scsih_suspend calls mpt2sas_base_free_resources, which
in turn calls pci_disable_device if the device is enabled prior to
suspending. However, _scsih_suspend also calls pci_disable_device
itself.
Thus, in the event that the device is enabled prior to suspending,
pci_disable_device wil
On Fri, 25 Apr 2014, James Bottomley wrote:
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 65a123d..9db097a 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -137,6 +137,7 @@ static void __scsi_queue_insert(struct scsi_cmnd *cmd,
> int reason, i
On Fri, Apr 25, 2014 at 3:49 PM, David Rientjes wrote:
>
> Hmm, I see why this is needed because of the scsi_put_command(cmd), but I
> think you need to do struct scsi_device *sdev = ACCESS_ONCE(cmd->device)
> instead to prevent gcc from messing with the code generation.
No, if gcc were to move t
Acked-by: Michael Schmitz
All NCR5380 drivers already include the NCR5380.h header. Better to
adopt those macros rather than have three variations on them.
Moreover, the macros in NCR5380.h are preferable anyway: the atari_NCR5380
and sun3_NCR5380 versions are inflexible. For example, they can
Acked-by: Michael Schmitz
All NCR5380 drivers already include the NCR5380.h header. Better to
adopt those macros rather than have three variations on them.
Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380
and sun3_NCR5380 versions are inflexible. For example, they can
Acked-by: MIchael Schmitz
Remove the unused (and divergent) debugging macro definitions from
the sun3_NCR5380 and atari_NCR5380 drivers. These drivers have been
converted to use the common macros in NCR5380.h.
Signed-off-by: Finn Thain
---
drivers/scsi/atari_scsi.h | 93 -
20 matches
Mail list logo
