[Bug 73621] New: Kernel exception loading sym53c8xx on dual AMD Athlon Tyan S2460 motherboard

2014-04-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=73621 Bug ID: 73621 Summary: Kernel exception loading sym53c8xx on dual AMD Athlon Tyan S2460 motherboard Product: SCSI Drivers Version: 2.5 Kernel Version: 3.10.36 Hardware:

Re: esp_scsi QTAG in FAS216

2014-04-06 Thread Michael Schmitz
Hello Dave, Tuomas, >> Also, looking at the timeout formulae in the old NCR53C9x.c driver, >> the values would be different for FAS216. Why was this dropped from >> the modern esp_scsi? > > I've never seen a formula for any ESP or FAS chip for the timeout > other than the one mentioned in huge com

[PATCH 2/6] vhost/scsi: Move sanity check into vhost_scsi_map_iov_to_sgl

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Move the overflow check for sgl_count > TCM_VHOST_PREALLOC_SGLS into vhost_scsi_map_iov_to_sgl() so that it's based on the total number of SGLs for all IOVs, instead of single IOVs. Also, rename TCM_VHOST_PREALLOC_PAGES -> TCM_VHOST_PREALLOC_UPAGES to better describe poi

[PATCH 5/6] vhost/scsi: Enable T10 PI IOV -> SGL memory mapping

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates vhost_scsi_handle_vq() to check for the existance of virtio_scsi_cmd_req_pi comparing vq->iov[0].iov_len in order to calculate seperate data + protection SGLs from data_num. Also update tcm_vhost_submission_work() to pass the pre-allocated cmd->tvc_pro

[PATCH 3/6] vhost/scsi: Add preallocation of protection SGLs

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates tcm_vhost_make_nexus() to pre-allocate per descriptor tcm_vhost_cmd->tvc_prot_sgl[] used to expose protection SGLs from within virtio-scsi guest memory to vhost-scsi. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Martin K. Petersen Cc: Christoph Hell

[PATCH 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates virtscsi_probe() to setup necessary Scsi_Host level protection resources. (currently hardcoded to 1) It changes virtscsi_add_cmd() to attach outgoing / incoming protection SGLs preceeding the data payload, and is using the new virtio_scsi_cmd_req_pi->d

[PATCH 4/6] vhost/scsi: Add T10 PI IOV -> SGL memory mapping logic

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds vhost_scsi_map_iov_to_prot() to perform the mapping of T10 data integrity memory between virtio iov + struct scatterlist using get_user_pages_fast() following existing code. As with vhost_scsi_map_iov_to_sgl(), this does sanity checks against the total pr

[PATCH 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi MST, MKP, Paolo & Co, This is an updated patch series for adding T1O protection information (PI) SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric endpoints. Following Paolo's recommendations, this patch uses VIRTIO_SCSI_F_T10_PI feature bits in bot

[PATCH 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits

2014-04-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a virtio_scsi_cmd_req_pi header as recommened by Paolo that contains do_pi_niov + di_pi_niov elements used for signaling when protection information buffers are expected to preceed the data buffers. Also add new VIRTIO_SCSI_F_T10_PI feature bit to be used

Re: [PATCH] target/tcm_fc: Fix use-after-free of ft_tpg

2014-04-06 Thread Nicholas A. Bellinger
Hi Andy, On Fri, 2014-04-04 at 16:44 -0700, Andy Grover wrote: > ft_del_tpg checks tpg->tport is set before unlinking the tpg from the > tport when the tpg is being removed. Set this pointer in ft_tport_create, > or the unlinking won't happen in ft_del_tpg and tport->tpg will reference > a deleted

Re: [PATCH 0/5] target/tcm_fc: Misc. fixups

2014-04-06 Thread Nicholas A. Bellinger
On Fri, 2014-04-04 at 16:54 -0700, Andy Grover wrote: > Hi nab and fcoe developers, > > In fixing the other issue I just posted a patch for, I found some other > things in the tcm_fc fabric that could be improved. Please take a look? > > Thanks! -- Regards -- Andy > > Andy Grover (5): > target

[PATCH] [SCSI] FlashPoint: Fix non-ANSI function declaration

2014-04-06 Thread Daeseok Youn
sparse says: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll' Signed-off-by: Daeseok Youn --- drivers/scsi/FlashPoint.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c index 5c74e4c..867b864 1006

Re: [PATCH] [SCSI] FlashPoint: Fix non-ANSI function declaration

2014-04-06 Thread Khalid Aziz
On Mon, 2014-04-07 at 11:51 +0900, Daeseok Youn wrote: > sparse says: > non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll' > > Signed-off-by: Daeseok Youn > --- > drivers/scsi/FlashPoint.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/s

Re: esp_scsi QTAG in FAS216

2014-04-06 Thread David Miller
From: Michael Schmitz Date: Mon, 7 Apr 2014 08:33:12 +1200 > Hello Dave, Tuomas, > >>> Also, looking at the timeout formulae in the old NCR53C9x.c driver, >>> the values would be different for FAS216. Why was this dropped from >>> the modern esp_scsi? >> >> I've never seen a formula for any ESP