Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Hannes Reinecke
On 03/02/2014 09:53 AM, Bart Van Assche wrote: > On 02/13/14 11:27, Hannes Reinecke wrote: >> After discussion with jejb I've dropped the EVPD parsing. >> So with this version we're just displaying the EVPD page >> 0x80 and 0x83 as hexdumps; no parsing is attempted. >> This drastically simplifies t

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Bart Van Assche
On 03/05/14 09:00, Hannes Reinecke wrote: > On 03/02/2014 09:53 AM, Bart Van Assche wrote: >> A general comment about this patch series: I think the cached copies of >> these pages should be refreshed at least after an INQUIRY DATA HAS >> CHANGED unit attention code has been received. Some SCSI tar

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-05 Thread Hannes Reinecke
On 03/05/2014 09:23 AM, Bart Van Assche wrote: > On 03/05/14 09:00, Hannes Reinecke wrote: >> On 03/02/2014 09:53 AM, Bart Van Assche wrote: >>> A general comment about this patch series: I think the cached copies of >>> these pages should be refreshed at least after an INQUIRY DATA HAS >>> CHANGED

Loan Application

2014-03-05 Thread Loans
Loan Application at a low rate of 0.5% send your Name,Amount,Phone and country to standar...@56788.com Note: $5,000.00 USD minimum and $100,000,000 Maximum. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH 0/6] iser-target: Fix active I/O shutdown related issues

2014-03-05 Thread Sagi Grimberg
On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote: On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote: On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger Hi Or & Sagi, This series addresses a number of active I/O shutdown related issues in iser-target code that hav

[Bug 71231] System unresponsable after a lot of LUNs have been added to the system

2014-03-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=71231 --- Comment #7 from Alex --- ea461abf61753b4b79e625a7c20650105b990f21 is the first bad commit commit ea461abf61753b4b79e625a7c20650105b990f21 Author: Gavin Shan Date: Wed Jun 5 15:34:02 2013 +0800 powerpc/eeh: Fix fetching bus for single-d

[PATCH] bnx2fc: remove unused variable hash_table_size

2014-03-05 Thread Maurizio Lombardi
hash_table_size is not used by the bnx2fc_free_hash_table() function. Signed-off-by: Maurizio Lombardi --- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c index 46a3765..261af2a 100644 ---

[PATCH v2 02/13] IB/iser: Push the decision what memory key to use into fast_reg_mr routine

2014-03-05 Thread Sagi Grimberg
This is a preparation step for T10-PI offload support. We prefer to push the desicion of which mkey to use (global or fastreg) to iser_fast_reg_mr. We choose to do this since it in T10-PI we may need to register for protection buffers and in this case we wish to simplify iser_fast_reg_mr instead of

[PATCH v2 03/13] IB/iser: Move fast_reg_descriptor initialization to a function

2014-03-05 Thread Sagi Grimberg
fastreg descriptor will include protection information context. In order to place the logic in one place we introduce iser_create_fr_desc function. This patch does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iser_verb

[PATCH v2 10/13] IB/iser: Support T10-PI operations

2014-03-05 Thread Sagi Grimberg
Add logic to initialize protection information entities. Upon each iSCSI task, we keep the scsi_cmnd in order to query the scsi protection operations and reference to protection buffers. Modify iser_fast_reg_mr to receive indication weather it is registering the data or protection buffers. In add

[PATCH v2 12/13] IB/iser: Implement check_protection

2014-03-05 Thread Sagi Grimberg
Once the iSCSI transaction is completed we must imeplement check_protection in order to notify on DIF errors that may have occured. The routine boils down to calling ib_check_mr_status to get the signature status of the transaction. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik Si

[PATCH v2 00/13] T10-PI support for iSER initiator

2014-03-05 Thread Sagi Grimberg
Hey Roland, Nic, Mike and Co This patchset adds T10 protection information offload support over RDMA signature verbs API. This set, along with the iSER target set, allow end-to-end protection information passthrough and validation. The patchset was tested against Linux SCSI target with iSER DIF su

[PATCH v2 01/13] IB/iser: Avoid FRWR notation, use fastreg instead

2014-03-05 Thread Sagi Grimberg
FRWR stands for "fast registration work request". We want to avoid calling the fastreg pool with that name, instead we name it fastreg which stands for "fast registration". This pool will include more elements in the future, so it is a good idea to generalize the name. Signed-off-by: Sagi Grimber

[PATCH v2 08/13] IB/iser: Introduce pi_enable, pi_guard module parameters

2014-03-05 Thread Sagi Grimberg
From: Alex Tabachnik Use modparams to activate protection information support. pi_enable bool: Based on this parameter iSER will know if it should support T10-PI. We don't want to do this by default as it requires to allocate and initiatlize extra resources. In case pi_enable=N, iSER won't publi

[PATCH v2 13/13] IB/iser: Publish T10-PI support to SCSI midlayer

2014-03-05 Thread Sagi Grimberg
After allocating a scsi_host we set protection types and guard type supported. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/infiniba

[PATCH v2 04/13] IB/iser: Keep IB device attributes under iser_device

2014-03-05 Thread Sagi Grimberg
For T10-PI offload support, we will need to know the device signature offload capability upon every connection establishment. This patch does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iscsi_iser.h |1 + drivers/

[PATCH v2 09/13] IB/iser: Initialize T10-PI resources

2014-03-05 Thread Sagi Grimberg
From: Alex Tabachnik During connection establishment we also initiatlize T10-PI resources (QP, PI contexts) in order to support SCSI's protection operations. Signed-off-by: Alex Tabachnik Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 - drivers/infin

[PATCH v2 06/13] IB/iser: Generalize iser_unmap_task_data and finalize_rdma_unaligned_sg

2014-03-05 Thread Sagi Grimberg
This routines operates on data buffers and may also work with protection infomation buffers. So we generalize them to handle an iser_data_buf which can be the command data or command protection information. This patch does not change any functionality. Signed-off-by: Sagi Grimberg --- drivers/i

[PATCH v2 05/13] IB/iser: Replace fastreg descriptor valid bool with indicators container

2014-03-05 Thread Sagi Grimberg
In T10-PI support we will have memory keys for protection buffers and signature transactions. We prefer to compact indicators rather than keeping multiple bools. This commit does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp

[PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-05 Thread Sagi Grimberg
iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike transport errors, DIF errors should not prevent successful completion of the tran

[PATCH v2 07/13] IB/iser: Generalize fall_to_bounce_buf routine

2014-03-05 Thread Sagi Grimberg
Unaligned SG-lists may also happen for protection information. Genrelize bounce buffer routine to handle any iser_data_buf which may be data and/or protection. This patch does not change any functionality. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iser_memory.c | 53 +++

[PATCH] SCSI/libiscsi: Allow transport xmit_task to fail with non-transient error codes

2014-03-05 Thread Sagi Grimberg
Allow transport callback xmit_task to return either transient errors such as -ENOMEM or -EAGAIN to retry the task, and non-transient such as -EINVAL to abort it. Signed-off-by: Sagi Grimberg --- drivers/scsi/libiscsi.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff

Slow I/O performance on SAS1064

2014-03-05 Thread Markus
Hi I have problem with SATA disks at my Sunfire v245 and its lsi controller they are very slow. So I test it with dd and while dd in a nother terminal i see dstat results of sda: Copy from ramdisk to sda. === Test ext4 === DD root@outpost:/ramdisk# dd if=debian-7.4.0-sparc-netinst.iso of=/ro

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-05 Thread Mike Christie
On 03/04/2014 03:59 AM, Sagi Grimberg wrote: > On 3/4/2014 11:38 AM, Or Gerlitz wrote: >> On 03/03/2014 06:44, Mike Christie wrote: >>> The xmit_task callout does handle failures like EINVAL. If the above map >>> calls fail then you would get infinite retries. You would currently want >>> to do the

Re: Slow I/O performance on SAS1064

2014-03-05 Thread Mark Knecht
On Wed, Mar 5, 2014 at 9:50 AM, Markus wrote: > The hdparm result looks like there is somethink not right . There were no > features supported but why ? Does the HDD have S.M.A.R.T. features? Possibly smartctl -a /dev/sda would provide some additional visibility? - Mark -- To unsubscribe f

Re: [PATCH 1/3] ipr: Remove extended delay bit on GSCSI reads/writes ops

2014-03-05 Thread wenxiong
Hi James, I didn't see these patches got merged yet. Do you want me to re-submit them? Thanks for your help! Wendy Quoting wenxi...@linux.vnet.ibm.com: This patch removes extended delay bit on GSCSI reads/writes ops, the performance will be significanly better. Signed-off-by: Wen Xiong ---

Re: [PATCH 6/8] target_core_spc: Include target device descriptor in VPD page 83

2014-03-05 Thread Andy Grover
On 12/18/2013 01:20 AM, Hannes Reinecke wrote: On 12/17/2013 09:01 PM, Nicholas A. Bellinger wrote: On Tue, 2013-12-17 at 11:50 -0800, Nicholas A. Bellinger wrote: On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: We should be including a descriptor referring to the target device to al

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-05 Thread Christoph Hellwig
On Wed, Mar 05, 2014 at 08:38:01AM +0100, Hannes Reinecke wrote: > > Either way I think the call to query evpd 0 should be a separate > > function, so even if we don't store the information it's abstracted out. > > > Hmm. That would work if we were just asking for a single page; but > when we're c

Re: [PATCH 6/8] target_core_spc: Include target device descriptor in VPD page 83

2014-03-05 Thread Andy Grover
On 03/05/2014 11:41 AM, Andy Grover wrote: Hi, fbfe858 only bumps INQUIRY_BUF to 768 although the comment says 1024, is this expected and ok? Doh, read the diff backwards, disregard. -- Andy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to ma

[PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-05 Thread Dan Williams
Tejun says: "At least for libata, worrying about suspend/resume failures don't make whole lot of sense. If suspend failed, just proceed with suspend. If the device can't be woken up afterwards, that's that. There isn't anything we could have done differently anyway. The same for resu

[PATCH v5 3/3] scsi: async sd resume

2014-03-05 Thread Dan Williams
async_schedule() sd resume work to allow disks and other devices to resume in parallel. This moves the entirety of scsi_device resume to an async context to ensure that scsi_device_resume() remains ordered with respect to the completion of the start/stop command. For the duration of the resume, n

[PATCH v5 0/3] Accelerate Storage Resume (2x or more)

2014-03-05 Thread Dan Williams
It is not everyday that a kernel operation gets 2x faster. Nice find by Todd and his AnalyzeSuspend tool [1]. Todd is on vacation so I am taking care of these patches to make sure they get in the queue for 3.15. The significant changes from Todd's last submission [2]: 1/ Split out the pure clea

[PATCH v5 2/3] libata: async resume

2014-03-05 Thread Dan Williams
From: Todd Brandt Improve overall system resume time by making libata link recovery actions asynchronous relative to other resume events. Link resume operations are performed using the scsi_eh thread, so commands, particularly the sd resume start/stop command, will be held off until the device e

Re: [PATCH v14 2/3] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-05 Thread Loc Ho
Hi, >> +#define pdata_to_ctx(x) container_of(x, struct xgene_ahci_context, >> plat_data) >> + >> +struct xgene_ahci_context { >> + struct ahci_platform_data plat_data; > > plat_data is used only to get to struct xgene_ahci_context instance > so it can be removed (especially since we want to r

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-03-05 Thread Loc Ho
Hi, >> >> This patch adds function set_speed to the generic PHY framework >> >> operation >> >> structure. This function can be called to instruct the PHY >> >> underlying layer >> >> at specified lane to configure for specified speed in hertz. >> > >> > why ?

Re: Slow I/O performance on SAS1064

2014-03-05 Thread markus
On Wed, Mar 05, 2014 at 10:21:07AM -0800, Mark Knecht wrote: > On Wed, Mar 5, 2014 at 9:50 AM, Markus wrote: > > > > The hdparm result looks like there is somethink not right . There were no > > features supported but why ? > > > Does the HDD have S.M.A.R.T. features? Possibly > > smartctl -

Re: [PATCH 0/6] iser-target: Fix active I/O shutdown related issues

2014-03-05 Thread Nicholas A. Bellinger
On Wed, 2014-03-05 at 14:12 +0200, Sagi Grimberg wrote: > On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote: > > On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote: > >> On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote: > >>> From: Nicholas Bellinger > >>> > >> More on cleanup flow. isert_cm

[PATCH v13 0/3] PHY: Add APM X-Gene SoC 15Gbps Multi-purpose PHY support

2014-03-05 Thread Loc Ho
This patch adds support for APM X-Gene SoC 15Gbps Multi-purpose PHY. This is the physical layer interface for the corresponding host controller. This driver uses the PHY generic framework. v13: * Remove PHY patch for initial version as only Gen3 speed is supported * Remove function xgene_phy_sata_

[PATCH v15 0/3] ata: Add APM X-Gene SoC AHCI SATA host controller support

2014-03-05 Thread Loc Ho
This patch adds support for the APM X-Gene SoC AHCI SATA host controller. In order for the host controller to work, the corresponding PHY driver musts also be available. Currently, only Gen3 disk is supported with this initial version. v15: * Rebase to libata next branch * Remove field plat_data

[PATCH v13 3/3] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-03-05 Thread Loc Ho
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose PHY driver. The PHY for SATA controller 2 and 3 are enabled by default. Signed-off-by: Loc Ho Signed-off-by: Tuan Phan Signed-off-by: Suman Tripathi --- arch/arm64/boot/dts/apm-storm.dtsi | 75 +++

[PATCH v13 1/3] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2014-03-05 Thread Loc Ho
This patch adds the APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation. Signed-off-by: Loc Ho Signed-off-by: Tuan Phan Signed-off-by: Suman Tripathi --- .../devicetree/bindings/phy/apm-xgene-phy.txt | 79 1 files changed, 79 insertions(+), 0 delet

[PATCH v15 1/3] Documentation: Add documentation for the APM X-Gene SoC SATA host controller DTS binding

2014-03-05 Thread Loc Ho
This patch adds documentation for the APM X-Gene SoC SATA host controller DTS binding. Signed-off-by: Loc Ho Signed-off-by: Tuan Phan Signed-off-by: Suman Tripathi --- .../devicetree/bindings/ata/apm-xgene.txt | 70 1 files changed, 70 insertions(+), 0 deletions

[PATCH v15 2/3] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-05 Thread Loc Ho
This patch adds support for the APM X-Gene SoC AHCI SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. This initial version only supports Gen3 speed. Signed-off-by: Loc Ho Signed-off-by: Tuan Phan Signed-off-by: Suman Tripathi --- drivers/ata/Kconfig |

[PATCH v15 3/3] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-03-05 Thread Loc Ho
This patch adds APM X-Gene SoC AHCI SATA host controller DTS entries. Signed-off-by: Loc Ho Signed-off-by: Tuan Phan Signed-off-by: Suman Tripathi --- arch/arm64/boot/dts/apm-storm.dtsi | 75 1 files changed, 75 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH RESEND] SCSI: sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE

2014-03-05 Thread Dan Williams
On Mon, Mar 3, 2014 at 1:25 PM, Daniel Mack wrote: > From: Alan Stern > > Evidently some wacky USB-ATA bridges don't recognize the SYNCHRONIZE > CACHE command, as shown in this email thread: > > http://marc.info/?t=13897835622&r=1&w=2 > > The fact that we can't tell them to drain thei