Re: [PATCH 7/8] target_core_alua: Referrals infrastructure

2013-12-18 Thread Hannes Reinecke
On 12/17/2013 09:06 PM, Nicholas A. Bellinger wrote: > On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: >> Add infrastructure for referrals. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/target/target_core_alua.c | 153 >> ++ >> drivers/targe

Re: [PATCH 8/8] target_core_alua: Referrals configfs integration

2013-12-18 Thread Hannes Reinecke
On 12/17/2013 09:49 PM, Nicholas A. Bellinger wrote: > On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: >> Referrals need an LBA map, which needs to be kept >> consistent across all target port groups. So >> instead of tying the map to the target port groups >> I've implemented a single at

Re: [PATCH 6/8] target_core_spc: Include target device descriptor in VPD page 83

2013-12-18 Thread Hannes Reinecke
On 12/17/2013 09:01 PM, Nicholas A. Bellinger wrote: > On Tue, 2013-12-17 at 11:50 -0800, Nicholas A. Bellinger wrote: >> On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: >>> We should be including a descriptor referring to the target device >>> to allow identification of different TCM ins

[PATCH] pm80xx: Spinlock fix

2013-12-18 Thread Viswas G
>From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 2001 From: Suresh Thiagarajan Date: Mon, 16 Dec 2013 21:15:20 +0530 Subject: [PATCH] pm80xx: Spinlock fix spin_unlock was used instead of spin_unlock_irqrestore. To fix this lock_flags per-adapter is added and used across all the

Re: PROBLEM: special sense code asc,ascq=04h,0Ch abort scsi scan in the middle

2013-12-18 Thread Vaughan Cao
On 2013年10月21日 14:07, vaughan wrote: On 10/16/2013 02:52 PM, Hannes Reinecke wrote: But seeing that this approach raises quite some issues I've attached a different patch. Vaughan, could you test with that, too? Should be functionally equivalent to the previous one. Cheers, Hannes Hi Hannes,

[Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ?

2013-12-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=67091 Alan changed: What|Removed |Added CC||a...@lxorguk.ukuu.org.uk Component|Other

Suspend issues with a LaCie USB hard disk connected

2013-12-18 Thread Daniel Mack
Hi, I'm facing an issue putting an embedded system to sleep while a Lacie external USB hard disk is connected. Relevant kernel messages that occur at the attempt are: [ 13.834731] PM: Sending message for entering DeepSleep mode [ 13.846575] sd 0:0:0:0: [sda] Synchronizing SCSI cache [ 13.85

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-18 Thread Kees Cook
On Tue, Dec 17, 2013 at 9:42 PM, Joe Perches wrote: > On Tue, 2013-12-17 at 10:27 -0800, Kees Cook wrote: >> This makes sure format strings cannot leak into the printk call via the >> constructed buffer. > [] >> diff --git a/drivers/scsi/esas2r/esas2r_log.c >> b/drivers/scsi/esas2r/esas2r_log.c >

[PATCH v2] scsi: esas2r: fix potential format string flaw

2013-12-18 Thread Kees Cook
This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook Acked-by: Bradley Grove --- v2: - add newline via printk instead. --- drivers/scsi/esas2r/esas2r_log.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --g

[PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h

2013-12-18 Thread Rashika Kheria
Move prototype declaration of function spc_parse_naa_6h_vendor_specific() from target_core_xcopy.c to header file target_core_pr.h because it is used by more than one file. This eliminates the following warning in target_core_spc.c: drivers/target/target_core_spc.c:138:6: warning: no previous prot

[PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c

2013-12-18 Thread Rashika Kheria
Mark function iblock_get_write_cache() as static in target_core_iblock.c because it is not used outside this file. This eliminates the following warning in target_core_iblock.c: drivers/target/target_core_iblock.c:766:6: warning: no previous prototype for ‘iblock_get_write_cache’ [-Wmissing-proto

[PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c

2013-12-18 Thread Rashika Kheria
Mark functions tcm_loop_make_naa_tpg(), tcm_loop_drop_naa_tpg(), tcm_loop_make_scsi_hba() and tcm_loop_drop_scsi_hba() as static in loopback/tcm_loop.c because they are not used outside this file. This eliminates the following warning in loopback/tcm_loop.c: drivers/target/loopback/tcm_loop.c:1231

[PATCH 4/4] drivers: target: Mark functions and structures as static in tfc_conf.c

2013-12-18 Thread Rashika Kheria
Mark functions ft_tpg_alloc_fabric_acl(), ft_register_configfs() and ft_deregister_configfs() as static in tcm_fc/tfc_conf.c because they are not used outside this file. This eliminates the following warnings in tcm_fc/tfc_conf.c: drivers/target/tcm_fc/tfc_conf.c:270:21: warning: no previous proto

Re: [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h

2013-12-18 Thread josh
On Wed, Dec 18, 2013 at 11:54:32PM +0530, Rashika Kheria wrote: > Move prototype declaration of function > spc_parse_naa_6h_vendor_specific() from target_core_xcopy.c to header > file target_core_pr.h because it is used by more than one file. > > This eliminates the following warning in target_cor

Re: [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c

2013-12-18 Thread josh
On Wed, Dec 18, 2013 at 11:56:44PM +0530, Rashika Kheria wrote: > Mark function iblock_get_write_cache() as static in target_core_iblock.c > because it is not used outside this file. > > This eliminates the following warning in target_core_iblock.c: > drivers/target/target_core_iblock.c:766:6: war

Re: [PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c

2013-12-18 Thread josh
On Thu, Dec 19, 2013 at 12:02:54AM +0530, Rashika Kheria wrote: > Mark functions tcm_loop_make_naa_tpg(), tcm_loop_drop_naa_tpg(), > tcm_loop_make_scsi_hba() and tcm_loop_drop_scsi_hba() as static in > loopback/tcm_loop.c because they are not used outside this file. > > This eliminates the followi

Re: [PATCH 4/4] drivers: target: Mark functions and structures as static in tfc_conf.c

2013-12-18 Thread josh
On Thu, Dec 19, 2013 at 12:05:59AM +0530, Rashika Kheria wrote: > Mark functions ft_tpg_alloc_fabric_acl(), ft_register_configfs() and > ft_deregister_configfs() as static in tcm_fc/tfc_conf.c because they are > not used outside this file. > > This eliminates the following warnings in tcm_fc/tfc_c

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread Sarah Sharp
On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > This set should fix our target problems with USB by making the target > visibility properly reference counted. Since it's a major change to the > infrastructure, we'll incubate upstream first before backporting to > stable. > > Ja

Re: Suspend issues with a LaCie USB hard disk connected

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Daniel Mack wrote: > Hi, > > I'm facing an issue putting an embedded system to sleep while a Lacie > external USB hard disk is connected. Relevant kernel messages that occur > at the attempt are: > > [ 13.834731] PM: Sending message for entering DeepSleep mode > [ 13.846

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Sarah Sharp wrote: > On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > > This set should fix our target problems with USB by making the target > > visibility properly reference counted. Since it's a major change to the > > infrastructure, we'll incubate upstr

Re: randconfig build error with next-20131218, in drivers/target/target_core_alua.c

2013-12-18 Thread Nicholas A. Bellinger
Hi Jim, On Wed, 2013-12-18 at 06:45 -0700, Jim Davis wrote: > Building with the attached random configuration file, > > LD init/built-in.o > drivers/built-in.o: In function `core_alua_state_lba_dependent': > /home/jim/linux/drivers/target/target_core_alua.c:492: undefined > reference to `_

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread James Bottomley
On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: > On Wed, 18 Dec 2013, Sarah Sharp wrote: > > > On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > > > This set should fix our target problems with USB by making the target > > > visibility properly reference counted. Since it's

Re: [PATCH 1/4] drivers: target: Move prototype declaration of function to header file target_core_pr.h

2013-12-18 Thread Nicholas A. Bellinger
On Wed, 2013-12-18 at 23:54 +0530, Rashika Kheria wrote: > Move prototype declaration of function > spc_parse_naa_6h_vendor_specific() from target_core_xcopy.c to header > file target_core_pr.h because it is used by more than one file. > > This eliminates the following warning in target_core_spc.c

Re: [PATCH 4/4] drivers: target: Mark functions and structures as static in tfc_conf.c

2013-12-18 Thread Nicholas A. Bellinger
On Thu, 2013-12-19 at 00:05 +0530, Rashika Kheria wrote: > Mark functions ft_tpg_alloc_fabric_acl(), ft_register_configfs() and > ft_deregister_configfs() as static in tcm_fc/tfc_conf.c because they are > not used outside this file. > > This eliminates the following warnings in tcm_fc/tfc_conf.c:

Re: [PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c

2013-12-18 Thread Nicholas A. Bellinger
On Thu, 2013-12-19 at 00:02 +0530, Rashika Kheria wrote: > Mark functions tcm_loop_make_naa_tpg(), tcm_loop_drop_naa_tpg(), > tcm_loop_make_scsi_hba() and tcm_loop_drop_scsi_hba() as static in > loopback/tcm_loop.c because they are not used outside this file. > > This eliminates the following warn

Re: [PATCH 2/4] drivers: target: Mark function as static in target_core_iblock.c

2013-12-18 Thread Nicholas A. Bellinger
On Wed, 2013-12-18 at 23:56 +0530, Rashika Kheria wrote: > Mark function iblock_get_write_cache() as static in target_core_iblock.c > because it is not used outside this file. > > This eliminates the following warning in target_core_iblock.c: > drivers/target/target_core_iblock.c:766:6: warning: n

Re: [PATCH 8/8] target_core_alua: Referrals configfs integration

2013-12-18 Thread Nicholas A. Bellinger
On Wed, 2013-12-18 at 09:15 +0100, Hannes Reinecke wrote: > On 12/17/2013 09:49 PM, Nicholas A. Bellinger wrote: > > On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: > >> Referrals need an LBA map, which needs to be kept > >> consistent across all target port groups. So > >> instead of tyi

Re: [PATCH 8/8] target_core_alua: Referrals configfs integration

2013-12-18 Thread Hannes Reinecke
On 12/19/2013 07:25 AM, Nicholas A. Bellinger wrote: > On Wed, 2013-12-18 at 09:15 +0100, Hannes Reinecke wrote: >> On 12/17/2013 09:49 PM, Nicholas A. Bellinger wrote: >>> On Tue, 2013-12-17 at 09:18 +0100, Hannes Reinecke wrote: Referrals need an LBA map, which needs to be kept consiste

Re: [Bug 67091] scsi/be2iscsi/be_main.c:328: possible bad if expression ?

2013-12-18 Thread Mike Christie
On 12/18/2013 08:24 AM, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=67091 > > Alan changed: > >What|Removed |Added > > CC