Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/17/2013 01:43 AM, James Bottomley wrote: > OK, so three people have now told you that's not how the code > works. Why don't you just read it? because there's not really much > point us reading your patches until you do. I have, which is why I

[PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan G. Bem
This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. Signed-off-by: Geyslan G. Bem --- drivers/scsi/be2iscsi/be_iscsi.c | 41 +--- 1 file changed, 22 insertions(+),

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when > necessary. You pointlessly renamed a variable, which makes the diff hard to read. Please don't do

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley : > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and >> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when >> necessary. > > You pointlessly renamed a variable, which makes th

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > 2013/11/17 James Bottomley : > > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > >> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' wh

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread Douglas Gilbert
On 13-11-17 11:15 AM, Phillip Susi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/17/2013 01:43 AM, James Bottomley wrote: OK, so three people have now told you that's not how the code works. Why don't you just read it? because there's not really much point us reading your patche

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 11:15 -0500, Phillip Susi wrote: > On 11/17/2013 01:43 AM, James Bottomley wrote: > > OK, so three people have now told you that's not how the code > > works. Why don't you just read it? because there's not really much > > point us reading your patches until you do. > > I ha

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/17/2013 06:54 PM, Douglas Gilbert wrote: > Even if the SCSI EH code does spin-up the disk, it is inefficient > and undesirable to send a device into EH for what is a normal, > predictable situation (i.e. that a SCSI disk will need a START STOP

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/17/2013 07:09 PM, James Bottomley wrote: > Because you don't damn well listen. Two emails ago I said: > > The error handler is not automatically activated for a not > ready/initializing command required because of multi-path And I replied t

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley : > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: >> 2013/11/17 James Bottomley : >> > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >> >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and >> >> 'ISCSI_NET_PARAM_VLAN_PRIORITY

RE: Question on SCSI target scan

2013-11-17 Thread Ramesh Chikkanayakanahally
Thanks for the response. If using RSCN sounds like a reasonable approach in this scenario (protocol limitations), then as per the original question - would it be acceptable to add an interface in scsi_transport_fc layer, which can be invoked on receiving RSCN to trigger SCSI target re-scan (

Re: [RFC] drivers/scsi/dc395x.c - msgin_qtag()

2013-11-17 Thread Oliver Neukum
On Fri, 2013-11-15 at 17:53 -0200, Geyslan Gregório Bem wrote: Hi, > Hi guys, > > In the function msgin_qtag() [line 2632], this dereference was intentional? > > static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb, > struct DeviceCtlBlk *dcb, u8 tag) > { > struct ScsiReqB