Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

2013-10-29 Thread Jack Wang
Hi Viswas, As ioctl interface is not welcome for new feature, that's why we removed ioctl interface when pm8001 accepted into mainline. I suggest you use bsg interface for this, see sas_host_smp.c for details. Regards, Jack On 10/22/2013 02:20 PM, Viswas G wrote: > > Signed-off-by: Viswas G >

Re: [SCSI] sr: sr_mutex ,multi-drive performance is bad

2013-10-29 Thread yang jun
Dear Mr.Meta I saw your patch about sr_module, I very curious why the latest kernel still keep sr_mutex. Can sr_mutex be deleted just like sd_module? Yours Sincerely 2013/10/28 yang jun : > Dear Mr.Axboe, > > The latest kernel sr_module still uses single mutex,it will serialise > all sr ioctls.

Re: [SCSI] sr: sr_mutex ,multi-drive performance is bad

2013-10-29 Thread yang jun
Dear Mr.Meta I saw your patch about sr_module, I very curious why the latest kernel still keep sr_mutex. Can sr_mutex be deleted just like sd_module? Yours Sincerely 2013/10/28 yang jun : > Dear Mr.Axboe, > > The latest kernel sr_module still uses single mutex,it will serialise > all sr ioctls.

Re: [SCSI] sr: sr_mutex ,multi-drive performance is bad

2013-10-29 Thread Jens Axboe
On 10/28/2013 08:30 AM, yang jun wrote: > Dear Mr.Axboe, > > The latest kernel sr_module still uses single mutex,it will serialise > all sr ioctls. Otto Meta had mentioned this on Jan 1st, 2013 . Some > record tools such as growisofs use SG_IO to write data to disc, so if > there are multiple cdro

arcmsr driver update

2013-10-29 Thread Markus Blank-Burian
Dear all, two month ago, there was a patch submitted by the company areca regarding their in-kernel driver: "[PATCH v1.2 1/1] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284" This patch fixes (among other things) a major bug which forces a hardware reset on the adapter (1882 in

Re: arcmsr driver update

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 16:14 +0100, Markus Blank-Burian wrote: > Dear all, > > two month ago, there was a patch submitted by the company areca > regarding their in-kernel driver: > "[PATCH v1.2 1/1] arcmsr: Support Areca new SATA Raid Adapter > ARC1214/1224/1264/1284" The patch never made it to th

Re: [PATCH] [SCSI] hpsa: fix return value check in start_controller_lockup_detector()

2013-10-29 Thread scameron
On Tue, Oct 29, 2013 at 02:43:56PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function kthread_run() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun > --- > drive

[PATCH] hpsa: return 0 from driver probe function on success, not 1

2013-10-29 Thread Stephen M. Cameron
From: Stephen M. Cameron A return value of 1 is interpreted as an error Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 891c86b..3c97974 100644 --- a/drivers/scsi

[patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread Dan Carpenter
If "fibsize" is zero then it leads to a ZERO_SIZE_PTR dereference when we dereference user_srbcmd. Due to a missing capable() check in the compat ioctls then this error can be triggered without CAP_SYS_RAWIO. I have fixed that in a separate patch. Reported-by: Nico Golde Reported-by: Fabian Yam

[patch] [SCSI] aacraid: missing capable() check in compat ioctl

2013-10-29 Thread Dan Carpenter
In d496f94d22d1 ('[SCSI] aacraid: fix security weakness') we added a check on CAP_SYS_RAWIO to the ioctl. The compat ioctls need the check as well. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 408a42e..f0d432c 100644 --- a/drivers/s

Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

2013-10-29 Thread Joseph Salisbury
Hi Martin, A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d Author: Martin K. Petersen Date: Thu Jun 6 22:15:55 2013 -0400 [SCSI] sd: Update WRITE SAME

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 22:10 +0300, Dan Carpenter wrote: > If "fibsize" is zero then it leads to a ZERO_SIZE_PTR dereference when > we dereference user_srbcmd. > > Due to a missing capable() check in the compat ioctls then this error > can be triggered without CAP_SYS_RAWIO. I have fixed that in a

Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

2013-10-29 Thread Douglas Gilbert
On 13-10-29 03:21 PM, Joseph Salisbury wrote: Hi Martin, A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d Author: Martin K. Petersen Date: Thu Jun 6 22:15

Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

2013-10-29 Thread Bernd Schubert
Hello Joseph, On 10/29/2013 08:21 PM, Joseph Salisbury wrote: Hi Martin, A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d Author: Martin K. Petersen Date:

Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

2013-10-29 Thread Joseph Salisbury
On 10/29/2013 03:46 PM, Bernd Schubert wrote: > Hello Joseph, > > On 10/29/2013 08:21 PM, Joseph Salisbury wrote: >> Hi Martin, >> >> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, >> it was found that reverting the following commit resolved this bug: >> >> commit 66c28f9712

Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

2013-10-29 Thread Joseph Salisbury
On 10/29/2013 03:41 PM, Douglas Gilbert wrote: > On 13-10-29 03:21 PM, Joseph Salisbury wrote: >> Hi Martin, >> >> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect, >> it was found that reverting the following commit resolved this bug: >> >> commit 66c28f97120e8a621afd5aa7a31c4

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread Linus Torvalds
On Tue, Oct 29, 2013 at 12:10 PM, Dan Carpenter wrote: > If "fibsize" is zero then it leads to a ZERO_SIZE_PTR dereference when > we dereference user_srbcmd. Btw, these "ZERO_SIZE_PTR dereference" issues aren't about ZERO_SIZE_PTR, they are about overrunning the allocations. The ZERO_SIZE_PTR poi

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread Dan Carpenter
You and James are right. It should be checking against the sizeof(). I will send a v2 tomorrow. Sorry about that. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread Linus Torvalds
On Tue, Oct 29, 2013 at 1:06 PM, Dan Carpenter wrote: > You and James are right. It should be checking against the sizeof(). > I will send a v2 tomorrow. Sorry about that. Looking some more at this, I have to say that I absolutely detest those aacraid structures. And I'm not sure that sizeof()

Re: [PATCH] [SCSI] hpsa: fix return value check in start_controller_lockup_detector()

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 11:09 -0500, scame...@beardog.cce.hp.com wrote: > On Tue, Oct 29, 2013 at 02:43:56PM +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function kthread_run() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value check > >

Re: [PATCH 1/3] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic

2013-10-29 Thread Mike Christie
Patches 1-3 look ok to me. Signed-off-by: Mike Christie > On Oct 27, 2013, at 9:23 AM, "Or Gerlitz" wrote: > > From: Shlomo Pongratz > > Restructure the iscsi_tcp_r2t_rsp routine in order to avoid allocating > r2t from r2tpool.queue and returning it back in case the parameters > rhdr->data