The former minimum valid value of 'eh_deadline' is 1s, which means
the earliest occasion to shorten EH is 1 second later since a
command is failed or timed out. But if we want to skip EH steps
ASAP, we have to wait until the first EH step is finished. If the
duration of the first EH step is long, t
Hi Aaron,
I found a race condition with the block layer runtime PM due to which
the q->nr_pending is decremented to less than zero (0x_ (-1))
and hence the blk pre-runtime suspend always returns -EBUSY.
The issue is easily reproduced with a scsi disk with disabled tagged
command queuing
> Hi Aaron,
>
> I found a race condition with the block layer runtime PM due to which
> the q->nr_pending is decremented to less than zero (0x_ (-1))
> and hence the blk pre-runtime suspend always returns -EBUSY.
>
>
> The issue is easily reproduced with a scsi disk with disabled tagged
> c
On 10/09/2013 09:43 AM, Ren Mingxin wrote:
The former minimum valid value of 'eh_deadline' is 1s, which means
the earliest occasion to shorten EH is 1 second later since a
command is failed or timed out. But if we want to skip EH steps
ASAP, we have to wait until the first EH step is finished. If
On 10/09/2013 04:32 PM, sthu...@codeaurora.org wrote:
>> Hi Aaron,
>>
>> I found a race condition with the block layer runtime PM due to which
>> the q->nr_pending is decremented to less than zero (0x_ (-1))
>> and hence the blk pre-runtime suspend always returns -EBUSY.
>>
>>
>> The issue
There are only two bar memeory got ioremap ,when triggering pm8001_phy_control
got the following Oops
BUG: unable to handle kernel paging request at 1034
IP: [] pm8001_phy_control+0x1e6/0x2a0 [pm80xx]
PGD 16bf1f067 PUD 231368067 PMD 0
Oops: [#1] SMP
last sysfs file:
/sys/devices/p
On Wed, 2013-10-09 at 15:43 +0800, Ren Mingxin wrote:
> The former minimum valid value of 'eh_deadline' is 1s, which means
> the earliest occasion to shorten EH is 1 second later since a
> command is failed or timed out. But if we want to skip EH steps
> ASAP, we have to wait until the first EH ste
On Mon, Oct 07, 2013 at 02:01:11PM -0400, Tejun Heo wrote:
> Hmmm... yean, the race condition could be an issue as multiple msi
> allocation might fail even if the driver can and explicitly handle
> multiple allocation if the quota gets reduced inbetween.
BTW, should we care about the quota gettin
Hello,
On Tue, Oct 08, 2013 at 02:22:16PM +0200, Alexander Gordeev wrote:
> If we talk about pSeries quota, then the current pSeries pci_enable_msix()
> implementation is racy internally and could fail if the quota went down
> *while* pci_enable_msix() is executing. In this case the loop will have
Hello,
On Wed, Oct 09, 2013 at 02:57:16PM +0200, Alexander Gordeev wrote:
> On Mon, Oct 07, 2013 at 02:01:11PM -0400, Tejun Heo wrote:
> > Hmmm... yean, the race condition could be an issue as multiple msi
> > allocation might fail even if the driver can and explicitly handle
> > multiple allocati
On Mon, Oct 07, 2013 at 09:48:01PM +0100, Ben Hutchings wrote:
> > There is one major flaw in min-max approach - the generic MSI layer
> > will have to take decisions on exact number of MSIs to request, not
> > device drivers.
> [...
>
> No, the min-max functions should be implemented using the sa
Hello, Alexander.
On Tue, Oct 08, 2013 at 09:48:26AM +0200, Alexander Gordeev wrote:
> > If there are many which duplicate the above pattern, it'd probably be
> > worthwhile to provide a helper? It's usually a good idea to reduce
> > the amount of boilerplate code in drivers.
>
> I wanted to lim
Hello,
On Tue, Oct 08, 2013 at 11:07:16AM +0200, Alexander Gordeev wrote:
> Multipe MSIs is just a handful of drivers, really. MSI-X impact still
Yes, so it's pretty nice to try out things there before going full-on.
> will be huge. But if we opt a different name for the new pci_enable_msix()
>
Hi nab, please apply.
Changes from v1:
- Drop #4, whose value was debatable
- Add hch reviewed-by's
-- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
Just a dereference, don't need a macro.
Reviewed-by: Christoph Hellwig
Signed-off-by: Andy Grover
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 20 ++--
drivers/scsi/qla2xxx/tcm_qla2xxx.h |2 --
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/qla2x
These just want to return a pointer instead of a value, but are otherwise
the same.
ISCSI_TPG_LUN macro was unused.
Reviewed-by: Christoph Hellwig
Signed-off-by: Andy Grover
---
drivers/target/iscsi/iscsi_target.c |2 +-
drivers/target/iscsi/iscsi_target_auth.c |2 +-
drivers/ta
These are all straightforward.
Reviewed-by: Christoph Hellwig
Signed-off-by: Andy Grover
---
drivers/target/iscsi/iscsi_target_configfs.c | 42 +-
drivers/target/iscsi/iscsi_target_core.h |9 -
drivers/target/iscsi/iscsi_target_nego.c |8 ++--
drive
Remove a lingering macro that just hid a dereference.
Reviewed-by: Christoph Hellwig
Signed-off-by: Andy Grover
---
Documentation/target/tcm_mod_builder.py | 18 ++--
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 36
drivers/target/iscsi/iscsi_target_c
Hi folks,
Just a heads up that the scsi-mq alpha branch has been updated to Jen's
latest linux-block/new-queue containing hch's recent blk-mq
improvements, along with Alexander's patch for the is_flush_fua +
queue_depth=1 bug.
The branch @ v3.12-rc3 is available here:
https://git.kernel.org/cgit
On Wed, 2013-10-09 at 11:05 -0700, Andy Grover wrote:
> Hi nab, please apply.
>
> Changes from v1:
> - Drop #4, whose value was debatable
> - Add hch reviewed-by's
>
Applied to target-pending/for-next.
Thanks,
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
On Wed, Oct 09, 2013 at 12:12:51PM -0700, Nicholas A. Bellinger wrote:
> Just a heads up that the scsi-mq alpha branch has been updated to Jen's
> latest linux-block/new-queue containing hch's recent blk-mq
> improvements, along with Alexander's patch for the is_flush_fua +
> queue_depth=1 bug.
O
On Wed, 2013-10-09 at 21:46 +0200, Alexander Gordeev wrote:
> On Wed, Oct 09, 2013 at 12:12:51PM -0700, Nicholas A. Bellinger wrote:
> > Just a heads up that the scsi-mq alpha branch has been updated to Jen's
> > latest linux-block/new-queue containing hch's recent blk-mq
> > improvements, along wi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
I have been trying out the new block layer runtime pm, and run into a
problem: udisks keeps waking up the disk. Every 10 minutes it tries
to poll the SMART status of the drive, but it does first issue an ata
CHECK POWER command to see if it is in st
On 10/10/2013 09:40 AM, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> I have been trying out the new block layer runtime pm, and run into a
> problem: udisks keeps waking up the disk. Every 10 minutes it tries
> to poll the SMART status of the drive, but it does firs
> On 10/09/2013 04:32 PM, sthu...@codeaurora.org wrote:
>>> Hi Aaron,
>>>
>>> I found a race condition with the block layer runtime PM due to which
>>> the q->nr_pending is decremented to less than zero (0x_ (-1))
>>> and hence the blk pre-runtime suspend always returns -EBUSY.
>>>
>>>
>>>
Sujit has found a race condition that would make q->nr_pending
unbalanced, it occurs as Sujit explained:
"
sd_probe_async() ->
add_disk() ->
disk_add_event() ->
schedule(disk_events_workfn)
sd_revalidate_disk()
blk_pm_runtime_init()
r
We are European Loan service,Do you need a Loan,contact Via
(europanl...@foxmail.com)
This message was sent using IMP, the Internet Messaging Program.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
27 matches
Mail list logo
