Re: [GIT PULL] target updates for v3.12-rc1

2013-09-13 Thread joel billy
On 9/13/13, Nicholas A. Bellinger wrote: <..>, Removed individual CCs > The patches to add COMPARE_AND_WRITE and EXTENDED_COPY support are of > particular significance, which make us the first and only open source > target to support the full set of VAAI primitives. Probably not the first and on

[PATCH v3 5/6] uas: replace BUG_ON() + WARN_ON() with WARN_ON_ONCE()

2013-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index f049038..046eedf 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @

[PATCH v3 3/6] uas: make work list per-device

2013-09-13 Thread Gerd Hoffmann
Simplifies locking, we'll protect the list with the device spin lock. Also plugs races which can happen when two devices operate on the global list. While being at it rename the list head from "list" to "work", preparing for the addition of a second list. Signed-off-by: Gerd Hoffmann --- driver

[PATCH v3 2/6] uas: properly reinitialize in uas_eh_bus_reset_handler

2013-09-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index d966b59..fc08ee9 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -85,6 +85,8 @@ static int uas_

[PATCH v3 4/6] uas: add dead request list

2013-09-13 Thread Gerd Hoffmann
This patch adds a new list where all requests which are canceled are added to, so we don't loose them. Then, after killing all inflight urbs on bus reset (and disconnect) we'll walk over the list and clean them up. Without this we can end up with aborted requests lingering around in case of statu

[PATCH] scsi, aic94xx Fix uninitialized warning

2013-09-13 Thread Prarit Bhargava
Fix uninitialized warning. drivers/scsi/aic94xx/aic94xx_sds.c: In function ‘asd_process_ctrl_a_user’: drivers/scsi/aic94xx/aic94xx_sds.c:597:21: error: ‘offs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] asd_read_reg_string(asd_ha, buffer, asd_ha->hw_prof.flash.bar+o

[PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread Andy Whitcroft
tl;dr -- enable TRIM support for Hyper-V emulated disks. The Hyper-V hypervisor can support TRIM for its devices, advertising this via the appropriate VPD pages. However the emulated disks only claim to be SPC-2 devices. According to the specs VPD pages (in general) did exist at SPC-2 but the sp

[PATCH 4/4] scsi: hyper-v storage -- mark as preferring READ CAPACITY (16) at SPC-2

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 14ba8fd..25e7dd5 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scs

[PATCH 1/4] scsi: add scsi device flag to request VPD pages be used at SPC-2

2013-09-13 Thread Andy Whitcroft
Under Hyper-V the disk devices support the trim extensions advertising them via the appropriate VPD pages, it however reports itself as SPC-2 only. The relevant pages were added in SPC-3 and later, so we do not even attempt to see if they are present; the VPD page 0 lists which other pages are pres

[PATCH 2/4] scsi: add scsi device flag to request READ CAPACITY (16) be preferred

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/sd.c | 2 ++ include/scsi/scsi_device.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 5a8a04d..eba4d6c 100644 --- a/drivers/scsi/sd.c +++ b/d

[PATCH 3/4] scsi: hyper-v storage -- mark as VPD capable at SPC-2

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 1a28f56..14ba8fd 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scs

Re: Ejected Nook (usb mass storage) prevents suspend

2013-09-13 Thread Andy Lutomirski
What's the status of this? Do I still need to test it? I won't have access to the Nook that triggered it the first time for a couple weeks, but I could try to find another device like that. --Andy On Fri, Aug 2, 2013 at 7:18 AM, Alan Stern wrote: > On Fri, 2 Aug 2013, Oliver Neukum wrote: > >>

Re: [PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread James Bottomley
On Fri, 2013-09-13 at 13:58 +0100, Andy Whitcroft wrote: > tl;dr -- enable TRIM support for Hyper-V emulated disks. > > The Hyper-V hypervisor can support TRIM for its devices, advertising this > via the appropriate VPD pages. However the emulated disks only claim > to be SPC-2 devices. Accordin

Re: Ejected Nook (usb mass storage) prevents suspend

2013-09-13 Thread Oliver Neukum
On Fri, 2013-09-13 at 06:37 -0700, Andy Lutomirski wrote: > What's the status of this? Do I still need to test it? > > I won't have access to the Nook that triggered it the first time for a > couple weeks, but I could try to find another device like that. It works for me. I'll push upstream in a

Re: [PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread Andy Whitcroft
On Fri, Sep 13, 2013 at 07:57:58AM -0700, James Bottomley wrote: > This is an awful lot of contortions (which don't seem to have any other > users on the horizon) to support a device that's not standards > compliant. What about this, it's simple, it does the right thing and > it's contained in th

Re: [PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread Douglas Gilbert
On 13-09-13 08:58 AM, Andy Whitcroft wrote: tl;dr -- enable TRIM support for Hyper-V emulated disks. The Hyper-V hypervisor can support TRIM for its devices, advertising this via the appropriate VPD pages. However the emulated disks only claim to be SPC-2 devices. According to the specs VPD pa

Re: [PATCH] SCSI: buslogic: Added check for DMA mapping errors (was Re:[BusLogic] DMA-API: device driver failed to check map error)

2013-09-13 Thread Tetsuo Handa
Khalid Aziz wrote: > Added check for DMA mapping errors for request sense data > buffer. Checking for mapping error can avoid potential wild > writes. This patch was prompted by the warning from > dma_unmap when kernel is compiled with CONFIG_DMA_API_DEBUG. This patch fixes CONFIG_DMA_API_DEBUG wa

Re: [PATCH] SCSI: buslogic: Added check for DMA mapping errors (was Re:[BusLogic] DMA-API: device driver failed to check map error)

2013-09-13 Thread Khalid Aziz
On 09/13/2013 09:42 AM, Tetsuo Handa wrote: Khalid Aziz wrote: Added check for DMA mapping errors for request sense data buffer. Checking for mapping error can avoid potential wild writes. This patch was prompted by the warning from dma_unmap when kernel is compiled with CONFIG_DMA_API_DEBUG.

[PATCH] megaraid: Use resource_size_t for PCI resources, not long

2013-09-13 Thread Ben Collins
The assumption that sizeof(long) >= sizeof(resource_size_t) can lead to truncation of the PCI resource address, meaning this driver didn't work on 32-bit systems with 64-bit PCI adressing ranges. Signed-off-by: Ben Collins Cc: Sumit Saxena Cc: DL-MegaRAID Linux --- drivers/scsi/megaraid/megara

RE: [PATCH] megaraid: Use resource_size_t for PCI resources, not long

2013-09-13 Thread Saxena, Sumit
>-Original Message- >From: Ben Collins [mailto:be...@servergy.com] >Sent: Friday, September 13, 2013 10:17 PM >To: linux-scsi >Cc: Saxena, Sumit; DL-MegaRAID Linux >Subject: [PATCH] megaraid: Use resource_size_t for PCI resources, not >long > >The assumption that sizeof(long) >= sizeof(re

[PATCH v2] SCSI: buslogic: Added check for DMA mapping errors (was Re:[BusLogic] DMA-API: device driver failed to check map error)

2013-09-13 Thread Khalid Aziz
Added check for DMA mapping errors for request sense data buffer. Checking for mapping error can avoid potential wild writes. This patch was prompted by the warning from dma_unmap when kernel is compiled with CONFIG_DMA_API_DEBUG. Signed-off-by: Khalid Aziz --- Changelog: v1 - Fixed a typo and

[PATCH 1/1] scsi:aic7xxx_old: fix: add missing enum ahc_chip entries

2013-09-13 Thread Antonio Alecrim Jr
Due to this missing enum entries some switch cases have unreached conditions: drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] Signed-off-by: Antonio Alecrim Jr --- drivers/scsi/

[PATCH 1/1] [SCSI] scsi_debug: add missing csum var initialization

2013-09-13 Thread Antonio Alecrim Jr
Removes the warning: include/uapi/linux/swab.h:106:23: warning: ‘csum’ may be used uninitialized in this function Signed-off-by: Antonio Alecrim Jr --- drivers/scsi/scsi_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debu

[patch 3/5] drivers/scsi/dmx3191d.c: convert to module_pci_driver

2013-09-13 Thread akpm
From: Libo Chen Subject: drivers/scsi/dmx3191d.c: convert to module_pci_driver Signed-off-by: Libo Chen Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/dmx3191d.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff -puN drivers/scsi/dmx3191d.c~drive

[patch 1/5] drivers/scsi/a100u2w.c: convert to module_pci_driver

2013-09-13 Thread akpm
From: Libo Chen Subject: drivers/scsi/a100u2w.c: convert to module_pci_driver Use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/a100u2w.c | 12 +--- 1 file changed, 1 insertion(+)

[patch 5/5] drivers/scsi/mvumi.c: convert to module_pci_driver

2013-09-13 Thread akpm
From: Libo Chen Subject: drivers/scsi/mvumi.c: convert to module_pci_driver Signed-off-by: Libo Chen Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/mvumi.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff -puN drivers/scsi/mvumi.c~drivers-

[patch 4/5] drivers/scsi/initio.c: convert to module_pci_driver

2013-09-13 Thread akpm
From: Libo Chen Subject: drivers/scsi/initio.c: convert to module_pci_driver Signed-off-by: Libo Chen Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/initio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff -puN drivers/scsi/initio.c~drivers-scs

[patch 2/5] drivers/scsi/dc395x.c: convert to module_pci_driver

2013-09-13 Thread akpm
From: Libo Chen Subject: drivers/scsi/dc395x.c: convert to module_pci_driver Signed-off-by: Libo Chen Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/dc395x.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff -puN drivers/scsi/dc395x.c~

Re: [patch 1/5] drivers/scsi/a100u2w.c: convert to module_pci_driver

2013-09-13 Thread James Bottomley
On Fri, 2013-09-13 at 14:52 -0700, a...@linux-foundation.org wrote: > From: Libo Chen > Subject: drivers/scsi/a100u2w.c: convert to module_pci_driver > > Use module_pci_driver instead of init/exit, make code clean. To be honest, I don't really agree that any of these patches add value. Sure, for

Re: [PATCH v2] SCSI: buslogic: Added check for DMA mapping errors (wasRe:[BusLogic] DMA-API: device driver failed to check map error)

2013-09-13 Thread Tetsuo Handa
Khalid Aziz wrote: > Added check for DMA mapping errors for request sense data > buffer. Checking for mapping error can avoid potential wild > writes. This patch was prompted by the warning from > dma_unmap when kernel is compiled with CONFIG_DMA_API_DEBUG. This patch looks OK and works OK to me.