Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-08-12 Thread Subhash Jadavani
On 7/30/2013 6:32 PM, Seungwon Jeon wrote: On Mon, July 29, 2013, Sujit Reddy Thumma wrote: On 7/29/2013 11:47 AM, Subhash Jadavani wrote: On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It m

Re: [PATCH V5 0/4] scsi: ufs: Improve UFS error handling

2013-08-12 Thread Dolev Raviv
Hi, I tested the new set of patches (V5 1-4) and it works. Thanks, Dolev > The first patch fixes many issues with current task management handling > in UFSHCD driver. Others improve error handling in various scenarios. > > These patches are rebased on: > [PATCH 9/9] drivers/scsi/ufs: don't check

Re: [PATCH V5 2/4] scsi: ufs: Fix hardware race conditions while aborting a command

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv > There is a possible race condition in the hardware when the abort > command is issued to terminate the ongoing SCSI command as described > below: > > - A bit in the door-bell register is set in the controller for a > new SCSI command. > - In some rare situations, before

Re: [PATCH V5 1/4] scsi: ufs: Fix broken task management command implementation

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv > Currently, sending Task Management (TM) command to the card might > be broken in some scenarios as listed below: > > Problem: If there are more than 8 TM commands the implementation > returns error to the caller. > Fix: Wait for one of the slots to be emptied

Re: [PATCH V5 3/4] scsi: ufs: Fix device and host reset methods

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv > As of now SCSI initiated error handling is broken because, > the reset APIs don't try to bring back the device initialized and > ready for further transfers. > > In case of timeouts, the scsi error handler takes care of handling aborts > and resets. Improve the error hand

Re: [PATCH V5 4/4] scsi: ufs: Improve UFS fatal error handling

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv > Error handling in UFS driver is broken and resets the host controller > for fatal errors without re-initialization. Correct the fatal error > handling sequence according to UFS Host Controller Interface (HCI) > v1.1 specification. > > o Processed requests which are comple

Re: [PATCH] hpsa: fix warning with smp_processor_id() in preemptible

2013-08-12 Thread Sebastian Andrzej Siewior
* John Kacur | 2013-07-26 16:42:30 [+0200]: >Signed-off-by: John Kacur >Acked-by: Stephen ping. I checked the branches for-next, scsi-fixes, fixes and misc at [0] and I didn't see it. I'm going to take this for 3.10-rt but please don't lose it on its way to Linus :) [0] git://git.kernel.org/p

Re: [PATCH] hpsa: fix warning with smp_processor_id() in preemptible

2013-08-12 Thread John Kacur
- Original Message - > * John Kacur | 2013-07-26 16:42:30 [+0200]: > > >Signed-off-by: John Kacur > >Acked-by: Stephen > > ping. > > I checked the branches for-next, scsi-fixes, fixes and misc at [0] and I > didn't see it. I'm going to take this for 3.10-rt but please don't lose > it

Re: [PATCH] hpsa: fix warning with smp_processor_id() in preemptible

2013-08-12 Thread scameron
On Mon, Aug 12, 2013 at 09:33:32AM -0400, John Kacur wrote: > > > - Original Message - > > * John Kacur | 2013-07-26 16:42:30 [+0200]: > > > > >Signed-off-by: John Kacur > > >Acked-by: Stephen > > > > ping. > > > > I checked the branches for-next, scsi-fixes, fixes and misc at [0] an

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-12 Thread Alexander Gordeev
On Fri, Aug 09, 2013 at 11:07:37AM -0600, Jens Axboe wrote: > You don't have to resubmit, I'll get it reviewed and applied today. Hi Jens, I limited the minimal queue depth to 4, which is apparently wrong in case of libata. I will post a new series. > -- > Jens Axboe > -- Regards, Alexander

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-08-12 Thread vaughan
On 08/06/2013 04:52 AM, Douglas Gilbert wrote: > On 13-08-04 10:19 PM, vaughan wrote: >> On 08/03/2013 01:25 PM, Douglas Gilbert wrote: >>> On 13-08-01 01:01 AM, Douglas Gilbert wrote: On 13-07-22 01:03 PM, Jörn Engel wrote: > On Mon, 22 July 2013 12:40:29 +0800, Vaughan Cao wrote: >>

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-08-12 Thread Douglas Gilbert
On 13-08-12 10:46 PM, vaughan wrote: On 08/06/2013 04:52 AM, Douglas Gilbert wrote: On 13-08-04 10:19 PM, vaughan wrote: On 08/03/2013 01:25 PM, Douglas Gilbert wrote: On 13-08-01 01:01 AM, Douglas Gilbert wrote: On 13-07-22 01:03 PM, Jörn Engel wrote: On Mon, 22 July 2013 12:40:29 +0800, Va

Re: [PATCH 4/7] scsi: ufs: add dme configuration primitives

2013-08-12 Thread Subhash Jadavani
On 7/30/2013 6:32 PM, Seungwon Jeon wrote: On Mon, July 29, 2013, Subhash Jadavani wrote: On 7/26/2013 7:17 PM, Seungwon Jeon wrote: Implements to support GET and SET operations of the DME. These operations are used to configure the behavior of the UNIPRO. Along with basic operation, {Peer/Attr