On 06/30/13 23:05, David Dillow wrote:
On Fri, 2013-06-28 at 14:53 +0200, Bart Van Assche wrote:
+int srp_tmo_valid(int fast_io_fail_tmo, int dev_loss_tmo)
+{
+ return (fast_io_fail_tmo < 0 || dev_loss_tmo < 0 ||
+ fast_io_fail_tmo < dev_loss_tmo) &&
+ fast_io_f
On Thu, 2013-06-27 at 16:53 +0200, Bart Van Assche wrote:
> If something goes wrong during LUN scanning, e.g. a transport layer
> failure occurs, then __scsi_remove_device() can get invoked by the
> LUN scanning code for a SCSI device in state SDEV_CREATED_BLOCK. If
> this happens then the SCSI de
On 07/01/13 09:05, James Bottomley wrote:
On Thu, 2013-06-27 at 16:53 +0200, Bart Van Assche wrote:
If something goes wrong during LUN scanning, e.g. a transport layer
failure occurs, then __scsi_remove_device() can get invoked by the
LUN scanning code for a SCSI device in state SDEV_CREATED_BL
When a medium error is detected the SCSI stack should return
ENODATA to the upper layers.
Signed-off-by: Hannes Reinecke
---
block/blk-core.c | 3 +++
drivers/scsi/scsi_error.c | 2 +-
drivers/scsi/scsi_lib.c | 5 +
include/scsi/scsi.h | 1 +
4 files changed, 10 insertions(+
As discussed at LSF the SCSI stack already knows about several
error conditions, it's just not well documented.
Also there are some more conditions upper layers might be
interested in.
This patchset improves the documentation of the existing
I/O error codes and adds three more error codes, ENOSPC
Document the various error codes returned on I/O failure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_lib.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 86d5220..d3fc50f 100644
--- a/drivers/scsi/scsi_lib.c
+++
The scsi stack already uses DID_NO_CONNECT internally to signal
an invalid or removed device. This should be mapped to ENXIO,
as this then allows us to use a correct error code in
scsi_prep_return().
Signed-off-by: Hannes Reinecke
---
block/blk-core.c| 3 +++
drivers/scsi/scsi_lib.c | 7
We should be modifying the host_byte status in scsi_check_sense()
directly; this saves us to introduce a special return code for
each and every condition.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 21 +++--
include/scsi/scsi.h | 1 -
2 files changed, 7
When the thin provisioning hard threshold is reached we
should return ENOSPC to inform upper layers about this fact.
Signed-off-by: Hannes Reinecke
---
block/blk-core.c | 3 +++
drivers/scsi/scsi_error.c | 7 ++-
drivers/scsi/scsi_lib.c | 5 +
include/scsi/scsi.h | 1 +
On 06/27/2013 04:54 PM, Bart Van Assche wrote:
> Restrict the SCSI device state changes allowd via sysfs to the
> OFFLINE<>RUNNING transitions. Other transitions may confuse
> the SCSI mid-layer. As an example, changing the state of a SCSI
> device via sysfs into "cancel" or "deleted" prevents remo
On 06/27/2013 04:57 PM, Bart Van Assche wrote:
> Disallow the SDEV_TRANSPORT_OFFLINE to SDEV_CANCEL transition such
> that no I/O is sent to devices for which the transport is offline.
> Notes:
> - Functions like sd_shutdown() use scsi_execute_req() and hence
> set the REQ_PREEMPT flag. Such requ
On 07/01/13 17:12, Hannes Reinecke wrote:
> When a medium error is detected the SCSI stack should return
> ENODATA to the upper layers.
Hi Hannes,
since you change the error code from -EREMOTEIO to -ENODATA/-ENOSPC,
upper layers that checks -EREMOTEIO have to be updated as well.
Something like b
On 07/01/2013 11:12 AM, Jun'ichi Nomura wrote:
> On 07/01/13 17:12, Hannes Reinecke wrote:
>> When a medium error is detected the SCSI stack should return
>> ENODATA to the upper layers.
>
> Hi Hannes,
>
> since you change the error code from -EREMOTEIO to -ENODATA/-ENOSPC,
> upper layers that ch
-Original Message-
From: James Bottomley
Date: Saturday 29 June 2013 1:24 AM
To: Vikas
Cc: Mike Christie , scsi
, Lalit Chandivade
, Adheer Chandravanshi
Subject: Re: [PATCH V1 1/4] scsi_transport_iscsi: Exporting new attrs for
iscsi session and connection in sysfs
>On Wed, 2013-06-26
From: Vikas Chaudhary
Signed-off-by: Vikas Chaudhary
---
drivers/scsi/qla4xxx/ql4_version.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_version.h
b/drivers/scsi/qla4xxx/ql4_version.h
index fe873cf..c5edd0d 100644
--- a/drivers/scsi/qla4xxx
From: Adheer Chandravanshi
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Vikas Chaudhary
---
drivers/scsi/libiscsi.c | 97 +++
include/scsi/libiscsi.h | 31 +++
2 files changed, 128 insertions(+), 0 deletions(-)
diff --git a/dri
From: Adheer Chandravanshi
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Vikas Chaudhary
---
drivers/scsi/qla4xxx/ql4_os.c | 203 +
1 files changed, 146 insertions(+), 57 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4x
From: Adheer Chandravanshi
Exporting new iSCSI Session and Connection parameters to sysfs
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Vikas Chaudhary
---
drivers/scsi/scsi_transport_iscsi.c | 123 ++-
include/scsi/iscsi_if.h | 32 +
On 07/01/13 10:27, Hannes Reinecke wrote:
> On 06/27/2013 04:57 PM, Bart Van Assche wrote:
>> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
>> index dfbaa34..666b741 100644
>> --- a/drivers/scsi/scsi_sysfs.c
>> +++ b/drivers/scsi/scsi_sysfs.c
>> @@ -959,14 +959,16 @@ void __scs
On 07/01/2013 02:05 PM, Bart Van Assche wrote:
> On 07/01/13 10:27, Hannes Reinecke wrote:
>> On 06/27/2013 04:57 PM, Bart Van Assche wrote:
>>> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
>>> index dfbaa34..666b741 100644
>>> --- a/drivers/scsi/scsi_sysfs.c
>>> +++ b/drivers
On Mon, 2013-07-01 at 09:01 +0200, Bart Van Assche wrote:
> On 06/30/13 23:05, David Dillow wrote:
> > On Fri, 2013-06-28 at 14:53 +0200, Bart Van Assche wrote:
> >> +int srp_tmo_valid(int fast_io_fail_tmo, int dev_loss_tmo)
> >> +{
> >> + return (fast_io_fail_tmo < 0 || dev_loss_tmo < 0 ||
> >> +
We should be modifying the host_byte status in scsi_check_sense()
directly; this saves us to introduce a special return code for
each and every condition.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 21 +++--
include/scsi/scsi.h | 1 -
2 files changed, 7
Document the various error codes returned on I/O failure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_lib.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 86d5220..d3fc50f 100644
--- a/drivers/scsi/scsi_lib.c
+++
As discussed at LSF the SCSI stack already knows about several
error conditions, it's just not well documented.
Also there are some more conditions upper layers might be
interested in.
This patchset improves the documentation of the existing
I/O error codes and adds two more error codes, ENOSPC
fo
When the thin provisioning hard threshold is reached we
should return ENOSPC to inform upper layers about this fact.
Signed-off-by: Hannes Reinecke
---
block/blk-core.c | 3 +++
drivers/scsi/scsi_error.c | 7 ++-
drivers/scsi/scsi_lib.c | 5 +
include/scsi/scsi.h | 1 +
When a medium error is detected the SCSI stack should return
ENODATA to the upper layers.
Cc: Jun'ichi Nomura
Signed-off-by: Hannes Reinecke
---
block/blk-core.c | 3 +++
drivers/md/dm-mpath.c | 16 +++-
drivers/scsi/scsi_error.c | 2 +-
drivers/scsi/scsi_lib.c | 5
Hi,
I've got a box which recently got a Marvell 88SE9485 PCIe card
(Supermicro AOC-SAS2LP-MV8), which is connected by a mSAS->4x SATA-cable
to some 5 HDD backplanes (CFI-B53PM, chip is a SiI 3726).
The HBA's BIOS can see and access the HDDs through the backplanes, which
various Linux distribution
Signed-off-by: Hannes Reinecke
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index c6bdc92..a557e74 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_s
This patchset implements a new SCSI EH command timeout handler
which will be sending command aborts inline without actually
engaging SCSI EH.
SCSI EH will only be invoked if command abort fails.
In addition the commands will be returned directly
if the command abort succeeded, cutting down recover
Signed-off-by: Hannes Reinecke
Acked-by: Paolo Bonzini
---
drivers/scsi/virtio_scsi.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 2168258..f23b9ef 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index dcbf7c8..3a35ddc 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/driv
Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate
that a delayed error recovery has been initiated.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_error.c | 4
include/linux/blkdev.h| 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/scsi/scsi_error.c b/dr
When a command runs into a timeout we need to send an 'ABORT TASK'
TMF. This is typically done by the 'eh_abort_handler' LLDD callback.
Conceptually, however, this function is a normal SCSI command, so
there is no need to enter the error handler.
This patch implements a new scsi_abort_command() f
Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8
(Handle disk devices which can not process medium access commands)
was introduced to offline any device which cannot process medium
access commands.
However, commit 3eef6257de48ff84a5d98ca533685df8a3beaeb8
(Reduce error recovery time by reducing use o
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_transport_fc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index e106c27..1e1de9f 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_
Signed-off-by: Hannes Reinecke
---
drivers/message/fusion/mptsas.c | 3 ++-
drivers/message/fusion/mptscsih.c | 7 +++
drivers/message/fusion/mptscsih.h | 1 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
in
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libsas/sas_scsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_scsi_host.c
b/drivers/scsi/libsas/sas_scsi_host.c
index 6e795a1..9d5bd29 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drive
On Mon, 2013-07-01 at 16:09 +0200, Hajo Möller wrote:
> Hi,
>
> I've got a box which recently got a Marvell 88SE9485 PCIe card
> (Supermicro AOC-SAS2LP-MV8), which is connected by a mSAS->4x SATA-cable
> to some 5 HDD backplanes (CFI-B53PM, chip is a SiI 3726).
>
> The HBA's BIOS can see and acce
On Mon, 2013-07-01 at 09:14 +0200, Bart Van Assche wrote:
> On 07/01/13 09:05, James Bottomley wrote:
> >
> > On Thu, 2013-06-27 at 16:53 +0200, Bart Van Assche wrote:
> >> If something goes wrong during LUN scanning, e.g. a transport layer
> >> failure occurs, then __scsi_remove_device() can get i
On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote:
> Make concurrent invocations of scsi_device_set_state() safe.
Firstly, I don't understand from this where you think the races are.
Secondly, shouldn't this be the device lock? and thirdly, if we accept
that locking is required, encapsulat
On Thu, 2013-06-27 at 16:54 +0200, Bart Van Assche wrote:
> Restrict the SCSI device state changes allowd via sysfs to the
> OFFLINE<>RUNNING transitions. Other transitions may confuse
> the SCSI mid-layer. As an example, changing the state of a SCSI
> device via sysfs into "cancel" or "deleted" pr
On 07/01/13 16:49, James Bottomley wrote:
On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote:
Make concurrent invocations of scsi_device_set_state() safe.
Firstly, I don't understand from this where you think the races are.
Secondly, shouldn't this be the device lock? and thirdly, if we
When block runtime PM is enabled following warning is seen
while resuming the device.
BUG: sleeping function called from invalid context at
.../drivers/base/power/runtime.c:923
in_atomic(): 1, irqs_disabled(): 128, pid: 12, name: kworker/0:1
[] (unwind_backtrace+0x0/0x120) from
[] (__pm_runtime_su
Attention,
Important message from ADMIN- Please confirm your email address by clicking
this link:
http://upd.jimdo.com/
Webmaster
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
On Mon, 2013-07-01 at 17:17 +0200, Bart Van Assche wrote:
> On 07/01/13 16:49, James Bottomley wrote:
> > On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote:
> >> Make concurrent invocations of scsi_device_set_state() safe.
> >
> > Firstly, I don't understand from this where you think the rac
On Mon, 1 July 2013 08:50:48 +0200, Hannes Reinecke wrote:
>
> This patchset implements a new 'eh_deadline' attribute to the
> SCSI host. It will limit the overall SCSI EH runtime by a given
> timeout. If the timeout is reached all intermediate EH steps
> will be skipped and host reset will be sch
On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote:
> If a single device is bad, don't ever do a host
> reset.
This isn't a tenable position. Sometimes a device looks bad because the
host state for it has gone insane. At that point, the only safe action
is a reset of the host to sane state.
I
On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma
wrote:
> When block runtime PM is enabled following warning is seen
> while resuming the device.
>
> BUG: sleeping function called from invalid context at
> .../drivers/base/power/runtime.c:923
> in_atomic(): 1, irqs_disabled(): 128, pid: 12
On Mon, 2013-07-01 at 15:17 -0700, Andrew Morton wrote:
> On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma
> wrote:
>
> > When block runtime PM is enabled following warning is seen
> > while resuming the device.
> >
> > BUG: sleeping function called from invalid context at
> > .../drivers/
On Mon, 1 July 2013 19:23:25 +, James Bottomley wrote:
> On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote:
> > If a single device is bad, don't ever do a host
> > reset.
>
> This isn't a tenable position. Sometimes a device looks bad because the
> host state for it has gone insane. At tha
On Mon, 01 Jul 2013 15:24:11 -0700 James Bottomley
wrote:
> > --- a/block/blk-core.c~block-fix-possible-sleep-in-invalid-context-fix
> > +++ a/block/blk-core.c
> > @@ -3159,15 +3159,14 @@ EXPORT_SYMBOL(blk_pre_runtime_resume);
> > */
> > void blk_post_runtime_resume(struct request_queue *q, i
From: Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/dr
On 07/01/2013 11:28 PM, Sujit Reddy Thumma wrote:
> When block runtime PM is enabled following warning is seen
> while resuming the device.
>
> BUG: sleeping function called from invalid context at
> .../drivers/base/power/runtime.c:923
> in_atomic(): 1, irqs_disabled(): 128, pid: 12, name: kworke
Hi Hannes,
On 07/01/13 22:16, Hannes Reinecke wrote:
> When a medium error is detected the SCSI stack should return
> ENODATA to the upper layers.
>
> Cc: Jun'ichi Nomura
> Signed-off-by: Hannes Reinecke
> ---
> block/blk-core.c | 3 +++
> drivers/md/dm-mpath.c | 16 +
On 7/2/2013 8:34 AM, Aaron Lu wrote:
Fix this by releasing spin_lock_irq() before calling
>pm_runtime_autosuspend() in blk_post_runtime_resume().
Hi Sujit,
Thanks for testing out block layer runtime PM!
As for the problem here, it is already fixed by:
commit c60855cdb976c632b3bf8922eeab8a0e78
)
- * Update to SPC-4 T10/1713-D Rev 20, 22 May 2009, D. Gilbert 20090624
+ * Updated to SPC-4 T10/1713-D Rev 36g, D. Gilbert 20130701
*/
#include
@@ -21,12 +21,13 @@
/* Commands with service actions that change the command name */
-#define MAINTENANCE_IN 0xa3
-#define MAINTENANCE_OUT 0xa4
>-Original Message-
>From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>Sent: Saturday, June 29, 2013 2:51 AM
>To: DL-MegaRAID Linux; Saxena, Sumit
>Cc: James E.J. Bottomley; linux-scsi@vger.kernel.org; kernel-
>janit...@vger.kernel.org
>Subject: [patch] [SCSI] megaraid_sas: fix a bug f
On 07/01/2013 10:55 PM, Jörn Engel wrote:
> On Mon, 1 July 2013 19:23:25 +, James Bottomley wrote:
>> On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote:
>>> If a single device is bad, don't ever do a host
>>> reset.
>>
>> This isn't a tenable position. Sometimes a device looks bad because th
On Mon, 2013-07-01 at 16:55 -0400, Jörn Engel wrote:
> On Mon, 1 July 2013 19:23:25 +, James Bottomley wrote:
> > On Mon, 2013-07-01 at 13:44 -0400, Jörn Engel wrote:
> > > If a single device is bad, don't ever do a host
> > > reset.
> >
> > This isn't a tenable position. Sometimes a device l
On 07/01/13 18:52, James Bottomley wrote:
On Mon, 2013-07-01 at 17:17 +0200, Bart Van Assche wrote:
On 07/01/13 16:49, James Bottomley wrote:
On Thu, 2013-06-27 at 16:56 +0200, Bart Van Assche wrote:
Make concurrent invocations of scsi_device_set_state() safe.
Firstly, I don't understand fro
60 matches
Mail list logo
