Re: [PATCH 2/2] scsi: qla2xxx: print MAC via %pMR

2013-05-28 Thread Andy Shevchenko
On Thu, 2012-07-26 at 08:23 -0400, Chad Dupuis wrote: > > On Thu, 12 Jul 2012, Andy Shevchenko wrote: > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/scsi/qla2xxx/qla_attr.c |5 + > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/scsi/qla2xxx/qla_at

Re: [PATCH] fusion: print lan address via %pMR

2013-05-28 Thread Andy Shevchenko
On Thu, 2012-07-12 at 10:55 +0300, Andy Shevchenko wrote: > Signed-off-by: Andy Shevchenko > --- > drivers/message/fusion/mptbase.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/message/fusion/mptbase.c > b/drivers/message/fusion/mptbase.c

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
Come on man, same comments as last patches like this :) Could you use the same names that we currently use for existing params? Check for the inorder ones and the ones where we use en instead of enabled for the postfix. Also check the others. Also what is up with isns. If we support passing the a

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
On 05/28/2013 03:49 AM, Mike Christie wrote: > Come on man, same comments as last patches like this :) Could you use > the same names that we currently use for existing params? > > Check for the inorder ones and the ones where we use en instead of > enabled for the postfix. Also check the others.

Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-28 Thread Mike Christie
On 05/09/2013 05:02 AM, vikas.chaudh...@qlogic.com wrote: > + ISCSI_PARAM_DEF_TASKMGMT_TMO, We currently have: ISCSI_PARAM_ABORT_TMO, ISCSI_PARAM_LU_RESET_TMO, ISCSI_PARAM_HOST_RESET_TMO, Does your card just have the one timeout for all types of tmfs? I think the in

RE: [PATCH 1/1] bfa: Fix for possible null pointer dereference

2013-05-28 Thread Vijaya Mohan Guvva Guvva
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Jakob Normark > Sent: Monday, May 27, 2013 1:21 AM > To: Anil Gurumurthy; Vijaya Mohan Guvva Guvva; James E.J. Bottomley > Cc: linux-scsi@vger.kernel.org; linux-ker...@vge

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Tuesday 28 May 2013 2:19 PM To: Vikas Cc: "jbottom...@parallels.com" , scsi , Lalit Chandivade , Ravi Anand , Harish Zunjarrao Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings >Come on man, same comments as l

Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-28 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Tuesday 28 May 2013 2:27 PM To: Vikas Cc: "jbottom...@parallels.com" , scsi , Lalit Chandivade , Ravi Anand , Adheer Chandravanshi Subject: Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-28 Thread Jeremy Linton
On 5/27/2013 8:32 PM, Baruch Even wrote: > necessary but the command itself if it is already actively handled > continues in its path. The abort only cancels those commands that are in > the queue and if there really was a problem and the disk is engaging in > error recovery of its own you'll just

Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-28 Thread Mike Christie
On 05/28/2013 06:55 AM, Vikas Chaudhary wrote: > > > -Original Message- > From: Mike Christie > Date: Tuesday 28 May 2013 2:27 PM > To: Vikas > Cc: "jbottom...@parallels.com" , scsi > , Lalit Chandivade > , Ravi Anand , Adheer > Chandravanshi > Subject: Re: [PATCH 4/8] scsi_transport_i

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-28 Thread Baruch Even
On Tue, May 28, 2013 at 5:38 PM, Jeremy Linton wrote: > This is another part of what formed my opinions about error > isolation. If one > of your devices goes out to lunch and isn't recovering via abort/lun reset. > Its done! Wrecking the rest of the SAN doing "bus resets" and HBA resets

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-28 Thread Douglas Gilbert
Perhaps I'm missing something but I can never get DIF stuff to do what I want in scsi_debug. It was like this before your patches as well. Assume this set up: # lsscsi -gp [1:0:0:0]diskATA ST3320620AS 3.AA /dev/sda /dev/sg0 - - [6:0:9:0]diskSEAGATE ST3300065

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-28 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> No PI, why not? This was tested on lk 3.9.4 with your patches Doug> applied. I've been communicating with Akinobu offline about this. The reason is that I really only implemented DIX support in scsi_debug. The dif module parameter is only there to s

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-28 Thread Martin K. Petersen
> "Vladislav" == Vladislav Bolkhovitin writes: Vladislav> Linux block layer is purely artificial creature slowly Vladislav> reinventing wheel creating more problems, than solving. On the contrary. I do think we solve a whole bunch of problems. Vladislav> It enforces approach, where often "

[PATCH 0/2] Minor scsi_dh_emc error path fixes

2013-05-28 Thread Joe Lawrence
These two patches spun out of the blk_get_request return type changes I've been working on [1]. [1] http://thread.gmane.org/gmane.linux.scsi/80934 Should that patch go in, there are a few other device handler changes possible for 3.11 [2], but the following bugfixes are unrelated, so I thought

scsi_dh_emc: handle zero-senselen send_inquiry_cmd errors

2013-05-28 Thread Joe Lawrence
>From c6645f639f7e7551c7a6f0aacee78e57ddd37bc1 Mon Sep 17 00:00:00 2001 From: Joe Lawrence Date: Tue, 28 May 2013 14:49:37 -0400 Subject: [PATCH 1/2] scsi_dh_emc: handle zero-senselen send_inquiry_cmd errors The send_inquiry_cmd function may exit without setting senselen if get_req fails. Calle

scsi_dh_emc: set_params callback should consistently return errno

2013-05-28 Thread Joe Lawrence
>From db6c2d4406732585fd7a658fc89b14fa26e7d1d4 Mon Sep 17 00:00:00 2001 From: Joe Lawrence Date: Tue, 28 May 2013 15:47:20 -0400 Subject: [PATCH 2/2] scsi_dh_emc: set_params callback should consistently return errno A SCSI scsi_device_handler set_params routine should return a negative errno val

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-28 Thread Vladislav Bolkhovitin
Martin K. Petersen, on 05/28/2013 01:25 PM wrote: > Vladislav> Linux block layer is purely artificial creature slowly > Vladislav> reinventing wheel creating more problems, than solving. > > On the contrary. I do think we solve a whole bunch of problems. > > > Vladislav> It enforces approach, wh