Re: [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c

2013-05-01 Thread merez
Tested-by: Maya Erez > > Looks good. Reviewed-by: Subhash Jadavani > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: >> Move the ufshcd_hba_stop from header file. >> >> Signed-off-by: Seungwon Jeon >> --- >> drivers/scsi/ufs/ufshcd.c |9 + >> drivers/scsi/ufs/ufshcd.h |9 -

Re: [PATCH 2/5] scsi: ufs: wrap the i/o access operations

2013-05-01 Thread merez
Tested-by: Maya Erez I also tend to agree with Sujit on the order of the wrappers parameters. Thanks, Maya > On 4/26/2013 10:36 AM, Seungwon Jeon wrote: >> Hi, >> >> On Thursday, April 25, 2013, Sujit Reddy Thumma wrote: >>> On 4/24/2013 9:36 PM, Seungwon Jeon wrote: Simplify operations wi

Re: [PATCH 3/5] scsi: ufs: amend interrupt configuration

2013-05-01 Thread merez
Tested-by: Maya Erez > Patch looks good but one minor comment below. > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: >> It makes interrupt setting more flexible especially >> for disabling. And wrong bit mask is fixed for ver 1.0. >> [17:16] is added for mask. >> >> Signed-off-by: Seungwon Jeon >

Re: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-01 Thread merez
Tested-by: Maya Erez > Add uic command operations including DME_XXX series. > > Signed-off-by: Seungwon Jeon > --- > drivers/scsi/ufs/ufs-attrs.h | 129 > drivers/scsi/ufs/ufshcd.c| 220 > +- > drivers/scsi/ufs/ufshcd.h|

Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

2013-05-01 Thread Borislav Petkov
On Thu, Apr 11, 2013 at 07:45:03AM -0700, Joe Perches wrote: > CamelCase tests are a bit noisy against certain > types of code acceptable to some kernel developers. > > Make the test applicable only with --strict. > > Do not bleat a message on nominally acceptable > CamelCase uses that are separa

Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

2013-05-01 Thread James Bottomley
On Wed, 2013-05-01 at 14:34 +0200, Borislav Petkov wrote: > On Thu, Apr 11, 2013 at 07:45:03AM -0700, Joe Perches wrote: > > CamelCase tests are a bit noisy against certain > > types of code acceptable to some kernel developers. > > > > Make the test applicable only with --strict. > > > > Do not

Re: [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants

2013-05-01 Thread James Bottomley
On Mon, 2013-04-29 at 15:21 +0200, Arnd Bergmann wrote: > On Friday 26 April 2013, Masanori Goto wrote: > > 2013/4/25 Arnd Bergmann > > > > > > ARM cannot handle udelay for more than 2 miliseconds, so we > > > should use mdelay instead for those. > > > > > > > Singed-off-by: GOTO Masanori > >

[PATCH V4] scsi: ufs: add support for query requests

2013-05-01 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI command

Re: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name

2013-05-01 Thread James Bottomley
On Fri, 2013-03-08 at 13:28 -0800, Bhanu Prakash Gollapudi wrote: > +#ifndef PCI_DEVICE_ID_NX2_57710 > +#define PCI_DEVICE_ID_NX2_57710 0x164e > +#endif > +#ifndef PCI_DEVICE_ID_NX2_57711 > +#define PCI_DEVICE_ID_NX2_57711 0x164f > +#endif > +#ifndef PCI_DEVICE_ID_NX2_5771

Re: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name

2013-05-01 Thread Bhanu Prakash Gollapudi
On 05/01/2013 05:39 PM, James Bottomley wrote: On Fri, 2013-03-08 at 13:28 -0800, Bhanu Prakash Gollapudi wrote: +#ifndef PCI_DEVICE_ID_NX2_57710 +#define PCI_DEVICE_ID_NX2_577100x164e +#endif +#ifndef PCI_DEVICE_ID_NX2_57711 +#define PCI_DEVICE_ID_NX2_577110x164f

Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14

2013-05-01 Thread James Bottomley
On Fri, 2013-03-08 at 15:53 -0800, Bhanu Prakash Gollapudi wrote: > On 03/08/2013 01:28 PM, Bhanu Prakash Gollapudi wrote: > > Signed-off-by: Bhanu Prakash Gollapudi > > --- > > drivers/scsi/bnx2fc/bnx2fc.h |2 +- > > drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- > > 2 files changed, 2

[PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation

2013-05-01 Thread Tim Chen
Currently the CRC-T10DIF checksum is computed using a generic table lookup algorithm. By switching the checksum to PCLMULQDQ based computation, we can speedup the computation by 8x for checksumming 512 bytes and even more for larger buffer size. This will improve performance of SCSI drivers turni

[PATCH v3 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-05-01 Thread Tim Chen
When CRC T10 DIF is calculated using the crypto transform framework, we wrap the crc_t10dif function call to utilize it. This allows us to take advantage of any accelerated CRC T10 DIF transform that is plugged into the crypto framework. Signed-off-by: Tim Chen --- crypto/Kconfig |

[PATCH v3 3/4] Glue code to cast accelerated CRCT10DIF assembly as a crypto transform

2013-05-01 Thread Tim Chen
Glue code that plugs the PCLMULQDQ accelerated CRC T10 DIF hash into the crypto framework. The config CRYPTO_CRCT10DIF_PCLMUL should be turned on to enable the feature. The crc_t10dif crypto library function will use this faster algorithm when crct10dif_pclmul module is loaded. Signed-off-by: Ti

[PATCH v3 4/4] Simple correctness and speed test for CRCT10DIF hash

2013-05-01 Thread Tim Chen
These are simple tests to do sanity check of CRC T10 DIF hash. The correctness of the transform can be checked with the command modprobe tcrypt mode=47 The speed of the transform can be evaluated with the command modprobe tcrypt mode=320 Set the cpu frequency to constant and turn

[PATCH v3 2/4] Accelerated CRC T10 DIF computation with PCLMULQDQ instruction

2013-05-01 Thread Tim Chen
This is the x86_64 CRC T10 DIF transform accelerated with the PCLMULQDQ instructions. Details discussing the implementation can be found in the paper: "Fast CRC Computation for Generic Polynomials Using PCLMULQDQ Instruction" http://www.intel.com/content/dam/www/public/us/en/documents/white-paper

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-05-01 Thread Tim Chen
On Tue, 2013-04-30 at 11:27 +0800, Herbert Xu wrote: > On Mon, Apr 29, 2013 at 01:40:30PM -0700, Tim Chen wrote: > > > > If I allocate the transform under the mod init instead, how can I make > > sure that the fast version is already registered if I have it compiled > > in? It is not clear to me h

Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14

2013-05-01 Thread Bhanu Prakash Gollapudi
On 05/01/2013 06:05 PM, James Bottomley wrote: On Fri, 2013-03-08 at 15:53 -0800, Bhanu Prakash Gollapudi wrote: On 03/08/2013 01:28 PM, Bhanu Prakash Gollapudi wrote: Signed-off-by: Bhanu Prakash Gollapudi --- drivers/scsi/bnx2fc/bnx2fc.h |2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c

RE: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-05-01 Thread Seungwon Jeon
On Tuesday, April 30, 2013, Sujit Reddy Thumma wrote: > On 4/30/2013 12:03 PM, Seungwon Jeon wrote: > > On Monday, April 29, 2013, Sujit Reddy Thumma wrote: > >> On 4/29/2013 3:54 PM, Seungwon Jeon wrote: > >>> On Monday, April 29, 2013, Sujit Reddy Thumma wrote: > On 4/26/2013 10:44 AM, Seung

[PATCH RESEND 1/2] [SCSI] a4000t: use module_platform_driver_probe()

2013-05-01 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by: Jingoo Han --- drivers/scsi/a4000t.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/a4000t.c b/drivers/scsi/a4000t.c index 23c76f4..

[PATCH RESEND 2/2] [SCSI] a3000: use module_platform_driver_probe()

2013-05-01 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes the code smaller and simpler. Acked-by: Geert Uytterhoeven Signed-off-by: Jingoo Han --- drivers/scsi/a3000.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/a3000.c b/drivers/scs