Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
linux-...@vger.kernel.org is for UFS filesystem. > The API for submitting a query request is ufs_query_request() in > ufs_core.c. This function is responsible for: This can be part of ufshcd.c which is actually the core file, no need to create a new core file for the function. > + > +#define UFS

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
> > This can be done inside the following if condition i.e. if > (hba->query.descriptor != NULL). > and change the condition to if (!hba->query.descriptor). > I meant to write if (hba->query.descriptor)...:-) -- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

[PATCH -next 2/2] sun3_scsi: switch to ->show_info()

2013-04-10 Thread Geert Uytterhoeven
Based on Al's changes to atari_scsi. Signed-off-by: Geert Uytterhoeven --- http://kisskb.ellerman.id.au/kisskb/buildresult/8543326/ drivers/scsi/sun3_NCR5380.c | 185 ++ drivers/scsi/sun3_scsi.c|2 +- drivers/scsi/sun3_scsi.h|2 +- 3 file

[PATCH 1/2] sun3_scsi: Fill in missing scsi_host_template.proc_info method

2013-04-10 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/scsi/sun3_scsi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/sun3_scsi.c b/drivers/scsi/sun3_scsi.c index 6e25889..b0dc034 100644 --- a/drivers/scsi/sun3_scsi.c +++ b/drivers/scsi/sun3_scsi.c @@ -626,6 +626,7

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread Andy Whitcroft
On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote: > It's making checkpatch unusable on most drivers because it's spewing > tons of bogus warnings. The problem is the assumption that studly caps > is always wrong: it isn't if the variables are named after the various > conventions in

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread Joe Perches
On Wed, 2013-04-10 at 14:26 +0100, Andy Whitcroft wrote: > On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote: > > It's making checkpatch unusable on most drivers because it's spewing > > tons of bogus warnings. The problem is the assumption that studly caps > > is always wrong: it is

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2013 at 07:35:58AM -0700, Joe Perches wrote: > or maybe exclude drivers/scsi and include/scsi/ and arch/x86/kvm/emulate.c -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread James Bottomley
On Wed, 2013-04-10 at 16:52 +0200, Borislav Petkov wrote: > On Wed, Apr 10, 2013 at 07:35:58AM -0700, Joe Perches wrote: > > or maybe exclude drivers/scsi and include/scsi/ > > and arch/x86/kvm/emulate.c Actually, we get this all over drivers. Some of the problems are to do with the fact that th

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2013 at 08:07:41AM -0700, James Bottomley wrote: > On Wed, 2013-04-10 at 16:52 +0200, Borislav Petkov wrote: > > On Wed, Apr 10, 2013 at 07:35:58AM -0700, Joe Perches wrote: > > > or maybe exclude drivers/scsi and include/scsi/ > > > > and arch/x86/kvm/emulate.c > > Actually, we g

Re: [PATCH 0/5] qla4xxx: Updates for scsi "misc" branch

2013-04-10 Thread Mike Christie
On 04/05/2013 06:06 AM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > James, > > Please apply the following patches to the scsi tree at your earliest > convenience. > > Adheer Chandravanshi (3): > qla4xxx: Use correct flash ddb offset for ISP40XX > qla4xxx: Restrict

[PATCH 0/2] iscsi changes for scsi misc

2013-04-10 Thread michaelc
The following 2 patches are for the misc branch in the scsi tree. They cleanup duplicated code from a previous patch and add better support for swap over software iscsi by using the PF_MEMALLOC/__GFP_MEMALLOC flags like what was recently added for nbd. -- To unsubscribe from this list: send the li

[PATCH 2/2] iscsi_tcp: support PF_MEMALLOC/__GFP_MEMALLOC

2013-04-10 Thread michaelc
From: Mike Christie This patch has software iscsi use PF_MEMALLOC/__GFP_MEMALLOC to be able to better support swap over iscsi disks similar to what was added for nbd. Signed-off-by: Mike Christie --- drivers/scsi/iscsi_tcp.c | 18 +- 1 files changed, 13 insertions(+), 5 delet

[PATCH 1/2] libiscsi: avoid unnecessary multiple NULL assignments

2013-04-10 Thread michaelc
From: Masatake YAMATO In iscsi_free_task, NULL is assigned to task->sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session->lock, so multiple NULL assignments cause no trouble. But people reading the source code may be confused. The second NULL

Re: [PATCH 1/2] libiscsi: avoid unnecessary multiple NULL assignments

2013-04-10 Thread Mike Christie
On 04/10/2013 11:24 AM, micha...@cs.wisc.edu wrote: > From: Masatake YAMATO > > In iscsi_free_task, NULL is assigned to task->sc twice: before and > after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded > with session->lock, so multiple NULL assignments cause no trouble. But >

Re: [PATCH V3 01/12] pm80xx: fix for memory region free

2013-04-10 Thread James Bottomley
On Wed, 2013-03-20 at 10:20 -0700, Anand wrote: > >From 700bfe79294e9f9e1a5def178af52b13928902a9 Mon Sep 17 00:00:00 2001 > From: Sakthivel K > Date: Mon, 4 Feb 2013 12:10:02 +0530 > Subject: [PATCH V3 01/12] pm80xx: fix for memory region free This one is already upstream: commit bfb4809f7fff2f2

Re: [PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-04-10 Thread James Bottomley
On Wed, 2013-03-20 at 10:21 -0700, Anand wrote: > >From ef678e2188866af926f2a089719c24ec99e4e88c Mon Sep 17 00:00:00 2001 > From: Sakthivel K > Date: Wed, 27 Feb 2013 20:22:50 +0530 > Subject: [PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and > modify for SPC > > Updated pci id

Re: [PATCH V3 01/12] pm80xx: fix for memory region free

2013-04-10 Thread James Bottomley
On Wed, 2013-03-20 at 10:20 -0700, Anand wrote: > >From 700bfe79294e9f9e1a5def178af52b13928902a9 Mon Sep 17 00:00:00 2001 > From: Sakthivel K > Date: Mon, 4 Feb 2013 12:10:02 +0530 > Subject: [PATCH V3 01/12] pm80xx: fix for memory region free > > All memory regions are allocated based on variabl

[PATCH] target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs

2013-04-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a bug where a handful of informational / control CDBs that should be allowed during ALUA access state Standby/Offline/Transition where incorrectly returning CHECK_CONDITION + ASCQ_04H_ALUA_TG_PT_*. This includes INQUIRY + REPORT_LUNS, which would end up

Re: [PATCH V2 15/18] be2iscsi: Fix the session cleanup when reboot/shutdown happens

2013-04-10 Thread Mike Christie
On 4/5/13 10:38 PM, Jayamohan Kallickal wrote: During reboot/shutdown cycle, the active sessions were not updated. In iSCSI Boot case, the boot session was alive and this fix informs that the machine is going down, so no more ops happens on that session. Signed-off-by: John Soni Jose Sign

RE: [PATCH V3 01/12] pm80xx: fix for memory region free

2013-04-10 Thread Anand Kumar Santhanam
Hi James, Thanks for the feedback. We have resubmitted all the patches starting from 1st patch in this V3 patchset. The first patch (given below) does not contain pm8001_80xx_dispatch reference. Maybe you have already applied patch 1 and 2 from earlier patchset and trying to apply patch 1 from th

RE: [PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-04-10 Thread Anand Kumar Santhanam
Hi James, Did you take the patch attachment from the email? Pls let us know as to which version of diff tool you are using. I used the patch command to apply this patch against 3.8-rc6 tree to check whether the patch is applying properly. Regards Anand -Original Message- From: James Bott