Re: [PATCH 2/2] [SCSI] a3000: use module_platform_driver_probe()

2013-03-05 Thread James Bottomley
On Tue, 2013-03-05 at 12:42 +0900, Jingoo Han wrote: > This patch uses module_platform_driver_probe() macro which makes > the code smaller and simpler. These drivers are in deep maintenance mode. Unless you can find someone to actually test the changes, we err on the side of not touching the code

Re: [PATCH] st: Take additional queue ref in st_probe

2013-03-05 Thread Jan Vesely
Hi, I don't understand how error paths are supposed to work with this patch. As I see it, if we fail to get a reference, the error path tries to put a non-existent one. moreover, error paths on lines 4188 and 4196 still goto out_put_disk, leaking the reference. other than that, it fixes the l

[PATCH v2] st: Take additional queue ref in st_probe

2013-03-05 Thread Joe Lawrence
Changes from v1: Corrected error paths as noted by Ewan Milne and Jan Vesely. These changes were applied to scsi.git, branch "misc". This patch fixes a reference count bug in the SCSI tape driver which can be reproduced with the following: * Boot with slub_debug=FZPU, tape drive attached * ech

Re: [PATCH v2] st: Take additional queue ref in st_probe

2013-03-05 Thread Kai Makisara
On Tue, 5 Mar 2013, Joe Lawrence wrote: > Changes from v1: > Corrected error paths as noted by Ewan Milne and Jan Vesely. > > These changes were applied to scsi.git, branch "misc". This patch > fixes a reference count bug in the SCSI tape driver which can be > reproduced with the following: >

Re: [PATCH v2] st: Take additional queue ref in st_probe

2013-03-05 Thread James Bottomley
On Tue, 2013-03-05 at 19:17 +0200, Kai Makisara wrote: > On Tue, 5 Mar 2013, Joe Lawrence wrote: > > > Changes from v1: > > Corrected error paths as noted by Ewan Milne and Jan Vesely. > > > > These changes were applied to scsi.git, branch "misc". This patch > > fixes a reference count bug in

[PATCH] aic7xxx: Remove redundant NULL check before kfree

2013-03-05 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/scsi/aic7xxx/aic79xx_core.c | 12 drivers/scsi/aic7xxx/aic7xxx_core.c | 16 ++-- 2 files changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drive

[PATCH] lpfc 8.3.37: Remove redundant NULL check before kfree

2013-03-05 Thread Syam Sidhardhan
kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan --- drivers/scsi/lpfc/lpfc_bsg.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index 32d5683..2166097 100644 --- a/drivers/scsi/lpfc/lpfc_bsg.c

Re: [PATCH 2/2] [SCSI] a3000: use module_platform_driver_probe()

2013-03-05 Thread Geert Uytterhoeven
On Tue, Mar 5, 2013 at 10:08 AM, James Bottomley wrote: > On Tue, 2013-03-05 at 12:42 +0900, Jingoo Han wrote: >> This patch uses module_platform_driver_probe() macro which makes >> the code smaller and simpler. > > These drivers are in deep maintenance mode. Unless you can find someone > to actu

Re: qla2xxx: issues when creating a new target port

2013-03-05 Thread Nicholas A. Bellinger
Hi Chris, On Sun, 2013-03-03 at 13:49 +, Chris Boot wrote: > Hi all, > > When creating a new target port in targetcli (/qla2xxx create > 21:0x:...), and I have nothing plugged-in to the port, the creation > process takes quite some time. After a few seconds, the kernel prints > a message sayi

Re: qla2xxx: issues when creating a new target port

2013-03-05 Thread Chris Boot
On 05/03/2013 21:52, Nicholas A. Bellinger wrote: > Hi Chris, > > On Sun, 2013-03-03 at 13:49 +, Chris Boot wrote: >> Hi all, >> >> When creating a new target port in targetcli (/qla2xxx create >> 21:0x:...), and I have nothing plugged-in to the port, the creation >> process takes quite some ti

Re: [PATCH 1/2] mptfusion, mpt2sas, mpt3sas: Don't remove dead IOC PCI device

2013-03-05 Thread Bjorn Helgaas
[+cc linux-pci] On Mon, Mar 4, 2013 at 11:02 AM, Desai, Kashyap wrote: > > >> -Original Message- >> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >> ow...@vger.kernel.org] On Behalf Of Joe Lawrence >> Sent: Monday, March 04, 2013 9:26 PM >> To: linux-scsi@vger.kernel.org >> C

RE: [PATCH 1/2] mptfusion, mpt2sas, mpt3sas: Don't remove dead IOC PCI device

2013-03-05 Thread Desai, Kashyap
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Wednesday, March 06, 2013 4:43 AM > To: Desai, Kashyap > Cc: Joe Lawrence; linux-scsi@vger.kernel.org; DL-MPT Fusion Linux; > Support; Reddy, Sreekanth; Nandigama, Nagalakshmi; James E.J. Bottomley; > linux-..

Re: [PATCH 1/2] mptfusion, mpt2sas, mpt3sas: Don't remove dead IOC PCI device

2013-03-05 Thread Bjorn Helgaas
On Tue, Mar 5, 2013 at 6:46 PM, Desai, Kashyap wrote: > > >> -Original Message- >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> Sent: Wednesday, March 06, 2013 4:43 AM >> To: Desai, Kashyap >> Cc: Joe Lawrence; linux-scsi@vger.kernel.org; DL-MPT Fusion Linux; >> Support; Reddy, Sree

[PATCH] pm8001: updated MAINTAINERS list

2013-03-05 Thread Jack Wang
Sorry for resend, I forget to change the format to text. >From 960e481828a03d211f5e20e626036876b39600dc Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Tue, 5 Mar 2013 21:17:55 -0500 Subject: [PATCH] update mail address with my private gmail address for pm8001 driver Signed-off-by: Jack Wang ---

[PATCH] libsas: use right function to alloc smp response

2013-03-05 Thread Jack Wang
In fact the disc_resp buffer will be overwrite by smp response, so we never found this typo, correct it by using the right one. >From 43c522be7a5b4ce89de725926a1fbabd70674c64 Mon Sep 17 00:00:00 2001 From: John Gong Date: Fri, 1 Mar 2013 04:08:18 -0500 Subject: [PATCH] use right function to alloc

RE: [PATCH 1/2] mptfusion, mpt2sas, mpt3sas: Don't remove dead IOC PCI device

2013-03-05 Thread Desai, Kashyap
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Wednesday, March 06, 2013 7:55 AM > To: Desai, Kashyap > Cc: Joe Lawrence; linux-scsi@vger.kernel.org; DL-MPT Fusion Linux; > Support; Reddy, Sreekanth; Nandigama, Nagalakshmi; James E.J. Bottomley; > linux-..

[PATCH 1/1] scsi_dh_alua: fix stpg sense handling

2013-03-05 Thread michaelc
From: Mike Christie For the stpg_endio path we are not evaluating the sense. The bug is that 1. The error value is set to -EIO when there is sense, so we hit the first error check and always return SCSI_DH_IO. 2. h->senselen is set to zero in submit_stpg. It is not later set to req->sense_len l