[LSF/MM TOPIC] Thin provisioning SOFT_THRESHOLD error handling

2013-01-29 Thread Hannes Reinecke
Hi all, Thin-provisioned devices have the ability to set a 'soft threshold', which is triggered if the real free space for this device is beyond this mark. The intention behind this is to allow the system to induce some garbage collection with possibly freeing up unused space. Initially it

Re: [PATCH v3] qla2xxx: silence two GCC warnings

2013-01-29 Thread Paul Bolle
On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote: > Acked-by: Saurav Kashyap > > Thanks, > ~Saurav > > >Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC > >warnings: > >drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹: > >drivers/scsi/qla2xxx/qla_gs.c

Re: [PATCH] aic7xxx_old: silence GCC warnings

2013-01-29 Thread Paul Bolle
On Mon, 2012-10-29 at 13:45 +0100, Paul Bolle wrote: > On Mon, 2012-10-29 at 12:17 +, James Bottomley wrote: > > mvsas has a maintainer: poke them harder > > According to MAINTAINERS that's you. Is Xiangliang Yu perhaps the actual > maintainer? Building the mvsas driver triggers identical war

Re: [PATCH] [SCSI] advansys: change buildtime warning into runtime error

2013-01-29 Thread Paul Bolle
On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote: > Building advansys.o triggers this warning: > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not > properly converted to the DMA API [-Wcpp] > > This warning can be traced back to a patch called "advansys: add warning

[PATCH] block: fix ext_devt_idr handling

2013-01-29 Thread Tomas Henzl
While adding and removing a lot of disks disks and partitions this sometimes shows up - WARNING: at fs/sysfs/dir.c:512 sysfs_add_one+0xc9/0x130() (Not tainted) Hardware name: sysfs: cannot create duplicate filename '/dev/block/259:751' Modules linked in: raid1 autofs4 bnx2fc cnic uio fcoe libfcoe l

storvsc loops with No Sense messages

2013-01-29 Thread Olaf Hering
KY, while attempting to install the upcoming openSuSE 12.3 in a hyper-v guest (1 vcpu, 512MB) hosted on Windows Server 2012 I see a hanging guest after formating the root partition, when the installer starts to write files to it. After booting the install kernel with 'ignore_loglevel' I see a fl

RE: storvsc loops with No Sense messages

2013-01-29 Thread KY Srinivasan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Tuesday, January 29, 2013 10:28 AM > To: KY Srinivasan > Cc: linux-scsi@vger.kernel.org > Subject: storvsc loops with No Sense messages > > > KY, > > while attempting to install the upcoming openSuSE 12.3 in a hyp

[PATCH] mvsas: fixed timeout issue when removing module

2013-01-29 Thread yxlraid
From: Xiangliang Yu - Root cause is libsas will clear asd_sas_port phy_mask value in sas_port_deform after triggering destruct workqueue, but the workqueue will send sync cmd and still need phy_mask value. Now, mvsas using asd_sas_phy setting instead of asd_sas_port setting. --- driver

Re: storvsc loops with No Sense messages

2013-01-29 Thread Olaf Hering
On Tue, Jan 29, KY Srinivasan wrote: > I have not seen this. The SRB status indicates it is an illegal request; the > command is WRITE_SAME. I will take a look. I can ignore it like SET_WINDOW, and the installation proceeds. Just a few messages in dmesg: ... [ 107.448281] EXT4-fs (sda2): mount

Re: [PATCH] target: For iblock at default writecache enable.

2013-01-29 Thread Nicholas A. Bellinger
Hi majianpeng, On Fri, 2013-01-25 at 09:58 +0800, majianpeng wrote: > Like the harddisk, at default write cache is enable. > > Signed-off-by: Jianpeng Ma > --- > drivers/target/target_core_iblock.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/target/target_core_iblock

[LSF/MM TOPIC] Making sure soft SCSI Targets are Valid

2013-01-29 Thread Lee Duncan
Hi: I'm not sure if there is much interest in this, but I've recently realized that there is no good free software to validate iSCSI targets, not to mention FCOE targets, IB soft targets, etc. There's just no way to know if any change you make is "legal" short of learning to speak SCSI geek spec (

RE: storvsc loops with No Sense messages

2013-01-29 Thread KY Srinivasan
Was the installation done on a vhd or VHDX. I checked with Hyper-V guys and they say they never supported WRITE_SAME. I am wondering how it worked on ws2008. K. Y > -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Tuesday, January 29, 2013 1:56 PM > To: KY Srinivas

Re: storvsc loops with No Sense messages

2013-01-29 Thread Olaf Hering
On Tue, Jan 29, KY Srinivasan wrote: > Was the installation done on a vhd or VHDX. I checked with Hyper-V > guys and they say they never supported WRITE_SAME. I am wondering how > it worked on ws2008. Its a vhdx image, both fixed and dynamically size have the same issue. I will see what happens w

[PATCH 0/3] target: Fix zero-length regressions in v3.8-rc1 code

2013-01-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, The following are a handful of zero-length CDB regression bugfixes to address breakage introduced by the recent sense_reason_t conversion in v3.8-rc1 code, which incorrectly assumed CHECK_CONDITION status (in all CDB emulation cases) when NULL was returned by t

[PATCH 1/3] target: Fix zero-length INQUIRY additional sense code regression

2013-01-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a minor regression introduced in v3.8-rc1 code where a zero-length INQUIRY was no longer returning the correct INVALID FIELD IN CDB additional sense code. This regression was introduced with the following commit: commit de103c93aff0bed0ae984274e5dc8b9

[PATCH 2/3] target: Fix zero-length MODE_SENSE regression

2013-01-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression introduced in v3.8-rc1 code where a zero-length MODE_SENSE was no longer returning GOOD status, but instead returning TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE to generate a CHECK_CONDITION status. This regression was introduced with the follow

[PATCH 3/3] target: Fix zero-length READ_CAPACITY_16 regression

2013-01-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression introduced in v3.8-rc1 code where a zero-length READ_CAPACITY_16 was no longer returning GOOD status, but instead returning TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE to generate a CHECK_CONDITION status. This regression was introduced with the

Re: [PATCH] target: For iblock at default writecache enable.

2013-01-29 Thread Andy Grover
On 01/29/2013 11:03 AM, Nicholas A. Bellinger wrote: > So enabling emulate_write_cache=1 in the case when the underlying device > has not enabled it is incorrect. > > I'd like to enable this bit when we know the underlying device has WCE=1 > set, but currently there is not a way to determine this

Re: [PATCH] target: For iblock at default writecache enable.

2013-01-29 Thread Nicholas A. Bellinger
On Tue, 2013-01-29 at 15:04 -0800, Andy Grover wrote: > On 01/29/2013 11:03 AM, Nicholas A. Bellinger wrote: > > > So enabling emulate_write_cache=1 in the case when the underlying device > > has not enabled it is incorrect. > > > > I'd like to enable this bit when we know the underlying device h

[ANNOUNCE] python-sgutils 0.1

2013-01-29 Thread Andy Grover
Hi all, Just a probably-premature announcement that I'm working on Python bindings for sg3_utils's libsgutils2.so. The project is here: https://github.com/agrover/python-sgutils So far it supports inquiry, mode sense, readcap and report luns. I don't think it makes sense to go for 100% SCSI cmd

linux-scsi@vger.kernel.org

2013-01-29 Thread Hiral Patel (hiralpat)
Hi James, Sorry, somehow I missed looking at kbuild emails. I have fixed sparse and smatch issues and resubmitted patches 3-10. Thanks, Hiral On 1/28/13 7:16 PM, "James Bottomley" wrote: >On Mon, 2012-12-17 at 21:50 +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/

[PATCH 10/10] fnic: Incremented driver version

2013-01-29 Thread Hiral Patel
Incrementing driver versio after bug fixes and new feature commits. Signed-off-by: Brian Uchino Signed-off-by: Hiral Patel --- drivers/scsi/fnic/fnic.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index acec42a..b6d1f

[PATCH 08/10] fnic: FIP VLAN Discovery Feature Support

2013-01-29 Thread Hiral Patel
FIP VLAN discovery discovers the FCoE VLAN that will be used by all other FIP protocols as well as by the FCoE encapsulation for Fibre Channel payloads on the established virtual link. One of the goals of FC-BB-5 was to be as nonintrusive as possible on initiators and targets, and therefore FIP

[PATCH 04/10] fnic: Fix SGEs limit

2013-01-29 Thread Hiral Patel
Driver allows IOs with more SGEs than max SGEs supported by Palo. The current max SGEs supported by the fnic driver is 1024. The current register settings on Palo supports a max of 256 only. Palo would return any IO with more than 256 SGEs with an error indicating INVALID_SGLS. Fnic driver shoul

[PATCH 06/10] fnic: New debug flags and debug log messages

2013-01-29 Thread Hiral Patel
Added new fnic debug flags for identifying IO state at every stage of IO while debugging and also added more log messages for better debugging capability. Signed-off-by: Sesidhar Baddela Signed-off-by: Hiral Patel --- drivers/scsi/fnic/fnic.h | 31 --- drivers/scsi/fnic/fnic_io.

[PATCH 03/10] fnic:fixing issues in device and firmware reset code

2013-01-29 Thread Hiral Patel
1. Handling overlapped firmware resets This fix serialize multiple firmware resets to avoid situation where fnic device fails to come up for link up event, when firmware resets are issued back to back. If there are overlapped firmware resets are issued, the firmware reset operat

[PATCH 05/10] fnic: fnic driver may hit BUG_ON on device reset

2013-01-29 Thread Hiral Patel
The issue was observed when LUN Reset is issued through IOCTL or sg_reset utility. fnic driver issues LUN RESET to firmware. On successful completion of device reset, driver cleans up all the pending IOs that were issued prior to device reset. These pending IOs are expected to be in ABTS_PENDING s

[PATCH 09/10] fnic: Kernel panic due to FIP mode misconfiguration

2013-01-29 Thread Hiral Patel
If switch configured in FIP and adapter configured in non-fip mode, driver panics while queueing FIP frame in non-existing fip_frame_queue. Added config check before queueing FIP frame in misconfiguration case to avoid kernel panic. Signed-off-by: Hiral Patel --- drivers/scsi/fnic/fnic_fcs.c |

[PATCH 07/10] fnic: Fnic Trace Utility

2013-01-29 Thread Hiral Patel
Fnic Trace utility is a tracing functionality built directly into fnic driver to trace events. The benefit that trace buffer brings to fnic driver is the ability to see what it happening inside the fnic driver. It also provides the capability to trace every IO event inside fnic driver to debug pani

Re: [scsi:for-next 23/27] drivers/scsi/fnic/fnic_scsi.c:1260 fnic_rport_exch_reset() error: we previously assumed 'sc->device' could be null (see line 1237)

2013-01-29 Thread Hiral Patel (hiralpat)
Hi Dan, I have fixed the new smatch warnings which was introduced by fnic update patches and resubmitted new patches. Thanks, Hiral On 12/17/12 5:49 AM, "Dan Carpenter" wrote: >[ It doesn't make sense to check for NULL, print an error and then > dereference the pointer. The normal Oops messa

Re: Re: [PATCH] target: For iblock at default writecache enable.

2013-01-29 Thread majianpeng
>On Tue, 2013-01-29 at 15:04 -0800, Andy Grover wrote: >> On 01/29/2013 11:03 AM, Nicholas A. Bellinger wrote: >> >> > So enabling emulate_write_cache=1 in the case when the underlying device >> > has not enabled it is incorrect. >> > >> > I'd like to enable this bit when we know the underlying d

Re: [PATCH 08/10] fnic: FIP VLAN Discovery Feature Support

2013-01-29 Thread James Bottomley
On Tue, 2013-01-29 at 16:05 -0800, Hiral Patel wrote: > FIP VLAN discovery discovers the FCoE VLAN that will be used by all other FIP > protocols > as well as by the FCoE encapsulation for Fibre Channel payloads on the > established > virtual link. One of the goals of FC-BB-5 was to be as nonintr

Re: [scsi:for-next 14/27] drivers/scsi/qla2xxx/qla_os.c:364 qla2x00_free_req_que() info: redundant null check on req->outstanding_cmds calling kfree()

2013-01-29 Thread Saurav Kashyap
>On Mon, 2012-12-17 at 20:45 +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git >>for-next >> head: e3ff197a750d2912d0bb2a0161c23c18bad250ad >> commit: 99cc149bbdd78a3f18c6b366e1c239f62d59d096 [14/27] [SCSI] >>qla2xxx: Determine the number of

[scsi:misc 61/65] drivers/scsi/fnic/fnic_scsi.c:441:3: warning: cast from pointer to integer of different size

2013-01-29 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 52cb5cbe9b8ed89db0f8c9eeec8410fcfb0887fd commit: 6f3b5679f2af1ef3becbf7832d2bce977907c08a [61/65] [SCSI] fnic: fixing issues in device and firmware reset code config: make ARCH=i386 allmodconfig All warnings: dri

RE: mpt2sas: device_blocked question

2013-01-29 Thread Reddy, Sreekanth
Hi Spren, Reason code MPI2_EVENT_SAS_TOPO_RC_DELAY_NOT_RESPONDING mean that "A target device has stopped responding or is missing but the ReportDeviceMissingDelay timer has not expired for this device". Can you please send me the some more information i.e. 1. For which operation/TestCase this

[patch] [SCSI] libosd: check for kzalloc() failure

2013-01-29 Thread Dan Carpenter
There wasn't any error handling for this kzalloc(). Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index c06b8e5..d8293f2 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -144,6 +144,10 @@ stati

[PATCH] target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status

2013-01-29 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch allows IBLOCK to check block hints in request_queue->flush_flags when reporting current backend device WriteCacheEnabled status to a remote SCSI initiator port. This is done via a se_subsystem_api->get_write_cache() call instead of a backend se_device creation

[patch] [SCSI] qla4xxx: don't free NULL dma pool

2013-01-29 Thread Dan Carpenter
The error path calls dma_pool_free() on this path but "chap_table" is NULL and "chap_dma" is uninitialized. It's cleaner to just return directly. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 1c57c22..887e409 100644 --- a/drivers

Re: Re: [PATCH] target: For iblock at default writecache enable.

2013-01-29 Thread Nicholas A. Bellinger
Hi majianpeng, On Wed, 2013-01-30 at 09:19 +0800, majianpeng wrote: > >On Tue, 2013-01-29 at 15:04 -0800, Andy Grover wrote: > >> On 01/29/2013 11:03 AM, Nicholas A. Bellinger wrote: > >> > >> > So enabling emulate_write_cache=1 in the case when the underlying device > >> > has not enabled it is

Re: [PATCH] target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status

2013-01-29 Thread Asias He
On 01/30/2013 02:57 PM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch allows IBLOCK to check block hints in request_queue->flush_flags > when reporting current backend device WriteCacheEnabled status to a remote > SCSI initiator port. > > This is done via a se_subsystem_