Re: [PATCH] Fix libata-eh don't retry command after reset succeeded.

2013-01-14 Thread Mark Lord
> > From 9cc9a85f17a8525e53caf430611d762c105d324c Mon Sep 17 00:00:00 2001 > From: Bian Yu > Date: Tue, 18 Dec 2012 05:58:34 -0500 > Subject: [PATCH] Fix libata-eh don't retry command after reset succeeded. > It's introduced by commit 8d899e70c1b3afff, When disk has a UNC error, > qc->err_mask

Re: [PATCH] Fix libata-eh don't retry command after reset succeeded.

2013-01-14 Thread Mark Lord
On 13-01-14 09:01 AM, Mark Lord wrote: >> >> From 9cc9a85f17a8525e53caf430611d762c105d324c Mon Sep 17 00:00:00 2001 >> From: Bian Yu >> Date: Tue, 18 Dec 2012 05:58:34 -0500 >> Subject: [PATCH] Fix libata-eh don't retry command after reset succeeded. >> It's introduced by commit 8d899e70c1b3afff,

Re: [PATCH v6 0/4] block layer runtime pm

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Aaron Lu wrote: > On Tue, Jan 08, 2013 at 10:27:54AM -0500, Alan Stern wrote: > > On Tue, 8 Jan 2013, Aaron Lu wrote: > > > > > So this also reminds me that as long as CONFIG_PM_RUNTIME is selected, > > > the blk_pm_add/put/peek_request functions will be in the block IO path.

Re: [PATCH 6/8] V2 ipr: Implement block iopoll

2013-01-14 Thread wenxiong
Quoting Asias He : Hello Wen Xiong, On Sat, Jan 12, 2013 at 7:43 AM, wrote: This patch implements blk iopoll in ipr driver for performance improvement. Can you provide the performance numbers with/without the io polling? It would be interesting to know. we enable blk iopoll support in

Re: [PATCH] Fix libata-eh don't retry command after reset succeeded.

2013-01-14 Thread Sergei Shtylyov
Hello. On 01/14/2013 05:01 PM, Mark Lord wrote: >> From 9cc9a85f17a8525e53caf430611d762c105d324c Mon Sep 17 00:00:00 2001 >> From: Bian Yu >> Date: Tue, 18 Dec 2012 05:58:34 -0500 >> Subject: [PATCH] Fix libata-eh don't retry command after reset succeeded. >> It's introduced by commit 8d899e70c

Re: [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off

2013-01-14 Thread Jeff Garzik
On 01/11/2013 01:44 PM, Tejun Heo wrote: Hello, On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote: OK, will make it atomic in next version, thanks for the advice. Perhaps I can add two scsi helper functions in scsi_lib.c like: void sdev_disable_disk_events(struct scsi_device *sdev) {

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Aaron Lu wrote: > On Tue, Jan 08, 2013 at 10:22:45AM -0500, Alan Stern wrote: > > Just as importantly, all of the public routines added in patch 2/4 to > > blk-core.c should have kerneldoc explaining how and where to use them. > > In particular, the kerneldoc for blk_pm_runt

Re: xhci problem

2013-01-14 Thread Sarah Sharp
On Sun, Jan 13, 2013 at 09:34:58AM -0500, Allan Dennis wrote: > I left this problem for awhile, then finally got back to it. I upgraded > the gentoo kernel to 3.6.11 and was partially successful: the 3TB drive > mounted ok, but then had some serious trouble transferring files and I > believe that l

Re: [PATCH 0/8] V2 Add support for new IBM SAS controllers

2013-01-14 Thread Brian King
On 01/11/2013 05:43 PM, wenxi...@linux.vnet.ibm.com wrote: > This is version 2 of ipr patches to support new IBM SAS controllers. > In V2, we have fixed the following suggestions/warning/sparse errors: > > 1.Changed simple_strtoul() to kstrtoul() in ipr_restore_iopoll_weight routine. > 2.Removed

[Resend PATCH 2/3] scsi: sd: no need to set gendisk->minors in sd_probe_async()

2013-01-14 Thread Guo Chao
We already call alloc_disk() with SD_MINORS and ->minors will be always set there. Signed-off-by: Guo Chao --- drivers/scsi/sd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 181cd87..9fd67be 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd

[Resend PATCH 1/3] scsi: sd: set valid return value in failed path

2013-01-14 Thread Guo Chao
Set valid return value to avoid returning 0 in a failed path of sd_init(). Signed-off-by: Guo Chao --- drivers/scsi/sd.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 7992635..181cd87 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -

[Resend PATCH 3/3] scsi: sd: remove unnecessary initialization in sd_probe()

2013-01-14 Thread Guo Chao
We use kzalloc() to allocate scsi_disk, no need to reset ->openers. Signed-off-by: Guo Chao --- drivers/scsi/sd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 9fd67be..4f4bc7e 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2907,7 +

Re: [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off

2013-01-14 Thread Aaron Lu
On Mon, Jan 14, 2013 at 01:01:47PM -0500, Jeff Garzik wrote: > On 01/11/2013 01:44 PM, Tejun Heo wrote: > >Hello, > > > >On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote: > >>OK, will make it atomic in next version, thanks for the advice. > >> > >>Perhaps I can add two scsi helper functions