Re: [PATCH v6 4/4] sd: change to auto suspend mode

2013-01-07 Thread Oliver Neukum
On Sunday 06 January 2013 16:41:37 Aaron Lu wrote: > From: Lin Ming > > Uses block layer runtime pm helper functions in > scsi_runtime_suspend/resume. > Remove scsi_autopm_* from sd open/release path and check_events path. > And remove the quiesce call in runtime suspend path, as we know there is

Re: [PATCH v6 4/4] sd: change to auto suspend mode

2013-01-07 Thread Aaron Lu
On 01/07/2013 05:19 PM, Oliver Neukum wrote: > On Sunday 06 January 2013 16:41:37 Aaron Lu wrote: >> From: Lin Ming >> >> Uses block layer runtime pm helper functions in >> scsi_runtime_suspend/resume. >> Remove scsi_autopm_* from sd open/release path and check_events path. >> And remove the quies

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-07 Thread Paolo Bonzini
Il 07/01/2013 01:02, Rusty Russell ha scritto: > Paolo Bonzini writes: >> Il 02/01/2013 06:03, Rusty Russell ha scritto: >>> Paolo Bonzini writes: The virtqueue_add_buf function has two limitations: 1) it requires the caller to provide all the buffers in a single call; 2)

[PATCH] hpsa: update version number to 3.2.0

2013-01-07 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 4217e49..469ba9b 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -54,7 +54,7

Re: [PATCH v6 0/4] block layer runtime pm

2013-01-07 Thread Alan Stern
On Sun, 6 Jan 2013, Aaron Lu wrote: > In August 2010, Jens and Alan discussed about "Runtime PM and the block > layer". http://marc.info/?t=12825910841&r=1&w=2 > And then Alan has given a detailed implementation guide: > http://marc.info/?l=linux-scsi&m=133727953625963&w=2 > > To test: > # ls

Re: [PATCH v6 2/4] block: add runtime pm helpers

2013-01-07 Thread Alan Stern
On Sun, 6 Jan 2013, Aaron Lu wrote: > From: Lin Ming > > Add runtime pm helper functions: > > void blk_pm_runtime_init(struct request_queue *q, struct device *dev) > - Initialization function for drivers to call. > > int blk_pre_runtime_suspend(struct request_queue *q) > - If any requests

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Alan Stern
On Sun, 6 Jan 2013, Aaron Lu wrote: > From: Lin Ming > > When a request is added: > If device is suspended or is suspending and the request is not a > PM request, resume the device. > > When the last request finishes: > Call pm_runtime_mark_last_busy() and pm_runtime_autosuspend().

Re: [PATCH v11 2/9] libata: Add CONFIG_SATA_ZPODD

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:22AM +0800, Aaron Lu wrote: > Added a new config CONFIG_SATA_ZPODD, which is used to support > SATA based zero power ODD(ZPODD), and depends on ATA_ACPI. > > Signed-off-by: Aaron Lu Maybe just fold this into the next patch? It's rather unconventional to introduce t

Re: [PATCH v11 3/9] libata: identify and init ZPODD devices

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:23AM +0800, Aaron Lu wrote: > diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c > index ef01ac0..5aa7322 100644 > --- a/drivers/ata/libata-acpi.c > +++ b/drivers/ata/libata-acpi.c > @@ -1063,6 +1063,8 @@ void ata_acpi_bind(struct ata_device *dev) > >

Re: [PATCH v11 4/9] libata: move acpi notification code to zpodd

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:24AM +0800, Aaron Lu wrote: > @@ -7,6 +9,9 @@ struct zpodd { > bool slot:1; > bool drawer:1; > > + /* The following bits are synchronized by PM core */ > + bool from_notify:1; /* resumed as a result of acpi notification */ > + > struct ata_d

Re: [PATCH v11 5/9] libata: check zero power ready status for ZPODD

2013-01-07 Thread Tejun Heo
Hello, Aaron. On Sun, Jan 06, 2013 at 10:48:25AM +0800, Aaron Lu wrote: > +/* Check zero power ready status */ > +void zpodd_on_suspend(struct ata_device *dev) > +{ > + struct zpodd *zpodd = dev->zpodd; > + unsigned long expires; > + > + if (!zpready(dev)) { > + zpodd->zp_r

Re: [PATCH v11 7/9] libata: expose pm qos flags for ata device

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:27AM +0800, Aaron Lu wrote: > Expose pm qos flags to user space so that user has a chance to disable > pm features like power off, if he/she has a broken platform or devices > or simply does not like this pm feature. > > This flag is exposed to user space only for ata

Re: [PATCH v11 8/9] libata: no poll when ODD is powered off

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:28AM +0800, Aaron Lu wrote: > When the ODD is powered off, any action the user did to the ODD that > would generate a media event will trigger an ACPI interrupt, so the > poll for media event is no longer necessary. And the poll will also > cause a runtime status chang

Re: [PATCH v11 6/9] libata: handle power transition of ODD

2013-01-07 Thread Tejun Heo
On Sun, Jan 06, 2013 at 10:48:26AM +0800, Aaron Lu wrote: > +bool zpodd_zpready(struct ata_device *dev) > +{ > + struct zpodd *zpodd = dev->zpodd; > + return zpodd->zp_ready; > +} > + > +void zpodd_pre_poweroff(struct ata_device *dev) > +{ > + struct zpodd *zpodd = dev->zpodd; > + > +

Re: [PATCH v11 0/9] ZPODD Patches

2013-01-07 Thread Tejun Heo
Hello, Aaron. On Sun, Jan 06, 2013 at 10:48:20AM +0800, Aaron Lu wrote: > v11: > Introduce event_driven flag in scsi_device to silence the media event > poll after ODD is powered off; > Removed ata layer PM QOS control, instead, simply limit ACPI state to > D3_HOT when choosing state; > Make the p

Re: [PATCH] iscsi-target: Fix bug in handling of ExpStatSN ACK during u32 wrap-around

2013-01-07 Thread Roland Dreier
On Wed, Dec 26, 2012 at 1:33 PM, Ben Hutchings wrote: >> if (!(cmd->cmd_flags & ICF_OOO_CMDSN) && !cmd->immediate_cmd && >> - (cmd->cmd_sn >= conn->sess->exp_cmd_sn)) { >> + iscsi_sna_gte(cmd->stat_sn, conn->sess->exp_cmd_sn)) { >>

[PATCH] iscsi-target: Fix CmdSN comparison (use cmd->cmd_sn instead of cmd->stat_sn)

2013-01-07 Thread Roland Dreier
From: Roland Dreier Commit 64c13330a389 ("iscsi-target: Fix bug in handling of ExpStatSN ACK during u32 wrap-around") introduced a bug where we compare the wrong SN against our ExpCmdSN. Reported-by: Ben Hutchings Signed-off-by: Roland Dreier --- drivers/target/iscsi/iscsi_target_erl2.c | 2 +

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-07 Thread Rusty Russell
Paolo Bonzini writes: > Il 07/01/2013 01:02, Rusty Russell ha scritto: >> Paolo Bonzini writes: >>> Il 02/01/2013 06:03, Rusty Russell ha scritto: Paolo Bonzini writes: > The virtqueue_add_buf function has two limitations: > > 1) it requires the caller to provide all the buffers

Re: [PATCH 0/3] qla4xxx: Updates for scsi "misc" branch

2013-01-07 Thread Mike Christie
On 12/29/2012 01:24 AM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > James, > > Please apply the following patches to the scsi tree at your earliest > convenience. > > Thanks, > Vikas. > > Nilesh Javali (1): > qla4xxx: Correct the validation to check in get_sys_info mail

Re: [PATCH v6 0/4] block layer runtime pm

2013-01-07 Thread Aaron Lu
On 01/08/2013 01:11 AM, Alan Stern wrote: > On Sun, 6 Jan 2013, Aaron Lu wrote: > >> In August 2010, Jens and Alan discussed about "Runtime PM and the block >> layer". http://marc.info/?t=12825910841&r=1&w=2 >> And then Alan has given a detailed implementation guide: >> http://marc.info/?l=lin

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Aaron Lu
On 01/08/2013 01:21 AM, Alan Stern wrote: > On Sun, 6 Jan 2013, Aaron Lu wrote: > >> From: Lin Ming >> >> When a request is added: >> If device is suspended or is suspending and the request is not a >> PM request, resume the device. >> >> When the last request finishes: >> Call pm_run