[PATCH] a100u2w: Added sanitization for pointer dereference using a value from hardware. Detected using Carburizer (http://lwn.net/Articles/479653/)

2012-12-27 Thread Asim Kadav
Signed-off-by: Asim Kadav --- drivers/scsi/a100u2w.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 0163457..c2ca15c 100644 --- a/drivers/scsi/a100u2w.c +++ b/drivers/scsi/a100u2w.c @@ -821,6 +821,9 @@ static irqreturn_t orc_interrupt(

Re: [PATCH] a100u2w: Added sanitization for pointer dereference using a value from hardware. Detected using Carburizer (http://lwn.net/Articles/479653/)

2012-12-27 Thread James Bottomley
On Thu, 2012-12-27 at 02:59 -0600, Asim Kadav wrote: > Signed-off-by: Asim Kadav > --- > drivers/scsi/a100u2w.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c > index 0163457..c2ca15c 100644 > --- a/drivers/scsi/a100u2w.c > +++ b/drive

Re: [PATCH] a100u2w: Added sanitization for pointer dereference using a value from hardware. Detected using Carburizer (http://lwn.net/Articles/479653/)

2012-12-27 Thread Asim Kadav
> If your theory is that the hardware just returned a bogus value, this > isn't the right way to sanitise it because the chances are you'll > complete the wrong command and cause corruption: you'd have to halt the > entire system at that point. Also, I don't understand why you think the > value s

Re: [PATCH V5 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-12-27 Thread Subhash Jadavani
Few comments inline: On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting into core ufs driver and PCI glue driver. Also copyright header modification to remove extra warranty discl

Re: [PATCH] a100u2w: Added sanitization for pointer dereference using a value from hardware. Detected using Carburizer (http://lwn.net/Articles/479653/)

2012-12-27 Thread James Bottomley
On Thu, 2012-12-27 at 08:12 -0600, Asim Kadav wrote: > > If your theory is that the hardware just returned a bogus value, this > > isn't the right way to sanitise it because the chances are you'll > > complete the wrong command and cause corruption: you'd have to halt the > > entire system at that

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-12-27 Thread Subhash Jadavani
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-off-by: Vinayak Holikatti Signed-off-by: Santosh Yaraganavi --- drivers/scsi/ufs/Kconfig | 11

Re: [PATCH V5 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver

2012-12-27 Thread Subhash Jadavani
On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch separates PCI code from ufshcd.c and makes it as a core driver module and adds a new file ufshcd-pci.c as PCI glue driver. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-off-by: Vinayak Holika