Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-05 Thread James Bottomley
On Tue, 2012-12-04 at 16:00 -0600, Chris Friesen wrote: > As another data point, it looks like we may be doing a SEND DIAGNOSTIC > command specifying the default self-test in addition to the background > short self-test. This seems a bit risky and excessive to me, but > apparently the guy that wro

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: > @@ -5190,7 +5188,7 @@ static void > megasas_aen_polling(struct work_struct *work) > { > struct megasas_aen_event *ev = > - container_of(work, struct megasas_aen_event, hotplug_work); > + container_of(work, str

Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-05 Thread Daniel Vacek
On Wed, Dec 5, 2012 at 12:02 PM, Daniel Vacek wrote: > On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: >> @@ -5190,7 +5188,7 @@ static void >> megasas_aen_polling(struct work_struct *work) >> { >> struct megasas_aen_event *ev = >> - container_of(work, struct megasas_aen_e

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-05 Thread Ric Wheeler
On 12/05/2012 04:20 AM, James Bottomley wrote: On Tue, 2012-12-04 at 16:00 -0600, Chris Friesen wrote: As another data point, it looks like we may be doing a SEND DIAGNOSTIC command specifying the default self-test in addition to the background short self-test. This seems a bit risky and excess

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-05 Thread James Bottomley
On Wed, 2012-12-05 at 06:41 -0500, Ric Wheeler wrote: > I don't think that the basic stat gathering (smartctl -a ) has this kind > of > impact, but am worried about the running of the diagnostics, Right, that's what I was trying to say above. Anything that just reads existing data is fine.

[PATCH] scsi_ram: a RAM-based SCSI driver

2012-12-05 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" This driver is intended to run as fast as possible, hence the options to discard writes and reads. It's designed to let us find latency issues elsewhere in the storage stack (eg filesystem, block layer, scsi layer). There are a few different options, controlled through

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] > Modulo a few style issues (braces around one line if branches, etc.) and > having three state variables vs one, I can live with everything up to > aabfa852acd27962 at git://github.com/bvanassche/linux.git#srp-ha. Those > two are small th

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27962 at git://github.com/bvanassche/linux.gi

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:50, Bart Van Assche wrote: On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27

[PATCH 04/12] [SCSI] qla2xxx: Use standard PCIe Capability Link register field names

2012-12-05 Thread Bjorn Helgaas
Use the standard #defines for PCIe Link Capability register fields rather than bare numbers. This also uses the new PCI Express Capability accessor rather than reading the capability directly. Signed-off-by: Bjorn Helgaas CC: Andrew Vasquez CC: linux-dri...@qlogic.com CC: "James E.J. Bottomley"

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Or Gerlitz
On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche wrote: [...] > The only way to make I/O work reliably if a failure can occur at the > transport layer is to use multipathd on top of ib_srp. If a connection fails > for some reason, then the SRP SCSI host will be removed after the SCSI error > handle

[Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-05 Thread Chen Gang
Hello Maintainers: in drivers/target/sbp/sbp_target.c: tport->tpg must be NULL before process it in function sbp_make_tpg. (line 2185..2188) tport->tpg assigned a ptr (line 2198) if processing failed, not set tport->tpg = NULL (line 2208..2212, 2217..2221) we have done: when free t