Smatch complains that we are writing more data than ->srlid_base
member can hold. In fact, we are over writing the whole struct. I've
re-written it to be a bit more clear and to silence the static checker
warning.
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/s
On Tue, Oct 09, 2012 at 03:58:34PM +0100, James Bottomley wrote:
> On Tue, 2012-10-09 at 15:20 +0800, Aaron Lu wrote:
> > On 10/08/2012 06:21 PM, James Bottomley wrote:
> > > On Mon, 2012-10-08 at 17:27 +0800, Aaron Lu wrote:
> > >> On Sun, Sep 30, 2012 at 03:43:27PM -0400, Alan Stern wrote:
> > >>
On Wed, Oct 10, 2012 at 02:32:13PM -0400, Alan Stern wrote:
> On Wed, 10 Oct 2012, Aaron Lu wrote:
>
> > +static int run_dev_callback(struct device *dev, pm_message_t mesg)
> > +{
> > + int ret;
> > +
> > + switch (mesg.event) {
> > + case PM_EVENT_SUSPEND:
> > + re
On Wed, Oct 10, 2012 at 02:35:47PM -0400, Alan Stern wrote:
> On Wed, 10 Oct 2012, Aaron Lu wrote:
>
> > Update sd driver to use the callbacks defined in dev_pm_ops.
> >
> > sd_freeze is NULL, the bus level callback has taken care of quiescing
> > the device so there should be nothing needs to be
The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
used in struct osd_cdb_head, but it isn't marked as packed. Some
architectures will round the struct size up which triggers BUILD_BUG_ON
compile errors in osd_initiator.c when the outer structs are unexpected
sizes. This is fixe
On 10/11/12 11:15, James Hogan wrote:
The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
used in struct osd_cdb_head, but it isn't marked as packed. Some
architectures will round the struct size up which triggers BUILD_BUG_ON
compile errors in osd_initiator.c when the outer st
On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote:
> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
> used in struct osd_cdb_head, but it isn't marked as packed. Some
> architectures will round the struct size up which triggers BUILD_BUG_ON
> compile errors in osd_initiat
On 11/10/12 11:01, Bart Van Assche wrote:
> On 10/11/12 11:15, James Hogan wrote:
>> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
>> used in struct osd_cdb_head, but it isn't marked as packed. Some
>> architectures will round the struct size up which triggers BUILD_BUG_ON
On 11/10/12 11:24, James Bottomley wrote:
> On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote:
>> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
>> used in struct osd_cdb_head, but it isn't marked as packed. Some
>> architectures will round the struct size up which trigge
On Thu, 2012-10-11 at 12:32 +0100, James Hogan wrote:
> On 11/10/12 11:24, James Bottomley wrote:
> > On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote:
> >> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
> >> used in struct osd_cdb_head, but it isn't marked as packed. So
> > The alignment is fine (the offset of the u16 is 8 bytes), but
> > unfortunately with the metag port of gcc, sizeof(struct
> > scsi_varlen_cdb_hdr) is rounded up to a 4 byte boundary (even though the
> > largest data member alignment is only 2 bytes), which is 12 bytes
> > instead of 10.
>
> Th
On 11/10/12 13:58, James Bottomley wrote:
> On Thu, 2012-10-11 at 12:32 +0100, James Hogan wrote:
>> On 11/10/12 11:24, James Bottomley wrote:
>>> On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote:
The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
used in struct os
On Thu, 11 Oct 2012, Aaron Lu wrote:
> When device is runtime suspended, put it to stopped power state to save
> some power.
>
> This will also make the behaviour consistent with what the scsi_pm.c
> thinks about sd as the comment says:
> sd treats runtime suspend, system suspend and system hiber
I have a couple of small changes to suggest. Nothing major.
On Thu, 11 Oct 2012, Aaron Lu wrote:
> @@ -102,26 +77,87 @@ static int scsi_bus_prepare(struct device *dev)
>
> static int scsi_bus_suspend(struct device *dev)
> {
> - return scsi_bus_suspend_common(dev, PMSG_SUSPEND);
> + i
From: Roland Dreier
Hi everyone, a couple of qla2xxx target fixes that we've been shipping
for a while at Pure and that I've finally got around to cleaning up
and merging to the latest kernel tree...
Roland Dreier (2):
tcm_qla2xxx: Format VPD page 83h SCSI name string according to SPC
qla2xx
From: Roland Dreier
My draft of SPC-4 says the following about the SCSI name string in
inquiry VPD page 83h:
The SCSI NAME STRING field starts with either:
a) the four UTF-8 characters 'eui.' concatenated with 16, 24, or
32 hexadecimal digits (i.e., the UTF-8 characters 0 through
From: Roland Dreier
It is possible for the target code to change the loop_id or s_id of a
target session in reaction to an FC fabric change. However, the
session structures are stored in tables that are indexed by these two
keys, and if we just change the session structure but leave the
pointers
On Thu, Oct 11, 2012 at 10:50:37AM -0400, Alan Stern wrote:
> On Thu, 11 Oct 2012, Aaron Lu wrote:
>
> > When device is runtime suspended, put it to stopped power state to save
> > some power.
> >
> > This will also make the behaviour consistent with what the scsi_pm.c
> > thinks about sd as the
On Thu, Oct 11, 2012 at 10:57:26AM -0400, Alan Stern wrote:
> I have a couple of small changes to suggest. Nothing major.
>
> On Thu, 11 Oct 2012, Aaron Lu wrote:
>
> > @@ -102,26 +77,87 @@ static int scsi_bus_prepare(struct device *dev)
> >
> > static int scsi_bus_suspend(struct device *dev)
19 matches
Mail list logo
