Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread Li Zhong
On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: > On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: > > Just noticed that after commit 919f797, it is possible that > > scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking for > > drv > > returned from the above function

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 15:03 +0800, Li Zhong wrote: > On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: > > On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: > > > Just noticed that after commit 919f797, it is possible that > > > scsi_cmd_to_driver() returns NULL. This patch adds the NULL

Re: [PATCHv2] st: remove st_mutex

2012-09-24 Thread James Bottomley
On Mon, 2012-09-10 at 15:36 -0700, Lee Duncan wrote: > From: Hannes Reinecke > > The st_mutex was created when the BKL was removed, and > prevents simultaneous st_open calls. It is better to > protect just the necessary data. > > Signed-off-by: Hannes Reinecke > Reviewed-by: Lee Duncan That s

[Bug 47781] ata2: exception Emask 0x10 SAct 0x0 SErr 0x4050002 action 0xe frozen

2012-09-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=47781 Alan changed: What|Removed |Added Component|SCSI|Serial ATA AssignedTo|linux-scsi@vger.ker

Re: [RFC PATCH] libata: scsi: flush cache on scsi stop command

2012-09-24 Thread Aaron Lu
On Fri, Sep 21, 2012 at 12:05:33PM -0700, Gwendal Grignou wrote: > On Wed, Sep 19, 2012 at 1:56 AM, Aaron Lu wrote: > > scsi stop command is used to put a device into stopped power > > condition, and scsi devices will take care of its internal cache > > before entering this power condition. For at

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread Li Zhong
On Mon, 2012-09-24 at 11:35 +0400, James Bottomley wrote: > On Mon, 2012-09-24 at 15:03 +0800, Li Zhong wrote: > > On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: > > > On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: > > > > Just noticed that after commit 919f797, it is possible that

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 17:25 +0800, Li Zhong wrote: > On Mon, 2012-09-24 at 11:35 +0400, James Bottomley wrote: > > On Mon, 2012-09-24 at 15:03 +0800, Li Zhong wrote: > > > On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: > > > > On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: > > > > >

[V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-24 Thread Naresh Kumar Inna
This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel. This driver currently supports FCoE offload functionality over Chelsio T4-based 10Gb Converged Network Adapters. The following patches contain the driver sources for csiostor driver and updates to

[V5 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-09-24 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net/ethernet/chelsio/cxgb4

[V5 PATCH 2/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-24 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained CSIO_INC_STATS, since it is

[V5 PATCH 3/8] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-09-24 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h | 141 ++ driv

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-24 Thread Rafael J. Wysocki
On Monday, September 24, 2012, Aaron Lu wrote: > On Fri, Sep 21, 2012 at 10:49:32PM +0200, Rafael J. Wysocki wrote: > > On Friday, September 21, 2012, Aaron Lu wrote: > > > On Thu, Sep 20, 2012 at 10:48:10PM +0200, Rafael J. Wysocki wrote: > > > > On Wednesday, September 12, 2012, Aaron Lu wrote: >

Re: [PATCH v7 0/6] ZPODD patches

2012-09-24 Thread Rafael J. Wysocki
On Monday, September 24, 2012, Aaron Lu wrote: > On Fri, Sep 21, 2012 at 11:18:27PM +0200, Rafael J. Wysocki wrote: > > On Friday, September 21, 2012, Aaron Lu wrote: > > > On Thu, Sep 20, 2012 at 10:00:51PM +0200, Rafael J. Wysocki wrote: > > > > On Wednesday, September 19, 2012, Aaron Lu wrote: >

[PATCH, resend] Fix race between starved list processing and device removal

2012-09-24 Thread Bart Van Assche
Avoid that the sdev reference count can drop to zero before the queue is run by scsi_run_queue(). Also avoid that the sdev reference count can drop to zero in the same function by invoking __blk_run_queue(). Reported-by: Chanho Min Tested-by: Chanho Min Reviewed-by: Mike Christie Signed-off-by:

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-24 Thread Aaron Lu
On Mon, Sep 24, 2012 at 02:55:31PM +0200, Rafael J. Wysocki wrote: > On Monday, September 24, 2012, Aaron Lu wrote: > > On Fri, Sep 21, 2012 at 10:49:32PM +0200, Rafael J. Wysocki wrote: > > > On Friday, September 21, 2012, Aaron Lu wrote: > > > > On Thu, Sep 20, 2012 at 10:48:10PM +0200, Rafael J.

Re: [PATCH v7 0/6] ZPODD patches

2012-09-24 Thread Aaron Lu
On Mon, Sep 24, 2012 at 03:06:11PM +0200, Rafael J. Wysocki wrote: > On Monday, September 24, 2012, Aaron Lu wrote: > > On Fri, Sep 21, 2012 at 11:18:27PM +0200, Rafael J. Wysocki wrote: > > > On Friday, September 21, 2012, Aaron Lu wrote: > > > > On Thu, Sep 20, 2012 at 10:00:51PM +0200, Rafael J.

Re: [scsi] mpt-fusion: No SES device support?

2012-09-24 Thread Peter M. Petrakis
On 09/22/2012 03:54 PM, Lars Randers wrote: I can't get the SES device on my MPT controller to show up in Linux as a sg device. The controller is a re-flashed IBM BR10i (LSISAS1068E), running the latest firmware and it is connected to the SES capable backplane via i2c on the SFF-8087 sidebands

Re: [PATCH v7 0/6] ZPODD patches

2012-09-24 Thread Alan Stern
[CC: list trimmed somewhat] On Mon, 24 Sep 2012, Aaron Lu wrote: > I've tried to do a disk_block_events call on its suspend callback when > it is ready to be powered off, but there is a race that I don't know how > to solve: > pm_runtime_suspenddisk_events_workfn

Re: [scsi] mpt-fusion: No SES device support?

2012-09-24 Thread Lars Randers
2012/9/24 Peter M. Petrakis : > Hi Peter, thank you for taking the time to look into this. Sadly I can't run MegaCLI, that utility is for the LSISAS2008+ family of controllers i believe. The MPT bios is definately exporting the SES device, because Windows can see it just fine on the tgt:lun addre

Re: [PATCHv2] st: remove st_mutex

2012-09-24 Thread Lee Duncan
On 09/24/2012 02:06 AM, James Bottomley wrote: > On Mon, 2012-09-10 at 15:36 -0700, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The st_mutex was created when the BKL was removed, and >> prevents simultaneous st_open calls. It is better to >> protect just the necessary data. >> >> Signed-off-b

[PATCH 1/3] fcoe: Fix write errors on NPIV ports

2012-09-24 Thread Robert Love
From: Neerav Parikh SCSI errors were generated while writing to LUNs connected via NPIV ports. Debugging this it was found that the FCoE packets transmitted via the NPIV ports were not tagged with correct user priority as negotiated with peer by DCB agent. This resulted in FCoE traffic going wit

[PATCH 2/3] libfc: fix lun reset failure bugs in fc_fcp_resp handling of FCP_RSP_INFO

2012-09-24 Thread Robert Love
From: Yi Zou In LUN RESET testing involving NetApp targets, it is observed that LUN RESET is failing. The fc_fcp_resp() is not completing the completiong for the LUN RESET task since fc_fcp_resp assumes that the FCP_RSP_INFO is 8 bytes with the 4 byte reserved field, where in case of NetApp targe

[PATCH 3/3] Documentation: Add lesb/ to path for LESB attributes in FCoE bus documentation

2012-09-24 Thread Robert Love
The Link Error Status Block attributes are incorrectly named as they do not have the lesb_ prefix, but instead are grouped in the lesb/ attribute group. Signed-off-by: Robert Love Tested-by: Ross Brattain --- Documentation/ABI/testing/sysfs-bus-fcoe | 12 ++-- 1 file changed, 6 insert

[PATCH 0/3] libfc, libfcoe and fcoe updates for scsi-misc

2012-09-24 Thread Robert Love
Here are a few bug fixes for libfc and fcoe. Additionally there is a documentation fix for sysfs-bus-fcoe included. --- Neerav Parikh (1): fcoe: Fix write errors on NPIV ports Robert Love (1): Documentation: Add lesb/ to path for LESB attributes in FCoE bus documentation Yi Zou (1)

Re: [PATCH 1/2] block: Rename queue dead flag

2012-09-24 Thread Tejun Heo
Hello, On Sun, Sep 23, 2012 at 06:17:49PM +0200, Bart Van Assche wrote: > This patch is the result of running the command below and manually > fixing up indentation: > > git grep -lE 'blk_queue_dead|QUEUE_FLAG_DEAD' | > xargs sed -i .tmp -e 's/blk_queue_dead/blk_queue_dying/g' \ > -e 's/Q

Re: [PATCH 2/2] Make blk_cleanup_queue() wait until request_fn finished

2012-09-24 Thread Tejun Heo
Hello, Bart. On Sun, Sep 23, 2012 at 06:20:13PM +0200, Bart Van Assche wrote: > Some request_fn implementations, e.g. scsi_request_fn(), unlock > the queue lock. Make sure that blk_cleanup_queue() waits until all > active request_fn invocations have finished. This fixes a potential > use-after-fre

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK); M

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-24 Thread Rafael J. Wysocki
On Monday, September 24, 2012, Aaron Lu wrote: > On Mon, Sep 24, 2012 at 02:55:31PM +0200, Rafael J. Wysocki wrote: > > On Monday, September 24, 2012, Aaron Lu wrote: > > > On Fri, Sep 21, 2012 at 10:49:32PM +0200, Rafael J. Wysocki wrote: > > > > On Friday, September 21, 2012, Aaron Lu wrote: > >

Re: [PATCH v7 0/6] ZPODD patches

2012-09-24 Thread Rafael J. Wysocki
On Monday, September 24, 2012, Aaron Lu wrote: > On Mon, Sep 24, 2012 at 03:06:11PM +0200, Rafael J. Wysocki wrote: > > On Monday, September 24, 2012, Aaron Lu wrote: > > > On Fri, Sep 21, 2012 at 11:18:27PM +0200, Rafael J. Wysocki wrote: > > > > On Friday, September 21, 2012, Aaron Lu wrote: > >

Re: [PATCH v7 3/6] scsi: sr: support zero power ODD(ZPODD)

2012-09-24 Thread Jeff Garzik
On 09/12/2012 04:29 AM, Aaron Lu wrote: When ODD is runtime suspended, we will check if it is OK to remove its power: 1 For tray type, no medium inside and tray closed; 2 For slot type, no medium inside. And if yes, we will set the ready_to_power_off flag as an indication to ATA layer that it is

Re: [PATCH v7 6/6] libata: acpi: respect may_power_off flag

2012-09-24 Thread Jeff Garzik
On 09/12/2012 04:29 AM, Aaron Lu wrote: If user does not want the device to be powered off when runtime suspended by setting may_power_off flag to 0, we will not choose D3 cold for it. Signed-off-by: Aaron Lu --- drivers/ata/libata-acpi.c | 5 - 1 file changed, 4 insertions(+), 1 deletio

Re: [PATCH v2 1/4] scsi: introduce sync_before_stop flag

2012-09-24 Thread Jeff Garzik
On 09/18/2012 04:31 AM, Aaron Lu wrote: I agree that it is better handled in libata's SALT, I tried to do this but didn't find a good way so I introduced this flag. The SALT is 1-1 mapping, I'm not sure how to handle this 1-2 mapping. That is the crux of the matter: it is rather difficult with

[PATCH v3 10/26] block: Remove some unnecessary bi_vcnt usage

2012-09-24 Thread Kent Overstreet
More prep work for immutable bvecs/effecient bio splitting - usage of bi_vcnt has to be auditing, so getting rid of all the unnecessary usage makes that easier. Plus, bio_segments() is really what this code wanted, as it respects the current value of bi_idx. Signed-off-by: Kent Overstreet CC: Je

Re: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Jeff Garzik
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > Use min_t(size_t, ...) to fix. > > Signed-off-by: Tony Hung > --- > > diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c > --- a/linux-3

MDaemon Notification -- Attachment Removed

2012-09-24 Thread Postmaster
--- MDaemon has detected restricted attachments within an email message --- >From : linux-scsi@vger.kernel.org To: jo...@asmara-vietnam.com Subject : Mail

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: > > drivers/scsi/sd.c |4 > drivers/scsi/sd.h |2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs parameter like all our other controls), but what'

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs par

RE: RE: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Tony Hung - PTT 洪瑞嶸
On 2012/9/25 11:05 AM, Jeff Garzik wrote: > > On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > > > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > > > > > Use min_t(size_t, ...) to fix. Correct this, linux-3.2.0/drivers/ata/ahci.c: In function 'ahci_init_one':

RE: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Tony Hung - PTT 洪瑞嶸
On 2012/9/25 11:05 AM, Jeff Garzik wrote: > > On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > > > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > > > > > Use min_t(size_t, ...) to fix. Correct this, linux-3.2.0/drivers/ata/ahci.c: In function 'ahci_init_one':

[PATCH][SCSI] mpt3sas: linux/miscdevice.h

2012-09-24 Thread sreekanth.reddy
Adding support for MPT3SAS_MINOR(222) Signed-off-by: Sreekanth Reddy --- diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h index 0549d211..9c9ba04 100644 --- a/include/linux/miscdevice.h +++ b/include/linux/miscdevice.h @@ -34,6 +34,7 @@ #define MWAVE_MINOR219

RE: RE: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Tony Hung - PTT 洪瑞嶸
On 2012/9/25 11:05 AM, Jeff Garzik wrote: > > On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > > > linux-3.2.0/drivers/ata/ahci.c: In function 'ahci_init_one': > > > > > > Use promise_enable to disable AHCI control PCI RAID. > > > > > > Signed-off-by: Tony Hung > > > --- > > > > > > diff

Re: [PATCH 2/3] libfc: fix lun reset failure bugs in fc_fcp_resp handling of FCP_RSP_INFO

2012-09-24 Thread Bart Van Assche
On 09/24/12 20:52, Robert Love wrote: In LUN RESET testing involving NetApp targets, it is observed that LUN RESET is failing. The fc_fcp_resp() is not completing the completiong It looks like there is a typo in the patch description (in the last word of the second line) ? Bart. -- To unsub